summaryrefslogtreecommitdiff
path: root/lib/param
diff options
context:
space:
mode:
authorVolker Lendecke <vl@samba.org>2015-03-26 10:14:22 +0100
committerMichael Adam <obnox@samba.org>2015-03-26 14:54:20 +0100
commit5d0a5c421641f719bcee6133119c1443dd7a4710 (patch)
tree47893d162826f3098330c803dc56c032ef477090 /lib/param
parentd02840a3a4d113e17a4225b0e7b1c893634a31d9 (diff)
downloadsamba-5d0a5c421641f719bcee6133119c1443dd7a4710.tar.gz
loadparm: Fix CID 1273054 Improper use of negative value
Probably a "can't happen", but formally lpcfg_map_parameter can return -1 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
Diffstat (limited to 'lib/param')
-rw-r--r--lib/param/loadparm.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/lib/param/loadparm.c b/lib/param/loadparm.c
index e2b0ca29acc..ddb806a238d 100644
--- a/lib/param/loadparm.c
+++ b/lib/param/loadparm.c
@@ -1338,6 +1338,9 @@ bool handle_smb_ports(struct loadparm_context *lp_ctx, struct loadparm_service *
if (parm_num == -1) {
parm_num = lpcfg_map_parameter("smb ports");
+ if (parm_num == -1) {
+ return false;
+ }
}
if(!set_variable_helper(lp_ctx->globals->ctx, parm_num, ptr, "smb ports",