diff options
| author | Joe Guo <joeg@catalyst.net.nz> | 2018-08-07 16:45:16 +1200 |
|---|---|---|
| committer | Andrew Bartlett <abartlet@samba.org> | 2018-08-15 07:08:23 +0200 |
| commit | b9e2a2de247add415b4681c93849a9c9ba6f3c4a (patch) | |
| tree | 32537b1fb845c2bf72b49e16792fd300405372be /lib/ldb/ldb_key_value/ldb_kv_index.c | |
| parent | 9eccf6a16f5b198181a4fa80b835b1a65b40ed76 (diff) | |
| download | samba-b9e2a2de247add415b4681c93849a9c9ba6f3c4a.tar.gz | |
ldb: no need to call del_transaction in ldb_transaction_commit
No matter commit succeeded or failed, transation will be delete afterwards.
So there is no need to delete it here.
Aganst Samba this causes an `LDAP error 51 LDAP_BUSY` error when the transaction
fails, say while we try to add users to groups in large amount and
the original error is lost.
In Samba, the rootdse module fails early in the del part of the
start/end/del pattern, and in ldb_tdb and ldb_mdb a failed commit
always ends the transaction, even on failure.
Signed-off-by: Joe Guo <joeg@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Diffstat (limited to 'lib/ldb/ldb_key_value/ldb_kv_index.c')
0 files changed, 0 insertions, 0 deletions