diff options
| author | Volker Lendecke <vl@samba.org> | 2016-07-29 14:00:10 +0200 |
|---|---|---|
| committer | Jeremy Allison <jra@samba.org> | 2016-08-05 22:20:05 +0200 |
| commit | a320f53cb76b64c5b94476f6f0e61815ee095332 (patch) | |
| tree | 7c2843768a3bcef31a68d0dc369b9a65fb72aa9f /lib/ldb/common | |
| parent | 07d12d2c71195f8365c02ab599f4793928f9d9e5 (diff) | |
| download | samba-a320f53cb76b64c5b94476f6f0e61815ee095332.tar.gz | |
ldb: Fix two signed/unsigned hickups
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Diffstat (limited to 'lib/ldb/common')
| -rw-r--r-- | lib/ldb/common/ldb_dn.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/lib/ldb/common/ldb_dn.c b/lib/ldb/common/ldb_dn.c index 3fa5ab57056..b23ee1734cd 100644 --- a/lib/ldb/common/ldb_dn.c +++ b/lib/ldb/common/ldb_dn.c @@ -1699,7 +1699,7 @@ bool ldb_dn_remove_child_components(struct ldb_dn *dn, unsigned int num) */ bool ldb_dn_replace_components(struct ldb_dn *dn, struct ldb_dn *new_dn) { - int i; + unsigned int i; if ( ! ldb_dn_validate(dn) || ! ldb_dn_validate(new_dn)) { return false; @@ -1904,11 +1904,11 @@ int ldb_dn_set_component(struct ldb_dn *dn, int num, return LDB_ERR_OTHER; } - if (num >= dn->comp_num) { + if (num < 0) { return LDB_ERR_OTHER; } - if (num < 0) { + if ((unsigned)num >= dn->comp_num) { return LDB_ERR_OTHER; } |