summaryrefslogtreecommitdiff
path: root/lib/krb5_wrap
diff options
context:
space:
mode:
authorNoel Power <noel.power@suse.com>2019-06-18 10:42:06 +0000
committerNoel Power <npower@samba.org>2019-07-01 13:34:11 +0000
commit8b92539997a9df8e0d217790fd82fc8f59ea50cc (patch)
treec2cad09c8fad90f4b26baf53cfab724304cfc587 /lib/krb5_wrap
parent7bddd6aefe3bd764560e5284f9a192797051bb2d (diff)
downloadsamba-8b92539997a9df8e0d217790fd82fc8f59ea50cc.tar.gz
lib/krb5_wrap: clang: Fix warning: Call to function 'mktemp' is insecure
Fixes: lib/krb5_wrap/krb5_samba.c:2012:2: warning: Call to function 'mktemp' is insecure as it always creates or uses insecure temporary file. Use 'mkstemp' instead <--[clang] mktemp(tmp_name); ^~~~~~ Signed-off-by: Noel Power <noel.power@suse.com> Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Diffstat (limited to 'lib/krb5_wrap')
-rw-r--r--lib/krb5_wrap/krb5_samba.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/krb5_wrap/krb5_samba.c b/lib/krb5_wrap/krb5_samba.c
index 344a26cdb6c..eac86e6754b 100644
--- a/lib/krb5_wrap/krb5_samba.c
+++ b/lib/krb5_wrap/krb5_samba.c
@@ -2009,7 +2009,7 @@ krb5_error_code smb_krb5_kinit_keyblock_ccache(krb5_context ctx,
memcpy(tmp_name, SMB_CREDS_KEYTAB, sizeof(SMB_CREDS_KEYTAB));
mask = umask(S_IRWXO | S_IRWXG);
- mktemp(tmp_name);
+ mkstemp(tmp_name);
umask(mask);
if (tmp_name[0] == 0) {
return KRB5_KT_BADNAME;