diff options
| author | Andreas Schneider <asn@samba.org> | 2018-05-16 13:59:55 +0200 |
|---|---|---|
| committer | Andreas Schneider <asn@cryptomilk.org> | 2018-05-17 20:17:35 +0200 |
| commit | 8b7c8eb3907e2123acee67949e88c26072afc81a (patch) | |
| tree | 2f3b4bcb2eb3f2cc5e5529d95bebc47a4e56c9fe /lib/audit_logging | |
| parent | 609ef35c12900bbd5ecaa557f7b5d71b5784a103 (diff) | |
| download | samba-8b7c8eb3907e2123acee67949e88c26072afc81a.tar.gz | |
lib: Fix array size in audit_logging
../lib/audit_logging/audit_logging.c: In function ‘json_add_timestamp’:
../lib/audit_logging/audit_logging.c:603:12: error: ‘%s’ directive
output may be truncated writing up to 9 bytes into a region of size
between 0 and 43 [-Werror=format-truncation=]
"%s.%06ld%s",
^~
../lib/audit_logging/audit_logging.c:606:3:
tz);
~~
../lib/audit_logging/audit_logging.c:600:2: note: ‘snprintf’ output
between 8 and 70 bytes into a destination of size 50
snprintf(
^~~~~~~~~
timestamp,
~~~~~~~~~~
sizeof(timestamp),
~~~~~~~~~~~~~~~~~~
"%s.%06ld%s",
~~~~~~~~~~~~~
buffer,
~~~~~~~
tv.tv_usec,
~~~~~~~~~~~
tz);
~~~
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13437
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Thu May 17 20:17:35 CEST 2018 on sn-devel-144
Diffstat (limited to 'lib/audit_logging')
| -rw-r--r-- | lib/audit_logging/audit_logging.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/audit_logging/audit_logging.c b/lib/audit_logging/audit_logging.c index 7da161cd204..5c16806d54e 100644 --- a/lib/audit_logging/audit_logging.c +++ b/lib/audit_logging/audit_logging.c @@ -569,7 +569,7 @@ void json_add_version(struct json_object *object, int major, int minor) void json_add_timestamp(struct json_object *object) { char buffer[40]; /* formatted time less usec and timezone */ - char timestamp[50]; /* the formatted ISO 8601 time stamp */ + char timestamp[65]; /* the formatted ISO 8601 time stamp */ char tz[10]; /* formatted time zone */ struct tm* tm_info; /* current local time */ struct timeval tv; /* current system time */ |