diff options
| author | Noel Power <noel.power@suse.com> | 2019-07-09 15:06:30 +0000 |
|---|---|---|
| committer | Gary Lockyer <gary@samba.org> | 2019-07-24 21:33:21 +0000 |
| commit | be2b69fecebd35d7a60057d6515e4401d3ce1294 (patch) | |
| tree | f6fb1b8efae067347547c75539d00b76c9a316e6 /lib/addns | |
| parent | da4c1c5f39669274bf8ff5a0974b4111f80be798 (diff) | |
| download | samba-be2b69fecebd35d7a60057d6515e4401d3ce1294.tar.gz | |
lib/addns: clang: Fix 'Assigned value is garbage or undefined'
Fixes:
lib/addns/dnsquery.c:222:10: warning: Assigned value is garbage or undefined <--[clang]
*numdcs = num_srvs; /* size_t->int */
^
1 warning generated.
Also fixes the out param being modified even on failure
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
Diffstat (limited to 'lib/addns')
| -rw-r--r-- | lib/addns/dnsquery.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/lib/addns/dnsquery.c b/lib/addns/dnsquery.c index 87ae97e3d0b..90e4de9a053 100644 --- a/lib/addns/dnsquery.c +++ b/lib/addns/dnsquery.c @@ -205,7 +205,7 @@ NTSTATUS ads_dns_lookup_srv(TALLOC_CTX *ctx, struct tevent_context *ev; struct tevent_req *req; NTSTATUS status = NT_STATUS_NO_MEMORY; - size_t num_srvs; + size_t num_srvs = 0; ev = samba_tevent_context_init(ctx); if (ev == NULL) { @@ -219,7 +219,9 @@ NTSTATUS ads_dns_lookup_srv(TALLOC_CTX *ctx, goto fail; } status = ads_dns_lookup_srv_recv(req, ctx, dclist, &num_srvs); - *numdcs = num_srvs; /* size_t->int */ + if (NT_STATUS_IS_OK(status)) { + *numdcs = num_srvs; /* size_t->int */ + } fail: TALLOC_FREE(ev); return status; |