diff options
| author | Björn Jacke <bj@sernet.de> | 2019-08-23 02:19:20 +0200 |
|---|---|---|
| committer | Bjoern Jacke <bjacke@samba.org> | 2019-09-24 13:40:21 +0000 |
| commit | 4f5c4df316dc029f7b5ed6e8e48636dc61ecfe22 (patch) | |
| tree | ae269749bfc21bfe7820c8cef7597b18634e42a7 /docs-xml | |
| parent | c9088c6aa847685613ec34d61b61e31fe0395035 (diff) | |
| download | samba-4f5c4df316dc029f7b5ed6e8e48636dc61ecfe22.tar.gz | |
wscript_build: string concatenation efficiency cleanup
Signed-off-by: Bjoern Jacke <bjacke@samba.org>
Reviewed-by: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-User(master): Björn Jacke <bjacke@samba.org>
Autobuild-Date(master): Tue Sep 24 13:40:21 UTC 2019 on sn-devel-184
Diffstat (limited to 'docs-xml')
| -rw-r--r-- | docs-xml/wscript_build | 20 |
1 files changed, 8 insertions, 12 deletions
diff --git a/docs-xml/wscript_build b/docs-xml/wscript_build index f207e51ff21..b85309d4ead 100644 --- a/docs-xml/wscript_build +++ b/docs-xml/wscript_build @@ -115,26 +115,22 @@ def smbdotconf_generate_parameter_list(task): articles = task.inputs entities = bld.pathconfig_entities() - t = "<!DOCTYPE section [\n" - - for entity in entities: - t += "%s\n" % entity # We need this if we build with Heimdal mit_kdc_path = '"/usr/sbin/krb5kdc"' - # The MIT krb5kdc path is set if we build with MIT Kerberos if bld.CONFIG_SET('MIT_KDC_PATH'): mit_kdc_path = bld.CONFIG_GET('MIT_KDC_PATH') - t += "<!ENTITY pathconfig.MITKDCPATH %s>\n" % mit_kdc_path - - t += "]>\n" - t += "<section>\n" - for article in articles: - t += article.read() + t = "<!DOCTYPE section [\n" +\ + "\n".join(entities) +\ + "\n" +\ + "<!ENTITY pathconfig.MITKDCPATH " + mit_kdc_path + ">\n" +\ + "]>\n" +\ + "<section>\n" +\ + "".join(art.read() for art in articles) +\ + "</section>\n" - t += "</section>\n" save_file(parameter_all, t , create_dir=True) return 0 |