summaryrefslogtreecommitdiff
path: root/ctdb
diff options
context:
space:
mode:
authorMartin Schwenke <martin@meltin.net>2020-08-05 17:40:42 +1000
committerAmitay Isaacs <amitay@samba.org>2020-09-11 05:06:42 +0000
commitd9d8bf8c54c248f14133332444a065f0daeae196 (patch)
tree326d7ff6659196e08292c3f453a7f4c2782d6b40 /ctdb
parented9abf94b3167a1a61b5da163e9b07b06c8a457b (diff)
downloadsamba-d9d8bf8c54c248f14133332444a065f0daeae196.tar.gz
ctdb-tests: Simplify comment in large database recovery test
The older style controls mentioned are being removed. Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Diffstat (limited to 'ctdb')
-rwxr-xr-xctdb/tests/INTEGRATION/database/recovery.002.large.sh14
1 files changed, 4 insertions, 10 deletions
diff --git a/ctdb/tests/INTEGRATION/database/recovery.002.large.sh b/ctdb/tests/INTEGRATION/database/recovery.002.large.sh
index 4c0f7024a99..3dd0d66e000 100755
--- a/ctdb/tests/INTEGRATION/database/recovery.002.large.sh
+++ b/ctdb/tests/INTEGRATION/database/recovery.002.large.sh
@@ -2,16 +2,10 @@
# Test recovery of large volatile and persistent databases
-# Older style of recovery using PULL_DB and PUSH_DB controls tries to
-# construct a single large marshall buffer for all the records in the
-# database. However, this approach is problematic as talloc restricts the
-# maximum size of buffer to 256M. Also, trying to construct and send large
-# buffers is inefficient and can cause CTDB daemon to be tied up for long
-# periods of time.
-
-# Instead new style recovery is introduced using DB_PULL and
-# DB_PUSH_START/DB_PUSH_CONFIRM controls. This sends the records in
-# batches of ~RecBufferSizeLimit in size at a time.
+# Recovery now uses DB_PULL and DB_PUSH_START/DB_PUSH_CONFIRM
+# controls. This sends the records in batches of ~RecBufferSizeLimit
+# in size at a time. Test that large databases are re-assembled
+# correctly.
. "${TEST_SCRIPTS_DIR}/integration.bash"