diff options
| author | Martin Schwenke <martin@meltin.net> | 2022-08-08 18:19:34 +1000 |
|---|---|---|
| committer | Amitay Isaacs <amitay@samba.org> | 2022-08-25 16:15:45 +0000 |
| commit | a0e0fde039e924d192294ad95da4344eff390c0c (patch) | |
| tree | dadb8f157ae2da4f3edcb7042a4d2260259dd474 /ctdb | |
| parent | ff4935d180e1a290e4ba7ab0f8710d9a022d1b82 (diff) | |
| download | samba-a0e0fde039e924d192294ad95da4344eff390c0c.tar.gz | |
ctdb-tests: Avoid shellcheck warnings
Mostly
SC2086: Double quote to prevent globbing and word splitting.
Use ctdb_onnode() where it simplifies code. No behaviour changes
intended.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
Autobuild-Date(master): Thu Aug 25 16:15:45 UTC 2022 on sn-devel-184
Diffstat (limited to 'ctdb')
| -rwxr-xr-x | ctdb/tests/CLUSTER/complex/11_ctdb_delip_removes_ip.sh | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/ctdb/tests/CLUSTER/complex/11_ctdb_delip_removes_ip.sh b/ctdb/tests/CLUSTER/complex/11_ctdb_delip_removes_ip.sh index 77e59f8c927..072780ac215 100755 --- a/ctdb/tests/CLUSTER/complex/11_ctdb_delip_removes_ip.sh +++ b/ctdb/tests/CLUSTER/complex/11_ctdb_delip_removes_ip.sh @@ -20,13 +20,15 @@ ctdb_test_init select_test_node_and_ips +# $test_node and $test_ip set by select_test_node_and_ips() +# shellcheck disable=SC2154 echo "Checking that node ${test_node} hosts ${test_ip}..." test_node_has_test_ip echo "Attempting to remove ${test_ip} from node ${test_node}." -try_command_on_node $test_node $CTDB delip $test_ip -try_command_on_node $test_node $CTDB ipreallocate -wait_until_ips_are_on_node '!' $test_node $test_ip +ctdb_onnode "$test_node" "delip ${test_ip}" +ctdb_onnode "$test_node" "ipreallocate" +wait_until_ips_are_on_node '!' "$test_node" "$test_ip" echo "Waiting for ${test_ip} to disappear from node ${test_node}..." wait_until 60/5 '!' test_node_has_test_ip |