summaryrefslogtreecommitdiff
path: root/ctdb/server
diff options
context:
space:
mode:
authorMartin Schwenke <martin@meltin.net>2019-05-11 14:24:24 +1000
committerAmitay Isaacs <amitay@samba.org>2019-05-14 07:25:37 +0000
commit6a2941e2a9fd6ab2d5b8dbac042b61a7b1b0b914 (patch)
tree1e4271b24362f18afa592b36acf8ab1f9366221f /ctdb/server
parentdc89db8ca6aadd4a9f7e8a85843c53709d04587c (diff)
downloadsamba-6a2941e2a9fd6ab2d5b8dbac042b61a7b1b0b914.tar.gz
ctdb-recoverd: Fix memory leak
state is always freed before exiting this function, so allocate fde off it instead of long-lived ctdb context. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13943 Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com>
Diffstat (limited to 'ctdb/server')
-rw-r--r--ctdb/server/ctdb_recoverd.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/ctdb/server/ctdb_recoverd.c b/ctdb/server/ctdb_recoverd.c
index 9b3559b2a92..3e63bd1e7a5 100644
--- a/ctdb/server/ctdb_recoverd.c
+++ b/ctdb/server/ctdb_recoverd.c
@@ -1134,7 +1134,7 @@ static int helper_run(struct ctdb_recoverd *rec, TALLOC_CTX *mem_ctx,
state->done = false;
- fde = tevent_add_fd(rec->ctdb->ev, rec->ctdb, state->fd[0],
+ fde = tevent_add_fd(rec->ctdb->ev, state, state->fd[0],
TEVENT_FD_READ, helper_handler, state);
if (fde == NULL) {
goto fail;