summaryrefslogtreecommitdiff
path: root/ctdb/server/ctdb_takeover_helper.c
diff options
context:
space:
mode:
authorMartin Schwenke <martin@meltin.net>2017-02-07 15:30:08 +1100
committerMartin Schwenke <martins@samba.org>2017-02-24 11:50:36 +0100
commit52c4d33d01646bfd02442150860615173c287336 (patch)
treeee1a4fed859ab8d1ecc242b7de1dc9a68a826de8 /ctdb/server/ctdb_takeover_helper.c
parent75d08229858a3f236333aadc6422c18e92e872f8 (diff)
downloadsamba-52c4d33d01646bfd02442150860615173c287336.tar.gz
ctdb-takeover: Don't release IPs from nodes where they are not known
This avoids confusing log messages like: ctdbd[21635]: releaseip called for an ip '10.1.1.1' that is not a public address Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Amitay Isaacs <amitay@gmail.com> Autobuild-User(master): Martin Schwenke <martins@samba.org> Autobuild-Date(master): Fri Feb 24 11:50:36 CET 2017 on sn-devel-144
Diffstat (limited to 'ctdb/server/ctdb_takeover_helper.c')
-rw-r--r--ctdb/server/ctdb_takeover_helper.c6
1 files changed, 6 insertions, 0 deletions
diff --git a/ctdb/server/ctdb_takeover_helper.c b/ctdb/server/ctdb_takeover_helper.c
index af8656900e7..5efd6198394 100644
--- a/ctdb/server/ctdb_takeover_helper.c
+++ b/ctdb/server/ctdb_takeover_helper.c
@@ -301,6 +301,12 @@ static struct tevent_req *release_ip_send(TALLOC_CTX *mem_ctx,
for (i = 0; i < count; i++) {
uint32_t pnn = pnns[i];
+
+ /* Skip this node if IP is not known */
+ if (! bitmap_query(tmp_ip->known_on, pnn)) {
+ continue;
+ }
+
/* If pnn is not the node that should be
* hosting the IP then add it to the list of
* nodes that need to do a release. */