diff options
| author | Martin Schwenke <martin@meltin.net> | 2011-11-09 15:20:07 +1100 |
|---|---|---|
| committer | Martin Schwenke <martin@meltin.net> | 2011-11-09 15:20:07 +1100 |
| commit | c1e8ea08e38464243f1d6b4079413ee431410c6d (patch) | |
| tree | 35d0410ea87a243bf86b530b049a6d2e9d8bbd0d /ctdb/client | |
| parent | 3b47e5fa491360af5d3c94fbb5bb21fe6271962b (diff) | |
| download | samba-c1e8ea08e38464243f1d6b4079413ee431410c6d.tar.gz | |
Clean up warnings: log some unchecked return codes from function calls
In a few places functions are called, the return code is assigned into
a variable but it is not checked. This generates a compiler warning
like this:
warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
Instead we remove the warning by checking the return code variable and
log a warning at DEBUG level if the return code indicates an error.
The justification is that there may have been a future intent to check
the return code but it hasn't been important enough to follow-up. If
it matters, it will be logged for easy debugging.
Signed-off-by: Martin Schwenke <martin@meltin.net>
(This used to be ctdb commit 1932466c76de2b184c2a257120768ab8c9d6c12a)
Diffstat (limited to 'ctdb/client')
| -rw-r--r-- | ctdb/client/ctdb_client.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/ctdb/client/ctdb_client.c b/ctdb/client/ctdb_client.c index f0172e42326..870edaa5827 100644 --- a/ctdb/client/ctdb_client.c +++ b/ctdb/client/ctdb_client.c @@ -388,6 +388,9 @@ static struct ctdb_client_call_state *ctdb_client_call_local_send(struct ctdb_db state->ctdb_db = ctdb_db; ret = ctdb_call_local(ctdb_db, state->call, header, state, data, true); + if (ret != 0) { + DEBUG(DEBUG_DEBUG,("ctdb_call_local() failed, ignoring return code %d\n", ret)); + } return state; } @@ -916,6 +919,9 @@ static void invoke_control_callback(struct event_context *ev, struct timed_event NULL, NULL, NULL); + if (ret != 0) { + DEBUG(DEBUG_DEBUG,("ctdb_control_recv() failed, ignoring return code %d\n", ret)); + } talloc_free(tmp_ctx); } |