summaryrefslogtreecommitdiff
path: root/auth
diff options
context:
space:
mode:
authorJoseph Sutton <josephsutton@catalyst.net.nz>2022-11-07 19:27:24 +1300
committerAndrew Bartlett <abartlet@samba.org>2023-02-08 00:03:39 +0000
commit3d846db42db15465d47f2c5e285d3e958bdf5f98 (patch)
treed2cb009d393a991804edc3781cacd9afd5f9cb08 /auth
parentc7b76764dc10fd2479f51ddf3fb4f1eb20790371 (diff)
downloadsamba-3d846db42db15465d47f2c5e285d3e958bdf5f98.tar.gz
auth: Only process resource groups if NETLOGON_RESOURCE_GROUPS flag is set
MS-PAC section 2.5 states that if the resource_groups member is non-NULL, or resource_groups.groups.count is not zero, the NETLOGON_RESOURCE_GROUPS flag MUST be set. Thus, there's no need to process resource groups if the flag is not set. Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Diffstat (limited to 'auth')
-rw-r--r--auth/auth_sam_reply.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/auth/auth_sam_reply.c b/auth/auth_sam_reply.c
index b088ebb9a43..7632d263650 100644
--- a/auth/auth_sam_reply.c
+++ b/auth/auth_sam_reply.c
@@ -590,8 +590,6 @@ NTSTATUS make_user_info_dc_pac(TALLOC_CTX *mem_ctx,
const struct PAC_DOMAIN_GROUP_MEMBERSHIP *rg = NULL;
size_t sidcount;
- rg = &pac_logon_info->resource_groups;
-
validation.sam3 = discard_const_p(struct netr_SamInfo3, &pac_logon_info->info3);
nt_status = make_user_info_dc_netlogon_validation(mem_ctx, "", 3, &validation,