summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndreas Schneider <asn@samba.org>2021-06-22 09:35:47 +0200
committerAndrew Bartlett <abartlet@samba.org>2021-06-29 02:19:35 +0000
commitee9dc1fb47442c6b8839b10be135f2af525fe376 (patch)
treec30eca6b825e089c3765680d2f3382d6b29bc7a0
parent08585bcfb2b60c1684f2f5c69496d16b8d86ee6b (diff)
downloadsamba-ee9dc1fb47442c6b8839b10be135f2af525fe376.tar.gz
s3:libsmb: Check return code of cli_credentials_guess()
Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
-rw-r--r--source3/libsmb/auth_generic.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/source3/libsmb/auth_generic.c b/source3/libsmb/auth_generic.c
index 59560d677bc..e5120a083a6 100644
--- a/source3/libsmb/auth_generic.c
+++ b/source3/libsmb/auth_generic.c
@@ -64,6 +64,7 @@ NTSTATUS auth_generic_client_prepare(TALLOC_CTX *mem_ctx, struct auth_generic_st
struct gensec_settings *gensec_settings;
const struct gensec_security_ops **backends = NULL;
struct loadparm_context *lp_ctx;
+ bool ok;
ans = talloc_zero(mem_ctx, struct auth_generic_state);
if (!ans) {
@@ -120,7 +121,11 @@ NTSTATUS auth_generic_client_prepare(TALLOC_CTX *mem_ctx, struct auth_generic_st
return NT_STATUS_NO_MEMORY;
}
- cli_credentials_guess(ans->credentials, lp_ctx);
+ ok = cli_credentials_guess(ans->credentials, lp_ctx);
+ if (!ok) {
+ TALLOC_FREE(ans);
+ return NT_STATUS_INTERNAL_ERROR;
+ }
talloc_unlink(ans, lp_ctx);
talloc_unlink(ans, gensec_settings);