diff options
| author | Joseph Sutton <josephsutton@catalyst.net.nz> | 2022-05-10 16:18:14 +1200 |
|---|---|---|
| committer | Andrew Bartlett <abartlet@samba.org> | 2022-05-10 23:05:31 +0000 |
| commit | ede2fcb5fe855ceb81b8f7f40975334f52c811b5 (patch) | |
| tree | 545d4a45accf623581c9cf812d98ca0179bd52b4 | |
| parent | 187635ff6ff1d62a9c5630d3969e65867cb3bb4a (diff) | |
| download | samba-ede2fcb5fe855ceb81b8f7f40975334f52c811b5.tar.gz | |
tests/user_check_password_script: Don't try to delete user after failed add
The user account should not exist if account creation failed.
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
| -rw-r--r-- | python/samba/tests/samba_tool/user_check_password_script.py | 4 | ||||
| -rw-r--r-- | selftest/knownfail.d/samba-tool-add-user | 2 |
2 files changed, 0 insertions, 6 deletions
diff --git a/python/samba/tests/samba_tool/user_check_password_script.py b/python/samba/tests/samba_tool/user_check_password_script.py index 12d98eb7b62..60a9add1a19 100644 --- a/python/samba/tests/samba_tool/user_check_password_script.py +++ b/python/samba/tests/samba_tool/user_check_password_script.py @@ -42,10 +42,6 @@ class UserCheckPwdTestCase(SambaToolCmdTest): "-H", "ldap://%s" % os.environ["DC_SERVER"], "-U%s%%%s" % (os.environ["DC_USERNAME"], os.environ["DC_PASSWORD"])) self.assertCmdFail(result, "Should fail adding a user with %s password." % desc) - (result, out, err) = self.runsubcmd("user", "delete", user["name"], - "-H", "ldap://%s" % os.environ["DC_SERVER"], - "-U%s%%%s" % (os.environ["DC_USERNAME"], os.environ["DC_PASSWORD"])) - self.assertCmdSuccess(result, out, err, "Should delete user with %s password." % desc) (result, out, err) = self.runsubcmd("user", "add", user["name"], good_password, "-H", "ldap://%s" % os.environ["DC_SERVER"], diff --git a/selftest/knownfail.d/samba-tool-add-user b/selftest/knownfail.d/samba-tool-add-user deleted file mode 100644 index e487281ed7d..00000000000 --- a/selftest/knownfail.d/samba-tool-add-user +++ /dev/null @@ -1,2 +0,0 @@ -^samba.tests.samba_tool.user_check_password_script.samba.tests.samba_tool.user_check_password_script.UserCheckPwdTestCase.test_checkpassword_unacceptable.chgdcpass:local -^samba.tests.samba_tool.user_check_password_script.samba.tests.samba_tool.user_check_password_script.UserCheckPwdTestCase.test_checkpassword_username.chgdcpass:local |