diff options
| author | Douglas Bagnall <douglas.bagnall@catalyst.net.nz> | 2019-11-16 21:25:11 +1300 |
|---|---|---|
| committer | Douglas Bagnall <dbagnall@samba.org> | 2019-11-17 23:54:11 +0000 |
| commit | e856877ef88bf273cbf814ff17abad900ba7ea27 (patch) | |
| tree | c876022a71edd81810069b1a99d365173fca99ae | |
| parent | 816869ecea06b0b936e3ead4074bb754ee8650ca (diff) | |
| download | samba-e856877ef88bf273cbf814ff17abad900ba7ea27.tar.gz | |
ndrdump: avoid use after free
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Douglas Bagnall <dbagnall@samba.org>
Autobuild-Date(master): Sun Nov 17 23:54:11 UTC 2019 on sn-devel-184
| -rw-r--r-- | librpc/tools/ndrdump.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/librpc/tools/ndrdump.c b/librpc/tools/ndrdump.c index 2db6be3366b..e911cf4c1e4 100644 --- a/librpc/tools/ndrdump.c +++ b/librpc/tools/ndrdump.c @@ -228,10 +228,11 @@ static NTSTATUS ndrdump_pull_and_print_pipes(const char *function, return ndr_map_error2ntstatus(ndr_err); } pipes->pipes[i].ndr_print(ndr_print, n, c); - talloc_free(c); if (*count == 0) { + talloc_free(c); break; } + talloc_free(c); idx++; } } |