summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGary Lockyer <gary@catalyst.net.nz>2018-06-09 14:58:51 +0200
committerAndrew Bartlett <abartlet@samba.org>2018-06-10 19:02:19 +0200
commite5c0e6da6593fb77d5a16ece9aa85532d855d2be (patch)
tree85348e68aa8259c43859e91da0c61fd4f5524fc6
parent81f7ecc2a7fa1d44ef9a1f310eaf890c8fb8b158 (diff)
downloadsamba-e5c0e6da6593fb77d5a16ece9aa85532d855d2be.tar.gz
lib/audit_logging fix flapping test
Add an adjustment to the before and after values to cater for the occasional differences between the calculated times. The exact value of the time stamp is not important what is important is that is correctly formatted and that the value is reasonable i.e. it's close enough to the current time. Signed-off-by: Gary Lockyer <gary@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
-rw-r--r--lib/audit_logging/tests/audit_logging_test.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/lib/audit_logging/tests/audit_logging_test.c b/lib/audit_logging/tests/audit_logging_test.c
index 6be71f31dbe..26875c98944 100644
--- a/lib/audit_logging/tests/audit_logging_test.c
+++ b/lib/audit_logging/tests/audit_logging_test.c
@@ -219,6 +219,7 @@ static void test_json_add_timestamp(void **state)
time_t before;
time_t after;
time_t actual;
+ const int adjustment = 1;
object = json_new_object();
@@ -255,7 +256,10 @@ static void test_json_add_timestamp(void **state)
/*
* The timestamp should be before <= actual <= after
+ * but we adjust the times to cater for any precision issues.
*/
+ before -= adjustment;
+ after += adjustment;
assert_true(difftime(actual, before) >= 0);
assert_true(difftime(after, actual) >= 0);