summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMartin Schwenke <martin@meltin.net>2017-10-11 19:04:28 +1100
committerMartin Schwenke <martins@samba.org>2017-10-16 05:28:19 +0200
commite0cf8a4d0d3d820164d333d8968d4a3b599acd54 (patch)
treee6eb6692dd3bd5ad195547fd4bff7d16b6ede993
parent9b880defb6f364925ab2b0ebba3158a21ca062a6 (diff)
downloadsamba-e0cf8a4d0d3d820164d333d8968d4a3b599acd54.tar.gz
ctdb-test: Fix CID 1419118 (Error handling issues)
Signed-off-by: Martin Schwenke <martin@meltin.net> Reviewed-by: Volker Lendecke <vl@samba.org>
-rw-r--r--ctdb/tests/src/fake_ctdbd.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/ctdb/tests/src/fake_ctdbd.c b/ctdb/tests/src/fake_ctdbd.c
index 06b5b2265c9..b0a251af9be 100644
--- a/ctdb/tests/src/fake_ctdbd.c
+++ b/ctdb/tests/src/fake_ctdbd.c
@@ -251,7 +251,11 @@ static bool nodemap_parse(struct node_map *node_map)
}
node = &node_map->node[node_map->num_nodes];
- ctdb_sock_addr_from_string(ip, &node->addr, false);
+ ret = ctdb_sock_addr_from_string(ip, &node->addr, false);
+ if (ret != 0) {
+ fprintf(stderr, "bad line (%s) - invalid IP\n", line);
+ continue;
+ }
ctdb_sock_addr_set_port(&node->addr, CTDB_PORT);
node->pnn = pnn;
node->flags = flags;