summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVolker Lendecke <vl@samba.org>2018-08-07 22:50:52 +0200
committerKarolin Seeger <kseeger@samba.org>2018-08-23 10:38:28 +0200
commitd4e8fd5fd246a80e1a13a2bf3965d0335d4dc2c4 (patch)
treea2a394439cc7508b4e8bf1e670212ede0b304a3d
parent2e285845ea03c5505092b8de5f6097e5845b25ec (diff)
downloadsamba-d4e8fd5fd246a80e1a13a2bf3965d0335d4dc2c4.tar.gz
smbd: Fix CID 1438245 Dereference before null check
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13553 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org>
-rw-r--r--source3/smbd/nttrans.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/source3/smbd/nttrans.c b/source3/smbd/nttrans.c
index bad904b9eb8..68470766f77 100644
--- a/source3/smbd/nttrans.c
+++ b/source3/smbd/nttrans.c
@@ -2459,7 +2459,7 @@ static enum ndr_err_code extract_sids_from_buf(TALLOC_CTX *mem_ctx,
}
}
*sids = talloc_zero_array(mem_ctx, struct dom_sid, i);
- if (!sids) {
+ if (*sids == NULL) {
DBG_ERR("OOM\n");
err = NDR_ERR_ALLOC;
goto done;