diff options
| author | Martin Schwenke <martin@meltin.net> | 2014-12-30 16:17:19 +1100 |
|---|---|---|
| committer | Amitay Isaacs <amitay@samba.org> | 2015-05-10 03:22:13 +0200 |
| commit | c927ec928cce1ee4cf9ffcf4aa3d6c8ef6ad4144 (patch) | |
| tree | a21fb4d09bcefd3c9eff93c70734c11c67499227 | |
| parent | 7ee57b8d7c0b882227dab1f83187e44dd4639ad3 (diff) | |
| download | samba-c927ec928cce1ee4cf9ffcf4aa3d6c8ef6ad4144.tar.gz | |
ctdb-scripts: Drop update of public address configuration from config.tdb
This isn't used or documented anywhere.
2 differing points of view:
* This is a very good idea but it should probably be generalised to
cover more configuration items. This would end up like the Samba
registry configuration and would use a tool to support setting
configuration values.
* If people really want to update configuration while a node is down
then they should fix the configuration before bringing up that node.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Amitay Isaacs <amitay@gmail.com>
| -rwxr-xr-x | ctdb/config/events.d/00.ctdb | 22 |
1 files changed, 0 insertions, 22 deletions
diff --git a/ctdb/config/events.d/00.ctdb b/ctdb/config/events.d/00.ctdb index d8096ee46c6..5e8af4cbede 100755 --- a/ctdb/config/events.d/00.ctdb +++ b/ctdb/config/events.d/00.ctdb @@ -100,27 +100,6 @@ EOF done } -update_config_from_tdb() { - - # Pull optional ctdb configuration data out of config.tdb - ctdb_get_pnn - _key="public_addresses:node#${pnn}" - _t="$service_state_dir/public_addresses" - rm -f "$_t" - - if ctdb pfetch config.tdb "$_key" "$_t" 2>/dev/null && \ - [ -s "$_t" -a -n "$CTDB_PUBLIC_ADDRESSES"] && \ - ! cmp -s "$_t" "$CTDB_PUBLIC_ADDRESSES" ; then - - echo "CTDB public address configuration has changed." - echo "Extracting new configuration from database." - diff "$_t" "$CTDB_PUBLIC_ADDRESSES" - cp "$_t" "$CTDB_PUBLIC_ADDRESSES" - echo "Restarting CTDB" - service ctdb restart & - fi -} - set_ctdb_variables () { # set any tunables from the config file @@ -211,7 +190,6 @@ case "$1" in startup) ctdb attach ctdb.tdb persistent - update_config_from_tdb & ;; monitor) monitor_system_memory |