summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndreas Schneider <asn@samba.org>2022-03-15 13:02:05 +0100
committerJule Anger <janger@samba.org>2022-03-17 09:14:56 +0000
commitabe01ca6b215e51dea8328869731d88956bfb2dc (patch)
treefc3b2aa3fc72dd65a45d5928cc58a264781d0e72
parent3c5d0c379d7882d8c3c45a0dde53a68c7ec8a2a7 (diff)
downloadsamba-abe01ca6b215e51dea8328869731d88956bfb2dc.tar.gz
s3:libads: Check print_canonical_sockaddr_with_port() for NULL in get_kdc_ip_string()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15016 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org> (cherry picked from commit 12c843ad0a97fcbaaea738b82941533e5d2aec99)
-rw-r--r--source3/libads/kerberos.c9
1 files changed, 7 insertions, 2 deletions
diff --git a/source3/libads/kerberos.c b/source3/libads/kerberos.c
index 2087dc1e6f9..20dceeefb22 100644
--- a/source3/libads/kerberos.c
+++ b/source3/libads/kerberos.c
@@ -435,13 +435,18 @@ static char *get_kdc_ip_string(char *mem_ctx,
NTSTATUS status;
bool ok;
char *kdc_str = NULL;
+ char *canon_sockaddr = NULL;
SMB_ASSERT(pss != NULL);
+ canon_sockaddr = print_canonical_sockaddr_with_port(frame, pss);
+ if (canon_sockaddr == NULL) {
+ goto out;
+ }
+
kdc_str = talloc_asprintf(frame,
"\t\tkdc = %s\n",
- print_canonical_sockaddr_with_port(mem_ctx,
- pss));
+ canon_sockaddr);
if (kdc_str == NULL) {
goto out;
}