diff options
| author | Garming Sam <garming@catalyst.net.nz> | 2016-09-08 14:46:06 +1200 |
|---|---|---|
| committer | Karolin Seeger <kseeger@samba.org> | 2016-10-20 10:45:28 +0200 |
| commit | a67aa0ac6cf39fafd00dd1779169467dceb55b24 (patch) | |
| tree | e251c08101971c3b770d480f9fd8fdd8511a8430 | |
| parent | e7ef79c800b6942010b30edb89320433e7b86f65 (diff) | |
| download | samba-a67aa0ac6cf39fafd00dd1779169467dceb55b24.tar.gz | |
rpmd: Add a TODO regarding the additional work performed
Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
BUG: https://bugzilla.samba.org/show_bug.cgi?id=12382
(cherry picked from commit 434bf4a5b5899c3390730bbd1f8ffad899a3ff73)
| -rw-r--r-- | source4/dsdb/samdb/ldb_modules/repl_meta_data.c | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/source4/dsdb/samdb/ldb_modules/repl_meta_data.c b/source4/dsdb/samdb/ldb_modules/repl_meta_data.c index 2aae797eb5c..44fbbf46d76 100644 --- a/source4/dsdb/samdb/ldb_modules/repl_meta_data.c +++ b/source4/dsdb/samdb/ldb_modules/repl_meta_data.c @@ -2600,6 +2600,16 @@ static int replmd_modify_handle_linked_attribs(struct ldb_module *module, return LDB_SUCCESS; } + /* + * TODO: + * + * We should restrict this to the intersection of the list of + * linked attributes in the schema and the list of attributes + * being modified. + * + * This will help performance a little, as otherwise we have + * to allocate the entire object value-by-value. + */ ret = dsdb_module_search_dn(module, msg, &res, msg->dn, NULL, DSDB_FLAG_NEXT_MODULE | DSDB_SEARCH_SHOW_RECYCLED | |