diff options
| author | Jeremy Allison <jra@samba.org> | 2014-07-01 20:27:11 -0700 |
|---|---|---|
| committer | Michael Adam <obnox@samba.org> | 2014-07-02 08:03:15 +0200 |
| commit | 6767d519c5c78aee2fdb3195530ec38cf2f08fb6 (patch) | |
| tree | badd83818e13efb79693c3e62d85cdbd698ef628 | |
| parent | 9fc9e4869f1ddcfeea1e286f9caeb8e8a6cc3a9a (diff) | |
| download | samba-6767d519c5c78aee2fdb3195530ec38cf2f08fb6.tar.gz | |
s3:winbindd - fix bad bugfix for bug #10280 - winbind panic if AD server is down.
Previous bug fix reversed the sense of the test for out of memory.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=10280
Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
| -rw-r--r-- | source3/winbindd/winbindd_cache.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/source3/winbindd/winbindd_cache.c b/source3/winbindd/winbindd_cache.c index 51f3e04eae7..dfad8f5c089 100644 --- a/source3/winbindd/winbindd_cache.c +++ b/source3/winbindd/winbindd_cache.c @@ -2129,14 +2129,14 @@ static NTSTATUS rids_to_names(struct winbindd_domain *domain, have_mapped = have_unmapped = false; *names = talloc_array(mem_ctx, char *, num_rids); - if (*names != NULL) { + if (*names == NULL) { result = NT_STATUS_NO_MEMORY; goto error; } *types = talloc_array(mem_ctx, enum lsa_SidType, num_rids); - if (*types != NULL) { + if (*types == NULL) { result = NT_STATUS_NO_MEMORY; goto error; } |