summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJoseph Sutton <josephsutton@catalyst.net.nz>2023-03-07 11:13:41 +1300
committerAndrew Bartlett <abartlet@samba.org>2023-03-20 00:22:32 +0000
commit3c5296d9aea38521e6df8834a856d510106300a8 (patch)
tree460f07486fd0be0ecdeb1194c3f1c9debcb0236e
parented0b850e3dc13dba1f7291d8ed45e93fd1cb9c94 (diff)
downloadsamba-3c5296d9aea38521e6df8834a856d510106300a8.tar.gz
winbindd: Show warning message on tc connection errors too
Some of these conditions could never be hit. Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
-rw-r--r--source3/winbindd/winbindd_dual_srv.c12
1 files changed, 9 insertions, 3 deletions
diff --git a/source3/winbindd/winbindd_dual_srv.c b/source3/winbindd/winbindd_dual_srv.c
index aaa78a9cb6e..2272a8b80a8 100644
--- a/source3/winbindd/winbindd_dual_srv.c
+++ b/source3/winbindd/winbindd_dual_srv.c
@@ -1214,7 +1214,9 @@ check_return:
}
info2->tc_connection_status = check_result;
- if (!W_ERROR_IS_OK(info2->pdc_connection_status)) {
+ if (!W_ERROR_IS_OK(info2->pdc_connection_status) ||
+ !W_ERROR_IS_OK(info2->tc_connection_status))
+ {
DEBUG(2, ("%s: domain[%s/%s] dcname[%s] "
"pdc_connection[%s] tc_connection[%s]\n",
__func__, domain->name, domain->alt_name,
@@ -1282,7 +1284,9 @@ check_return:
}
info2->tc_connection_status = check_result;
- if (!W_ERROR_IS_OK(info2->pdc_connection_status)) {
+ if (!W_ERROR_IS_OK(info2->pdc_connection_status) ||
+ !W_ERROR_IS_OK(info2->tc_connection_status))
+ {
DEBUG(2, ("%s: domain[%s/%s] dcname[%s] "
"pdc_connection[%s] tc_connection[%s]\n",
__func__, domain->name, domain->alt_name,
@@ -1604,7 +1608,9 @@ verify_return:
}
info2->tc_connection_status = check_result;
- if (!W_ERROR_IS_OK(info2->pdc_connection_status)) {
+ if (!W_ERROR_IS_OK(info2->pdc_connection_status) ||
+ !W_ERROR_IS_OK(info2->tc_connection_status))
+ {
DEBUG(2, ("%s: domain[%s/%s] dcname[%s] "
"pdc_connection[%s] tc_connection[%s]\n",
__func__, domain->name, domain->alt_name,