summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorVolker Lendecke <vl@samba.org>2015-10-06 16:10:43 +0200
committerJeremy Allison <jra@samba.org>2015-10-24 05:01:32 +0200
commit0a924d13cf4bb570cce3955cf0de9d8678b37dbe (patch)
tree0ebe7497c2bb858e489bbe252bc1412ecd737d3a
parent11620aefac77ebeb58cce784d20d4415d227f4ee (diff)
downloadsamba-0a924d13cf4bb570cce3955cf0de9d8678b37dbe.tar.gz
smbd: Send SMB2 oplock breaks unencrypted
This is not what Windows server does, but it seems that Windows clients expect. Windows->Windows never runs into this issue, because an encryption-enabled SMB3 connection will always use leases, and lease breaks *are* unencrypted... You can reproduce the issue Windows->Windows by disabling leases on the Windows server. Disable leases using the registry key: HKLM\SYSTEM\CurrentControlSet\Services\LanmanServer\DisableLeasing Dochelp confirmed that this is a valid workaround for Windows clients dropping encrypted oplock breaks. BUG: https://bugzilla.samba.org/show_bug.cgi?id=11570 Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Sat Oct 24 05:01:32 CEST 2015 on sn-devel-104
-rw-r--r--source3/smbd/smb2_server.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/source3/smbd/smb2_server.c b/source3/smbd/smb2_server.c
index 29131eaae23..a31a6e21881 100644
--- a/source3/smbd/smb2_server.c
+++ b/source3/smbd/smb2_server.c
@@ -2994,7 +2994,7 @@ NTSTATUS smbd_smb2_send_oplock_break(struct smbXsrv_connection *xconn,
SBVAL(body, 0x08, op->global->open_persistent_id);
SBVAL(body, 0x10, op->global->open_volatile_id);
- return smbd_smb2_send_break(xconn, session, tcon, body, sizeof(body));
+ return smbd_smb2_send_break(xconn, NULL, NULL, body, sizeof(body));
}
NTSTATUS smbd_smb2_send_lease_break(struct smbXsrv_connection *xconn,