summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndrew Bartlett <abartlet@samba.org>2019-05-15 14:47:53 +1200
committerKarolin Seeger <kseeger@samba.org>2019-06-13 10:21:59 +0000
commit72e89a5d9df21a4f06e74fbbebc0675e2eaafbd8 (patch)
tree70188bd39a9d829986bcb70d075022d5fe592477
parent77de9567d92ed6d5c37ed611d5fc41df825527ee (diff)
downloadsamba-72e89a5d9df21a4f06e74fbbebc0675e2eaafbd8.tar.gz
s4 dsdb/repl_meta_data: allocate new extended DNs during ADD on a better context
Lower down in this function new_values is assigned over el->values and is filled in with the values of all the parsed DNs. Therefore it is the natural talloc parent. This will allow el->values to be allocated on tmp_ctx in the next commit for a working area during the function call. Signed-off-by: Andrew Bartlett <abartlet@samba.org> Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz> (cherry picked from commit 4aa9924310287ff3b36618496fa6c707c615ad4c)
-rw-r--r--source4/dsdb/samdb/ldb_modules/repl_meta_data.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/source4/dsdb/samdb/ldb_modules/repl_meta_data.c b/source4/dsdb/samdb/ldb_modules/repl_meta_data.c
index be4ea5592c4..053bdd1fc69 100644
--- a/source4/dsdb/samdb/ldb_modules/repl_meta_data.c
+++ b/source4/dsdb/samdb/ldb_modules/repl_meta_data.c
@@ -1007,7 +1007,7 @@ static int replmd_add_fix_la(struct ldb_module *module, TALLOC_CTX *mem_ctx,
for (i = 0; i < el->num_values; i++) {
struct parsed_dn *p = &pdn[i];
- ret = replmd_build_la_val(el->values, p->v, p->dsdb_dn,
+ ret = replmd_build_la_val(new_values, p->v, p->dsdb_dn,
&ac->our_invocation_id,
ac->seq_num, now);
if (ret != LDB_SUCCESS) {