From 72e89a5d9df21a4f06e74fbbebc0675e2eaafbd8 Mon Sep 17 00:00:00 2001 From: Andrew Bartlett Date: Wed, 15 May 2019 14:47:53 +1200 Subject: s4 dsdb/repl_meta_data: allocate new extended DNs during ADD on a better context Lower down in this function new_values is assigned over el->values and is filled in with the values of all the parsed DNs. Therefore it is the natural talloc parent. This will allow el->values to be allocated on tmp_ctx in the next commit for a working area during the function call. Signed-off-by: Andrew Bartlett Reviewed-by: Douglas Bagnall (cherry picked from commit 4aa9924310287ff3b36618496fa6c707c615ad4c) --- source4/dsdb/samdb/ldb_modules/repl_meta_data.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source4/dsdb/samdb/ldb_modules/repl_meta_data.c b/source4/dsdb/samdb/ldb_modules/repl_meta_data.c index be4ea5592c4..053bdd1fc69 100644 --- a/source4/dsdb/samdb/ldb_modules/repl_meta_data.c +++ b/source4/dsdb/samdb/ldb_modules/repl_meta_data.c @@ -1007,7 +1007,7 @@ static int replmd_add_fix_la(struct ldb_module *module, TALLOC_CTX *mem_ctx, for (i = 0; i < el->num_values; i++) { struct parsed_dn *p = &pdn[i]; - ret = replmd_build_la_val(el->values, p->v, p->dsdb_dn, + ret = replmd_build_la_val(new_values, p->v, p->dsdb_dn, &ac->our_invocation_id, ac->seq_num, now); if (ret != LDB_SUCCESS) { -- cgit v1.2.1