summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAndreas Schneider <asn@samba.org>2022-03-15 12:48:23 +0100
committerJule Anger <janger@samba.org>2022-03-17 09:14:56 +0000
commitcfbd47d7b48896847cd43da58167cd6afcbef31e (patch)
tree02bf42ead576715ccf05805107908c76b76ea71a
parentcce13c772f1db5a03e43f083819c458a4a8844c8 (diff)
downloadsamba-cfbd47d7b48896847cd43da58167cd6afcbef31e.tar.gz
s3:libads: Use talloc_asprintf_append() in get_kdc_ip_string()
BUG: https://bugzilla.samba.org/show_bug.cgi?id=15016 Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Guenther Deschner <gd@samba.org> (cherry picked from commit 812032833aa65729dbbfd4313a6e3fe072c88530)
-rw-r--r--source3/libads/kerberos.c9
1 files changed, 5 insertions, 4 deletions
diff --git a/source3/libads/kerberos.c b/source3/libads/kerberos.c
index 6a46d72a156..d1c410ffa4b 100644
--- a/source3/libads/kerberos.c
+++ b/source3/libads/kerberos.c
@@ -578,10 +578,11 @@ static char *get_kdc_ip_string(char *mem_ctx,
}
/* Append to the string - inefficient but not done often. */
- new_kdc_str = talloc_asprintf(mem_ctx, "%s\t\tkdc = %s\n",
- kdc_str,
- print_canonical_sockaddr_with_port(mem_ctx, &dc_addrs[i]));
- TALLOC_FREE(kdc_str);
+ new_kdc_str = talloc_asprintf_append(
+ kdc_str,
+ "\t\tkdc = %s\n",
+ print_canonical_sockaddr_with_port(
+ mem_ctx, &dc_addrs[i]));
if (new_kdc_str == NULL) {
goto out;
}