From cfbd47d7b48896847cd43da58167cd6afcbef31e Mon Sep 17 00:00:00 2001 From: Andreas Schneider Date: Tue, 15 Mar 2022 12:48:23 +0100 Subject: s3:libads: Use talloc_asprintf_append() in get_kdc_ip_string() BUG: https://bugzilla.samba.org/show_bug.cgi?id=15016 Signed-off-by: Andreas Schneider Reviewed-by: Guenther Deschner (cherry picked from commit 812032833aa65729dbbfd4313a6e3fe072c88530) --- source3/libads/kerberos.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/source3/libads/kerberos.c b/source3/libads/kerberos.c index 6a46d72a156..d1c410ffa4b 100644 --- a/source3/libads/kerberos.c +++ b/source3/libads/kerberos.c @@ -578,10 +578,11 @@ static char *get_kdc_ip_string(char *mem_ctx, } /* Append to the string - inefficient but not done often. */ - new_kdc_str = talloc_asprintf(mem_ctx, "%s\t\tkdc = %s\n", - kdc_str, - print_canonical_sockaddr_with_port(mem_ctx, &dc_addrs[i])); - TALLOC_FREE(kdc_str); + new_kdc_str = talloc_asprintf_append( + kdc_str, + "\t\tkdc = %s\n", + print_canonical_sockaddr_with_port( + mem_ctx, &dc_addrs[i])); if (new_kdc_str == NULL) { goto out; } -- cgit v1.2.1