diff options
| author | Stefan Metzmacher <metze@samba.org> | 2021-02-09 13:48:36 +0100 |
|---|---|---|
| committer | Karolin Seeger <kseeger@samba.org> | 2021-02-16 17:16:40 +0000 |
| commit | ecb41890f10e497a1dc1e25499b44538856af6f0 (patch) | |
| tree | 951ca122e36304b9933dfb568cfe66582ec1a710 | |
| parent | a6f228f67549f2be71cbfb96e632f0d0aa495055 (diff) | |
| download | samba-ecb41890f10e497a1dc1e25499b44538856af6f0.tar.gz | |
s3:pysmbd: fix fd leak in py_smbd_create_file()
Various 'samba-tool domain backup' commands use this and will
fail if there's over ~1000 files in the sysvol folder.
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13898
Signed-off-by: Stefan Metzmacher <metze@samba.org>
(cherry picked from commit d8fa464a2dfb11df4e1db4ebffe8bd28ff118c75)
| -rw-r--r-- | source3/smbd/pysmbd.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/source3/smbd/pysmbd.c b/source3/smbd/pysmbd.c index 042e31b79d6..3ef4fd7c248 100644 --- a/source3/smbd/pysmbd.c +++ b/source3/smbd/pysmbd.c @@ -1183,9 +1183,12 @@ static PyObject *py_smbd_create_file(PyObject *self, PyObject *args, PyObject *k if (!NT_STATUS_IS_OK(status)) { DBG_ERR("init_files_struct failed: %s\n", nt_errstr(status)); + } else if (fsp != NULL) { + SMB_VFS_CLOSE(fsp); } TALLOC_FREE(frame); + PyErr_NTSTATUS_NOT_OK_RAISE(status); Py_RETURN_NONE; } |