From ecb41890f10e497a1dc1e25499b44538856af6f0 Mon Sep 17 00:00:00 2001 From: Stefan Metzmacher Date: Tue, 9 Feb 2021 13:48:36 +0100 Subject: s3:pysmbd: fix fd leak in py_smbd_create_file() Various 'samba-tool domain backup' commands use this and will fail if there's over ~1000 files in the sysvol folder. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13898 Signed-off-by: Stefan Metzmacher (cherry picked from commit d8fa464a2dfb11df4e1db4ebffe8bd28ff118c75) --- source3/smbd/pysmbd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/source3/smbd/pysmbd.c b/source3/smbd/pysmbd.c index 042e31b79d6..3ef4fd7c248 100644 --- a/source3/smbd/pysmbd.c +++ b/source3/smbd/pysmbd.c @@ -1183,9 +1183,12 @@ static PyObject *py_smbd_create_file(PyObject *self, PyObject *args, PyObject *k if (!NT_STATUS_IS_OK(status)) { DBG_ERR("init_files_struct failed: %s\n", nt_errstr(status)); + } else if (fsp != NULL) { + SMB_VFS_CLOSE(fsp); } TALLOC_FREE(frame); + PyErr_NTSTATUS_NOT_OK_RAISE(status); Py_RETURN_NONE; } -- cgit v1.2.1