summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--lib/rack/session/cookie.rb2
-rw-r--r--test/spec_session_cookie.rb4
2 files changed, 5 insertions, 1 deletions
diff --git a/lib/rack/session/cookie.rb b/lib/rack/session/cookie.rb
index 63c426f0..c5e71711 100644
--- a/lib/rack/session/cookie.rb
+++ b/lib/rack/session/cookie.rb
@@ -55,7 +55,7 @@ module Rack
if @secret && session_data
session_data, digest = session_data.split("--")
- session_data = nil unless Utils.secure_compare(digest, generate_hmac(session_data))
+ session_data = nil unless session_data && digest && Rack::Utils.secure_compare(digest, generate_hmac(session_data))
end
begin
diff --git a/test/spec_session_cookie.rb b/test/spec_session_cookie.rb
index 518dc78c..ce77cab7 100644
--- a/test/spec_session_cookie.rb
+++ b/test/spec_session_cookie.rb
@@ -49,6 +49,10 @@ describe Rack::Session::Cookie do
res = Rack::MockRequest.new(Rack::Session::Cookie.new(incrementor)).
get("/", "HTTP_COOKIE" => "rack.session=blarghfasel")
res.body.should.equal '{"counter"=>1}'
+
+ app = Rack::Session::Cookie.new(incrementor, :secret => 'test')
+ res = Rack::MockRequest.new(app).get("/", "HTTP_COOKIE" => "rack.session=")
+ res.body.should.equal '{"counter"=>1}'
end
bigcookie = lambda do |env|