| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
This will greatly ease Pry support on Ruby 3.0 (when it's out).
|
| |
|
|
|
|
|
|
| |
I realise that some code might be less readable now, but now that we set a good
default limit, we protect the codebase from further mess. It's important to do
this to prevent adding more mess to already messy code that we have. :doctor:
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Commit a99861f1b1cea84d044c458ec5fba401d88c6802 broke some tests for me when I
try to run them locally. Example failures:
```
Failures:
1) gist nominally logs in
Failure/Error: expect(Pad.gist_calls[:login!]).not_to be_nil
expected: not nil
got: nil
2) show-doc on modules show-doc -a messages relating to -a indicates...
Failure/Error:
raise CommandError, "No docs found for: #{
obj_name ? obj_name : 'current context'
Pry::CommandError:
No docs found for: TestClassForShowSource
```
There's little reason to use our own task for specs since RSpec already provides
one. Switching to that deletes some old (likely unused) code and fixes the
failures for me. Win-win.
|
|
|
| |
Use bundle exec
|
| |
|
|
|
|
|
|
|
|
|
|
| |
There is no need to include the CPU in the platform string as there is
no compiled code shipped in the pry gems. The only difference is the
dependency.
Pry became a victim of rubygems/rubygems#1058 which will be fixed in
rubygems/rubygems#1120. I would also like to raise awareness of proper
use of platform parts while I'm fixing the bug in RubyGems.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removes Bacon and Mocha
Reasoning explained in this comment: https://github.com/pry/pry/issues/277#issuecomment-51708712
Mostly this went smoothly. There were a few errors that I fixed along
the way, e.g. tests that were failing but for various reasons still
passed. Should have documented them, but didn't think about it until
very near the end. But generaly, I remember 2 reasons this would happen:
`lambda { raise "omg" }.should.raise(RuntimeError, /not-omg/)` will pass
because the second argument is ignored by Bacon. And `1.should == 2`
will return false instead of raising an error when it is not in an it
block (e.g. if stuck in a describe block, that would just return false)
The only one that I felt unsure about was spec/helpers/table_spec.rb
`Pry::Helpers.tablify_or_one_line('head', %w(ing)).should == 'head: ing'`
This is wrong, but was not failing because it was in a describe block
instead of an it block. In reality, it returns `"head: ing\n"`,
I updated the test to reflect this, though I don't know for sure
this is the right thing to do
This will fail on master until https://github.com/pry/pry/pull/1281 is merged.
This makes https://github.com/pry/pry/pull/1278 unnecessary.
|
| |
|
| |
|
|
|
|
| |
This reverts commit 0ee65eee4e1b452c841a9a94d7c3d6d98a4ebfd6.
|
|
|
|
|
|
|
|
|
| |
This is based on this commit:
https://github.com/djberg96/win32-api/commit/ceb47f0eb48e
It should fix the issue where we were only building i386-specific gems
for Windows.
|
|
|
|
|
|
|
| |
Since 2cdf739baa1a7c1a0aa86649c1b0ca902f9f4bad started always loading
bundler/setup during tests, we can get rid of some manual load path
setup and dependency checking. We should also explicitly add bundler as
a development dependency.
|
|
|
|
| |
This simplifies our Rake and Travis config.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
Surprising how much this thrashed so far.
|
| |
|
| |
|
|
|
|
|
| |
* removed most historicla junk from lib/pry/test/helper.rb
* relocated recalcitrant junk to the local spec/helper.rb (this isn't exposed to 3rd parties)
|
|
|
|
| |
helpers
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Cap
Of silk moiré,
Little wand**
Of ivory,
Clothes
Very dark,
Paul watches
The cupboard,
Sticks out
Little tongue
At pear,
Prepares
Gives a poke,
And squitters
A.R.
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
This reverts commit e306ff5584f7ac098fb87167aadd612d161bc74f.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We've decided not to upgrade our slop dependency to version 3 for
several reasons:
1. People who are currently using pry in their programs are using slop
version 2; and they may not realise this. Bumping the slop dependency
could therefore break people's code in subtle ways. By removing the
dependency completely we make it obvious that breakage has occurred, and
allows programs to chose their own version of slop.
2. The new version of slop is incompatible with pry. As a command-line
tool we use our option parsing library very very intensely; and as such
we've grown used to (and even embraced) it's warts, inconcistencies and
undocumented behaviours. Upgrading the slop dependency at this point
requires a lot of fix up work both on the slop codebase and the pry
codebase.
3. The slop API is implicitly part of the pry API for defining custom
commands; by changing that API we run a significant risk of breaking
people's pry extensions.
4. The problems in 1., 2. and 3. are going to recur every time slop releases
a new version.
5. Doing this does not preclude upgrading the version of slop we use in
the future. Beacuse 1. will not occur anymore, the only breakage that we
can cause is in pry extensions; this seems resonable providing we signal
the fact that we're doing it (for example by updating the major
version number).
|