diff options
author | Austin Ziegler <austin@zieglers.ca> | 2019-01-27 00:15:29 -0500 |
---|---|---|
committer | Austin Ziegler <austin@zieglers.ca> | 2019-01-27 23:26:05 -0500 |
commit | 45ea1b30c7de0ad840f72afb82fd41eb2b9590db (patch) | |
tree | 22f879cbd21a183bac5c17f754c0aa598531d968 /spec/patch_spec.rb | |
parent | 07ed577eba341f0ff0d7eebf4c1c2cc23083cba7 (diff) | |
download | diff-lcs-45ea1b30c7de0ad840f72afb82fd41eb2b9590db.tar.gz |
Applied Rubocop rules that I like
- Other linting configuration also applied.
- Soft-deprecating versions older than 2.3.
Diffstat (limited to 'spec/patch_spec.rb')
-rw-r--r-- | spec/patch_spec.rb | 192 |
1 files changed, 93 insertions, 99 deletions
diff --git a/spec/patch_spec.rb b/spec/patch_spec.rb index 9f1a4f1..11b0981 100644 --- a/spec/patch_spec.rb +++ b/spec/patch_spec.rb @@ -1,54 +1,54 @@ -# -*- ruby encoding: utf-8 -*- +# frozen_string_literal: true require 'spec_helper' -describe "Diff::LCS.patch" do +describe 'Diff::LCS.patch' do include Diff::LCS::SpecHelper::Matchers - shared_examples "patch sequences correctly" do - it "correctly patches left-to-right (patch autodiscovery)" do + shared_examples 'patch sequences correctly' do + it 'correctly patches left-to-right (patch autodiscovery)' do expect(Diff::LCS.patch(s1, patch_set)).to eq(s2) end - it "correctly patches left-to-right (explicit patch)" do + it 'correctly patches left-to-right (explicit patch)' do expect(Diff::LCS.patch(s1, patch_set, :patch)).to eq(s2) expect(Diff::LCS.patch!(s1, patch_set)).to eq(s2) end - it "correctly patches right-to-left (unpatch autodiscovery)" do + it 'correctly patches right-to-left (unpatch autodiscovery)' do expect(Diff::LCS.patch(s2, patch_set)).to eq(s1) end - it "correctly patches right-to-left (explicit unpatch)" do + it 'correctly patches right-to-left (explicit unpatch)' do expect(Diff::LCS.patch(s2, patch_set, :unpatch)).to eq(s1) expect(Diff::LCS.unpatch!(s2, patch_set)).to eq(s1) end end - describe "using a Diff::LCS.diff patchset" do - describe "an empty patchset returns the source" do - it "works on a string (hello)" do + describe 'using a Diff::LCS.diff patchset' do + describe 'an empty patchset returns the source' do + it 'works on a string (hello)' do diff = Diff::LCS.diff(hello, hello) - expect(Diff::LCS::patch(hello, diff)).to eq(hello) + expect(Diff::LCS.patch(hello, diff)).to eq(hello) end - it "works on an array %W(h e l l o)" do + it 'works on an array %W(h e l l o)' do diff = Diff::LCS.diff(hello_ary, hello_ary) - expect(Diff::LCS::patch(hello_ary, diff)).to eq(hello_ary) + expect(Diff::LCS.patch(hello_ary, diff)).to eq(hello_ary) end end - describe "with default diff callbacks (DiffCallbacks)" do - describe "forward (s1 -> s2)" do - it_has_behavior "patch sequences correctly" do + describe 'with default diff callbacks (DiffCallbacks)' do + describe 'forward (s1 -> s2)' do + it_has_behavior 'patch sequences correctly' do let(:s1) { seq1 } let(:s2) { seq2 } let(:patch_set) { Diff::LCS.diff(seq1, seq2) } end end - describe "reverse (s2 -> s1)" do - it_has_behavior "patch sequences correctly" do + describe 'reverse (s2 -> s1)' do + it_has_behavior 'patch sequences correctly' do let(:s1) { seq2 } let(:s2) { seq1 } let(:patch_set) { Diff::LCS.diff(seq2, seq1) } @@ -56,9 +56,9 @@ describe "Diff::LCS.patch" do end end - describe "with context diff callbacks (ContextDiffCallbacks)" do - describe "forward (s1 -> s2)" do - it_has_behavior "patch sequences correctly" do + describe 'with context diff callbacks (ContextDiffCallbacks)' do + describe 'forward (s1 -> s2)' do + it_has_behavior 'patch sequences correctly' do let(:s1) { seq1 } let(:s2) { seq2 } let(:patch_set) { @@ -67,8 +67,8 @@ describe "Diff::LCS.patch" do end end - describe "reverse (s2 -> s1)" do - it_has_behavior "patch sequences correctly" do + describe 'reverse (s2 -> s1)' do + it_has_behavior 'patch sequences correctly' do let(:s1) { seq2 } let(:s2) { seq1 } let(:patch_set) { @@ -78,9 +78,9 @@ describe "Diff::LCS.patch" do end end - describe "with sdiff callbacks (SDiffCallbacks)" do - describe "forward (s1 -> s2)" do - it_has_behavior "patch sequences correctly" do + describe 'with sdiff callbacks (SDiffCallbacks)' do + describe 'forward (s1 -> s2)' do + it_has_behavior 'patch sequences correctly' do let(:s1) { seq1 } let(:s2) { seq2 } let(:patch_set) { @@ -89,8 +89,8 @@ describe "Diff::LCS.patch" do end end - describe "reverse (s2 -> s1)" do - it_has_behavior "patch sequences correctly" do + describe 'reverse (s2 -> s1)' do + it_has_behavior 'patch sequences correctly' do let(:s1) { seq2 } let(:s2) { seq1 } let(:patch_set) { @@ -101,20 +101,20 @@ describe "Diff::LCS.patch" do end end - describe "using a Diff::LCS.sdiff patchset" do - describe "an empty patchset returns the source" do - it "works on a string (hello)" do - expect(Diff::LCS::patch(hello, Diff::LCS.sdiff(hello, hello))).to eq(hello) + describe 'using a Diff::LCS.sdiff patchset' do + describe 'an empty patchset returns the source' do + it 'works on a string (hello)' do + expect(Diff::LCS.patch(hello, Diff::LCS.sdiff(hello, hello))).to eq(hello) end - it "works on an array %W(h e l l o)" do - expect(Diff::LCS::patch(hello_ary, Diff::LCS.sdiff(hello_ary, hello_ary))).to eq(hello_ary) + it 'works on an array %W(h e l l o)' do + expect(Diff::LCS.patch(hello_ary, Diff::LCS.sdiff(hello_ary, hello_ary))).to eq(hello_ary) end end - describe "with default diff callbacks (DiffCallbacks)" do - describe "forward (s1 -> s2)" do - it_has_behavior "patch sequences correctly" do + describe 'with default diff callbacks (DiffCallbacks)' do + describe 'forward (s1 -> s2)' do + it_has_behavior 'patch sequences correctly' do let(:s1) { seq1 } let(:s2) { seq2 } let(:patch_set) { @@ -123,8 +123,8 @@ describe "Diff::LCS.patch" do end end - describe "reverse (s2 -> s1)" do - it_has_behavior "patch sequences correctly" do + describe 'reverse (s2 -> s1)' do + it_has_behavior 'patch sequences correctly' do let(:s1) { seq2 } let(:s2) { seq1 } let(:patch_set) { @@ -134,9 +134,9 @@ describe "Diff::LCS.patch" do end end - describe "with context diff callbacks (DiffCallbacks)" do - describe "forward (s1 -> s2)" do - it_has_behavior "patch sequences correctly" do + describe 'with context diff callbacks (DiffCallbacks)' do + describe 'forward (s1 -> s2)' do + it_has_behavior 'patch sequences correctly' do let(:s1) { seq1 } let(:s2) { seq2 } let(:patch_set) { @@ -145,8 +145,8 @@ describe "Diff::LCS.patch" do end end - describe "reverse (s2 -> s1)" do - it_has_behavior "patch sequences correctly" do + describe 'reverse (s2 -> s1)' do + it_has_behavior 'patch sequences correctly' do let(:s1) { seq2 } let(:s2) { seq1 } let(:patch_set) { @@ -156,17 +156,17 @@ describe "Diff::LCS.patch" do end end - describe "with sdiff callbacks (SDiffCallbacks)" do - describe "forward (s1 -> s2)" do - it_has_behavior "patch sequences correctly" do + describe 'with sdiff callbacks (SDiffCallbacks)' do + describe 'forward (s1 -> s2)' do + it_has_behavior 'patch sequences correctly' do let(:s1) { seq1 } let(:s2) { seq2 } let(:patch_set) { Diff::LCS.sdiff(seq1, seq2) } end end - describe "reverse (s2 -> s1)" do - it_has_behavior "patch sequences correctly" do + describe 'reverse (s2 -> s1)' do + it_has_behavior 'patch sequences correctly' do let(:s1) { seq2 } let(:s2) { seq1 } let(:patch_set) { Diff::LCS.sdiff(seq2, seq1) } @@ -179,43 +179,43 @@ describe "Diff::LCS.patch" do # to s2 patches"), this cannot use the "patch sequences correctly" shared # set. Once the bug in autodiscovery is fixed, this can be converted as # above. - describe "fix bug 891: patchsets do not contain the last equal part" do + describe 'fix bug 891: patchsets do not contain the last equal part' do before :each do - @s1 = %w(a b c d e f g h i j k) + @s1 = %w(a b c d e f g h i j k) # rubocop:disable Layout/SpaceInsideArrayPercentLiteral @s2 = %w(a b c d D e f g h i j k) end - describe "using Diff::LCS.diff with default diff callbacks" do + describe 'using Diff::LCS.diff with default diff callbacks' do before :each do @patch_set_s1_s2 = Diff::LCS.diff(@s1, @s2) @patch_set_s2_s1 = Diff::LCS.diff(@s2, @s1) end - it "autodiscovers s1 to s2 patches" do + it 'autodiscovers s1 to s2 patches' do expect do expect(Diff::LCS.patch(@s1, @patch_set_s1_s2)).to eq(@s2) end.to_not raise_error end - it "autodiscovers s2 to s1 patches" do + it 'autodiscovers s2 to s1 patches' do expect do expect(Diff::LCS.patch(@s1, @patch_set_s2_s1)).to eq(@s2) end.to_not raise_error end - it "autodiscovers s2 to s1 the left-to-right patches" do + it 'autodiscovers s2 to s1 the left-to-right patches' do expect(Diff::LCS.patch(@s2, @patch_set_s2_s1)).to eq(@s1) expect(Diff::LCS.patch(@s2, @patch_set_s1_s2)).to eq(@s1) end - it "correctly patches left-to-right (explicit patch)" do + it 'correctly patches left-to-right (explicit patch)' do expect(Diff::LCS.patch(@s1, @patch_set_s1_s2, :patch)).to eq(@s2) expect(Diff::LCS.patch(@s2, @patch_set_s2_s1, :patch)).to eq(@s1) expect(Diff::LCS.patch!(@s1, @patch_set_s1_s2)).to eq(@s2) expect(Diff::LCS.patch!(@s2, @patch_set_s2_s1)).to eq(@s1) end - it "correctly patches right-to-left (explicit unpatch)" do + it 'correctly patches right-to-left (explicit unpatch)' do expect(Diff::LCS.patch(@s2, @patch_set_s1_s2, :unpatch)).to eq(@s1) expect(Diff::LCS.patch(@s1, @patch_set_s2_s1, :unpatch)).to eq(@s2) expect(Diff::LCS.unpatch!(@s2, @patch_set_s1_s2)).to eq(@s1) @@ -223,39 +223,37 @@ describe "Diff::LCS.patch" do end end - describe "using Diff::LCS.diff with context diff callbacks" do + describe 'using Diff::LCS.diff with context diff callbacks' do before :each do - @patch_set_s1_s2 = Diff::LCS.diff(@s1, @s2, - Diff::LCS::ContextDiffCallbacks) - @patch_set_s2_s1 = Diff::LCS.diff(@s2, @s1, - Diff::LCS::ContextDiffCallbacks) + @patch_set_s1_s2 = Diff::LCS.diff(@s1, @s2, Diff::LCS::ContextDiffCallbacks) + @patch_set_s2_s1 = Diff::LCS.diff(@s2, @s1, Diff::LCS::ContextDiffCallbacks) end - it "autodiscovers s1 to s2 patches" do + it 'autodiscovers s1 to s2 patches' do expect do expect(Diff::LCS.patch(@s1, @patch_set_s1_s2)).to eq(@s2) end.to_not raise_error end - it "autodiscovers s2 to s1 patches" do + it 'autodiscovers s2 to s1 patches' do expect do expect(Diff::LCS.patch(@s1, @patch_set_s2_s1)).to eq(@s2) end.to_not raise_error end - it "autodiscovers s2 to s1 the left-to-right patches" do + it 'autodiscovers s2 to s1 the left-to-right patches' do expect(Diff::LCS.patch(@s2, @patch_set_s2_s1)).to eq(@s1) expect(Diff::LCS.patch(@s2, @patch_set_s1_s2)).to eq(@s1) end - it "correctly patches left-to-right (explicit patch)" do + it 'correctly patches left-to-right (explicit patch)' do expect(Diff::LCS.patch(@s1, @patch_set_s1_s2, :patch)).to eq(@s2) expect(Diff::LCS.patch(@s2, @patch_set_s2_s1, :patch)).to eq(@s1) expect(Diff::LCS.patch!(@s1, @patch_set_s1_s2)).to eq(@s2) expect(Diff::LCS.patch!(@s2, @patch_set_s2_s1)).to eq(@s1) end - it "correctly patches right-to-left (explicit unpatch)" do + it 'correctly patches right-to-left (explicit unpatch)' do expect(Diff::LCS.patch(@s2, @patch_set_s1_s2, :unpatch)).to eq(@s1) expect(Diff::LCS.patch(@s1, @patch_set_s2_s1, :unpatch)).to eq(@s2) expect(Diff::LCS.unpatch!(@s2, @patch_set_s1_s2)).to eq(@s1) @@ -263,39 +261,37 @@ describe "Diff::LCS.patch" do end end - describe "using Diff::LCS.diff with sdiff callbacks" do + describe 'using Diff::LCS.diff with sdiff callbacks' do before(:each) do - @patch_set_s1_s2 = Diff::LCS.diff(@s1, @s2, - Diff::LCS::SDiffCallbacks) - @patch_set_s2_s1 = Diff::LCS.diff(@s2, @s1, - Diff::LCS::SDiffCallbacks) + @patch_set_s1_s2 = Diff::LCS.diff(@s1, @s2, Diff::LCS::SDiffCallbacks) + @patch_set_s2_s1 = Diff::LCS.diff(@s2, @s1, Diff::LCS::SDiffCallbacks) end - it "autodiscovers s1 to s2 patches" do + it 'autodiscovers s1 to s2 patches' do expect do expect(Diff::LCS.patch(@s1, @patch_set_s1_s2)).to eq(@s2) end.to_not raise_error end - it "autodiscovers s2 to s1 patches" do + it 'autodiscovers s2 to s1 patches' do expect do expect(Diff::LCS.patch(@s1, @patch_set_s2_s1)).to eq(@s2) end.to_not raise_error end - it "autodiscovers s2 to s1 the left-to-right patches" do + it 'autodiscovers s2 to s1 the left-to-right patches' do expect(Diff::LCS.patch(@s2, @patch_set_s2_s1)).to eq(@s1) expect(Diff::LCS.patch(@s2, @patch_set_s1_s2)).to eq(@s1) end - it "correctly patches left-to-right (explicit patch)" do + it 'correctly patches left-to-right (explicit patch)' do expect(Diff::LCS.patch(@s1, @patch_set_s1_s2, :patch)).to eq(@s2) expect(Diff::LCS.patch(@s2, @patch_set_s2_s1, :patch)).to eq(@s1) expect(Diff::LCS.patch!(@s1, @patch_set_s1_s2)).to eq(@s2) expect(Diff::LCS.patch!(@s2, @patch_set_s2_s1)).to eq(@s1) end - it "correctly patches right-to-left (explicit unpatch)" do + it 'correctly patches right-to-left (explicit unpatch)' do expect(Diff::LCS.patch(@s2, @patch_set_s1_s2, :unpatch)).to eq(@s1) expect(Diff::LCS.patch(@s1, @patch_set_s2_s1, :unpatch)).to eq(@s2) expect(Diff::LCS.unpatch!(@s2, @patch_set_s1_s2)).to eq(@s1) @@ -303,37 +299,37 @@ describe "Diff::LCS.patch" do end end - describe "using Diff::LCS.sdiff with default sdiff callbacks" do + describe 'using Diff::LCS.sdiff with default sdiff callbacks' do before(:each) do @patch_set_s1_s2 = Diff::LCS.sdiff(@s1, @s2) @patch_set_s2_s1 = Diff::LCS.sdiff(@s2, @s1) end - it "autodiscovers s1 to s2 patches" do + it 'autodiscovers s1 to s2 patches' do expect do expect(Diff::LCS.patch(@s1, @patch_set_s1_s2)).to eq(@s2) end.to_not raise_error end - it "autodiscovers s2 to s1 patches" do + it 'autodiscovers s2 to s1 patches' do expect do expect(Diff::LCS.patch(@s1, @patch_set_s2_s1)).to eq(@s2) end.to_not raise_error end - it "autodiscovers s2 to s1 the left-to-right patches" do + it 'autodiscovers s2 to s1 the left-to-right patches' do expect(Diff::LCS.patch(@s2, @patch_set_s2_s1)).to eq(@s1) expect(Diff::LCS.patch(@s2, @patch_set_s1_s2)).to eq(@s1) end - it "correctly patches left-to-right (explicit patch)" do + it 'correctly patches left-to-right (explicit patch)' do expect(Diff::LCS.patch(@s1, @patch_set_s1_s2, :patch)).to eq(@s2) expect(Diff::LCS.patch(@s2, @patch_set_s2_s1, :patch)).to eq(@s1) expect(Diff::LCS.patch!(@s1, @patch_set_s1_s2)).to eq(@s2) expect(Diff::LCS.patch!(@s2, @patch_set_s2_s1)).to eq(@s1) end - it "correctly patches right-to-left (explicit unpatch)" do + it 'correctly patches right-to-left (explicit unpatch)' do expect(Diff::LCS.patch(@s2, @patch_set_s1_s2, :unpatch)).to eq(@s1) expect(Diff::LCS.patch(@s1, @patch_set_s2_s1, :unpatch)).to eq(@s2) expect(Diff::LCS.unpatch!(@s2, @patch_set_s1_s2)).to eq(@s1) @@ -341,39 +337,37 @@ describe "Diff::LCS.patch" do end end - describe "using Diff::LCS.sdiff with context diff callbacks" do + describe 'using Diff::LCS.sdiff with context diff callbacks' do before(:each) do - @patch_set_s1_s2 = Diff::LCS.sdiff(@s1, @s2, - Diff::LCS::ContextDiffCallbacks) - @patch_set_s2_s1 = Diff::LCS.sdiff(@s2, @s1, - Diff::LCS::ContextDiffCallbacks) + @patch_set_s1_s2 = Diff::LCS.sdiff(@s1, @s2, Diff::LCS::ContextDiffCallbacks) + @patch_set_s2_s1 = Diff::LCS.sdiff(@s2, @s1, Diff::LCS::ContextDiffCallbacks) end - it "autodiscovers s1 to s2 patches" do + it 'autodiscovers s1 to s2 patches' do expect do expect(Diff::LCS.patch(@s1, @patch_set_s1_s2)).to eq(@s2) end.to_not raise_error end - it "autodiscovers s2 to s1 patches" do + it 'autodiscovers s2 to s1 patches' do expect do expect(Diff::LCS.patch(@s1, @patch_set_s2_s1)).to eq(@s2) end.to_not raise_error end - it "autodiscovers s2 to s1 the left-to-right patches" do + it 'autodiscovers s2 to s1 the left-to-right patches' do expect(Diff::LCS.patch(@s2, @patch_set_s2_s1)).to eq(@s1) expect(Diff::LCS.patch(@s2, @patch_set_s1_s2)).to eq(@s1) end - it "correctly patches left-to-right (explicit patch)" do + it 'correctly patches left-to-right (explicit patch)' do expect(Diff::LCS.patch(@s1, @patch_set_s1_s2, :patch)).to eq(@s2) expect(Diff::LCS.patch(@s2, @patch_set_s2_s1, :patch)).to eq(@s1) expect(Diff::LCS.patch!(@s1, @patch_set_s1_s2)).to eq(@s2) expect(Diff::LCS.patch!(@s2, @patch_set_s2_s1)).to eq(@s1) end - it "correctly patches right-to-left (explicit unpatch)" do + it 'correctly patches right-to-left (explicit unpatch)' do expect(Diff::LCS.patch(@s2, @patch_set_s1_s2, :unpatch)).to eq(@s1) expect(Diff::LCS.patch(@s1, @patch_set_s2_s1, :unpatch)).to eq(@s2) expect(Diff::LCS.unpatch!(@s2, @patch_set_s1_s2)).to eq(@s1) @@ -381,37 +375,37 @@ describe "Diff::LCS.patch" do end end - describe "using Diff::LCS.sdiff with default diff callbacks" do + describe 'using Diff::LCS.sdiff with default diff callbacks' do before(:each) do @patch_set_s1_s2 = Diff::LCS.sdiff(@s1, @s2, Diff::LCS::DiffCallbacks) @patch_set_s2_s1 = Diff::LCS.sdiff(@s2, @s1, Diff::LCS::DiffCallbacks) end - it "autodiscovers s1 to s2 patches" do + it 'autodiscovers s1 to s2 patches' do expect do expect(Diff::LCS.patch(@s1, @patch_set_s1_s2)).to eq(@s2) end.to_not raise_error end - it "autodiscovers s2 to s1 patches" do + it 'autodiscovers s2 to s1 patches' do expect do expect(Diff::LCS.patch(@s1, @patch_set_s2_s1)).to eq(@s2) end.to_not raise_error end - it "autodiscovers s2 to s1 the left-to-right patches" do + it 'autodiscovers s2 to s1 the left-to-right patches' do expect(Diff::LCS.patch(@s2, @patch_set_s2_s1)).to eq(@s1) expect(Diff::LCS.patch(@s2, @patch_set_s1_s2)).to eq(@s1) end - it "correctly patches left-to-right (explicit patch)" do + it 'correctly patches left-to-right (explicit patch)' do expect(Diff::LCS.patch(@s1, @patch_set_s1_s2, :patch)).to eq(@s2) expect(Diff::LCS.patch(@s2, @patch_set_s2_s1, :patch)).to eq(@s1) expect(Diff::LCS.patch!(@s1, @patch_set_s1_s2)).to eq(@s2) expect(Diff::LCS.patch!(@s2, @patch_set_s2_s1)).to eq(@s1) end - it "correctly patches right-to-left (explicit unpatch)" do + it 'correctly patches right-to-left (explicit unpatch)' do expect(Diff::LCS.patch(@s2, @patch_set_s1_s2, :unpatch)).to eq(@s1) expect(Diff::LCS.patch(@s1, @patch_set_s2_s1, :unpatch)).to eq(@s2) expect(Diff::LCS.unpatch!(@s2, @patch_set_s1_s2)).to eq(@s1) |