diff options
Diffstat (limited to 'spec/functional')
-rw-r--r-- | spec/functional/resource/group_spec.rb | 12 | ||||
-rw-r--r-- | spec/functional/resource/link_spec.rb | 14 | ||||
-rw-r--r-- | spec/functional/resource/powershell_script_spec.rb | 8 | ||||
-rw-r--r-- | spec/functional/run_lock_spec.rb | 48 | ||||
-rw-r--r-- | spec/functional/win32/registry_spec.rb | 16 |
5 files changed, 49 insertions, 49 deletions
diff --git a/spec/functional/resource/group_spec.rb b/spec/functional/resource/group_spec.rb index 7e5b0725c1..a682e9c0c7 100644 --- a/spec/functional/resource/group_spec.rb +++ b/spec/functional/resource/group_spec.rb @@ -307,12 +307,12 @@ describe Chef::Resource::Group, :requires_root_or_running_windows do let(:number) do # Loop until we pick a gid that is not in use. loop do - begin - gid = rand(2000..9999) # avoid low group numbers - return nil if Etc.getgrgid(gid).nil? # returns nil on windows - rescue ArgumentError # group does not exist - return gid - end + + gid = rand(2000..9999) # avoid low group numbers + return nil if Etc.getgrgid(gid).nil? # returns nil on windows + rescue ArgumentError # group does not exist + return gid + end end diff --git a/spec/functional/resource/link_spec.rb b/spec/functional/resource/link_spec.rb index c9177ebc77..fc260845e4 100644 --- a/spec/functional/resource/link_spec.rb +++ b/spec/functional/resource/link_spec.rb @@ -55,13 +55,13 @@ describe Chef::Resource::Link do end after(:each) do - begin - cleanup_link(to) if File.exists?(to) - cleanup_link(target_file) if File.exists?(target_file) - cleanup_link(CHEF_SPEC_BACKUP_PATH) if File.exists?(CHEF_SPEC_BACKUP_PATH) - rescue - puts "Could not remove a file: #{$!}" - end + + cleanup_link(to) if File.exists?(to) + cleanup_link(target_file) if File.exists?(target_file) + cleanup_link(CHEF_SPEC_BACKUP_PATH) if File.exists?(CHEF_SPEC_BACKUP_PATH) + rescue + puts "Could not remove a file: #{$!}" + end def user(user) diff --git a/spec/functional/resource/powershell_script_spec.rb b/spec/functional/resource/powershell_script_spec.rb index 5e8a00fd4d..70442eb2b1 100644 --- a/spec/functional/resource/powershell_script_spec.rb +++ b/spec/functional/resource/powershell_script_spec.rb @@ -273,10 +273,10 @@ describe Chef::Resource::WindowsScript::PowershellScript, :windows_only do context "when running on a 32-bit version of Windows", :windows32_only do it "raises an exception if :x86_64 process architecture is specified" do - begin - expect(resource.architecture(:x86_64)).to raise_error Chef::Exceptions::Win32ArchitectureIncorrect - rescue Chef::Exceptions::Win32ArchitectureIncorrect - end + + expect(resource.architecture(:x86_64)).to raise_error Chef::Exceptions::Win32ArchitectureIncorrect + rescue Chef::Exceptions::Win32ArchitectureIncorrect + end end end diff --git a/spec/functional/run_lock_spec.rb b/spec/functional/run_lock_spec.rb index fa450b9c8d..a7440638d7 100644 --- a/spec/functional/run_lock_spec.rb +++ b/spec/functional/run_lock_spec.rb @@ -61,17 +61,17 @@ describe Chef::RunLock do let!(:p1) { ClientProcess.new(self, "p1") } let!(:p2) { ClientProcess.new(self, "p2") } after(:each) do |example| - begin - p1.stop - p2.stop - rescue - example.exception = $! - raise - ensure - if example.exception - print_events - end + + p1.stop + p2.stop + rescue + example.exception = $! + raise + ensure + if example.exception + print_events end + end def print_events @@ -445,21 +445,21 @@ describe Chef::RunLock do def start example.log_event("#{name}.start") @pid = fork do - begin - Timeout.timeout(CLIENT_PROCESS_TIMEOUT) do - run_lock = TestRunLock.new(example.lockfile) - run_lock.client_process = self - fire_event("started") - run_lock.acquire - fire_event("acquired lock") - run_lock.save_pid - fire_event("saved pid") - exit!(0) - end - rescue - fire_event($!.message.lines.join(" // ")) - raise + + Timeout.timeout(CLIENT_PROCESS_TIMEOUT) do + run_lock = TestRunLock.new(example.lockfile) + run_lock.client_process = self + fire_event("started") + run_lock.acquire + fire_event("acquired lock") + run_lock.save_pid + fire_event("saved pid") + exit!(0) end + rescue + fire_event($!.message.lines.join(" // ")) + raise + end example.log_event("#{name}.start forked (pid #{pid})") end diff --git a/spec/functional/win32/registry_spec.rb b/spec/functional/win32/registry_spec.rb index 638197a30a..3a1c71edf1 100644 --- a/spec/functional/win32/registry_spec.rb +++ b/spec/functional/win32/registry_spec.rb @@ -267,10 +267,10 @@ describe "Chef::Win32::Registry", :windows_only do describe "create_key" do before(:all) do ::Win32::Registry::HKEY_CURRENT_USER.open("Software\\Root") do |reg| - begin - reg.delete_key("Trunk", true) - rescue - end + + reg.delete_key("Trunk", true) + rescue + end end @@ -362,10 +362,10 @@ describe "Chef::Win32::Registry", :windows_only do before(:all) do ::Win32::Registry::HKEY_CURRENT_USER.create "Software\\Root\\Trunk" ::Win32::Registry::HKEY_CURRENT_USER.open("Software\\Root\\Trunk") do |reg| - begin - reg.delete_key("Red", true) - rescue - end + + reg.delete_key("Red", true) + rescue + end end |