summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorWayne Davison <wayned@samba.org>2009-04-12 12:57:31 -0700
committerWayne Davison <wayned@samba.org>2009-04-12 13:01:14 -0700
commit9be5093726d73826b63f18435940bbe1afddc66c (patch)
treec43adceb20ed3cd12839fe65228bfea80b682834
parentfeb8dacc148d5428be2498e5748ef9aa2ea889a2 (diff)
downloadrsync-9be5093726d73826b63f18435940bbe1afddc66c.tar.gz
Don't allow --remove-s*-files with --read-batch.
-rw-r--r--NEWS3
-rw-r--r--options.c6
2 files changed, 9 insertions, 0 deletions
diff --git a/NEWS b/NEWS
index 836d4768..45ff1bdd 100644
--- a/NEWS
+++ b/NEWS
@@ -47,3 +47,6 @@ Changes since 3.0.5:
- Fixed a run-time issue for systems that can't find iconv_open() by adding
the --disable-iconv-open configure option.
+
+ - Complain and die if the user tries to combine --remove-source-files (or
+ the deprecated --remove-sent-files) with --read-batch.
diff --git a/options.c b/options.c
index 75fa1ab6..b6f7bae4 100644
--- a/options.c
+++ b/options.c
@@ -1357,6 +1357,12 @@ int parse_arguments(int *argc_p, const char ***argv_p)
"--read-batch cannot be used with --files-from\n");
return 0;
}
+ if (read_batch && remove_source_files) {
+ snprintf(err_buf, sizeof err_buf,
+ "--read-batch cannot be used with --remove-%s-files\n",
+ remove_source_files == 1 ? "source" : "sent");
+ return 0;
+ }
if (batch_name && strlen(batch_name) > MAX_BATCH_NAME_LEN) {
snprintf(err_buf, sizeof err_buf,
"the batch-file name must be %d characters or less.\n",