1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
1648
1649
1650
1651
1652
1653
1654
1655
1656
1657
1658
1659
1660
1661
1662
1663
1664
1665
1666
1667
1668
1669
1670
1671
1672
1673
1674
1675
1676
1677
1678
1679
1680
1681
1682
1683
1684
1685
1686
1687
1688
1689
1690
1691
1692
1693
1694
1695
1696
1697
1698
1699
1700
1701
1702
1703
1704
1705
1706
1707
1708
1709
1710
1711
1712
1713
1714
1715
1716
1717
1718
1719
1720
1721
1722
1723
1724
1725
1726
1727
1728
1729
1730
1731
1732
1733
1734
1735
1736
1737
1738
1739
1740
1741
1742
1743
1744
1745
1746
1747
1748
1749
1750
1751
1752
1753
1754
1755
1756
1757
1758
1759
1760
1761
1762
1763
1764
1765
1766
1767
1768
1769
1770
1771
1772
1773
1774
1775
1776
1777
1778
1779
1780
1781
1782
1783
1784
1785
1786
1787
1788
1789
1790
1791
1792
1793
1794
1795
1796
1797
1798
1799
1800
1801
1802
1803
1804
1805
1806
1807
1808
1809
1810
1811
1812
1813
1814
1815
1816
1817
1818
1819
1820
1821
1822
1823
1824
1825
1826
1827
1828
1829
1830
1831
1832
1833
1834
1835
1836
1837
1838
1839
1840
1841
1842
1843
1844
1845
1846
1847
1848
1849
1850
1851
1852
1853
1854
1855
1856
1857
1858
1859
1860
1861
1862
1863
1864
1865
1866
1867
1868
1869
1870
1871
1872
1873
1874
1875
1876
1877
1878
1879
1880
1881
1882
1883
1884
1885
1886
1887
1888
1889
1890
1891
1892
1893
1894
1895
1896
1897
1898
1899
1900
1901
1902
1903
1904
1905
1906
1907
1908
1909
1910
1911
1912
1913
1914
1915
1916
1917
1918
1919
1920
1921
1922
1923
1924
1925
1926
1927
1928
1929
1930
1931
1932
1933
1934
1935
1936
1937
1938
1939
1940
1941
1942
1943
1944
1945
1946
1947
1948
1949
1950
1951
1952
1953
1954
1955
1956
1957
1958
1959
1960
1961
1962
1963
1964
1965
1966
1967
1968
1969
1970
1971
1972
1973
1974
1975
1976
1977
1978
1979
1980
1981
1982
1983
1984
1985
1986
1987
1988
1989
1990
1991
1992
1993
1994
1995
1996
1997
1998
1999
2000
2001
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
2013
2014
2015
2016
2017
2018
2019
2020
2021
2022
2023
2024
2025
2026
2027
2028
2029
2030
2031
2032
2033
2034
2035
2036
2037
2038
2039
2040
2041
2042
2043
2044
2045
2046
2047
2048
2049
2050
2051
2052
2053
2054
2055
2056
2057
2058
2059
2060
2061
2062
2063
2064
2065
2066
2067
2068
2069
2070
2071
2072
2073
2074
2075
2076
2077
2078
2079
2080
2081
2082
2083
2084
2085
2086
2087
2088
2089
2090
2091
2092
2093
2094
2095
2096
2097
2098
2099
2100
2101
2102
2103
2104
2105
2106
2107
2108
2109
2110
2111
2112
2113
2114
2115
2116
2117
2118
2119
2120
2121
2122
2123
2124
2125
2126
2127
2128
2129
2130
2131
2132
2133
2134
2135
2136
2137
2138
2139
2140
2141
2142
2143
2144
2145
2146
2147
2148
2149
2150
2151
2152
2153
2154
2155
2156
2157
2158
2159
2160
2161
2162
2163
2164
2165
2166
2167
2168
2169
2170
2171
2172
2173
2174
2175
2176
2177
2178
2179
2180
2181
2182
2183
2184
2185
2186
2187
2188
2189
2190
2191
2192
2193
2194
2195
2196
2197
2198
2199
2200
2201
2202
2203
2204
2205
2206
2207
2208
2209
2210
2211
2212
2213
2214
2215
2216
2217
2218
2219
2220
2221
2222
2223
2224
2225
2226
2227
2228
2229
2230
2231
2232
2233
2234
2235
2236
2237
2238
2239
2240
2241
2242
2243
2244
2245
2246
2247
2248
2249
2250
2251
2252
2253
2254
2255
2256
2257
2258
2259
2260
2261
2262
2263
2264
2265
2266
2267
2268
2269
2270
2271
2272
2273
2274
2275
2276
2277
2278
2279
2280
2281
2282
2283
2284
2285
2286
2287
2288
2289
2290
2291
2292
2293
2294
2295
2296
2297
2298
2299
2300
2301
2302
2303
2304
2305
2306
2307
2308
2309
2310
2311
2312
2313
2314
2315
2316
2317
2318
2319
2320
2321
2322
2323
2324
2325
2326
2327
2328
2329
2330
2331
2332
2333
2334
2335
2336
2337
2338
2339
2340
2341
2342
2343
2344
2345
2346
2347
2348
2349
2350
2351
2352
2353
2354
2355
2356
2357
2358
2359
2360
2361
2362
2363
2364
2365
2366
2367
2368
2369
2370
2371
2372
2373
2374
2375
2376
2377
2378
2379
2380
2381
2382
2383
2384
2385
2386
2387
2388
2389
2390
2391
2392
2393
2394
2395
2396
2397
2398
2399
2400
2401
2402
2403
2404
2405
2406
2407
2408
2409
2410
2411
2412
2413
2414
2415
2416
2417
2418
2419
2420
2421
2422
2423
2424
2425
2426
2427
2428
2429
2430
2431
2432
2433
2434
2435
2436
2437
2438
2439
2440
2441
2442
2443
2444
2445
2446
2447
2448
2449
2450
2451
2452
2453
2454
2455
2456
2457
2458
2459
2460
2461
2462
2463
2464
2465
2466
2467
2468
2469
2470
2471
2472
2473
2474
2475
2476
2477
2478
2479
2480
2481
2482
2483
2484
2485
2486
2487
2488
2489
2490
2491
2492
2493
2494
2495
2496
2497
2498
2499
2500
2501
2502
2503
2504
2505
2506
2507
2508
2509
2510
2511
2512
2513
2514
2515
2516
2517
2518
2519
2520
2521
2522
2523
2524
2525
2526
2527
2528
2529
2530
2531
2532
2533
2534
2535
2536
2537
2538
2539
2540
2541
2542
2543
2544
2545
2546
2547
2548
2549
2550
2551
2552
2553
2554
2555
2556
2557
2558
2559
2560
2561
2562
2563
2564
2565
2566
2567
2568
2569
2570
2571
2572
2573
2574
2575
2576
2577
2578
2579
2580
2581
2582
2583
2584
2585
2586
2587
2588
2589
2590
2591
2592
2593
2594
2595
2596
2597
2598
2599
2600
2601
2602
2603
2604
2605
2606
2607
2608
2609
2610
2611
2612
2613
2614
2615
2616
2617
2618
2619
2620
2621
2622
2623
2624
2625
2626
2627
2628
2629
2630
2631
2632
2633
2634
2635
2636
2637
2638
2639
2640
2641
2642
2643
2644
2645
2646
2647
2648
2649
2650
2651
2652
2653
2654
2655
2656
2657
2658
2659
2660
2661
2662
2663
2664
2665
2666
2667
2668
2669
2670
2671
2672
2673
2674
2675
2676
2677
2678
2679
2680
2681
2682
2683
2684
2685
2686
2687
2688
2689
2690
2691
2692
2693
2694
2695
2696
2697
2698
2699
2700
2701
2702
2703
2704
2705
2706
2707
2708
2709
2710
2711
2712
2713
2714
2715
2716
2717
2718
2719
2720
2721
2722
2723
2724
2725
2726
2727
2728
2729
2730
2731
2732
2733
2734
2735
2736
2737
2738
2739
2740
2741
2742
2743
2744
2745
2746
2747
2748
2749
2750
2751
2752
2753
2754
2755
2756
2757
2758
2759
2760
2761
2762
2763
2764
2765
2766
2767
2768
2769
2770
2771
2772
2773
2774
2775
2776
2777
2778
2779
2780
2781
2782
2783
2784
2785
2786
2787
2788
2789
2790
2791
2792
2793
2794
2795
2796
2797
2798
2799
2800
2801
2802
2803
2804
2805
2806
2807
2808
2809
2810
2811
2812
2813
2814
2815
2816
2817
2818
2819
2820
2821
2822
2823
2824
2825
2826
2827
2828
2829
2830
2831
2832
2833
2834
2835
2836
2837
2838
2839
2840
2841
2842
2843
2844
2845
2846
2847
2848
2849
2850
2851
2852
2853
2854
2855
2856
2857
2858
2859
2860
2861
2862
2863
2864
2865
2866
2867
2868
2869
2870
2871
2872
2873
2874
2875
2876
2877
2878
2879
2880
2881
2882
2883
2884
2885
2886
2887
2888
2889
2890
2891
2892
2893
2894
2895
2896
2897
2898
2899
2900
2901
2902
2903
2904
2905
2906
2907
2908
2909
2910
2911
2912
2913
2914
2915
2916
2917
2918
2919
2920
2921
2922
2923
2924
2925
2926
2927
2928
2929
2930
2931
2932
2933
2934
2935
2936
2937
2938
2939
2940
2941
2942
2943
2944
2945
2946
2947
2948
2949
2950
2951
2952
2953
2954
2955
2956
2957
2958
2959
2960
2961
2962
2963
2964
2965
2966
2967
2968
2969
2970
2971
2972
2973
2974
2975
2976
2977
2978
2979
2980
2981
2982
2983
2984
2985
2986
2987
2988
2989
2990
2991
2992
2993
2994
2995
2996
2997
2998
2999
3000
3001
3002
3003
3004
3005
3006
3007
3008
3009
3010
3011
3012
3013
3014
3015
3016
3017
3018
3019
3020
3021
3022
3023
3024
3025
3026
3027
3028
3029
3030
3031
3032
3033
3034
3035
3036
3037
3038
3039
3040
3041
3042
3043
3044
3045
3046
3047
3048
3049
3050
3051
3052
3053
3054
3055
3056
3057
3058
3059
3060
3061
3062
3063
3064
3065
3066
3067
3068
3069
3070
3071
3072
3073
3074
3075
3076
3077
3078
3079
3080
3081
3082
3083
3084
3085
3086
3087
3088
3089
3090
3091
3092
3093
3094
3095
3096
3097
3098
3099
3100
3101
3102
3103
3104
3105
3106
3107
3108
3109
3110
3111
3112
3113
3114
3115
3116
3117
3118
3119
3120
3121
3122
3123
3124
3125
3126
3127
3128
3129
3130
3131
3132
3133
3134
3135
3136
3137
3138
3139
3140
3141
3142
3143
3144
3145
3146
3147
3148
3149
3150
3151
3152
3153
3154
3155
3156
3157
3158
3159
3160
3161
3162
3163
3164
3165
3166
3167
3168
3169
3170
3171
3172
3173
3174
3175
3176
3177
3178
3179
3180
3181
3182
3183
3184
3185
3186
3187
3188
3189
3190
3191
3192
3193
3194
3195
3196
3197
3198
3199
3200
3201
3202
3203
3204
3205
3206
3207
3208
3209
3210
3211
3212
3213
3214
3215
3216
3217
3218
3219
3220
3221
3222
3223
3224
3225
3226
3227
3228
3229
3230
3231
3232
3233
3234
3235
3236
3237
3238
3239
3240
3241
3242
3243
3244
3245
3246
3247
3248
3249
3250
3251
3252
3253
3254
3255
3256
3257
3258
3259
3260
3261
3262
3263
3264
3265
3266
3267
3268
3269
3270
3271
3272
3273
3274
3275
3276
3277
3278
3279
3280
3281
3282
3283
3284
3285
3286
3287
3288
3289
3290
3291
3292
3293
3294
3295
3296
3297
3298
3299
3300
3301
3302
3303
3304
3305
3306
3307
3308
3309
3310
3311
3312
3313
3314
3315
3316
3317
3318
3319
3320
3321
3322
3323
3324
3325
3326
3327
3328
3329
3330
3331
3332
3333
3334
3335
3336
3337
3338
3339
3340
3341
3342
3343
3344
3345
3346
3347
3348
3349
3350
3351
3352
3353
3354
3355
3356
3357
3358
3359
3360
3361
3362
3363
3364
3365
3366
3367
3368
3369
3370
3371
3372
3373
3374
3375
3376
3377
3378
3379
3380
3381
3382
3383
3384
3385
3386
3387
3388
3389
3390
3391
3392
3393
3394
3395
3396
3397
3398
3399
3400
3401
3402
3403
3404
3405
3406
3407
3408
3409
3410
3411
3412
3413
3414
3415
3416
3417
3418
3419
3420
3421
3422
3423
3424
3425
3426
3427
3428
3429
3430
3431
3432
3433
3434
3435
3436
3437
3438
3439
3440
3441
3442
3443
3444
3445
3446
3447
3448
3449
3450
3451
3452
3453
3454
3455
3456
3457
3458
3459
3460
3461
3462
3463
3464
3465
3466
3467
3468
3469
3470
3471
3472
3473
3474
3475
3476
3477
3478
3479
3480
3481
3482
3483
3484
3485
3486
3487
3488
3489
3490
3491
3492
3493
3494
3495
3496
3497
3498
3499
3500
3501
3502
3503
3504
3505
3506
3507
3508
3509
3510
3511
3512
3513
3514
3515
3516
3517
3518
3519
3520
3521
3522
3523
3524
3525
3526
3527
3528
3529
3530
3531
3532
3533
3534
3535
3536
3537
3538
3539
3540
3541
3542
3543
3544
3545
3546
3547
3548
3549
3550
3551
3552
3553
3554
3555
3556
3557
3558
3559
3560
3561
3562
3563
3564
3565
3566
3567
3568
3569
3570
3571
3572
3573
3574
3575
3576
3577
3578
3579
3580
3581
3582
3583
3584
3585
3586
3587
3588
3589
3590
3591
3592
3593
3594
3595
3596
3597
3598
3599
3600
3601
3602
3603
3604
3605
3606
3607
3608
3609
3610
3611
3612
3613
3614
3615
3616
3617
3618
3619
3620
3621
3622
3623
3624
3625
3626
3627
3628
3629
3630
3631
3632
3633
3634
3635
3636
3637
3638
3639
3640
3641
3642
3643
3644
3645
3646
3647
3648
3649
3650
3651
3652
3653
3654
3655
3656
3657
3658
3659
3660
3661
3662
3663
3664
3665
3666
3667
3668
3669
3670
3671
3672
3673
3674
3675
3676
3677
3678
3679
3680
3681
3682
3683
3684
3685
3686
3687
3688
3689
3690
3691
3692
3693
3694
3695
3696
3697
3698
3699
3700
3701
3702
3703
3704
3705
3706
3707
3708
3709
3710
3711
3712
3713
3714
3715
3716
3717
3718
3719
3720
3721
3722
3723
3724
3725
3726
3727
3728
3729
3730
3731
3732
3733
3734
3735
3736
3737
3738
3739
3740
3741
3742
3743
3744
3745
3746
3747
3748
3749
3750
3751
3752
3753
3754
3755
3756
3757
3758
3759
3760
3761
3762
3763
3764
3765
3766
3767
3768
3769
3770
3771
3772
3773
3774
3775
3776
3777
3778
3779
3780
3781
3782
3783
3784
3785
3786
3787
3788
3789
3790
3791
3792
3793
3794
3795
3796
3797
3798
3799
3800
3801
3802
3803
3804
3805
3806
3807
3808
3809
3810
3811
3812
3813
3814
3815
3816
3817
3818
3819
3820
3821
3822
3823
3824
3825
3826
3827
3828
3829
3830
3831
3832
3833
3834
3835
3836
3837
3838
3839
3840
3841
3842
3843
3844
3845
3846
3847
3848
3849
3850
3851
3852
3853
3854
3855
3856
3857
3858
3859
3860
3861
3862
3863
3864
3865
3866
3867
3868
3869
3870
3871
3872
3873
3874
3875
3876
3877
3878
3879
3880
3881
3882
3883
3884
3885
3886
3887
3888
3889
3890
3891
3892
3893
3894
3895
3896
3897
3898
3899
3900
3901
3902
3903
3904
3905
3906
3907
3908
3909
3910
3911
3912
3913
3914
3915
3916
3917
3918
3919
3920
3921
3922
3923
3924
3925
3926
3927
3928
3929
3930
3931
3932
3933
3934
3935
3936
3937
3938
3939
3940
3941
3942
3943
3944
3945
3946
3947
3948
3949
3950
3951
3952
3953
3954
3955
3956
3957
3958
3959
3960
3961
3962
3963
3964
3965
3966
3967
3968
3969
3970
3971
3972
3973
3974
3975
3976
3977
3978
3979
3980
3981
3982
3983
3984
3985
3986
3987
3988
3989
3990
3991
3992
3993
3994
3995
3996
3997
3998
3999
4000
4001
4002
4003
4004
4005
4006
4007
4008
4009
4010
4011
4012
4013
4014
4015
4016
4017
4018
4019
4020
4021
4022
4023
4024
4025
4026
4027
4028
4029
4030
4031
4032
4033
4034
4035
4036
4037
4038
4039
4040
4041
4042
4043
4044
4045
4046
4047
4048
4049
4050
4051
4052
4053
4054
4055
4056
4057
4058
4059
4060
4061
4062
4063
4064
4065
4066
4067
4068
4069
4070
4071
4072
4073
4074
4075
4076
4077
4078
4079
4080
4081
4082
4083
4084
4085
4086
4087
4088
4089
4090
4091
4092
4093
4094
4095
4096
4097
4098
4099
4100
4101
4102
4103
4104
4105
4106
4107
4108
4109
4110
4111
4112
4113
4114
4115
4116
4117
4118
4119
4120
4121
4122
4123
4124
4125
4126
4127
4128
4129
4130
4131
4132
4133
4134
4135
4136
4137
4138
4139
4140
4141
4142
4143
4144
4145
4146
4147
4148
4149
4150
4151
4152
4153
4154
4155
4156
4157
4158
4159
4160
4161
4162
4163
4164
4165
4166
4167
4168
4169
4170
4171
4172
4173
4174
4175
4176
4177
4178
4179
4180
4181
4182
4183
4184
4185
4186
4187
4188
4189
4190
4191
4192
4193
4194
4195
4196
4197
4198
4199
4200
4201
4202
4203
4204
4205
4206
4207
4208
4209
4210
4211
4212
4213
4214
4215
4216
4217
4218
4219
4220
4221
4222
4223
4224
4225
4226
4227
4228
4229
4230
4231
4232
4233
4234
4235
4236
4237
4238
4239
4240
4241
4242
4243
4244
4245
4246
4247
4248
4249
4250
4251
4252
4253
4254
4255
4256
4257
4258
4259
4260
4261
4262
4263
4264
4265
4266
4267
4268
4269
4270
4271
4272
4273
4274
4275
4276
4277
4278
4279
4280
4281
4282
4283
4284
4285
4286
4287
4288
4289
4290
4291
4292
4293
4294
4295
4296
4297
4298
4299
4300
4301
4302
4303
4304
4305
4306
4307
4308
4309
4310
4311
4312
4313
4314
4315
4316
4317
4318
4319
4320
4321
4322
4323
4324
4325
4326
4327
4328
4329
4330
4331
4332
4333
4334
4335
4336
4337
4338
4339
4340
4341
4342
4343
4344
4345
4346
4347
4348
4349
4350
4351
4352
4353
4354
4355
4356
4357
4358
4359
4360
4361
4362
4363
4364
4365
4366
4367
4368
4369
4370
4371
4372
4373
4374
4375
4376
4377
4378
4379
4380
4381
4382
4383
4384
4385
4386
4387
4388
4389
4390
4391
4392
4393
4394
4395
4396
4397
4398
4399
4400
4401
4402
4403
4404
4405
4406
4407
4408
4409
4410
4411
4412
4413
4414
4415
4416
4417
4418
4419
4420
4421
4422
4423
4424
4425
4426
4427
4428
4429
4430
4431
4432
4433
4434
4435
4436
4437
4438
4439
4440
4441
4442
4443
4444
4445
4446
4447
4448
4449
4450
4451
4452
4453
4454
4455
4456
4457
4458
4459
4460
4461
4462
4463
4464
4465
4466
4467
4468
4469
4470
4471
4472
4473
4474
4475
4476
4477
4478
4479
4480
4481
4482
4483
4484
4485
4486
4487
4488
4489
4490
4491
4492
4493
4494
4495
4496
4497
4498
4499
4500
4501
4502
4503
4504
4505
4506
4507
4508
4509
4510
4511
4512
4513
4514
4515
4516
4517
4518
4519
4520
4521
4522
4523
4524
4525
4526
4527
4528
4529
4530
4531
4532
4533
4534
4535
4536
4537
4538
4539
4540
4541
4542
4543
4544
4545
4546
4547
4548
4549
4550
4551
4552
4553
4554
4555
4556
4557
4558
4559
4560
4561
4562
4563
4564
4565
4566
4567
4568
4569
4570
4571
4572
4573
4574
4575
4576
4577
4578
4579
4580
4581
4582
4583
4584
4585
4586
4587
4588
4589
4590
4591
4592
4593
4594
4595
4596
4597
4598
4599
4600
4601
4602
4603
4604
4605
4606
4607
4608
4609
4610
4611
4612
4613
4614
4615
4616
4617
4618
4619
4620
4621
4622
4623
4624
4625
4626
4627
4628
4629
4630
4631
4632
4633
4634
4635
4636
4637
4638
4639
4640
4641
4642
4643
4644
4645
4646
4647
4648
4649
4650
4651
4652
4653
4654
4655
4656
4657
4658
4659
4660
4661
4662
4663
4664
4665
4666
4667
4668
4669
4670
4671
4672
4673
4674
4675
4676
4677
4678
4679
4680
4681
4682
4683
4684
4685
4686
4687
4688
4689
4690
4691
4692
4693
4694
4695
4696
4697
4698
4699
4700
4701
4702
4703
4704
4705
4706
4707
4708
4709
4710
4711
4712
4713
4714
4715
4716
4717
4718
4719
4720
4721
4722
4723
4724
4725
4726
4727
4728
4729
4730
4731
4732
4733
4734
4735
4736
4737
4738
4739
4740
4741
4742
4743
4744
4745
4746
4747
4748
4749
4750
4751
4752
4753
4754
4755
4756
4757
4758
4759
4760
4761
4762
4763
4764
4765
4766
4767
4768
4769
4770
4771
4772
4773
4774
4775
4776
4777
4778
4779
4780
4781
4782
4783
4784
4785
4786
4787
4788
4789
4790
4791
4792
4793
4794
4795
4796
4797
4798
4799
4800
4801
4802
4803
4804
4805
4806
4807
4808
4809
4810
4811
4812
4813
4814
4815
4816
4817
4818
4819
4820
4821
4822
4823
4824
4825
4826
4827
4828
4829
4830
4831
4832
4833
4834
4835
4836
4837
4838
4839
4840
4841
4842
4843
4844
4845
4846
4847
4848
4849
4850
4851
4852
4853
4854
4855
4856
4857
4858
4859
4860
4861
4862
4863
4864
4865
4866
4867
4868
4869
4870
4871
4872
4873
4874
4875
4876
4877
4878
4879
4880
4881
4882
4883
4884
4885
4886
4887
4888
4889
4890
4891
4892
4893
4894
4895
4896
4897
4898
4899
4900
4901
4902
4903
4904
4905
4906
4907
4908
4909
4910
4911
4912
4913
4914
4915
4916
4917
4918
4919
4920
4921
4922
4923
4924
4925
4926
4927
4928
4929
4930
4931
4932
4933
4934
4935
4936
4937
4938
4939
4940
4941
4942
4943
4944
4945
4946
4947
4948
4949
4950
4951
4952
4953
4954
4955
4956
4957
4958
4959
4960
4961
4962
4963
4964
4965
4966
4967
4968
4969
4970
4971
4972
4973
4974
4975
4976
4977
4978
4979
4980
4981
4982
4983
4984
4985
4986
4987
4988
4989
4990
4991
4992
4993
4994
4995
4996
4997
4998
4999
5000
5001
5002
5003
5004
5005
5006
5007
5008
5009
5010
5011
5012
5013
5014
5015
5016
5017
5018
5019
5020
5021
5022
5023
5024
5025
5026
5027
5028
5029
5030
5031
5032
5033
5034
5035
5036
5037
5038
5039
5040
5041
5042
5043
5044
5045
5046
5047
5048
5049
5050
5051
5052
5053
5054
5055
5056
5057
5058
5059
5060
5061
5062
5063
5064
5065
5066
5067
5068
5069
5070
5071
5072
5073
5074
5075
5076
5077
5078
5079
5080
5081
5082
5083
5084
5085
5086
5087
5088
5089
5090
5091
5092
5093
5094
5095
5096
5097
5098
5099
5100
5101
5102
5103
5104
5105
5106
5107
5108
5109
5110
5111
5112
5113
5114
5115
5116
5117
5118
5119
5120
5121
5122
5123
5124
5125
5126
5127
5128
5129
5130
5131
5132
5133
5134
5135
5136
5137
5138
5139
5140
5141
5142
5143
5144
5145
5146
5147
5148
5149
5150
5151
5152
5153
5154
5155
5156
5157
5158
5159
5160
5161
5162
5163
5164
5165
5166
5167
5168
5169
5170
5171
5172
5173
5174
5175
5176
5177
5178
5179
5180
5181
5182
5183
5184
5185
5186
5187
5188
5189
5190
5191
5192
5193
5194
5195
5196
5197
5198
5199
5200
5201
5202
5203
5204
5205
5206
5207
5208
5209
5210
5211
5212
5213
5214
5215
5216
5217
5218
5219
5220
5221
5222
5223
5224
5225
5226
5227
5228
5229
5230
5231
5232
5233
5234
5235
5236
5237
5238
5239
5240
5241
5242
5243
5244
5245
5246
5247
5248
5249
5250
5251
5252
5253
5254
5255
5256
5257
5258
5259
5260
5261
5262
5263
5264
5265
5266
5267
5268
5269
5270
5271
5272
5273
5274
5275
5276
5277
5278
5279
5280
5281
5282
5283
5284
5285
5286
5287
5288
5289
5290
5291
5292
5293
5294
5295
5296
5297
5298
5299
5300
5301
5302
5303
5304
5305
5306
5307
5308
5309
5310
5311
5312
5313
5314
5315
5316
5317
5318
5319
5320
5321
5322
5323
5324
5325
5326
5327
5328
5329
5330
5331
5332
5333
5334
5335
5336
5337
5338
5339
5340
5341
5342
5343
5344
5345
5346
5347
5348
5349
5350
5351
5352
5353
5354
5355
5356
5357
5358
5359
5360
5361
5362
5363
5364
5365
5366
5367
5368
5369
5370
5371
5372
5373
5374
5375
5376
5377
5378
5379
5380
5381
5382
5383
5384
5385
5386
5387
5388
5389
5390
5391
5392
5393
5394
5395
5396
5397
5398
5399
5400
5401
5402
5403
5404
5405
5406
5407
5408
5409
5410
5411
5412
5413
5414
5415
5416
5417
5418
5419
5420
5421
5422
5423
5424
5425
5426
5427
5428
5429
5430
5431
5432
5433
5434
5435
5436
5437
5438
5439
5440
5441
5442
5443
5444
5445
5446
5447
5448
5449
5450
5451
5452
5453
5454
5455
5456
5457
5458
5459
5460
5461
5462
5463
5464
5465
5466
5467
5468
5469
5470
5471
5472
5473
5474
5475
5476
5477
5478
5479
5480
5481
5482
5483
5484
5485
5486
5487
5488
5489
5490
5491
5492
5493
5494
5495
5496
5497
5498
5499
5500
5501
5502
5503
5504
5505
5506
5507
5508
5509
5510
5511
5512
5513
5514
5515
5516
5517
5518
5519
5520
5521
5522
5523
5524
5525
5526
5527
5528
5529
5530
5531
5532
5533
5534
5535
5536
5537
5538
5539
5540
5541
5542
5543
5544
5545
5546
5547
5548
5549
5550
5551
5552
5553
5554
5555
5556
5557
5558
5559
5560
5561
5562
5563
5564
5565
5566
5567
5568
5569
5570
5571
5572
5573
5574
5575
5576
5577
5578
5579
5580
5581
5582
5583
5584
5585
5586
5587
5588
5589
5590
5591
5592
5593
5594
5595
5596
5597
5598
5599
5600
5601
5602
5603
5604
5605
5606
5607
5608
5609
5610
5611
5612
5613
5614
5615
5616
5617
5618
5619
5620
5621
5622
5623
5624
5625
5626
5627
5628
5629
5630
5631
5632
5633
5634
5635
5636
5637
5638
5639
5640
5641
5642
5643
5644
5645
5646
5647
5648
5649
5650
5651
5652
5653
5654
5655
5656
5657
5658
5659
5660
5661
5662
5663
5664
5665
5666
5667
5668
5669
5670
5671
5672
5673
5674
5675
5676
5677
5678
5679
5680
5681
5682
5683
5684
5685
5686
5687
5688
5689
5690
5691
5692
5693
5694
5695
5696
5697
5698
5699
5700
5701
5702
5703
5704
5705
5706
5707
5708
5709
5710
5711
5712
5713
5714
5715
5716
5717
5718
5719
5720
5721
5722
5723
5724
5725
5726
5727
5728
5729
5730
5731
5732
5733
5734
5735
5736
5737
5738
5739
5740
5741
5742
5743
5744
5745
5746
5747
5748
5749
5750
5751
5752
5753
5754
5755
5756
5757
5758
5759
5760
5761
5762
5763
5764
5765
5766
5767
5768
5769
5770
5771
5772
5773
5774
5775
5776
5777
5778
5779
5780
5781
5782
5783
5784
5785
5786
5787
5788
5789
5790
5791
5792
5793
5794
5795
5796
5797
5798
5799
5800
5801
5802
5803
5804
5805
5806
5807
5808
5809
5810
5811
5812
5813
5814
5815
5816
5817
5818
5819
5820
5821
5822
5823
5824
5825
5826
5827
5828
5829
5830
5831
5832
5833
5834
5835
5836
5837
5838
5839
5840
5841
5842
5843
5844
5845
5846
5847
5848
5849
5850
5851
5852
5853
5854
5855
5856
5857
5858
5859
5860
5861
5862
5863
5864
5865
5866
5867
5868
5869
5870
5871
5872
5873
5874
5875
5876
5877
5878
5879
5880
5881
5882
5883
5884
5885
5886
5887
5888
5889
5890
5891
5892
5893
5894
5895
5896
5897
5898
5899
5900
5901
5902
5903
5904
5905
5906
5907
5908
5909
5910
5911
5912
5913
5914
5915
5916
5917
5918
5919
5920
5921
5922
5923
5924
5925
5926
5927
5928
5929
5930
5931
5932
5933
5934
5935
5936
5937
5938
5939
5940
5941
5942
5943
5944
5945
5946
5947
5948
5949
5950
5951
5952
5953
5954
5955
5956
5957
5958
5959
5960
5961
5962
5963
5964
5965
5966
5967
5968
5969
5970
5971
5972
5973
5974
5975
5976
5977
5978
5979
5980
5981
5982
5983
5984
5985
5986
5987
5988
5989
5990
5991
5992
5993
5994
5995
5996
5997
5998
5999
6000
6001
6002
6003
6004
6005
6006
6007
6008
6009
6010
6011
6012
6013
6014
6015
6016
6017
6018
6019
6020
6021
6022
6023
6024
6025
6026
6027
6028
6029
6030
6031
6032
6033
6034
6035
6036
6037
6038
6039
6040
6041
6042
6043
6044
6045
6046
6047
6048
6049
6050
6051
6052
6053
6054
6055
6056
6057
6058
6059
6060
6061
6062
6063
6064
6065
6066
6067
6068
6069
6070
6071
6072
6073
6074
6075
6076
6077
6078
6079
6080
6081
6082
6083
6084
6085
6086
6087
6088
6089
6090
6091
6092
6093
6094
6095
6096
6097
6098
6099
6100
6101
6102
6103
6104
6105
6106
6107
6108
6109
6110
6111
6112
6113
6114
6115
6116
6117
6118
6119
6120
6121
6122
6123
6124
6125
6126
6127
6128
6129
6130
6131
6132
6133
6134
6135
6136
6137
6138
6139
6140
6141
6142
6143
6144
6145
6146
6147
6148
6149
6150
6151
6152
6153
6154
6155
6156
6157
6158
6159
6160
6161
6162
6163
6164
6165
6166
6167
6168
6169
6170
6171
6172
6173
6174
6175
6176
6177
6178
6179
6180
6181
6182
6183
6184
6185
6186
6187
6188
6189
6190
6191
6192
6193
6194
6195
6196
6197
6198
6199
6200
6201
6202
6203
6204
6205
6206
6207
6208
6209
6210
6211
6212
6213
6214
6215
6216
6217
6218
6219
6220
6221
6222
6223
6224
6225
6226
6227
6228
6229
6230
6231
6232
6233
6234
6235
6236
6237
6238
6239
6240
6241
6242
6243
6244
6245
6246
6247
6248
6249
6250
6251
6252
6253
6254
6255
6256
6257
6258
6259
6260
6261
6262
6263
6264
6265
6266
6267
6268
6269
6270
6271
6272
6273
6274
6275
6276
6277
6278
6279
6280
6281
6282
6283
6284
6285
6286
6287
6288
6289
6290
6291
6292
6293
6294
6295
6296
6297
6298
6299
6300
6301
6302
6303
6304
6305
6306
6307
6308
6309
6310
6311
6312
6313
6314
6315
6316
6317
6318
6319
6320
6321
6322
6323
6324
6325
6326
6327
6328
6329
6330
6331
6332
6333
6334
6335
6336
6337
6338
6339
6340
6341
6342
6343
6344
6345
6346
6347
6348
6349
6350
6351
6352
6353
6354
6355
6356
6357
6358
6359
6360
6361
6362
6363
6364
6365
6366
6367
6368
6369
6370
6371
6372
6373
6374
6375
6376
6377
6378
6379
6380
6381
6382
6383
6384
6385
6386
6387
6388
6389
6390
6391
6392
6393
6394
6395
6396
6397
6398
6399
6400
6401
6402
6403
6404
6405
6406
6407
6408
6409
6410
6411
6412
6413
6414
6415
6416
6417
6418
6419
6420
6421
6422
6423
6424
6425
6426
6427
6428
6429
6430
6431
6432
6433
6434
6435
6436
6437
6438
6439
6440
6441
6442
6443
6444
6445
6446
6447
6448
6449
6450
6451
6452
6453
6454
6455
6456
6457
6458
6459
6460
6461
6462
6463
6464
6465
6466
6467
6468
6469
6470
6471
6472
6473
6474
6475
6476
6477
6478
6479
6480
6481
6482
6483
6484
6485
6486
6487
6488
6489
6490
6491
6492
6493
6494
6495
6496
6497
6498
6499
6500
6501
6502
6503
6504
6505
6506
6507
6508
6509
6510
6511
6512
6513
6514
6515
6516
6517
6518
6519
6520
6521
6522
6523
6524
6525
6526
6527
6528
6529
6530
6531
6532
6533
6534
6535
6536
6537
6538
6539
6540
6541
6542
6543
6544
6545
6546
6547
6548
6549
6550
6551
6552
6553
6554
6555
6556
6557
6558
6559
6560
6561
6562
6563
6564
6565
6566
6567
6568
6569
6570
6571
6572
6573
6574
6575
6576
6577
6578
6579
6580
6581
6582
6583
6584
6585
6586
6587
6588
6589
6590
6591
6592
6593
6594
6595
6596
6597
6598
6599
6600
6601
6602
6603
6604
6605
6606
6607
6608
6609
6610
6611
6612
6613
6614
6615
6616
6617
6618
6619
6620
6621
6622
6623
6624
6625
6626
6627
6628
6629
6630
6631
6632
6633
6634
6635
6636
6637
6638
6639
6640
6641
6642
6643
6644
6645
6646
6647
6648
6649
6650
6651
6652
6653
6654
6655
6656
6657
6658
6659
6660
6661
6662
6663
6664
6665
6666
6667
6668
6669
6670
6671
6672
6673
6674
6675
6676
6677
6678
6679
6680
6681
6682
6683
6684
6685
6686
6687
6688
6689
6690
6691
6692
6693
6694
6695
6696
6697
6698
6699
6700
6701
6702
6703
6704
6705
6706
6707
6708
6709
6710
6711
6712
6713
6714
6715
6716
6717
6718
6719
6720
6721
6722
6723
6724
6725
6726
6727
6728
6729
6730
6731
6732
6733
6734
6735
6736
6737
6738
6739
6740
6741
6742
6743
6744
6745
6746
6747
6748
6749
6750
6751
6752
6753
6754
6755
6756
6757
6758
6759
6760
6761
6762
6763
6764
6765
6766
6767
6768
6769
6770
6771
6772
6773
6774
6775
6776
6777
6778
6779
6780
6781
6782
6783
6784
6785
6786
6787
6788
6789
6790
6791
6792
6793
6794
6795
6796
6797
6798
6799
6800
6801
6802
6803
6804
6805
6806
6807
6808
6809
6810
6811
6812
6813
6814
6815
6816
6817
6818
6819
6820
6821
6822
6823
6824
6825
6826
6827
6828
6829
6830
6831
6832
6833
6834
6835
6836
6837
6838
6839
6840
6841
6842
6843
6844
6845
6846
6847
6848
6849
6850
6851
6852
6853
6854
6855
6856
6857
6858
6859
6860
6861
6862
6863
6864
6865
6866
6867
6868
6869
6870
6871
6872
6873
6874
6875
6876
6877
6878
6879
6880
6881
6882
6883
6884
6885
6886
6887
6888
6889
6890
6891
6892
6893
6894
6895
6896
6897
6898
6899
6900
6901
6902
6903
6904
6905
6906
6907
6908
6909
6910
6911
6912
6913
6914
6915
6916
6917
6918
6919
6920
6921
6922
6923
6924
6925
6926
6927
6928
6929
6930
6931
6932
6933
6934
6935
6936
6937
6938
6939
6940
6941
6942
6943
6944
6945
6946
6947
6948
6949
6950
6951
6952
6953
6954
6955
6956
6957
6958
6959
6960
6961
6962
6963
6964
6965
6966
6967
6968
6969
6970
6971
6972
6973
6974
6975
6976
6977
6978
6979
6980
6981
6982
6983
6984
6985
6986
6987
6988
6989
6990
6991
6992
6993
6994
6995
6996
6997
6998
6999
7000
7001
7002
7003
7004
7005
7006
7007
7008
7009
7010
7011
7012
7013
7014
7015
7016
7017
7018
7019
7020
7021
7022
7023
7024
7025
7026
7027
7028
7029
7030
7031
7032
7033
7034
7035
7036
7037
7038
7039
7040
7041
7042
7043
7044
7045
7046
7047
7048
7049
7050
7051
7052
7053
7054
7055
7056
7057
7058
7059
7060
7061
7062
7063
7064
7065
7066
7067
7068
7069
7070
7071
7072
7073
7074
7075
7076
7077
7078
7079
7080
7081
7082
7083
7084
7085
7086
7087
7088
7089
7090
7091
7092
7093
7094
7095
7096
7097
7098
7099
7100
7101
7102
7103
7104
7105
7106
7107
7108
7109
7110
7111
7112
7113
7114
7115
7116
7117
7118
7119
7120
7121
7122
7123
7124
7125
7126
7127
7128
7129
7130
7131
7132
7133
7134
7135
7136
7137
7138
7139
7140
7141
7142
7143
7144
7145
7146
7147
7148
7149
7150
7151
7152
7153
7154
7155
7156
7157
7158
7159
7160
7161
7162
7163
7164
7165
7166
7167
7168
7169
7170
7171
7172
7173
7174
7175
7176
7177
7178
7179
7180
7181
7182
7183
7184
7185
7186
7187
7188
7189
7190
7191
7192
7193
7194
7195
7196
7197
7198
7199
7200
7201
7202
7203
7204
7205
7206
7207
7208
7209
7210
7211
7212
7213
7214
7215
7216
7217
7218
7219
7220
7221
7222
7223
7224
7225
7226
7227
7228
7229
7230
7231
7232
7233
7234
7235
7236
7237
7238
7239
7240
7241
7242
7243
7244
7245
7246
7247
7248
7249
7250
7251
7252
7253
7254
7255
7256
7257
7258
7259
7260
7261
7262
7263
7264
7265
7266
7267
7268
7269
7270
7271
7272
7273
7274
7275
7276
7277
7278
7279
7280
7281
7282
7283
7284
7285
7286
7287
7288
7289
7290
7291
7292
7293
7294
7295
7296
7297
7298
7299
7300
7301
7302
7303
7304
7305
7306
7307
7308
7309
7310
7311
7312
7313
7314
7315
7316
7317
7318
7319
7320
7321
7322
7323
7324
7325
7326
7327
7328
7329
7330
7331
7332
7333
7334
7335
7336
7337
7338
7339
7340
7341
7342
7343
7344
7345
7346
7347
7348
7349
7350
7351
7352
7353
7354
7355
7356
7357
7358
7359
7360
7361
7362
7363
7364
7365
7366
7367
7368
7369
7370
7371
7372
7373
7374
7375
7376
7377
7378
7379
7380
7381
7382
7383
7384
7385
7386
7387
7388
7389
7390
7391
7392
7393
7394
7395
7396
7397
7398
7399
7400
7401
7402
7403
7404
7405
7406
7407
7408
7409
7410
7411
7412
7413
7414
7415
7416
7417
7418
7419
7420
7421
7422
7423
7424
7425
7426
7427
7428
7429
7430
7431
7432
7433
7434
7435
7436
7437
7438
7439
7440
7441
7442
7443
7444
7445
7446
7447
7448
7449
7450
7451
7452
7453
7454
7455
7456
7457
7458
7459
7460
7461
7462
7463
7464
7465
7466
7467
7468
7469
7470
7471
7472
7473
7474
7475
7476
7477
7478
7479
7480
7481
7482
7483
7484
7485
7486
7487
7488
7489
7490
7491
7492
7493
7494
7495
7496
7497
7498
7499
7500
7501
7502
7503
7504
7505
7506
7507
7508
7509
7510
7511
7512
7513
7514
7515
7516
7517
7518
7519
7520
7521
7522
7523
7524
7525
7526
7527
7528
7529
7530
7531
7532
7533
7534
7535
7536
7537
7538
7539
7540
7541
7542
7543
7544
7545
7546
7547
7548
7549
7550
7551
7552
7553
7554
7555
7556
7557
7558
7559
7560
7561
7562
7563
7564
7565
7566
7567
7568
7569
7570
7571
7572
7573
7574
7575
7576
7577
7578
7579
7580
7581
7582
7583
7584
7585
7586
7587
7588
7589
7590
7591
7592
7593
7594
7595
7596
7597
7598
7599
7600
7601
7602
7603
7604
7605
7606
7607
7608
7609
7610
7611
7612
7613
7614
7615
7616
7617
7618
7619
7620
7621
7622
7623
7624
7625
7626
7627
7628
7629
7630
7631
7632
7633
7634
7635
7636
7637
7638
7639
7640
7641
7642
7643
7644
7645
7646
7647
7648
7649
7650
7651
7652
7653
7654
7655
7656
7657
7658
7659
7660
7661
7662
7663
7664
7665
7666
7667
7668
7669
7670
7671
7672
7673
7674
7675
7676
7677
7678
7679
7680
7681
7682
7683
7684
7685
7686
7687
7688
7689
7690
7691
7692
7693
7694
7695
7696
7697
7698
7699
7700
7701
7702
7703
7704
7705
7706
7707
7708
7709
7710
7711
7712
7713
7714
7715
7716
7717
7718
7719
7720
7721
7722
7723
7724
7725
7726
7727
7728
7729
7730
7731
7732
7733
7734
7735
7736
7737
7738
7739
7740
7741
7742
7743
7744
7745
7746
7747
7748
7749
7750
7751
7752
7753
7754
7755
7756
7757
7758
7759
7760
7761
7762
7763
7764
7765
7766
7767
7768
7769
7770
7771
7772
7773
7774
7775
7776
7777
7778
7779
7780
7781
7782
7783
7784
7785
7786
7787
7788
7789
7790
7791
7792
7793
7794
7795
7796
7797
7798
7799
7800
7801
7802
7803
7804
7805
7806
7807
7808
7809
7810
7811
7812
7813
7814
7815
7816
7817
7818
7819
7820
7821
7822
7823
7824
7825
7826
7827
7828
7829
7830
7831
7832
7833
7834
7835
7836
7837
7838
7839
7840
7841
7842
7843
7844
7845
7846
7847
7848
7849
7850
7851
7852
7853
7854
7855
7856
7857
7858
7859
7860
7861
7862
7863
7864
7865
7866
7867
7868
7869
7870
7871
7872
7873
7874
7875
7876
7877
7878
7879
7880
7881
7882
7883
7884
7885
7886
7887
7888
7889
7890
7891
7892
7893
7894
7895
7896
7897
7898
7899
7900
7901
7902
7903
7904
7905
7906
7907
7908
7909
7910
7911
7912
7913
7914
7915
7916
7917
7918
7919
7920
7921
7922
7923
7924
7925
7926
7927
7928
7929
7930
7931
7932
7933
7934
7935
7936
7937
7938
7939
7940
7941
7942
7943
7944
7945
7946
7947
7948
7949
7950
7951
7952
7953
7954
7955
7956
7957
7958
7959
7960
7961
7962
7963
7964
7965
7966
7967
7968
7969
7970
7971
7972
7973
7974
7975
7976
7977
7978
7979
7980
7981
7982
7983
7984
7985
7986
7987
7988
7989
7990
7991
7992
7993
7994
7995
7996
7997
7998
7999
8000
8001
8002
8003
8004
8005
8006
8007
8008
8009
8010
8011
8012
8013
8014
8015
8016
8017
8018
8019
8020
8021
8022
8023
8024
8025
8026
8027
8028
8029
8030
8031
8032
8033
8034
8035
8036
8037
8038
8039
8040
8041
8042
8043
8044
8045
8046
8047
8048
8049
8050
8051
8052
8053
8054
8055
8056
8057
8058
8059
8060
8061
8062
8063
8064
8065
8066
8067
8068
8069
8070
8071
8072
8073
8074
8075
8076
8077
8078
8079
8080
8081
8082
8083
8084
8085
8086
8087
8088
8089
8090
8091
8092
8093
8094
8095
8096
8097
8098
8099
8100
8101
8102
8103
8104
8105
8106
8107
8108
8109
8110
8111
8112
8113
8114
8115
8116
8117
8118
8119
8120
8121
8122
8123
8124
8125
8126
8127
8128
8129
8130
8131
8132
8133
8134
8135
8136
8137
8138
8139
8140
8141
8142
8143
8144
8145
8146
8147
8148
8149
8150
8151
8152
8153
8154
8155
8156
8157
8158
8159
8160
8161
8162
8163
8164
8165
8166
8167
8168
8169
8170
8171
8172
8173
8174
8175
8176
8177
8178
8179
8180
8181
8182
8183
8184
8185
8186
8187
8188
8189
8190
8191
8192
8193
8194
8195
8196
8197
8198
8199
8200
8201
8202
8203
8204
8205
8206
8207
8208
8209
8210
8211
8212
8213
8214
8215
8216
8217
8218
8219
8220
8221
8222
8223
8224
8225
8226
8227
8228
8229
8230
8231
8232
8233
8234
8235
8236
8237
8238
8239
8240
8241
8242
8243
8244
8245
8246
8247
8248
8249
8250
8251
8252
8253
8254
8255
8256
8257
8258
8259
8260
8261
8262
8263
8264
8265
8266
8267
8268
8269
8270
8271
8272
8273
8274
8275
8276
8277
8278
8279
8280
8281
8282
8283
8284
8285
8286
8287
8288
8289
8290
8291
8292
8293
8294
8295
8296
8297
8298
8299
8300
8301
8302
8303
8304
8305
8306
8307
8308
8309
8310
8311
8312
8313
8314
8315
8316
8317
8318
8319
8320
8321
8322
8323
8324
8325
8326
8327
8328
8329
8330
8331
8332
8333
8334
8335
8336
8337
8338
8339
8340
8341
8342
8343
8344
8345
8346
8347
8348
8349
8350
8351
8352
8353
8354
8355
8356
8357
8358
8359
8360
8361
8362
8363
8364
8365
8366
8367
8368
8369
8370
8371
8372
8373
8374
8375
8376
8377
8378
8379
8380
8381
8382
8383
8384
8385
8386
8387
8388
8389
8390
8391
8392
8393
8394
8395
8396
8397
8398
8399
8400
8401
8402
8403
8404
8405
8406
8407
8408
8409
8410
8411
8412
8413
8414
8415
8416
8417
8418
8419
8420
8421
8422
8423
8424
8425
8426
8427
8428
8429
8430
8431
8432
8433
8434
8435
8436
8437
8438
8439
8440
8441
8442
8443
8444
8445
8446
8447
8448
8449
8450
8451
8452
8453
8454
8455
8456
8457
8458
8459
8460
8461
8462
8463
8464
8465
8466
8467
8468
8469
8470
8471
8472
8473
8474
8475
8476
8477
8478
8479
8480
8481
8482
8483
8484
8485
8486
8487
8488
8489
8490
8491
8492
8493
8494
8495
8496
8497
8498
8499
8500
8501
8502
8503
8504
8505
8506
8507
8508
8509
8510
8511
8512
8513
8514
8515
8516
8517
8518
8519
8520
8521
8522
8523
8524
8525
8526
8527
8528
8529
8530
8531
8532
8533
8534
8535
8536
8537
8538
8539
8540
8541
8542
8543
8544
8545
8546
8547
8548
8549
8550
8551
8552
8553
8554
8555
8556
8557
8558
8559
8560
8561
8562
8563
8564
8565
8566
8567
8568
8569
8570
8571
8572
8573
8574
8575
8576
8577
8578
8579
8580
8581
8582
8583
8584
8585
8586
8587
8588
8589
8590
8591
8592
8593
8594
8595
8596
8597
8598
8599
8600
8601
8602
8603
8604
8605
8606
8607
8608
8609
8610
8611
8612
8613
8614
8615
8616
8617
8618
8619
8620
8621
8622
8623
8624
8625
8626
8627
8628
8629
8630
8631
8632
8633
8634
8635
8636
8637
8638
8639
8640
8641
8642
8643
8644
8645
8646
8647
8648
8649
8650
8651
8652
8653
8654
8655
8656
8657
8658
8659
8660
8661
8662
8663
8664
8665
8666
8667
8668
8669
8670
8671
8672
8673
8674
8675
8676
8677
8678
8679
8680
8681
8682
8683
8684
8685
8686
8687
8688
8689
8690
8691
8692
8693
8694
8695
8696
8697
8698
8699
8700
8701
8702
8703
8704
8705
8706
8707
8708
8709
8710
8711
8712
8713
8714
8715
8716
8717
8718
8719
8720
8721
8722
8723
8724
8725
8726
8727
8728
8729
8730
8731
8732
8733
8734
8735
8736
8737
8738
8739
8740
8741
8742
8743
8744
8745
8746
8747
8748
8749
8750
8751
8752
8753
8754
8755
8756
8757
8758
8759
8760
8761
8762
8763
8764
8765
8766
8767
8768
8769
8770
8771
8772
8773
8774
8775
8776
8777
8778
8779
8780
8781
8782
8783
8784
8785
8786
8787
8788
8789
8790
8791
8792
8793
8794
8795
8796
8797
8798
8799
8800
8801
8802
8803
8804
8805
8806
8807
8808
8809
8810
8811
8812
8813
8814
8815
8816
8817
8818
8819
8820
8821
8822
8823
8824
8825
8826
8827
8828
8829
8830
8831
8832
8833
8834
8835
8836
8837
8838
8839
8840
8841
8842
8843
8844
8845
8846
8847
8848
8849
8850
8851
8852
8853
8854
8855
8856
8857
8858
8859
8860
8861
8862
8863
8864
8865
8866
8867
8868
8869
8870
8871
8872
8873
8874
8875
8876
8877
8878
8879
8880
8881
8882
8883
8884
8885
8886
8887
8888
8889
8890
8891
8892
8893
8894
8895
8896
8897
8898
8899
8900
8901
8902
8903
8904
8905
8906
8907
8908
8909
8910
8911
8912
8913
8914
8915
8916
8917
8918
8919
8920
8921
8922
8923
8924
8925
8926
8927
8928
8929
8930
8931
8932
8933
8934
8935
8936
8937
8938
8939
8940
8941
8942
8943
8944
8945
8946
8947
8948
8949
8950
8951
8952
8953
8954
8955
8956
8957
8958
8959
8960
8961
8962
8963
8964
8965
8966
8967
8968
8969
8970
8971
8972
8973
8974
8975
8976
8977
8978
8979
8980
8981
8982
8983
8984
8985
8986
8987
8988
8989
8990
8991
8992
8993
8994
8995
8996
8997
8998
8999
9000
9001
9002
9003
9004
9005
9006
9007
9008
9009
9010
9011
9012
9013
9014
9015
9016
9017
9018
9019
9020
9021
9022
9023
9024
9025
9026
9027
9028
9029
9030
9031
9032
9033
9034
9035
9036
9037
9038
9039
9040
9041
9042
9043
9044
9045
9046
9047
9048
9049
9050
9051
9052
9053
9054
9055
9056
9057
9058
9059
9060
9061
9062
9063
9064
9065
9066
9067
9068
9069
9070
9071
9072
9073
9074
9075
9076
9077
9078
9079
9080
9081
9082
9083
9084
9085
9086
9087
9088
9089
9090
9091
9092
9093
9094
9095
9096
9097
9098
9099
9100
9101
9102
9103
9104
9105
9106
9107
9108
9109
9110
9111
9112
9113
9114
9115
9116
9117
9118
9119
9120
9121
9122
9123
9124
9125
9126
9127
9128
9129
9130
9131
9132
9133
9134
9135
9136
9137
9138
9139
9140
9141
9142
9143
9144
9145
9146
9147
9148
9149
9150
9151
9152
9153
9154
9155
9156
9157
9158
9159
9160
9161
9162
9163
9164
9165
9166
9167
9168
9169
9170
9171
9172
9173
9174
9175
9176
9177
9178
9179
9180
9181
9182
9183
9184
9185
9186
9187
9188
9189
9190
9191
9192
9193
9194
9195
9196
9197
9198
9199
9200
9201
9202
9203
9204
9205
9206
9207
9208
9209
9210
9211
9212
9213
9214
9215
9216
9217
9218
9219
9220
9221
9222
9223
9224
9225
9226
9227
9228
9229
9230
9231
9232
9233
9234
9235
9236
9237
9238
9239
9240
9241
9242
9243
9244
9245
9246
9247
9248
9249
9250
9251
9252
9253
9254
9255
9256
9257
9258
9259
9260
9261
9262
9263
9264
9265
9266
9267
9268
9269
9270
9271
9272
9273
9274
9275
9276
9277
9278
9279
9280
9281
9282
9283
9284
9285
9286
9287
9288
9289
9290
9291
9292
9293
9294
9295
9296
9297
9298
9299
9300
9301
9302
9303
9304
9305
9306
9307
9308
9309
9310
9311
9312
9313
9314
9315
9316
9317
9318
9319
9320
9321
9322
9323
9324
9325
9326
9327
9328
9329
9330
9331
9332
9333
9334
9335
9336
9337
9338
9339
9340
9341
9342
9343
9344
9345
9346
9347
9348
9349
9350
9351
9352
9353
9354
9355
9356
9357
9358
9359
9360
9361
9362
9363
9364
9365
9366
9367
9368
9369
9370
9371
9372
9373
9374
9375
9376
9377
9378
9379
9380
9381
9382
9383
9384
9385
9386
9387
9388
9389
9390
9391
9392
9393
9394
9395
9396
9397
9398
9399
9400
9401
9402
9403
9404
9405
9406
9407
9408
9409
9410
9411
9412
9413
9414
9415
9416
9417
9418
9419
9420
9421
9422
9423
9424
9425
9426
9427
9428
9429
9430
9431
9432
9433
9434
9435
9436
9437
9438
9439
9440
9441
9442
9443
9444
9445
9446
9447
9448
9449
9450
9451
9452
9453
9454
9455
9456
9457
9458
9459
9460
9461
9462
9463
9464
9465
9466
9467
9468
9469
9470
9471
9472
9473
9474
9475
9476
9477
9478
9479
9480
9481
9482
9483
9484
9485
9486
9487
9488
9489
9490
9491
9492
9493
9494
9495
9496
9497
9498
9499
9500
9501
9502
9503
9504
9505
9506
9507
9508
9509
9510
9511
9512
9513
9514
9515
9516
9517
9518
9519
9520
9521
9522
9523
9524
9525
9526
9527
9528
9529
9530
9531
9532
9533
9534
9535
9536
9537
9538
9539
9540
9541
9542
9543
9544
9545
9546
9547
9548
9549
9550
9551
9552
9553
9554
9555
9556
9557
9558
9559
9560
9561
9562
9563
9564
9565
9566
9567
9568
9569
9570
9571
9572
9573
9574
9575
9576
9577
9578
9579
9580
9581
9582
9583
9584
9585
9586
9587
9588
9589
9590
9591
9592
9593
9594
9595
9596
9597
9598
9599
9600
9601
9602
9603
9604
9605
9606
9607
9608
9609
9610
9611
9612
9613
9614
9615
9616
9617
9618
9619
9620
9621
9622
9623
9624
9625
9626
9627
9628
9629
9630
9631
9632
9633
9634
9635
9636
9637
9638
9639
9640
9641
9642
9643
9644
9645
9646
9647
9648
9649
9650
9651
9652
9653
9654
9655
9656
9657
9658
9659
9660
9661
9662
9663
9664
9665
9666
9667
9668
9669
9670
9671
9672
9673
9674
9675
9676
9677
9678
9679
9680
9681
9682
9683
9684
9685
9686
9687
9688
9689
9690
9691
9692
9693
9694
9695
9696
9697
9698
9699
9700
9701
9702
9703
9704
9705
9706
9707
9708
9709
9710
9711
9712
9713
9714
9715
9716
9717
9718
9719
9720
9721
9722
9723
9724
9725
9726
9727
9728
9729
9730
9731
9732
9733
9734
9735
9736
9737
9738
9739
9740
9741
9742
9743
9744
9745
9746
9747
9748
9749
9750
9751
9752
9753
9754
9755
9756
9757
9758
9759
9760
9761
9762
9763
9764
9765
9766
9767
9768
9769
9770
9771
9772
9773
9774
9775
9776
9777
9778
9779
9780
9781
9782
9783
9784
9785
9786
9787
9788
9789
9790
9791
9792
9793
9794
9795
9796
9797
9798
9799
9800
9801
9802
9803
9804
9805
9806
9807
9808
9809
9810
9811
9812
9813
9814
9815
9816
9817
9818
9819
9820
9821
9822
9823
9824
9825
9826
9827
9828
9829
9830
9831
9832
9833
9834
9835
9836
9837
9838
9839
9840
9841
9842
9843
9844
9845
9846
9847
9848
9849
9850
9851
9852
9853
9854
9855
9856
9857
9858
9859
9860
9861
9862
9863
9864
9865
9866
9867
9868
9869
9870
9871
9872
9873
9874
9875
9876
9877
9878
9879
9880
9881
9882
9883
9884
9885
9886
9887
9888
9889
9890
9891
9892
9893
9894
9895
9896
9897
9898
9899
9900
9901
9902
9903
9904
9905
9906
9907
9908
9909
9910
9911
9912
9913
9914
9915
9916
9917
9918
9919
9920
9921
9922
9923
9924
9925
9926
9927
9928
9929
9930
9931
9932
9933
9934
9935
9936
9937
9938
9939
9940
9941
9942
9943
9944
9945
9946
9947
9948
9949
9950
9951
9952
9953
9954
9955
9956
9957
9958
9959
9960
9961
9962
9963
9964
9965
9966
9967
9968
9969
9970
9971
9972
9973
9974
9975
9976
9977
9978
9979
9980
9981
9982
9983
9984
9985
9986
9987
9988
9989
9990
9991
9992
9993
9994
9995
9996
9997
9998
9999
10000
10001
10002
10003
10004
10005
10006
10007
10008
10009
10010
10011
10012
10013
10014
10015
10016
10017
10018
10019
10020
10021
10022
10023
10024
10025
10026
10027
10028
10029
10030
10031
10032
10033
10034
10035
10036
10037
10038
10039
10040
10041
10042
10043
10044
10045
10046
10047
10048
10049
10050
10051
10052
10053
10054
10055
10056
10057
10058
10059
10060
10061
10062
10063
10064
10065
10066
10067
10068
10069
10070
10071
10072
10073
10074
10075
10076
10077
10078
10079
10080
10081
10082
10083
10084
10085
10086
10087
10088
10089
10090
10091
10092
10093
10094
10095
10096
10097
10098
10099
10100
10101
10102
10103
10104
10105
10106
10107
10108
10109
10110
10111
10112
10113
10114
10115
10116
10117
10118
10119
10120
10121
10122
10123
10124
10125
10126
10127
10128
10129
10130
10131
10132
10133
10134
10135
10136
10137
10138
10139
10140
10141
10142
10143
10144
10145
10146
10147
10148
10149
10150
10151
10152
10153
10154
10155
10156
10157
10158
10159
10160
10161
10162
10163
10164
10165
10166
10167
10168
10169
10170
10171
10172
10173
10174
10175
10176
10177
10178
10179
10180
10181
10182
10183
10184
10185
10186
10187
10188
10189
10190
10191
10192
10193
10194
10195
10196
10197
10198
10199
10200
10201
10202
10203
10204
10205
10206
10207
10208
10209
10210
10211
10212
10213
10214
10215
10216
10217
10218
10219
10220
10221
10222
10223
10224
10225
10226
10227
10228
10229
10230
10231
10232
10233
10234
10235
10236
10237
10238
10239
10240
10241
10242
10243
10244
10245
10246
10247
10248
10249
10250
10251
10252
10253
10254
10255
10256
10257
10258
10259
10260
10261
10262
10263
10264
10265
10266
10267
10268
10269
10270
10271
10272
10273
10274
10275
10276
10277
10278
10279
10280
10281
10282
10283
10284
10285
10286
10287
10288
10289
10290
10291
10292
10293
10294
10295
10296
10297
10298
10299
10300
10301
10302
10303
10304
10305
10306
10307
10308
10309
10310
10311
10312
10313
10314
10315
10316
10317
10318
10319
10320
10321
10322
10323
10324
10325
10326
10327
10328
10329
10330
10331
10332
10333
10334
10335
10336
10337
10338
10339
10340
10341
10342
10343
10344
10345
10346
10347
10348
10349
10350
10351
10352
10353
10354
10355
10356
10357
10358
10359
10360
10361
10362
10363
10364
10365
10366
10367
10368
10369
10370
10371
10372
10373
10374
10375
10376
10377
10378
10379
10380
10381
10382
10383
10384
10385
10386
10387
10388
10389
10390
10391
10392
10393
10394
10395
10396
10397
10398
10399
10400
10401
10402
10403
10404
10405
10406
10407
10408
10409
10410
10411
10412
10413
10414
10415
10416
10417
10418
10419
10420
10421
10422
10423
10424
10425
10426
10427
10428
10429
10430
10431
10432
10433
10434
10435
10436
10437
10438
10439
10440
10441
10442
10443
10444
10445
10446
10447
10448
10449
10450
10451
10452
10453
10454
10455
10456
10457
10458
10459
10460
10461
10462
10463
10464
10465
10466
10467
10468
10469
10470
10471
10472
10473
10474
10475
10476
10477
10478
10479
10480
10481
10482
10483
10484
10485
10486
10487
10488
10489
10490
10491
10492
10493
10494
10495
10496
10497
10498
10499
10500
10501
10502
10503
10504
10505
10506
10507
10508
10509
10510
10511
10512
10513
10514
10515
10516
10517
10518
10519
10520
10521
10522
10523
10524
10525
10526
10527
10528
10529
10530
10531
10532
10533
10534
10535
10536
10537
10538
10539
10540
10541
10542
10543
10544
10545
10546
10547
10548
10549
10550
10551
10552
10553
10554
10555
10556
10557
10558
10559
10560
10561
10562
10563
10564
10565
10566
10567
10568
10569
10570
10571
10572
10573
10574
10575
10576
10577
10578
10579
10580
10581
10582
10583
10584
10585
10586
10587
10588
10589
10590
10591
10592
10593
10594
10595
10596
10597
10598
10599
10600
10601
10602
10603
10604
10605
10606
10607
10608
10609
10610
10611
10612
10613
10614
10615
10616
10617
10618
10619
10620
10621
10622
10623
10624
10625
10626
10627
10628
10629
10630
10631
10632
10633
10634
10635
10636
10637
10638
10639
10640
10641
10642
10643
10644
10645
10646
10647
10648
10649
10650
10651
10652
10653
10654
10655
10656
10657
10658
10659
10660
10661
10662
10663
10664
10665
10666
10667
10668
10669
10670
10671
10672
10673
10674
10675
10676
10677
10678
10679
10680
10681
10682
10683
10684
10685
10686
10687
10688
10689
10690
10691
10692
10693
10694
10695
10696
10697
10698
10699
10700
10701
10702
10703
10704
10705
10706
10707
10708
10709
10710
10711
10712
10713
10714
10715
10716
10717
10718
10719
10720
10721
10722
10723
10724
10725
10726
10727
10728
10729
10730
10731
10732
10733
10734
10735
10736
10737
10738
10739
10740
10741
10742
10743
10744
10745
10746
10747
10748
10749
10750
10751
10752
10753
10754
10755
10756
10757
10758
10759
10760
10761
10762
10763
10764
10765
10766
10767
10768
10769
10770
10771
10772
10773
10774
10775
10776
10777
10778
10779
10780
10781
10782
10783
10784
10785
10786
10787
10788
10789
10790
10791
10792
10793
10794
10795
10796
10797
10798
10799
10800
10801
10802
10803
10804
10805
10806
10807
10808
10809
10810
10811
10812
10813
10814
10815
10816
10817
10818
10819
10820
10821
10822
10823
10824
10825
10826
10827
10828
10829
10830
10831
10832
10833
10834
10835
10836
10837
10838
10839
10840
10841
10842
10843
10844
10845
10846
10847
10848
10849
10850
10851
10852
10853
10854
10855
10856
10857
10858
10859
10860
10861
10862
10863
10864
10865
10866
10867
10868
10869
10870
10871
10872
10873
10874
10875
10876
10877
10878
10879
10880
10881
10882
10883
10884
10885
10886
10887
10888
10889
10890
10891
10892
10893
10894
10895
10896
10897
10898
10899
10900
10901
10902
10903
10904
10905
10906
10907
10908
10909
10910
10911
10912
10913
10914
10915
10916
10917
10918
10919
10920
10921
10922
10923
10924
10925
10926
10927
10928
10929
10930
10931
10932
10933
10934
10935
10936
10937
10938
10939
10940
10941
10942
10943
10944
10945
10946
10947
10948
10949
10950
10951
10952
10953
10954
10955
10956
10957
10958
10959
10960
10961
10962
10963
10964
10965
10966
10967
10968
10969
10970
10971
10972
10973
10974
10975
10976
10977
10978
10979
10980
10981
10982
10983
10984
10985
10986
10987
10988
10989
10990
10991
10992
10993
10994
10995
10996
10997
10998
10999
11000
11001
11002
11003
11004
11005
11006
11007
11008
11009
11010
11011
11012
11013
11014
11015
11016
11017
11018
11019
11020
11021
11022
11023
11024
11025
11026
11027
11028
11029
11030
11031
11032
11033
11034
11035
11036
11037
11038
11039
11040
11041
11042
11043
11044
11045
11046
11047
11048
11049
11050
11051
11052
11053
11054
11055
11056
11057
11058
11059
11060
11061
11062
11063
11064
11065
11066
11067
11068
11069
11070
11071
11072
11073
11074
11075
11076
11077
11078
11079
11080
11081
11082
11083
11084
11085
11086
11087
11088
11089
11090
11091
11092
11093
11094
11095
11096
11097
11098
11099
11100
11101
11102
11103
11104
11105
11106
11107
11108
11109
11110
11111
11112
11113
11114
11115
11116
11117
11118
11119
11120
11121
11122
11123
11124
11125
11126
11127
11128
11129
11130
11131
11132
11133
11134
11135
11136
11137
11138
11139
11140
11141
11142
11143
11144
11145
11146
11147
11148
11149
11150
11151
11152
11153
11154
11155
11156
11157
11158
11159
11160
11161
11162
11163
11164
11165
11166
11167
11168
11169
11170
11171
11172
11173
11174
11175
11176
11177
11178
11179
11180
11181
11182
11183
11184
11185
11186
11187
11188
11189
11190
11191
11192
11193
11194
11195
11196
11197
11198
11199
11200
11201
11202
11203
11204
11205
11206
11207
11208
11209
11210
11211
11212
11213
11214
11215
11216
11217
11218
11219
11220
11221
11222
11223
11224
11225
11226
11227
11228
11229
11230
11231
11232
11233
11234
11235
11236
11237
11238
11239
11240
11241
11242
11243
11244
11245
11246
11247
11248
11249
11250
11251
11252
11253
11254
11255
11256
11257
11258
11259
11260
11261
11262
11263
11264
11265
11266
11267
11268
11269
11270
11271
11272
11273
11274
11275
11276
11277
11278
11279
11280
11281
11282
11283
11284
11285
11286
11287
11288
11289
11290
11291
11292
11293
11294
11295
11296
11297
11298
11299
11300
11301
11302
11303
11304
11305
11306
11307
11308
11309
11310
11311
11312
11313
11314
11315
11316
11317
11318
11319
11320
11321
11322
11323
11324
11325
11326
11327
11328
11329
11330
11331
11332
11333
11334
11335
11336
11337
11338
11339
11340
11341
11342
11343
11344
11345
11346
11347
11348
11349
11350
11351
11352
11353
11354
11355
11356
11357
11358
11359
11360
11361
11362
11363
11364
11365
11366
11367
11368
11369
11370
11371
11372
11373
11374
11375
11376
11377
11378
11379
11380
11381
11382
11383
11384
11385
11386
11387
11388
11389
11390
11391
11392
11393
11394
11395
11396
11397
11398
11399
11400
11401
11402
11403
11404
11405
11406
11407
11408
11409
11410
11411
11412
11413
11414
11415
11416
11417
11418
11419
11420
11421
11422
11423
11424
11425
11426
11427
11428
11429
11430
11431
11432
11433
11434
11435
11436
11437
11438
11439
11440
11441
11442
11443
11444
11445
11446
11447
11448
11449
11450
11451
11452
11453
11454
11455
11456
11457
11458
11459
11460
11461
11462
11463
11464
11465
11466
11467
11468
11469
11470
11471
11472
11473
11474
11475
11476
11477
11478
11479
11480
11481
11482
11483
11484
11485
11486
11487
11488
11489
11490
11491
11492
11493
11494
11495
11496
11497
11498
11499
11500
11501
11502
11503
11504
11505
11506
11507
11508
11509
11510
11511
11512
11513
11514
11515
11516
11517
11518
11519
11520
11521
11522
11523
11524
11525
11526
11527
11528
11529
11530
11531
11532
11533
11534
11535
11536
11537
11538
11539
11540
11541
11542
11543
11544
11545
11546
11547
11548
11549
11550
11551
11552
11553
11554
11555
11556
11557
11558
11559
11560
11561
11562
11563
11564
11565
11566
11567
11568
11569
11570
11571
11572
11573
11574
11575
11576
11577
11578
11579
11580
11581
11582
11583
11584
11585
11586
11587
11588
11589
11590
11591
11592
11593
11594
11595
11596
11597
11598
11599
11600
11601
11602
11603
11604
11605
11606
11607
11608
11609
11610
11611
11612
11613
11614
11615
11616
11617
11618
11619
11620
11621
11622
11623
11624
11625
11626
11627
11628
11629
11630
11631
11632
11633
11634
11635
11636
11637
11638
11639
11640
11641
11642
11643
11644
11645
11646
11647
11648
11649
11650
11651
11652
11653
11654
11655
11656
11657
11658
11659
11660
11661
11662
11663
11664
11665
11666
11667
11668
11669
11670
11671
11672
11673
11674
11675
11676
11677
11678
11679
11680
11681
11682
11683
11684
11685
11686
11687
11688
11689
11690
11691
11692
11693
11694
11695
11696
11697
11698
11699
11700
11701
11702
11703
11704
11705
11706
11707
11708
11709
11710
11711
11712
11713
11714
11715
11716
11717
11718
11719
11720
11721
11722
11723
11724
11725
11726
11727
11728
11729
11730
11731
11732
11733
11734
11735
11736
11737
11738
11739
11740
11741
11742
11743
11744
11745
11746
11747
11748
11749
11750
11751
11752
11753
11754
11755
11756
11757
11758
11759
11760
11761
11762
11763
11764
11765
11766
11767
11768
11769
11770
11771
11772
11773
11774
11775
11776
11777
11778
11779
11780
11781
11782
11783
11784
11785
11786
11787
11788
11789
11790
11791
11792
11793
11794
11795
11796
11797
11798
11799
11800
11801
11802
11803
11804
11805
11806
11807
11808
11809
11810
11811
11812
11813
11814
11815
11816
11817
11818
11819
11820
11821
11822
11823
11824
11825
11826
11827
11828
11829
11830
11831
11832
11833
11834
11835
11836
11837
11838
11839
11840
11841
11842
11843
11844
11845
11846
11847
11848
11849
11850
11851
11852
11853
11854
11855
11856
11857
11858
11859
11860
11861
11862
11863
11864
11865
11866
11867
11868
11869
11870
11871
11872
11873
11874
11875
11876
11877
11878
11879
11880
11881
11882
11883
11884
11885
11886
11887
11888
11889
11890
11891
11892
11893
11894
11895
11896
11897
11898
11899
11900
11901
11902
11903
11904
11905
11906
11907
11908
11909
11910
11911
11912
11913
11914
11915
11916
11917
11918
11919
11920
11921
11922
11923
11924
11925
11926
11927
11928
11929
11930
11931
11932
11933
11934
11935
11936
11937
11938
11939
11940
11941
11942
11943
11944
11945
11946
11947
11948
11949
11950
11951
11952
11953
11954
11955
11956
11957
11958
11959
11960
11961
11962
11963
11964
11965
11966
11967
11968
11969
11970
11971
11972
11973
11974
11975
11976
11977
11978
11979
11980
11981
11982
11983
11984
11985
11986
11987
11988
11989
11990
11991
11992
11993
11994
11995
11996
11997
11998
11999
12000
12001
12002
12003
12004
12005
12006
12007
12008
12009
12010
12011
12012
12013
12014
12015
12016
12017
12018
12019
12020
12021
12022
12023
12024
12025
12026
12027
12028
12029
12030
12031
12032
12033
12034
12035
12036
12037
12038
12039
12040
12041
12042
12043
12044
12045
12046
12047
12048
12049
12050
12051
12052
12053
12054
12055
12056
12057
12058
12059
12060
12061
12062
12063
12064
12065
12066
12067
12068
12069
12070
12071
12072
12073
12074
12075
12076
12077
12078
12079
12080
12081
12082
12083
12084
12085
12086
12087
12088
12089
12090
12091
12092
12093
12094
12095
12096
12097
12098
12099
12100
12101
12102
12103
12104
12105
12106
12107
12108
12109
12110
12111
12112
12113
12114
12115
12116
12117
12118
12119
12120
12121
12122
12123
12124
12125
12126
12127
12128
12129
12130
12131
12132
12133
12134
12135
12136
12137
12138
12139
12140
12141
12142
12143
12144
12145
12146
12147
12148
12149
12150
12151
12152
12153
12154
12155
12156
12157
12158
12159
12160
12161
12162
12163
12164
12165
12166
12167
12168
12169
12170
12171
12172
12173
12174
12175
12176
12177
12178
12179
12180
12181
12182
12183
12184
12185
12186
12187
12188
12189
12190
12191
12192
12193
12194
12195
12196
12197
12198
12199
12200
12201
12202
12203
12204
12205
12206
12207
12208
12209
12210
12211
12212
12213
12214
12215
12216
12217
12218
12219
12220
12221
12222
12223
12224
12225
12226
12227
12228
12229
12230
12231
12232
12233
12234
12235
12236
12237
12238
12239
12240
12241
12242
12243
12244
12245
12246
12247
12248
12249
12250
12251
12252
12253
12254
12255
12256
12257
12258
12259
12260
12261
12262
12263
12264
12265
12266
12267
12268
12269
12270
12271
12272
12273
12274
12275
12276
12277
12278
12279
12280
12281
12282
12283
12284
12285
12286
12287
12288
12289
12290
12291
12292
12293
12294
12295
12296
12297
12298
12299
12300
12301
12302
12303
12304
12305
12306
12307
12308
12309
12310
12311
12312
12313
12314
12315
12316
12317
12318
12319
12320
12321
12322
12323
12324
12325
12326
12327
12328
12329
12330
12331
12332
12333
12334
12335
12336
12337
12338
12339
12340
12341
12342
12343
12344
12345
12346
12347
12348
12349
12350
12351
12352
12353
12354
12355
12356
12357
12358
12359
12360
12361
12362
12363
12364
12365
12366
12367
12368
12369
12370
12371
12372
12373
12374
12375
12376
12377
12378
12379
12380
12381
12382
12383
12384
12385
12386
12387
12388
12389
12390
12391
12392
12393
12394
12395
12396
12397
12398
12399
12400
12401
12402
12403
12404
12405
12406
12407
12408
12409
12410
12411
12412
12413
12414
12415
12416
12417
12418
12419
12420
12421
12422
12423
12424
12425
12426
12427
12428
12429
12430
12431
12432
12433
12434
12435
12436
12437
12438
12439
12440
12441
12442
12443
12444
12445
12446
12447
12448
12449
12450
12451
12452
12453
12454
12455
12456
12457
12458
12459
12460
12461
12462
12463
12464
12465
12466
12467
12468
12469
12470
12471
12472
12473
12474
12475
12476
12477
12478
12479
12480
12481
12482
12483
12484
12485
12486
12487
12488
12489
12490
12491
12492
12493
12494
12495
12496
12497
12498
12499
12500
12501
12502
12503
12504
12505
12506
12507
12508
12509
12510
12511
12512
12513
12514
12515
12516
12517
12518
12519
12520
12521
12522
12523
12524
12525
12526
12527
12528
12529
12530
12531
12532
12533
12534
12535
12536
12537
12538
12539
12540
12541
12542
12543
12544
12545
12546
12547
12548
12549
12550
12551
12552
12553
12554
12555
12556
12557
12558
12559
12560
12561
12562
12563
12564
12565
12566
12567
12568
12569
12570
12571
12572
12573
12574
12575
12576
12577
12578
12579
12580
12581
12582
12583
12584
12585
12586
12587
12588
12589
12590
12591
12592
12593
12594
12595
12596
12597
12598
12599
12600
12601
12602
12603
12604
12605
12606
12607
12608
12609
12610
12611
12612
12613
12614
12615
12616
12617
12618
12619
12620
12621
12622
12623
12624
12625
12626
12627
12628
12629
12630
12631
12632
12633
12634
12635
12636
12637
12638
12639
12640
12641
12642
12643
12644
12645
12646
12647
12648
12649
12650
12651
12652
12653
12654
12655
12656
12657
12658
12659
12660
12661
12662
12663
12664
12665
12666
12667
12668
12669
12670
12671
12672
12673
12674
12675
12676
12677
12678
12679
12680
12681
12682
12683
12684
12685
12686
12687
12688
12689
12690
12691
12692
12693
12694
12695
12696
12697
12698
12699
12700
12701
12702
12703
12704
12705
12706
12707
12708
12709
12710
12711
12712
12713
12714
12715
12716
12717
12718
12719
12720
12721
12722
12723
12724
12725
12726
12727
12728
12729
12730
12731
12732
12733
12734
12735
12736
12737
12738
12739
12740
12741
12742
12743
12744
12745
12746
12747
12748
12749
12750
12751
12752
12753
12754
12755
12756
12757
12758
12759
12760
12761
12762
12763
12764
12765
12766
12767
12768
12769
12770
12771
12772
12773
12774
12775
12776
12777
12778
12779
12780
12781
12782
12783
12784
12785
12786
12787
12788
12789
12790
12791
12792
12793
12794
12795
12796
12797
12798
12799
12800
12801
12802
12803
12804
12805
12806
12807
12808
12809
12810
12811
12812
12813
12814
12815
12816
12817
12818
12819
12820
12821
12822
12823
12824
12825
12826
12827
12828
12829
12830
12831
12832
12833
12834
12835
12836
12837
12838
12839
12840
12841
12842
12843
12844
12845
12846
12847
12848
12849
12850
12851
12852
12853
12854
12855
12856
12857
12858
12859
12860
12861
12862
12863
12864
12865
12866
12867
12868
12869
12870
12871
12872
12873
12874
12875
12876
12877
12878
12879
12880
12881
12882
12883
12884
12885
12886
12887
12888
12889
12890
12891
12892
12893
12894
12895
12896
12897
12898
12899
12900
12901
12902
12903
12904
12905
12906
12907
12908
12909
12910
12911
12912
12913
12914
12915
12916
12917
12918
12919
12920
12921
12922
12923
12924
12925
12926
12927
12928
12929
12930
12931
12932
12933
12934
12935
12936
12937
12938
12939
12940
12941
12942
12943
12944
12945
12946
12947
12948
12949
12950
12951
12952
12953
12954
12955
12956
12957
12958
12959
12960
12961
12962
12963
12964
12965
12966
12967
12968
12969
12970
12971
12972
12973
12974
12975
12976
12977
12978
12979
12980
12981
12982
12983
12984
12985
12986
12987
12988
12989
12990
12991
12992
12993
12994
12995
12996
12997
12998
12999
13000
13001
13002
13003
13004
13005
13006
13007
13008
13009
13010
13011
13012
13013
13014
13015
13016
13017
13018
13019
13020
13021
13022
13023
13024
13025
13026
13027
13028
13029
13030
13031
13032
13033
13034
13035
13036
13037
13038
13039
13040
13041
13042
13043
13044
13045
13046
13047
13048
13049
13050
13051
13052
13053
13054
13055
13056
13057
13058
13059
13060
13061
13062
13063
13064
13065
13066
13067
13068
13069
13070
13071
13072
13073
13074
13075
13076
13077
13078
13079
13080
13081
13082
13083
13084
13085
13086
13087
13088
13089
13090
13091
13092
13093
13094
13095
13096
13097
13098
13099
13100
13101
13102
13103
13104
13105
13106
13107
13108
13109
13110
13111
13112
13113
13114
13115
13116
13117
13118
13119
13120
13121
13122
13123
13124
13125
13126
13127
13128
13129
13130
13131
13132
13133
13134
13135
13136
13137
13138
13139
13140
13141
13142
13143
13144
13145
13146
13147
13148
13149
13150
13151
13152
13153
13154
13155
13156
13157
13158
13159
13160
13161
13162
13163
13164
13165
13166
13167
13168
13169
13170
13171
13172
13173
13174
13175
13176
13177
13178
13179
13180
13181
13182
13183
13184
13185
13186
13187
13188
13189
13190
13191
13192
13193
13194
13195
13196
13197
13198
13199
13200
13201
13202
13203
13204
13205
13206
13207
13208
13209
13210
13211
13212
13213
13214
13215
13216
13217
13218
13219
13220
13221
13222
13223
13224
13225
13226
13227
13228
13229
13230
13231
13232
13233
13234
13235
13236
13237
13238
13239
13240
13241
13242
13243
13244
13245
13246
13247
13248
13249
13250
13251
13252
13253
13254
13255
13256
13257
13258
13259
13260
13261
13262
13263
13264
13265
13266
13267
13268
13269
13270
13271
13272
13273
13274
13275
13276
13277
13278
13279
13280
13281
13282
13283
13284
13285
13286
13287
13288
13289
13290
13291
13292
13293
13294
13295
13296
13297
13298
13299
13300
13301
13302
13303
13304
13305
13306
13307
13308
13309
13310
13311
13312
13313
13314
13315
13316
13317
13318
13319
13320
13321
13322
13323
13324
13325
13326
13327
13328
13329
13330
13331
13332
13333
13334
13335
13336
13337
13338
13339
13340
13341
13342
13343
13344
13345
13346
13347
13348
13349
13350
13351
13352
13353
13354
13355
13356
13357
13358
13359
13360
13361
13362
13363
13364
13365
13366
13367
13368
13369
13370
13371
13372
13373
13374
13375
13376
13377
13378
13379
13380
13381
13382
13383
13384
13385
13386
13387
13388
13389
13390
13391
13392
13393
13394
13395
13396
13397
13398
13399
13400
13401
13402
13403
13404
13405
13406
13407
13408
13409
13410
13411
13412
13413
13414
13415
13416
13417
13418
13419
13420
13421
13422
13423
13424
13425
13426
13427
13428
13429
13430
13431
13432
13433
13434
13435
13436
13437
13438
13439
13440
13441
13442
13443
13444
13445
13446
13447
13448
13449
13450
13451
13452
13453
13454
13455
13456
13457
13458
13459
13460
13461
13462
13463
13464
13465
13466
13467
13468
13469
13470
13471
13472
13473
13474
13475
13476
13477
13478
13479
13480
13481
13482
13483
13484
13485
13486
13487
13488
13489
13490
13491
13492
13493
13494
13495
13496
13497
13498
13499
13500
13501
13502
13503
13504
13505
13506
13507
13508
13509
13510
13511
13512
13513
13514
13515
13516
13517
13518
13519
13520
13521
13522
13523
13524
13525
13526
13527
13528
13529
13530
13531
13532
13533
13534
13535
13536
13537
13538
13539
13540
13541
13542
13543
13544
13545
13546
13547
13548
13549
13550
13551
13552
13553
13554
13555
13556
13557
13558
13559
13560
13561
13562
13563
13564
13565
13566
13567
13568
13569
13570
13571
13572
13573
13574
13575
13576
13577
13578
13579
13580
13581
13582
13583
13584
13585
13586
13587
13588
13589
13590
13591
13592
13593
13594
13595
13596
13597
13598
13599
13600
13601
13602
13603
13604
13605
13606
13607
13608
13609
13610
13611
13612
13613
13614
13615
13616
13617
13618
13619
13620
13621
13622
13623
13624
13625
13626
13627
13628
13629
13630
13631
13632
13633
13634
13635
13636
13637
13638
13639
13640
13641
13642
13643
13644
13645
13646
13647
13648
13649
13650
13651
13652
13653
13654
13655
13656
13657
13658
13659
13660
13661
13662
13663
13664
13665
13666
13667
13668
13669
13670
13671
13672
13673
13674
13675
13676
13677
13678
13679
13680
13681
13682
13683
13684
13685
13686
13687
13688
13689
13690
13691
13692
13693
13694
13695
13696
13697
13698
13699
13700
13701
13702
13703
13704
13705
13706
13707
13708
13709
13710
13711
13712
13713
13714
13715
13716
13717
13718
13719
13720
13721
13722
13723
13724
13725
13726
13727
13728
13729
13730
13731
13732
13733
13734
13735
13736
13737
13738
13739
13740
13741
13742
13743
13744
13745
13746
13747
13748
13749
13750
13751
13752
13753
13754
13755
13756
13757
13758
13759
13760
13761
13762
13763
13764
13765
13766
13767
13768
13769
13770
13771
13772
13773
13774
13775
13776
13777
13778
13779
13780
13781
13782
13783
13784
13785
13786
13787
13788
13789
13790
13791
13792
13793
13794
13795
13796
13797
13798
13799
13800
13801
13802
13803
13804
13805
13806
13807
13808
13809
13810
13811
13812
13813
13814
13815
13816
13817
13818
13819
13820
13821
13822
13823
13824
13825
13826
13827
13828
13829
13830
13831
13832
13833
13834
13835
13836
13837
13838
13839
13840
13841
13842
13843
13844
13845
13846
13847
13848
13849
13850
13851
13852
13853
13854
13855
13856
13857
13858
13859
13860
13861
13862
13863
13864
13865
13866
13867
13868
13869
13870
13871
13872
13873
13874
13875
13876
13877
13878
13879
13880
13881
13882
13883
13884
13885
13886
13887
13888
13889
13890
13891
13892
13893
13894
13895
13896
13897
13898
13899
13900
13901
13902
13903
13904
13905
13906
13907
13908
13909
13910
13911
13912
13913
13914
13915
13916
13917
13918
13919
13920
13921
13922
13923
13924
13925
13926
13927
13928
13929
13930
13931
13932
13933
13934
13935
13936
13937
13938
13939
13940
13941
13942
13943
13944
13945
13946
13947
13948
13949
13950
13951
13952
13953
13954
13955
13956
13957
13958
13959
13960
13961
13962
13963
13964
13965
13966
13967
13968
13969
13970
13971
13972
13973
13974
13975
13976
13977
13978
13979
13980
13981
13982
13983
13984
13985
13986
13987
13988
13989
13990
13991
13992
13993
13994
13995
13996
13997
13998
13999
14000
14001
14002
14003
14004
14005
14006
14007
14008
14009
14010
14011
14012
14013
14014
14015
14016
14017
14018
14019
14020
14021
14022
14023
14024
14025
14026
14027
14028
14029
14030
14031
14032
14033
14034
14035
14036
14037
14038
14039
14040
14041
14042
14043
14044
14045
14046
14047
14048
14049
14050
14051
14052
14053
14054
14055
14056
14057
14058
14059
14060
14061
14062
14063
14064
14065
14066
14067
14068
14069
14070
14071
14072
14073
14074
14075
14076
14077
14078
14079
14080
14081
14082
14083
14084
14085
14086
14087
14088
14089
14090
14091
14092
14093
14094
14095
14096
14097
14098
14099
14100
14101
14102
14103
14104
14105
14106
14107
14108
14109
14110
14111
14112
14113
14114
14115
14116
14117
14118
14119
14120
14121
14122
14123
14124
14125
14126
14127
14128
14129
14130
14131
14132
14133
14134
14135
14136
14137
14138
14139
14140
14141
14142
14143
14144
14145
14146
14147
14148
14149
14150
14151
14152
14153
14154
14155
14156
14157
14158
14159
14160
14161
14162
14163
14164
14165
14166
14167
14168
14169
14170
14171
14172
14173
14174
14175
14176
14177
14178
14179
14180
14181
14182
14183
14184
14185
14186
14187
14188
14189
14190
14191
14192
14193
14194
14195
14196
14197
14198
14199
14200
14201
14202
14203
14204
14205
14206
14207
14208
14209
14210
14211
14212
14213
14214
14215
14216
14217
14218
14219
14220
14221
14222
14223
14224
14225
14226
14227
14228
14229
14230
14231
14232
14233
14234
14235
14236
14237
14238
14239
14240
14241
14242
14243
14244
14245
14246
14247
14248
14249
14250
14251
14252
14253
14254
14255
14256
14257
14258
14259
14260
14261
14262
14263
14264
14265
14266
14267
14268
14269
14270
14271
14272
14273
14274
14275
14276
14277
14278
14279
14280
14281
14282
14283
14284
14285
14286
14287
14288
14289
14290
14291
14292
14293
14294
14295
14296
14297
14298
14299
14300
14301
14302
14303
14304
14305
14306
14307
14308
14309
14310
14311
14312
14313
14314
14315
14316
14317
14318
14319
14320
14321
14322
14323
14324
14325
14326
14327
14328
14329
14330
14331
14332
14333
14334
14335
14336
14337
14338
14339
14340
14341
14342
14343
14344
14345
14346
14347
14348
14349
14350
14351
14352
14353
14354
14355
14356
14357
14358
14359
14360
14361
14362
14363
14364
14365
14366
14367
14368
14369
14370
14371
14372
14373
14374
14375
14376
14377
14378
14379
14380
14381
14382
14383
14384
14385
14386
14387
14388
14389
14390
14391
14392
14393
14394
14395
14396
14397
14398
14399
14400
14401
14402
14403
14404
14405
14406
14407
14408
14409
14410
14411
14412
14413
14414
14415
14416
14417
14418
14419
14420
14421
14422
14423
14424
14425
14426
14427
14428
14429
14430
14431
14432
14433
14434
14435
14436
14437
14438
14439
14440
14441
14442
14443
14444
14445
14446
14447
14448
|
2012-10-22 Jocelyn Turcotte <jocelyn.turcotte@digia.com>
[Qt] Fix "ASSERTION FAILED: !document->inPageCache()" when loading a page
https://bugs.webkit.org/show_bug.cgi?id=98514
Reviewed by Kenneth Rohde Christiansen.
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::transitionToCommittedForNewPage):
2012-10-21 Andreas Kling <kling@webkit.org>
Remove Page::javaScriptURLsAreAllowed setting.
<http://webkit.org/b/99944>
Reviewed by Anders Carlsson.
Have WebView::setJavaScriptURLsAreAllowed() do nothing and return E_NOTIMPL
to prevent COM ABI breakage.
* WebView.cpp:
(WebView::setJavaScriptURLsAreAllowed):
2012-10-18 Roger Fong <roger_fong@apple.com>
Unreviewed. Build fix after r131701 and r131777.
* WebKit.vcproj/WebKit.sln:
2012-10-14 Sam Weinig <sam@webkit.org>
Fix the windows build.
* WebView.cpp:
(toStringVector):
2012-10-10 Brady Eidson <beidson@apple.com>
Switch ResourceLoader::resourceData() from SharedBuffer to ResourceBuffer
https://bugs.webkit.org/show_bug.cgi?id=98976
Reviewed by Anders Carlsson.
* WebDataSource.cpp:
(WebDataSource::data):
2012-10-10 Jon Lee <jonlee@apple.com>
[WK2] Activate plugins when user clicks on snapshot
https://bugs.webkit.org/show_bug.cgi?id=98328
<rdar://problem/12426681>
Reviewed by Brady Eidson.
* WebCoreSupport/WebFrameLoaderClient.h:
(WebFrameLoaderClient::recreatePlugin): Stub implementation of recreatePlugin().
2012-10-10 Brady Eidson <beidson@apple.com>
Switch CachedResource over from SharedBuffer to a new ResourceBuffer
https://bugs.webkit.org/show_bug.cgi?id=98541
Reviewed by Anders Carlsson.
* WebDataSource.cpp:
(WebDataSource::subresourceForURL):
2012-10-08 Simon Fraser <simon.fraser@apple.com>
Some GraphicsLayer cleanup to separate the concepts of using a tile cache, and being the main tile cache layer
https://bugs.webkit.org/show_bug.cgi?id=98574
Reviewed by Dean Jackson.
GraphicsLayerCA assumed that using a TileCache equated to being the main page tile
cache layer, which has some special considerations. Make these two concepts separate
to get closer to being able to use TileCaches in place of CATiledLayer.
* FullscreenVideoController.cpp:
(FullscreenVideoController::LayerClient::platformCALayerShowRepaintCounter):
2012-10-07 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Rename first/second to key/value in HashMap iterators
https://bugs.webkit.org/show_bug.cgi?id=82784
Reviewed by Eric Seidel.
* COMPropertyBag.h:
(::Read):
(::GetPropertyInfo):
* WebCoreStatistics.cpp:
(WebCoreStatistics::javaScriptProtectedObjectTypeCounts):
* WebCoreSupport/WebPlatformStrategies.cpp:
(WebPlatformStrategies::getPluginInfo):
* WebHistory.cpp:
(WebHistory::removeItemFromDateCaches):
* WebKitCOMAPI.cpp:
(classFactory):
* WebKitStatistics.cpp:
(WebKitStatistics::comClassNameCounts):
* WebNotificationCenter.cpp:
(WebNotificationCenter::postNotificationInternal):
(WebNotificationCenter::addObserver):
(WebNotificationCenter::removeObserver):
2012-10-04 Simon Fraser <simon.fraser@apple.com>
Final part of "sync" to "flush" renaming
https://bugs.webkit.org/show_bug.cgi?id=98430
Reviewed by Tim Horton.
Change method names on GraphicsLayer and GraphicsLayerClient that
refer to "sync" to use the term "flush" instead, to be consistent
with the rest of the code.
* WebView.cpp:
(WebView::notifyFlushRequired):
(WebView::flushPendingGraphicsLayerChanges):
* WebView.h:
2012-10-04 Simon Fraser <simon.fraser@apple.com>
Standardize on "flush" terminology for compositing layer flushing/syncing
https://bugs.webkit.org/show_bug.cgi?id=98321
Reviewed by Simon Fraser.
Rename compositing-related methods that refer to "syncing" to instead
refer to "flushing".
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::scheduleCompositingLayerFlush):
* WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
* WebView.cpp:
(WebView::flushPendingGraphicsLayerChanges):
2012-10-02 Anders Carlsson <andersca@apple.com>
Change most GraphicsLayer::create calls to use the version that takes a GraphicsLayerFactory
https://bugs.webkit.org/show_bug.cgi?id=98217
Reviewed by Andreas Kling.
* WebView.cpp:
(WebView::setAcceleratedCompositing):
2012-10-01 Brady Eidson <beidson@apple.com>
Remove the Safari 2 -> Safari 3 icon database import code.
https://bugs.webkit.org/show_bug.cgi?id=98113
Reviewed by Maciej Stachowiak.
Nuke the performImport() IconDatabaseClient method.
* WebIconDatabase.cpp:
* WebIconDatabase.h:
(WebIconDatabase):
2012-09-25 Beth Dakin <bdakin@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=95397
Need to merge didFirstVisuallyNonEmptyLayout and
didNewFirstVisuallyNonEmptyLayout
-and corresponding-
<rdar://problem/10791680>
Reviewed by Sam Weinig.
Remove dispatchDidFirstLayout,
dispatchDidFirstVisuallyNonEmptyLayout, and
dispatchDidNewFirstVisuallyNonEmptyLayout. Their functionality
is now replaced by dispatchDidLayout(LayoutMilestoneOptions)
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDidLayout):
* WebCoreSupport/WebFrameLoaderClient.h:
(WebFrameLoaderClient):
It is now necessary to opt into getting any of the
"layout milestone" notifications.
* WebView.cpp:
(WebView::initWithFrame):
2012-09-19 Patrick Gansterer <paroga@webkit.org>
[WIN] Use BString in favour of BSTR to improve memory management
https://bugs.webkit.org/show_bug.cgi?id=93128
Reviewed by Anders Carlsson.
BString automatically calls SysFreeString() in its destructor which helps
avoiding memory leaks. So it should be used instead of BSTR directly.
Add operator& to BString to allow its usage for out parameters too (like COMPtr).
This fixes already a few memory leaks in the existing code.
* DefaultPolicyDelegate.cpp:
(DefaultPolicyDelegate::decidePolicyForNavigationAction):
(DefaultPolicyDelegate::decidePolicyForMIMEType):
(DefaultPolicyDelegate::unableToImplementPolicyWithError):
* MarshallingHelpers.cpp:
(MarshallingHelpers::KURLToBSTR):
(MarshallingHelpers::CFStringRefToBSTR):
(MarshallingHelpers::stringArrayToSafeArray):
(MarshallingHelpers::safeArrayToStringArray):
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::runJavaScriptPrompt):
* WebCoreSupport/WebEditorClient.cpp:
(WebEditorClient::checkGrammarOfString):
(WebEditorClient::getGuessesForWord):
* WebFrame.cpp:
(WebFrame::canProvideDocumentSource):
* WebHistory.cpp:
(WebHistory::removeItem):
(WebHistory::addItem):
* WebIconDatabase.cpp:
(WebIconDatabase::startUpIconDatabase):
* WebNotificationCenter.cpp:
(WebNotificationCenter::postNotification):
* WebPreferences.cpp:
(WebPreferences::setStringValue):
* WebView.cpp:
(toAtomicString):
(toString):
(toKURL):
(PreferencesChangedOrRemovedObserver::onNotify):
(WebView::close):
(WebView::canShowMIMEType):
(WebView::initWithFrame):
(WebView::setApplicationNameForUserAgent):
(WebView::setCustomUserAgent):
(WebView::userAgentForURL):
(WebView::setCustomTextEncodingName):
(WebView::customTextEncodingName):
(WebView::setPreferences):
(WebView::searchFor):
(WebView::executeCoreCommandByName):
(WebView::markAllMatchesForText):
(WebView::setGroupName):
(WebView::registerURLSchemeAsLocal):
(WebView::replaceSelectionWithText):
(WebView::onNotify):
(WebView::notifyPreferencesChanged):
(WebView::MIMETypeForExtension):
(WebView::standardUserAgentWithApplicationName):
(WebView::addAdditionalPluginDirectory):
(WebView::registerEmbeddedViewMIMEType):
(WebView::addOriginAccessWhitelistEntry):
(WebView::removeOriginAccessWhitelistEntry):
(WebView::geolocationDidFailWithError):
(WebView::setDomainRelaxationForbiddenForURLScheme):
(WebView::setCompositionForTesting):
(WebView::confirmCompositionForTesting):
2012-09-17 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r128809.
http://trac.webkit.org/changeset/128809
https://bugs.webkit.org/show_bug.cgi?id=96958
Broke the Windows build. (Requested by andersca on #webkit).
* DefaultPolicyDelegate.cpp:
(DefaultPolicyDelegate::decidePolicyForNavigationAction):
(DefaultPolicyDelegate::decidePolicyForMIMEType):
(DefaultPolicyDelegate::unableToImplementPolicyWithError):
* MarshallingHelpers.cpp:
(MarshallingHelpers::KURLToBSTR):
(MarshallingHelpers::CFStringRefToBSTR):
(MarshallingHelpers::stringArrayToSafeArray):
(MarshallingHelpers::safeArrayToStringArray):
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::runJavaScriptPrompt):
* WebCoreSupport/WebEditorClient.cpp:
(WebEditorClient::checkGrammarOfString):
(WebEditorClient::getGuessesForWord):
* WebFrame.cpp:
(WebFrame::canProvideDocumentSource):
* WebHistory.cpp:
(WebHistory::removeItem):
(WebHistory::addItem):
* WebIconDatabase.cpp:
(WebIconDatabase::startUpIconDatabase):
* WebNotificationCenter.cpp:
(WebNotificationCenter::postNotification):
* WebPreferences.cpp:
(WebPreferences::setStringValue):
* WebView.cpp:
(PreferencesChangedOrRemovedObserver::onNotify):
(WebView::close):
(WebView::canShowMIMEType):
(WebView::initWithFrame):
(WebView::setApplicationNameForUserAgent):
(WebView::setCustomUserAgent):
(WebView::userAgentForURL):
(WebView::setCustomTextEncodingName):
(WebView::customTextEncodingName):
(WebView::setPreferences):
(WebView::searchFor):
(WebView::executeCoreCommandByName):
(WebView::markAllMatchesForText):
(WebView::setGroupName):
(WebView::registerURLSchemeAsLocal):
(WebView::replaceSelectionWithText):
(WebView::onNotify):
(WebView::notifyPreferencesChanged):
(WebView::MIMETypeForExtension):
(WebView::standardUserAgentWithApplicationName):
(WebView::addAdditionalPluginDirectory):
(WebView::registerEmbeddedViewMIMEType):
(toString):
(toKURL):
(WebView::addOriginAccessWhitelistEntry):
(WebView::removeOriginAccessWhitelistEntry):
(WebView::geolocationDidFailWithError):
(WebView::setDomainRelaxationForbiddenForURLScheme):
(WebView::setCompositionForTesting):
(WebView::confirmCompositionForTesting):
2012-09-16 Mark Lam <mark.lam@apple.com>
Added MSVC project changes to enable building the llint.
https://bugs.webkit.org/show_bug.cgi?id=96175.
Reviewed by Geoff Garen.
This only adds the ability to build the llint, but currently, only the
C++ backend is supported. By default, the Windows port will remain
running with the baseline JIT. The llint will not be enabled.
* WebKit.vcproj/WebKit.sln:
2012-09-13 Brent Fulgham <bfulgham@webkit.org>
[WinCairo] Unreviewed build fix.
* WebCookieManagerCurl.cpp: Remove unused 'using WebCore'
declaration that prevented the build from completing.
2012-09-12 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r127876.
http://trac.webkit.org/changeset/127876
https://bugs.webkit.org/show_bug.cgi?id=96600
mouse click doesn't work for spin button if spin button in
iframe (Requested by yosin on #webkit).
* WebActionPropertyBag.cpp:
(WebActionPropertyBag::Read):
* WebView.cpp:
(WebView::handleContextMenuEvent):
(WebView::elementAtPoint):
2012-09-10 Beth Dakin <bdakin@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=96158
Need API to suppress scrollbar animations
-and corresponding-
<rdar://problem/12210972>
Reviewed by Sam Weinig.
ScrollableArea::isOnActivePage() has been re-named to
ScrollableArea:: scrollbarsCanBeActive().
* WebScrollBar.cpp:
(WebScrollBar::scrollbarsCanBeActive):
* WebScrollBar.h:
(WebScrollBar):
2012-09-10 Dominic Mazzoni <dmazzoni@google.com>
AX: Update Windows port accessible role mappings to fix some tests
https://bugs.webkit.org/show_bug.cgi?id=96219
Reviewed by Chris Fleizach.
Update a bunch of accessible role mappings to fix tests and improve win
accessibility.
* AccessibleBase.cpp:
(MSAARole):
2012-09-07 Allan Sandfeld Jensen <allan.jensen@nokia.com>
Simplify hitTestResultAtPoint and nodesFromRect APIs
https://bugs.webkit.org/show_bug.cgi?id=95720
Reviewed by Antonio Gomes.
Update calls to new API.
* WebActionPropertyBag.cpp:
(WebActionPropertyBag::Read):
* WebView.cpp:
(WebView::handleContextMenuEvent):
(WebView::elementAtPoint):
2012-09-05 Sam Weinig <sam@webkit.org>
Part 2 of removing PlatformString.h, remove PlatformString.h
https://bugs.webkit.org/show_bug.cgi?id=95931
Reviewed by Adam Barth.
Remove PlatformString.h
* DOMCSSClasses.cpp:
* DefaultPolicyDelegate.cpp:
* MarshallingHelpers.cpp:
* WebCoreSupport/WebInspectorClient.h:
* WebDownload.h:
* WebFrame.h:
* WebHistoryItem.h:
* WebIconDatabase.cpp:
* WebKitDLL.h:
* WebKitGraphics.cpp:
* WebKitSystemBits.cpp:
* WebLocalizableStrings.cpp:
* WebNotificationCenter.cpp:
* WebResource.h:
2012-09-06 Patrick Gansterer <paroga@webkit.org>
Remove String::operator+=() from windows platform code
https://bugs.webkit.org/show_bug.cgi?id=95904
Reviewed by Benjamin Poulain.
Use StringBuilder and operator+() to concatenate strings instead of operator+=().
* AccessibleBase.cpp:
(AccessibleBase::get_accKeyboardShortcut):
* WebDownload.cpp:
(WebDownload::bundlePathForTargetPath):
* WebView.cpp:
(imeCompositionArgumentNames):
2012-09-05 Kaustubh Atrawalkar <kaustubh@motorola.com>
[DRT] LTC:: Move printing related APIs from LayoutTestController to Internals
https://bugs.webkit.org/show_bug.cgi?id=92735
Reviewed by Hajime Morita.
Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
Kept the function defination and declaration to keep binary compatibility for IWebFramePrivate.idl
* WebFrame.cpp:
(WebFrame::numberOfPages):
2012-08-30 Benjamin Poulain <bpoulain@apple.com>
Replace JSC::UString by WTF::String
https://bugs.webkit.org/show_bug.cgi?id=95271
Reviewed by Geoffrey Garen.
Replace UString by String.
* WebFrame.cpp:
(WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
* WebView.cpp:
(WebView::stringByEvaluatingJavaScriptFromString):
2012-08-29 Dominic Mazzoni <dmazzoni@google.com>
AX: Canvas should have a distinct role
https://bugs.webkit.org/show_bug.cgi?id=95248
Reviewed by Chris Fleizach.
Map new CanvasRole to the same as ImageRole.
* AccessibleBase.cpp:
(MSAARole):
2012-08-29 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r126972.
http://trac.webkit.org/changeset/126972
https://bugs.webkit.org/show_bug.cgi?id=95349
accessibility/canvas-description-and-role.html has been
failing consistently on several bots and Dominic needs some
time to investigate why (Requested by jchaffraix on #webkit).
* AccessibleBase.cpp:
(MSAARole):
2012-08-29 Dominic Mazzoni <dmazzoni@google.com>
AX: Canvas should have a distinct role
https://bugs.webkit.org/show_bug.cgi?id=95248
Reviewed by Chris Fleizach.
Map new CanvasRole to the same as ImageRole.
* AccessibleBase.cpp:
(MSAARole):
2012-08-28 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r126914.
http://trac.webkit.org/changeset/126914
https://bugs.webkit.org/show_bug.cgi?id=95239
it breaks everything and fixes nothing (Requested by pizlo on
#webkit).
* COMPropertyBag.h:
(::Read):
(::GetPropertyInfo):
* WebCoreStatistics.cpp:
(WebCoreStatistics::javaScriptProtectedObjectTypeCounts):
* WebCoreSupport/WebPlatformStrategies.cpp:
(WebPlatformStrategies::getPluginInfo):
* WebHistory.cpp:
(WebHistory::removeItemFromDateCaches):
* WebKitCOMAPI.cpp:
(classFactory):
* WebKitStatistics.cpp:
(WebKitStatistics::comClassNameCounts):
* WebNotificationCenter.cpp:
(WebNotificationCenter::postNotificationInternal):
(WebNotificationCenter::addObserver):
(WebNotificationCenter::removeObserver):
2012-08-28 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Rename first/second to key/value in HashMap iterators
https://bugs.webkit.org/show_bug.cgi?id=82784
Reviewed by Eric Seidel.
* COMPropertyBag.h:
(::Read):
(::GetPropertyInfo):
* WebCoreStatistics.cpp:
(WebCoreStatistics::javaScriptProtectedObjectTypeCounts):
* WebCoreSupport/WebPlatformStrategies.cpp:
(WebPlatformStrategies::getPluginInfo):
* WebHistory.cpp:
(WebHistory::removeItemFromDateCaches):
* WebKitCOMAPI.cpp:
(classFactory):
* WebKitStatistics.cpp:
(WebKitStatistics::comClassNameCounts):
* WebNotificationCenter.cpp:
(WebNotificationCenter::postNotificationInternal):
(WebNotificationCenter::addObserver):
(WebNotificationCenter::removeObserver):
2012-08-27 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r126836.
http://trac.webkit.org/changeset/126836
https://bugs.webkit.org/show_bug.cgi?id=95163
Broke all Apple ports, EFL, and Qt. (Requested by tkent on
#webkit).
* COMPropertyBag.h:
(::Read):
(::GetPropertyInfo):
* WebCoreStatistics.cpp:
(WebCoreStatistics::javaScriptProtectedObjectTypeCounts):
* WebCoreSupport/WebPlatformStrategies.cpp:
(WebPlatformStrategies::getPluginInfo):
* WebHistory.cpp:
(WebHistory::removeItemFromDateCaches):
* WebKitCOMAPI.cpp:
(classFactory):
* WebKitStatistics.cpp:
(WebKitStatistics::comClassNameCounts):
* WebNotificationCenter.cpp:
(WebNotificationCenter::postNotificationInternal):
(WebNotificationCenter::addObserver):
(WebNotificationCenter::removeObserver):
2012-08-27 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Rename first/second to key/value in HashMap iterators
https://bugs.webkit.org/show_bug.cgi?id=82784
Reviewed by Eric Seidel.
* COMPropertyBag.h:
(::Read):
(::GetPropertyInfo):
* WebCoreStatistics.cpp:
(WebCoreStatistics::javaScriptProtectedObjectTypeCounts):
* WebCoreSupport/WebPlatformStrategies.cpp:
(WebPlatformStrategies::getPluginInfo):
* WebHistory.cpp:
(WebHistory::removeItemFromDateCaches):
* WebKitCOMAPI.cpp:
(classFactory):
* WebKitStatistics.cpp:
(WebKitStatistics::comClassNameCounts):
* WebNotificationCenter.cpp:
(WebNotificationCenter::postNotificationInternal):
(WebNotificationCenter::addObserver):
(WebNotificationCenter::removeObserver):
2012-08-23 Adrienne Walker <enne@google.com>
Convert ScrollableArea ASSERT_NOT_REACHED virtuals
https://bugs.webkit.org/show_bug.cgi?id=93306
Reviewed by Darin Adler.
Add implementations where necessary to make derived classes concrete.
Add OVERRIDE for ScrollableArea functions.
* WebScrollBar.cpp:
(WebScrollBar::visibleHeight):
(WebScrollBar::visibleWidth):
(WebScrollBar::contentsSize):
(WebScrollBar::isOnActivePage):
(WebScrollBar::scrollableAreaBoundingBox):
* WebScrollBar.h:
(WebScrollBar):
2012-08-22 Nikhil Bhargava <nbhargava@google.com>
Reduce Font.h includes across project -- improves RenderObject.h compile time
https://bugs.webkit.org/show_bug.cgi?id=93629
Reviewed by Eric Seidel.
Adds includes due to change in RenderStyle.h
* DOMCoreClasses.cpp:
2012-08-15 Ryosuke Niwa <rniwa@webkit.org>
Update manual tests and comments to refer to TestRunner instead of LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=94168
Reviewed by Kent Tamura.
* Interfaces/IWebPreferencesPrivate.idl:
2012-08-14 Adam Barth <abarth@webkit.org>
Delete Frame::domWindow() and Frame::existingDOMWindow()
https://bugs.webkit.org/show_bug.cgi?id=93990
Reviewed by Eric Seidel.
* WebFrame.cpp:
(WebFrame::DOMWindow):
(WebFrame::pendingFrameUnloadEventCount):
2012-08-13 Tom Sepez <tsepez@chromium.org>
[chromium] release FrameLoaderClientImpl::m_pluginWidget refptr upon Plugin Document detach.
https://bugs.webkit.org/show_bug.cgi?id=93283
Reviewed by Eric Seidel.
Change the client redirectDataToPlugin method(s) to expect the possibility of
a NULL argument, keeping existing behaviour otherwise.
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::redirectDataToPlugin):
2012-08-05 Patrick Gansterer <paroga@webkit.org>
[WIN] Use sizeof() for cbWndExtra values
https://bugs.webkit.org/show_bug.cgi?id=93179
Reviewed by Eric Carlson.
Using sizof() instead of hardcoding the pointer size of
the 32bit platform allows us to use the code on 64bit too.
* FullscreenVideoController.cpp:
(FullscreenVideoController::registerHUDWindowClass):
* WebView.cpp:
(WebView::registerWebViewWindowClass):
2012-07-26 Gyuyoung Kim <gyuyoung.kim@samsung.com>
[Mac] Fix build break on Apple win bot after r123711
https://bugs.webkit.org/show_bug.cgi?id=92354
Reviewed by Adam Barth.
Missing return value.
* WebFrame.cpp:
(WebFrame::pageNumberForElementById):
2012-07-26 Kaustubh Atrawalkar <kaustubh@motorola.com>
[DRT] LTC:: pageNumberForElementById() could be moved to Internals
https://bugs.webkit.org/show_bug.cgi?id=92091
Reviewed by Adam Barth.
Moved the pageNumberForElementById from LayoutTestCotroller to Internals and
remove the old platform specific implementations as it exclusively tests WebCore functionality.
* WebFrame.cpp: Added comment for removing the function. Removed implementation.
2012-07-25 Roger Fong <roger_fong@apple.com>
Changes to the WebFrame API cause dependent apps to crash.
https://bugs.webkit.org/show_bug.cgi?id=91656
<rdar://problem/11904605>
Reviewed by Jon Honeycutt.
Changes to the WebFrame API cause certain apps to crash because of inconsistencies in the COM interface.
The resumeAnimations and suspendAnimations are removed, which are still needed.
The counterValueByElementId method was also removed, although is not needed there.
However, for all of these methods, no method stubs were added where appropriate after removal.
* Interfaces/IWebFramePrivate.idl:
Added resumeAnimations() and suspendAnimations() methods back in. Added unused method stub for counterValueByElementId method.
* WebFrame.cpp:
(WebFrame::resumeAnimations):
Added this method back in.
(WebFrame::suspendAnimations):
Added this method back in.
* WebFrame.h:
(Re)added methods and unused method stubs.
2012-07-23 Patrick Gansterer <paroga@webkit.org>
Build fix if NOMINMAX is defined by the build system.
* COMEnumVariant.h: Added #ifndef NOMINMAX around #define NOMINMAX.
* COMPropertyBag.h: Ditto.
2012-07-23 Pierre Rossi <pierre.rossi@gmail.com>
Unify numTouchEventHandlersChanged and needTouchEvents in the chrome client
https://bugs.webkit.org/show_bug.cgi?id=91006
Reviewed by Ryosuke Niwa.
Remove numTouchEventHandlersChanged stub.
* WebCoreSupport/WebChromeClient.h:
2012-07-17 Vivek Galatage <vivekgalatage@gmail.com>
Web Inspector: refactor InspectorController::connectFrontend() to accept InspectorFrontendChannel.
https://bugs.webkit.org/show_bug.cgi?id=91196
Reviewed by Pavel Feldman.
Refactoring InspectorClients. InspectorClient::openInspectorFrontend
now returning the InspectorFrontendChannel.
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::openInspectorFrontend):
* WebCoreSupport/WebInspectorClient.h:
(WebInspectorClient):
2012-07-14 Eric Carlson <eric.carlson@apple.com>
Enable AVCF hardware video decoding
https://bugs.webkit.org/show_bug.cgi?id=90015
<rdar://problem/10770317>
Reviewed by Anders Carlsson.
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::graphicsDeviceAdapter): New, return the view's graphics adapter.
* WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
* WebView.cpp:
(WebView::graphicsDeviceAdapter): New, return the layer tree host's graphics adapter.
* WebView.h:
(WebCore):
(WebView):
2012-07-10 Adam Barth <abarth@webkit.org>
WebCore::Settings for Hixie76 WebSocket protocol doesn't do anything and should be removed
https://bugs.webkit.org/show_bug.cgi?id=90910
Reviewed by Eric Seidel.
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::setHixie76WebSocketProtocolEnabled):
(WebPreferences::hixie76WebSocketProtocolEnabled):
* WebView.cpp:
(WebView::notifyPreferencesChanged):
2012-07-02 Ryosuke Niwa <rniwa@webkit.org>
Make HTMLCollection RefCounted
https://bugs.webkit.org/show_bug.cgi?id=90414
Reviewed by Sam Weinig.
* DOMHTMLClasses.cpp:
(DOMHTMLDocument::forms):
(DOMHTMLSelectElement::options):
2012-07-03 Mihai Balan <mibalan@adobe.com>
[CSS Regions] Enabling regions on Windows lead to crash-on-launch for WebKit.exe
https://bugs.webkit.org/show_bug.cgi?id=90435
Reviewed by Csaba Osztrogonác.
Initial patch for enabling regions led to WebKit crashing on launch. Moving the
IDL declarations for CSS regions getter/setter at the end of the file solves the
problem. As per http://trac.webkit.org/changeset/95650 seems it has to do with
binary compatibility.
* Interfaces/IWebPreferences.idl: Mover getter/setter for CSS regions at the end of file
2012-07-02 Benjamin Poulain <bpoulain@apple.com>
Do not do any logging initialization when logging is disabled
https://bugs.webkit.org/show_bug.cgi?id=90228
Reviewed by Simon Fraser.
* WebView.cpp:
(WebView::initWithFrame):
2012-06-29 Mihai Balan <mibalan@adobe.com>
[CSS Regions] Adding feature defines for CSS Regions for Windows
https://bugs.webkit.org/show_bug.cgi?id=88645
Reviewed by Tony Chang.
Re-trying to enable CSS regions on Windows. This time only enabling
regions since exclusions lead to some very strange compiling/linking
problems. This time adding preferences code to make sure the settings
get propagated to DRT (previous experiments by abucur showed they
didn't.).
* WebPreferenceKeysPrivate.h: Added preference key for CSS regions
* Interfaces/IWebPreferences.idl: Added getters and setters for CSS regions settings
* WebPreferences.cpp: ditto
(WebPreferences::initializeDefaultSettings):
(WebPreferences::isCSSRegionsEnabled):
(WebPreferences::setCSSRegionsEnabled):
* WebPreferences.h: ditto
(WebPreferences):
* WebView.cpp: Added settings code to handle CSS regions, too
(WebView::notifyPreferencesChanged):
2012-06-25 Mark Hahnenberg <mhahnenberg@apple.com>
JSLock should be per-JSGlobalData
https://bugs.webkit.org/show_bug.cgi?id=89123
Reviewed by Geoffrey Garen.
Changed all sites that used JSLock to instead use the new JSLockHolder
and pass in the correct JS context that the code is about to interact with that
needs protection. Also added a couple JSLocks to places that didn't already
have it that needed it.
* WebCoreStatistics.cpp:
(WebCoreStatistics::javaScriptObjectsCount):
(WebCoreStatistics::javaScriptGlobalObjectsCount):
(WebCoreStatistics::javaScriptProtectedObjectsCount):
(WebCoreStatistics::javaScriptProtectedGlobalObjectsCount):
(WebCoreStatistics::javaScriptProtectedObjectTypeCounts):
* WebFrame.cpp:
(WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
* WebJavaScriptCollector.cpp:
(WebJavaScriptCollector::objectCount):
* WebView.cpp:
(WebView::stringByEvaluatingJavaScriptFromString):
(WebView::reportException):
(WebView::elementFromJS):
2012-06-23 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r121058.
http://trac.webkit.org/changeset/121058
https://bugs.webkit.org/show_bug.cgi?id=89809
Patch causes plugins tests to crash in GTK debug builds
(Requested by zdobersek on #webkit).
* WebCoreStatistics.cpp:
(WebCoreStatistics::javaScriptObjectsCount):
(WebCoreStatistics::javaScriptGlobalObjectsCount):
(WebCoreStatistics::javaScriptProtectedObjectsCount):
(WebCoreStatistics::javaScriptProtectedGlobalObjectsCount):
(WebCoreStatistics::javaScriptProtectedObjectTypeCounts):
* WebFrame.cpp:
(WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
* WebJavaScriptCollector.cpp:
(WebJavaScriptCollector::objectCount):
* WebView.cpp:
(WebView::stringByEvaluatingJavaScriptFromString):
(WebView::reportException):
(WebView::elementFromJS):
2012-06-20 Mark Hahnenberg <mhahnenberg@apple.com>
JSLock should be per-JSGlobalData
https://bugs.webkit.org/show_bug.cgi?id=89123
Reviewed by Gavin Barraclough.
Changed all sites that used JSLock to instead use the new JSLockHolder
and pass in the correct JS context that the code is about to interact with that
needs protection.
* WebCoreStatistics.cpp:
(WebCoreStatistics::javaScriptObjectsCount):
(WebCoreStatistics::javaScriptGlobalObjectsCount):
(WebCoreStatistics::javaScriptProtectedObjectsCount):
(WebCoreStatistics::javaScriptProtectedGlobalObjectsCount):
(WebCoreStatistics::javaScriptProtectedObjectTypeCounts):
* WebFrame.cpp:
(WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
* WebJavaScriptCollector.cpp:
(WebJavaScriptCollector::objectCount):
* WebView.cpp:
(WebView::stringByEvaluatingJavaScriptFromString):
(WebView::reportException):
(WebView::elementFromJS):
2012-06-20 Garret Kelly <gdk@chromium.org>
Moving cookieEnabled/setCookieEnabled from Page to Settings.
https://bugs.webkit.org/show_bug.cgi?id=89545
Reviewed by Adam Barth.
* WebView.cpp:
(WebView::setCookieEnabled):
(WebView::cookieEnabled):
2012-06-20 Julien Chaffraix <jchaffraix@webkit.org>
Use IntSize in RenderLayer to represent scroll offsets
https://bugs.webkit.org/show_bug.cgi?id=89154
Reviewed by Eric Seidel.
* WebView.cpp:
(WebView::gesture):
Updated to pass an IntSize to scrollByRecursively.
2012-06-11 Kaustubh Atrawalkar <kaustubh@motorola.com>
[DRT] LTC:: counterValueForElementById() could be moved to Internals.
https://bugs.webkit.org/show_bug.cgi?id=84406
Reviewed by Hajime Morita.
Move the counterValueForElementById from LayoutTestCotroller to Internals and
remove the old platform specific implementations as it exclusively tests WebCore functionality.
* Interfaces/IWebFramePrivate.idl:
* WebFrame.cpp:
* WebFrame.h:
2012-06-11 Sam Weinig <sam@webkit.org>
Remove support for disconnected/excluded from search frames, they are not used by Safari anymore
https://bugs.webkit.org/show_bug.cgi?id=88723
Reviewed by Dan Bernstein.
* WebFrame.cpp:
(WebFrame::setIsDisconnected):
(WebFrame::setExcludeFromTextSearch):
Stop doing anything in these functions.
2012-06-10 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r119955.
http://trac.webkit.org/changeset/119955
https://bugs.webkit.org/show_bug.cgi?id=88758
Breaks Chromium compile - Chromium depends on removed API
(Requested by dominicc on #webkit).
* WebFrame.cpp:
(WebFrame::setIsDisconnected):
(WebFrame::setExcludeFromTextSearch):
2012-06-10 Sam Weinig <sam@webkit.org>
Remove support for disconnected/excluded from search frames, they are not used by Safari anymore
https://bugs.webkit.org/show_bug.cgi?id=88723
Reviewed by Dan Bernstein.
* WebFrame.cpp:
(WebFrame::setIsDisconnected):
(WebFrame::setExcludeFromTextSearch):
Stop doing anything in these functions.
2012-05-31 Hajime Morrita <morrita@chromium.org>
REGRESSION(r117572): editing/spelling/spellcheck-async-remove-frame.html crashes on Mac
https://bugs.webkit.org/show_bug.cgi?id=86859
Reviewed by Ryosuke Niwa.
* WebCoreSupport/WebEditorClient.h:
(WebEditorClient::requestCheckingOfString):
2012-05-25 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
WebKitTestRunner needs to support layoutTestController.setJavaScriptProfilingEnabled
https://bugs.webkit.org/show_bug.cgi?id=42328
Reviewed by Eric Seidel.
* WebInspector.cpp:
(WebInspector::setJavaScriptProfilingEnabled):
2012-05-25 Lynn Neir <lynn.neir@skype.net>
Added methods needed to implement backend for DRT's TextInputController on windows, https://bugs.webkit.org/show_bug.cgi?id=32021
Reviewed by Eric Seidel.
* Interfaces/IWebViewPrivate.idl:
* WebView.cpp:
(WebView::setCompositionForTesting):
(WebView::hasCompositionForTesting):
(WebView::confirmCompositionForTesting):
(WebView::compositionRangeForTesting):
(WebView::firstRectForCharacterRangeForTesting):
(WebView::selectedRangeForTesting):
* WebView.h:
(WebView):
2012-05-21 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
Move setEditingBehavior() from layoutTestController to window.internals
https://bugs.webkit.org/show_bug.cgi?id=42689
Reviewed by Hajime Morita and Kenneth Rohde Christiansen.
Remove Win private API to get/set the editing behavior. Follow the previous
removals that keep the virtual functions there but failing.
* Interfaces/IWebPreferences.idl:
* WebPreferenceKeysPrivate.h:
* WebPreferences.cpp:
(WebPreferences::unused5):
(WebPreferences::unused6):
* WebPreferences.h:
(WebPreferences):
* WebView.cpp:
(WebView::notifyPreferencesChanged):
2012-05-18 MORITA Hajime <morrita@google.com>
Another unreviewed attempt to fix build breakage on r117572.
* WebCoreSupport/WebEditorClient.h:
(WebEditorClient::frameWillDetachPage):
2012-05-18 MORITA Hajime <morrita@google.com>
https://bugs.webkit.org/show_bug.cgi?id=85515
Stale frame in WebCore::SpellChecker::didCheckSucceeded
Reviewed by Ryosuke Niwa.
* WebCoreSupport/WebEditorClient.h:
(WebEditorClient::frameWillDetachPage):
2012-05-17 Hironori Bono <hbono@chromium.org>
[Refactoring] Move platform-specific code in Editor::respondToChangedSelection to the WebKit layer
https://bugs.webkit.org/show_bug.cgi?id=86591
Reviewed by Ryosuke Niwa.
This change adds a TextCheckerClient::shouldEraseMarkersAfterChangeSelection
function to remove platform-specific code from Editor::respondToChangedSelection
function.
No new tests, no change in behavior.
* WebCoreSupport/WebEditorClient.cpp:
(WebEditorClient::shouldEraseMarkersAfterChangeSelection):
* WebCoreSupport/WebEditorClient.h:
(WebEditorClient):
2012-05-17 Dan Bernstein <mitz@apple.com>
REGRESSION (r117428): WebKit API/SPI was removed
https://bugs.webkit.org/show_bug.cgi?id=86748
Reverted r117428.
* Interfaces/IWebViewPrivate.idl:
* WebView.cpp:
(WebView::setDomainRelaxationForbiddenForURLScheme):
* WebView.h:
(WebView):
2012-05-17 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Convert setDomainRelaxationForbiddenForURLScheme to use InternalSettings interface
https://bugs.webkit.org/show_bug.cgi?id=86704
Reviewed by Eric Seidel.
Remove setDomainRelaxationForbiddenForURLScheme functions, because it is able to work in the
cross-port way through the InternalSettings interface.
* Interfaces/IWebViewPrivate.idl:
* WebView.cpp:
* WebView.h:
(WebView):
2012-05-10 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Move resumeAnimations to use Internals interface
https://bugs.webkit.org/show_bug.cgi?id=86063
Reviewed by Alexey Proskuryakov.
Remove resumeAnimations functions, because it is able to work in the
cross-port way through the Internals interface.
* Interfaces/IWebFramePrivate.idl:
* WebFrame.cpp:
* WebFrame.h:
2012-05-10 Anders Carlsson <andersca@apple.com>
Rename the missing plug-in indicator to the unavailable plug-in indicator
https://bugs.webkit.org/show_bug.cgi?id=86136
Reviewed by Sam Weinig.
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::shouldUnavailablePluginMessageBeButton):
(WebChromeClient::unavailablePluginButtonClicked):
* WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
2012-05-09 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Move suspendAnimations to use Internals interface.
https://bugs.webkit.org/show_bug.cgi?id=85986
Reviewed by Ryosuke Niwa.
Remove suspendAnimations functions, because it is able to work in the
cross-port way through the Internals interface.
* Interfaces/IWebFramePrivate.idl:
* WebFrame.cpp:
* WebFrame.h:
2012-05-07 Julien Chaffraix <jchaffraix@webkit.org>
Refactor windowClipRectForLayer to remove the explicit RenderLayer dependency
https://bugs.webkit.org/show_bug.cgi?id=84090
Reviewed by David Hyatt.
* WebCoreSupport/EmbeddedWidget.cpp:
(EmbeddedWidget::windowClipRect):
Updated after windowClipRectForLayer name and signature change.
* WebCoreSupport/EmbeddedWidget.h:
(EmbeddedWidget):
(EmbeddedWidget::EmbeddedWidget):
Updated the internal DOM pointer to be an HTMLPlugInElement
as it was what was passed in anyway. Also fixed some style
issues detected by our tools.
2012-05-05 Dean Jackson <dino@apple.com>
Add new Setting/Preference to disable requestAnimationFrame
https://bugs.webkit.org/show_bug.cgi?id=85693
Reviewed by Simon Fraser.
Exposes a new WebPreference: WebKitRequestAnimationFrameEnabled.
The default value is true. The majority of applications will leave
it this way.
* Interfaces/IWebPreferencesPrivate.idl:
* WebPreferenceKeysPrivate.h:
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::setRequestAnimationFrameEnabled):
(WebPreferences::requestAnimationFrameEnabled):
* WebPreferences.h:
(WebPreferences):
* WebView.cpp:
(WebView::notifyPreferencesChanged):
2012-05-04 Nate Chapin <japhet@chromium.org>
Don't require FrameLoaderClient to manufacture a commitData() call for empty documents.
https://bugs.webkit.org/show_bug.cgi?id=85533
Reviewed by Alexey Proskuryakov.
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::finishedLoading):
2012-04-27 Jon Lee <jonlee@apple.com>
Migrate permission functions to Notification from NotificationCenter
https://bugs.webkit.org/show_bug.cgi?id=80485
<rdar://problem/10965458>
Reviewed by Jian Li.
* WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
(WebDesktopNotificationsDelegate::requestPermission):
* WebCoreSupport/WebDesktopNotificationsDelegate.h:
(WebDesktopNotificationsDelegate): Add stub implementation of requestPermission.
2012-04-23 Jon Honeycutt <jhoneycutt@apple.com>
FrameLoaderClient::dispatchWillSendSubmitEvent() should be given more
information about the form being submitted
https://bugs.webkit.org/show_bug.cgi?id=84297
Reviewed by Andy Estes.
* WebFrame.h:
Fix function stub for new parameter.
2012-05-01 Ryosuke Niwa <rniwa@webkit.org>
*Command.h files shouldn't be exported to WebKit layer
https://bugs.webkit.org/show_bug.cgi?id=74778
Reviewed by Eric Seidel.
* WebView.cpp:
2012-04-20 Emil A Eklund <eae@chromium.org>
[win] Update windows platform code to use pixel snapped values
https://bugs.webkit.org/show_bug.cgi?id=84283
Reviewed by Eric Seidel.
* AccessibleBase.cpp:
(AccessibleBase::accLocation):
2012-04-18 Vivek Galatage <vivekgalatage@gmail.com>
Web Inspector: Disabling Inspector causes build failure on Windows
https://bugs.webkit.org/show_bug.cgi?id=83557
Reviewed by Pavel Feldman.
The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
This change brings all such API calls under the guard.
* WebCoreSupport/WebInspectorClient.cpp:
* WebInspector.cpp:
* WebNodeHighlight.cpp:
(WebNodeHighlight::WebNodeHighlight):
(WebNodeHighlight::update):
* WebNodeHighlight.h:
(WebNodeHighlight):
* WebView.cpp:
(WebView::WebView):
(WebView::close):
(WebView::initWithFrame):
(WebView::inspector):
* WebView.h:
(WebView):
2012-04-11 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r113836.
http://trac.webkit.org/changeset/113836
https://bugs.webkit.org/show_bug.cgi?id=83705
Broke all the WebKit2 inspector tests (Requested by andersca
on #webkit).
* WebCoreSupport/WebInspectorClient.cpp:
(registerWindowClass):
* WebInspector.cpp:
(WebInspector::setTimelineProfilingEnabled):
* WebNodeHighlight.cpp:
(WebNodeHighlight::WebNodeHighlight):
(WebNodeHighlight::update):
* WebNodeHighlight.h:
(WebNodeHighlight):
* WebView.cpp:
(WebView::WebView):
(WebView::close):
(WebView::initWithFrame):
(WebView::inspector):
* WebView.h:
(WebView):
2012-04-11 Vivek Galatage <vivekgalatage@gmail.com>
Web Inspector: Disabling Inspector causes build failure on Windows
https://bugs.webkit.org/show_bug.cgi?id=83557
Reviewed by Pavel Feldman.
The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
This change brings all such API calls under the guard.
* WebCoreSupport/WebInspectorClient.cpp:
* WebInspector.cpp:
* WebNodeHighlight.cpp:
(WebNodeHighlight::WebNodeHighlight):
(WebNodeHighlight::update):
* WebNodeHighlight.h:
(WebNodeHighlight):
* WebView.cpp:
(WebView::WebView):
(WebView::close):
(WebView::initWithFrame):
(WebView::inspector):
* WebView.h:
(WebView):
2012-03-30 Mark Pilgrim <pilgrim@chromium.org>
GEOLOCATION should be implemented as Page Supplement
https://bugs.webkit.org/show_bug.cgi?id=82228
Reviewed by Adam Barth.
Geolocation is now a Supplement in Page so the interface
has changed for setting up the page's geolocation client
initially and accessing the controller later.
* WebView.cpp:
(WebView::initWithFrame):
(WebView::geolocationDidChangePosition):
(WebView::geolocationDidFailWithError):
2012-03-29 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r112553.
http://trac.webkit.org/changeset/112553
https://bugs.webkit.org/show_bug.cgi?id=82638
It made all tests crash on Qt WK2 (Requested by Ossy_away on
#webkit).
* WebView.cpp:
(WebView::initWithFrame):
(WebView::geolocationDidChangePosition):
(WebView::geolocationDidFailWithError):
2012-03-29 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
HashMap<>::add should return a more descriptive object
https://bugs.webkit.org/show_bug.cgi?id=71063
Reviewed by Ryosuke Niwa.
Update code to use AddResult instead of a pair.
* WebKitCOMAPI.cpp:
(classFactory):
2012-03-29 Mark Pilgrim <pilgrim@chromium.org>
GEOLOCATION should be implemented as Page Supplement
https://bugs.webkit.org/show_bug.cgi?id=82228
Reviewed by Adam Barth.
Geolocation is now a Supplement in Page so the interface
has changed for setting up the page's geolocation client
initially and accessing the controller later.
* WebView.cpp:
(WebView::initWithFrame):
(WebView::geolocationDidChangePosition):
(WebView::geolocationDidFailWithError):
2012-03-28 Nate Chapin <japhet@chromium.org>
Remove dispatchDidLoadMainResource callback, since no
port implements it.
https://bugs.webkit.org/show_bug.cgi?id=82539
Reviewed by Alexey Proskuryakov.
* WebCoreSupport/WebFrameLoaderClient.cpp:
* WebCoreSupport/WebFrameLoaderClient.h:
(WebFrameLoaderClient):
2012-03-26 Adam Barth <abarth@webkit.org>
FrameLoader::shouldAllowNavigation uses Frame for context rather than Document
https://bugs.webkit.org/show_bug.cgi?id=81020
Reviewed by Eric Seidel.
Update call site to new function name.
* WebFrame.cpp:
(WebFrame::dispatchWillSubmitForm):
2012-03-22 Anders Carlsson <andersca@apple.com>
ASSERT(!needsLayout) in RenderView.cpp when visiting http://www.panic.com/blog/
https://bugs.webkit.org/show_bug.cgi?id=81953
<rdar://problem/11086998>
Reviewed by Sam Weinig.
Update for changes to WebCore.
* FullscreenVideoController.cpp:
(FullscreenVideoController::LayerClient::platformCALayerDidCreateTiles):
2012-03-20 Steve Falkenburg <sfalken@apple.com>
Move WTF-related Windows project files out of JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=80680
Reviewed by Jessie Berlin.
* WebKit.vcproj/WebKit.sln:
2012-03-20 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Convert hasSpellingMarker to use Internals interface.
https://bugs.webkit.org/show_bug.cgi?id=81300
Reviewed by Ryosuke Niwa.
Remove hasSpellingMarker interface support, since it can support in the cross-port
way through the Internals interface.
* Interfaces/IWebFramePrivate.idl:
2012-03-19 Adam Barth <abarth@webkit.org>
Remove support for "magic" iframe
https://bugs.webkit.org/show_bug.cgi?id=81590
Reviewed by Eric Seidel.
Remove FrameLoaderClient methods that no longer exist.
* WebCoreSupport/WebFrameLoaderClient.cpp:
* WebCoreSupport/WebFrameLoaderClient.h:
(WebFrameLoaderClient):
2012-03-19 Anders Carlsson <andersca@apple.com>
Fix Windows build.
* FullscreenVideoController.cpp:
(FullscreenVideoController::LayerClient::platformCALayerDeviceScaleFactor):
2012-03-13 Jon Lee <jonlee@apple.com>
Separate NOTIFICATIONS and LEGACY_NOTIFICATIONS
https://bugs.webkit.org/show_bug.cgi?id=80922
<rdar://problem/11035082>
Reviewed by Jian Li.
You can include either NOTIFICATIONS or LEGACY_NOTIFICATIONS and have a complete API.
LEGACY_NOTIFICATIONS should cover all of the previous functionality, and NOTIFICATIONS will cover the
new API. Therefore, APIs that are common between the two will have:
#if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
This patch initially sets both to be exactly the same. As other bugs with patches begin to migrate to
the new API, the defines will begin to split. This allows ports to decide which set of APIs to include.
Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::WebChromeClient):
* WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
* WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
* WebCoreSupport/WebDesktopNotificationsDelegate.h:
2012-03-13 Adam Barth <abarth@webkit.org> && Benjamin Poulain <bpoulain@apple.com>
Always enable ENABLE(CLIENT_BASED_GEOLOCATION)
https://bugs.webkit.org/show_bug.cgi?id=78853
Reviewed by Adam Barth.
* WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
* WebCoreSupport/WebGeolocationClient.cpp:
(WebGeolocationClient::lastPosition):
* WebGeolocationPosition.cpp:
(WebGeolocationPosition::initWithTimestamp):
(core):
* WebGeolocationPosition.h:
(WebGeolocationPosition):
(WebGeolocationPosition::impl):
* WebView.cpp:
(WebView::initWithFrame):
(WebView::geolocationDidChangePosition):
(WebView::geolocationDidFailWithError):
2012-03-12 Jessie Berlin <jberlin@apple.com>
More Windows build fixing.
* MarshallingHelpers.cpp:
* WebDatabaseManager.cpp:
2012-03-09 Jon Lee <jonlee@apple.com>
Rename NotificationPresenter to NotificationClient
https://bugs.webkit.org/show_bug.cgi?id=80488
<rdar://problem/10965558>
Reviewed by Kentaro Hara.
Refactor to use renamed WebCore::NotificationClient.
* WebCoreSupport/WebChromeClient.h:
(WebChromeClient::notificationPresenter):
* WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
(WebDesktopNotificationsDelegate::checkPermission):
* WebCoreSupport/WebDesktopNotificationsDelegate.h:
(WebDesktopNotificationsDelegate):
2012-03-09 Emil A Eklund <eae@chromium.org>
Add roundedPoint to HitTestResult and change platform code to use it
https://bugs.webkit.org/show_bug.cgi?id=80715
Reviewed by James Robinson.
Change ports to use roundedPoint to avoid exposing subpixel types to
platform code.
* WebView.cpp:
(WebView::handleContextMenuEvent):
2012-03-08 Steve Falkenburg <sfalken@apple.com>
Separate WTF parts of JavaScriptCoreGenerated into WTFGenerated for Windows build
https://bugs.webkit.org/show_bug.cgi?id=80657
Preparation for WTF separation from JavaScriptCore.
The "Generated" vcproj files on Windows are necessary so Visual Studio can calculate correct
dependencies for generated files.
Reviewed by Jessie Berlin.
* WebKit.vcproj/WebKit.sln: Add WTFGenerated, update dependent projects.
2012-03-03 Benjamin Poulain <benjamin@webkit.org>
Remove the redundant method KURL::protocolInHTTPFamily()
https://bugs.webkit.org/show_bug.cgi?id=80216
Reviewed by Anders Carlsson.
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDidFailToStartPlugin):
* WebHistory.cpp:
(WebHistory::visitedURL):
2012-02-26 Hajime Morrita <morrita@chromium.org>
Move ChromeClient::showContextMenu() to ContextMenuClient
https://bugs.webkit.org/show_bug.cgi?id=79427
Reviewed by Adam Barth.
* WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
2012-02-24 Shinya Kawanaka <shinyak@chromium.org>
SpellCheckRequest needs to know the context where the spellcheck happened.
https://bugs.webkit.org/show_bug.cgi?id=79320
Reviewed by Hajime Morita.
* WebCoreSupport/WebEditorClient.h:
(WebEditorClient::requestCheckingOfString):
(WebEditorClient):
2012-02-21 Ryosuke Niwa <rniwa@webkit.org>
Remove the remaining uses of CSSStyleDeclaration in Editor
https://bugs.webkit.org/show_bug.cgi?id=78939
Reviewed by Enrica Casucci.
* WebCoreSupport/WebEditorClient.cpp:
(WebEditorClient::shouldApplyStyle):
* WebCoreSupport/WebEditorClient.h:
(WebEditorClient):
2012-02-22 Ryosuke Niwa <rniwa@webkit.org>
Remove the remaining uses of CSSStyleDeclaration in Editor
https://bugs.webkit.org/show_bug.cgi?id=78939
Reviewed by Enrica Casucci.
* WebCoreSupport/WebEditorClient.cpp:
(WebEditorClient::shouldApplyStyle):
* WebCoreSupport/WebEditorClient.h:
(WebEditorClient):
2012-02-17 Kalev Lember <kalevlember@gmail.com>
Remove unused parameters from WTF threading API
https://bugs.webkit.org/show_bug.cgi?id=78389
Reviewed by Adam Roben.
waitForThreadCompletion() had an out param 'void **result' to get the
'void *' returned by ThreadFunction. However, the implementation in
ThreadingWin.cpp ignored the out param, not filling it in. This had
led to a situation where none of the client code made use of the param
and just ignored it.
To clean this up, the patch changes the signature of ThreadFunction to
return void instead of void* and drops the the unused 'void **result'
parameter from waitForThreadCompletion. Also, all client code is
updated for the API change.
As mentioned in https://bugs.webkit.org/show_bug.cgi?id=78389 , even
though the change only affects internal API, Safari is using it
directly and we'll need to keep the old versions around for ABI
compatibility. For this, the patch adds compatibility wrappers with
the old ABI.
* WebKit.vcproj/WebKit_Cairo.def: Add the new functions.
* WebKit.vcproj/WebKit_Cairo_debug.def: Ditto.
2012-02-15 Sadrul Habib Chowdhury <sadrul@chromium.org>
Notify ChromeClient when touch-event handlers are installed/removed.
https://bugs.webkit.org/show_bug.cgi?id=77440
Reviewed by Darin Fisher and Ryosuke Niwa.
* WebCoreSupport/WebChromeClient.h:
(WebChromeClient::numTouchEventHandlersChanged):
2012-02-14 Alexey Proskuryakov <ap@apple.com>
[Mac][Win][WK2] Switch to RFC 6455 protocol for WebSockets
https://bugs.webkit.org/show_bug.cgi?id=78541
<rdar://problem/10036695>
Reviewed by Kent Tamura.
* WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): Changed default value of
the preference
2012-02-11 Nikolas Zimmermann <nzimmermann@rim.com>
Convert svg/animations to use SMIL methods for driving the timeline
https://bugs.webkit.org/show_bug.cgi?id=78422
Reviewed by Dirk Schulze.
Remove SVG animation sampling functionality provided for DRT, which no longer uses it.
Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.
* Interfaces/IWebFramePrivate.idl:
* WebFrame.cpp:
* WebFrame.h:
2012-02-13 Andy Estes <aestes@apple.com>
Fix the Windows build.
* WebCoreSupport/WebPlatformStrategies.cpp:
(WebPlatformStrategies::createPasteboardStrategy):
* WebCoreSupport/WebPlatformStrategies.h:
(WebPlatformStrategies):
2012-02-12 Andy Estes <aestes@apple.com>
[Windows] Add API to enable inverted color drawing on a WebView
https://bugs.webkit.org/show_bug.cgi?id=77382
Reviewed by Adam Roben.
Add a new private WebPreference key called "WebKitShouldInvertColors"
and add private cover methods to get and set the preference. When this
preference changes on a WebPreference object, all WebViews listening to
that object will repaint to reflect the new value.
* Interfaces/IWebPreferencesPrivate.idl: Add [setS|s]houldInvertColors()
cover methods for WebKitShouldInvertColorsPreferenceKey.
* WebPreferenceKeysPrivate.h: Add WebKitShouldInvertColorsPreferenceKey.
* WebPreferences.cpp:
(WebPreferences::shouldInvertColors):
(WebPreferences::setShouldInvertColors):
* WebPreferences.h:
(WebPreferences):
* WebView.cpp:
(WebView::setShouldInvertColors): If m_shouldInvertColors changes,
update the value on the WebView and in m_layerTreeHost, then repaint
the view.
(WebView::notifyPreferencesChanged):
(WebView::setAcceleratedCompositing): When creating a new layer tree
host, tell it whether it should be inverting colors.
* WebView.h:
2012-02-07 MORITA Hajime <morrita@google.com>
Replacement text should be available from the marker.
https://bugs.webkit.org/show_bug.cgi?id=77934
Reviewed by Kent Tamura.
* WebKit.vcproj/WebKit_Cairo.def:
* WebKit.vcproj/WebKit_Cairo_debug.def:
2012-02-02 Jon Lee <jonlee@apple.com>
Clear shown notifications when context is no longer active
https://bugs.webkit.org/show_bug.cgi?id=77363
<rdar://problem/10568907>
Reviewed by Darin Adler.
* WebCoreSupport/WebDesktopNotificationsDelegate.h:
(WebDesktopNotificationsDelegate): Add previously missing virtual functions.
* WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
(WebDesktopNotificationsDelegate::notificationControllerDestroyed):
(WebDesktopNotificationsDelegate::cancelRequestsForPermission):
2012-02-01 Anders Carlsson <andersca@apple.com>
Another attempt to fix the Windows build.
* FullscreenVideoController.cpp:
(FullscreenVideoController::LayerClient::platformCALayerDidCreateTiles):
2012-01-26 Andy Estes <aestes@apple.com>
[Windows] Optionally invert colors when drawing to a WebView's backing store.
https://bugs.webkit.org/show_bug.cgi?id=77168
Reviewed by Sam Weinig.
* WebView.cpp:
(WebView::WebView): Initialize m_shouldInvertColors to false.
(WebView::paintIntoBackingStore): If m_shouldInvertColors is true, draw
an opaque white quad using the CompositeDifference blend mode. This
blend operation instructs CoreGraphics to take the difference between
the source pixel (white) and the background pixel, resulting in an
inverted pixel.
* WebView.h: Define m_shouldInvertColors.
2012-01-23 Simon Fraser <simon.fraser@apple.com>
Show layer borders for scrollbar layers
https://bugs.webkit.org/show_bug.cgi?id=76888
Reviewed by Beth Dakin.
Update for new signature of GraphicsLayerClient::showDebugBorders()
and GraphicsLayerClient::showRepaintCounter().
* WebView.cpp:
(WebView::showDebugBorders):
(WebView::showRepaintCounter):
* WebView.h:
2012-01-23 David Levin <levin@chromium.org>
[windows] Convert usages of GetDC to HWndDC Part 2.
https://bugs.webkit.org/show_bug.cgi?id=76750
Reviewed by Adam Roben.
* FullscreenVideoController.cpp:
(createCompatibleDCForWindow): Moved out the code which creates a DC for a window
to keep the same scope for the DC lifetime.
(FullscreenVideoController::draw): Switch to using OwnPtr<HDC>
since createCompatibleDCForWindow returns a PassOwnPtr.
* WebNodeHighlight.cpp:
(WebNodeHighlight::update):
Cleaned up leaks from calling GetDC without release.
Note that there is a potential leak of hdc that previously existed
and still does in an early exit scenario. (This could be easily fixed
by using OwnPtr<HDC> but I was trying to keep this patch focused.)
* WebView.cpp:
(WebView::scrollBackingStore): Typical conversion.
(WebView::updateBackingStore): Reduced the scope of windowDC to be
right where it is being used.
(WebView::performLayeredWindowUpdate): Typical conversion.
(WebView::paintIntoBackingStore): Ditto.
2012-01-23 David Levin <levin@chromium.org>
[windows] Convert usages of GetDC to HWndDC Part 1.
https://bugs.webkit.org/show_bug.cgi?id=76744
Reviewed by Adam Roben.
* WebIconDatabase.cpp:
(createDIB): Changed GetDC to HWndDC and removed ReleaseDC.
2012-01-07 Andreas Kling <awesomekling@apple.com>
Windows build fix.
* DOMHTMLClasses.cpp:
(DOMHTMLDocument::forms):
(DOMHTMLSelectElement::options):
2012-01-06 Jessie Berlin <jberlin@apple.com>
Windows build fix.
* Interfaces/IWebViewPrivate.idl:
2012-01-05 Adam Roben <aroben@apple.com>
Add WebKitTestRunnerLauncher to WebKit.sln.
It builds just after WebKitTestRunner.
Part of <http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
Windows port of DumpRenderTree/WebKitTestRunner
Reviewed by Steve Falkenburg.
* WebKit.vcproj/WebKit.sln:
2012-01-05 Adam Roben <aroben@apple.com>
Add DumpRenderTreeLauncher to WebKit.sln.
It builds just after DumpRenderTree.
Part of <http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
Windows port of DumpRenderTree/WebKitTestRunner
Reviewed by Steve Falkenburg.
* WebKit.vcproj/WebKit.sln:
2012-01-04 Adam Roben <aroben@apple.com>
Add ImageDiffLauncher to WebKit.sln
It builds just after ImageDiff.
Part of <http://webkit.org/b/75572> ImageDiff.exe can't be run without first munging PATH
Reviewed by Anders Carlsson.
* WebKit.vcproj/WebKit.sln:
2012-01-04 Adam Roben <aroben@apple.com>
Add MiniBrowserLauncher to WebKit.sln
It builds just after MiniBrowser.
Part of <http://webkit.org/b/68576> <rdar://problem/10163853> MiniBrowser fails to launch
when double-clicked
Reviewed by Anders Carlsson.
* WebKit.vcproj/WebKit.sln: Added MiniBrowserLauncher.
2012-01-04 Adam Roben <aroben@apple.com>
Add WinLauncherLauncher to WebKit.sln
It builds just after WinLauncher.
Part of <http://webkit.org/b/68578> <rdar://problem/10163861> WinLauncher fails to launch
when double-clicked
Reviewed by Anders Carlsson.
* WebKit.vcproj/WebKit.sln: Added WinLauncherLauncher.
2011-12-21 Jessie Berlin <jberlin@apple.com>
Expose to Windows the way to allow a scheme access to Local Storage and Databases while
Private Browsing is enabled.
https://bugs.webkit.org/show_bug.cgi?id=75056
Reviewed by Sam Weinig.
Add the Windows WebKit API that corresponds to the Mac one added in r99439.
* WebView.cpp:
(WebView::registerURLSchemeAsSecure):
(WebView::registerURLSchemeAsAllowingLocalStorageAccessInPrivateBrowsing):
(WebView::registerURLSchemeAsAllowingDatabaseAccessInPrivateBrowsing):
* WebView.h:
2011-12-20 Pavel Feldman <pavel.feldman@gmail.com>
Web Inspector: reproducible crash after closing web inspector and browser window (iCab)
https://bugs.webkit.org/show_bug.cgi?id=74255
Reviewed by Yury Semikhatsky.
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::~WebInspectorClient):
(WebInspectorFrontendClient::destroyInspectorView):
* WebCoreSupport/WebInspectorClient.h:
2011-12-19 Sam Weinig <sam@webkit.org>
More PlatformEvent cleanup
https://bugs.webkit.org/show_bug.cgi?id=74831
Reviewed by Dan Bernstein.
* WebView.cpp:
(WebView::handleMouseEvent):
Update to use new names, access style.
2011-12-16 Ryosuke Niwa <rniwa@webkit.org>
Rename registerCommandFor(Undo|Redo) to register(Undo|Redo)Step
https://bugs.webkit.org/show_bug.cgi?id=74748
Reviewed by Eric Seidel.
* WebCoreSupport/WebEditorClient.cpp:
(WebEditorClient::registerUndoStep):
(WebEditorClient::registerRedoStep):
* WebCoreSupport/WebEditorClient.h:
2011-12-16 Sam Weinig <sam@webkit.org>
Give PlatformEvents a base class
https://bugs.webkit.org/show_bug.cgi?id=74685
Reviewed by Anders Carlsson.
Add a base class for PlatformMouseEvent, PlatformKeyboardEvent, PlatformWheelEvent
and PlatformGestureEvent and move Type enumeration and modifiers down to it.
* AccessibleBase.cpp:
(AccessibleBase::get_accKeyboardShortcut):
* WebDropSource.cpp:
(generateMouseEvent):
* WebView.cpp:
(WebView::keyUp):
(WebView::handleEditingKeyboardEvent):
(WebView::keyDown):
(WebView::keyPress):
2011-12-16 Ryosuke Niwa <rniwa@webkit.org>
Only EditCommandComposition should implement unapply and reapply
https://bugs.webkit.org/show_bug.cgi?id=74490
Reviewed by Eric Seidel.
* WebCoreSupport/WebEditorClient.cpp:
(WebEditorUndoCommand::WebEditorUndoCommand):
(WebEditorUndoCommand::execute):
(WebEditorClient::registerCommandForUndo):
(WebEditorClient::registerCommandForRedo):
* WebCoreSupport/WebEditorClient.h:
2011-12-14 Jing Zhao <jingzhao@chromium.org>
Opening two popup menus by dispatchEvent() makes problems.
https://bugs.webkit.org/show_bug.cgi?id=73304
Reviewed by Kent Tamura.
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::hasOpenedPopup): Not implemented.
* WebCoreSupport/WebChromeClient.h: Overrides hasOpenedPopup().
2011-12-14 Sam Weinig <weinig@apple.com>
Remove whitespace from InheritedPropertySheets attributes in
vsprops files to appease the Visual Studio project migrator.
Reviewed by Adam Roben.
* WebKit.vcproj/InterfacesDebug.vsprops:
* WebKit.vcproj/InterfacesDebugAll.vsprops:
* WebKit.vcproj/InterfacesDebugCairoCFLite.vsprops:
* WebKit.vcproj/InterfacesProduction.vsprops:
* WebKit.vcproj/InterfacesRelease.vsprops:
* WebKit.vcproj/InterfacesReleaseCairoCFLite.vsprops:
* WebKit.vcproj/WebKitGUIDDebug.vsprops:
* WebKit.vcproj/WebKitGUIDDebugAll.vsprops:
* WebKit.vcproj/WebKitGUIDDebugCairoCFLite.vsprops:
* WebKit.vcproj/WebKitGUIDProduction.vsprops:
* WebKit.vcproj/WebKitGUIDRelease.vsprops:
* WebKit.vcproj/WebKitGUIDReleaseCairoCFLite.vsprops:
* WebKit.vcproj/WebKitLibDebug.vsprops:
* WebKit.vcproj/WebKitLibDebugAll.vsprops:
* WebKit.vcproj/WebKitLibDebugCairoCFLite.vsprops:
* WebKit.vcproj/WebKitLibProduction.vsprops:
* WebKit.vcproj/WebKitLibRelease.vsprops:
* WebKit.vcproj/WebKitLibReleaseCairoCFLite.vsprops:
2011-12-07 Mary Wu <mary.wu@torchmobile.com.cn>
Change function name InitializeLoggingChannelsIfNecessary to follow coding style guideline
https://bugs.webkit.org/show_bug.cgi?id=73986
Reviewed by Kenneth Rohde Christiansen.
* WebView.cpp:
(WebView::initWithFrame):
2011-12-05 Eric Carlson <eric.carlson@apple.com>
WebKit/mac part of: Add WebKit preferences for text track settings
https://bugs.webkit.org/show_bug.cgi?id=73721
Reviewed by John Sullivan.
* Interfaces/IWebPreferences.idl: Declare getters and setters for new properties.
* WebPreferenceKeysPrivate.h: Added #define for shouldDisplaySubtitles, shouldDisplayCaptions,
and shouldDisplayTextDescriptions properties.
* WebPreferences.cpp:
(WebPreferences::setShouldDisplaySubtitles): Added.
(WebPreferences::shouldDisplaySubtitles): Ditto.
(WebPreferences::setShouldDisplayCaptions): Ditto.
(WebPreferences::shouldDisplayCaptions): Ditto.
(WebPreferences::setShouldDisplayTextDescriptions): Ditto.
(WebPreferences::shouldDisplayTextDescriptions): Ditto.
* WebPreferences.h: Declare new methods.
* WebView.cpp:
(WebView::notifyPreferencesChanged): Updates WebCore settings from WebKit prefs.
2011-12-02 Steve Falkenburg <sfalken@apple.com>
Reviewed by Darin Adler.
Changes to localStorageDatabasePath don't have any effect on Windows
https://bugs.webkit.org/show_bug.cgi?id=73606
<rdar://problem/10491296>
* WebView.cpp:
(WebView::notifyPreferencesChanged): Propagate local storage path change to m_page's settings.
2011-11-30 Alexey Proskuryakov <ap@apple.com>
Remove an unneeded argument from FrameLoaderClient::download
https://bugs.webkit.org/show_bug.cgi?id=73486
Reviewed by Andreas Kling.
* WebFrame.cpp:
(WebFrame::download):
* WebFrame.h:
Updated for the change.
2011-11-26 Pavel Feldman <pfeldman@google.com>
Web Inspector: remove disconnectFromBackend from the protocol.
https://bugs.webkit.org/show_bug.cgi?id=73127
Reviewed by Yury Semikhatsky.
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::inspectorDestroyed):
(WebInspectorClient::closeInspectorFrontend):
* WebCoreSupport/WebInspectorClient.h:
2011-11-26 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r101193.
http://trac.webkit.org/changeset/101193
https://bugs.webkit.org/show_bug.cgi?id=73158
Breaks Windows and Qt minimal. (Requested by pfeldman on
#webkit).
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::inspectorDestroyed):
(WebInspectorFrontendClient::disconnectFromBackend):
* WebCoreSupport/WebInspectorClient.h:
2011-11-26 Pavel Feldman <pfeldman@google.com>
Web Inspector: remove disconnectFromBackend from the protocol.
https://bugs.webkit.org/show_bug.cgi?id=73127
Reviewed by Yury Semikhatsky.
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::inspectorDestroyed):
(WebInspectorClient::closeInspectorFrontend):
* WebCoreSupport/WebInspectorClient.h:
2011-11-22 Pavel Feldman <pfeldman@google.com>
Web Inspector: remove Inspector::bringToFront from the protocol.
https://bugs.webkit.org/show_bug.cgi?id=72937
Reviewed by Yury Semikhatsky.
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::bringFrontendToFront):
* WebCoreSupport/WebInspectorClient.h:
2011-11-21 Pavel Feldman <pfeldman@google.com>
Not reviewed: an attempt to fix windows build.
* WebInspector.cpp:
(WebInspector::isJavaScriptProfilingEnabled):
(WebInspector::setJavaScriptProfilingEnabled):
2011-06-20 Pavel Feldman <pfeldman@chromium.org>
Web Inspector: introduce InspectorFrontendAPI for actions initiated from the application menu.
https://bugs.webkit.org/show_bug.cgi?id=62985
Both: inspector protocol and WebCore/InspectorController have a number of unnecessary
methods for plumbing the menu action handlers through the WebKit and WebCore.
I intend to remove this menu support from the protocol and WebCore/InspectorController API.
I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port.
WebKit/win and WebKit2 to follow.
Reviewed by Yury Semikhatsky.
* WebInspector.cpp:
(WebInspector::createInstance):
(WebInspector::WebInspector):
(WebInspector::webViewClosed):
(WebInspector::showConsole):
(WebInspector::isDebuggingJavaScript):
(WebInspector::toggleDebuggingJavaScript):
(WebInspector::isProfilingJavaScript):
(WebInspector::toggleProfilingJavaScript):
(WebInspector::isJavaScriptProfilingEnabled):
(WebInspector::setJavaScriptProfilingEnabled):
(WebInspector::isTimelineProfilingEnabled):
(WebInspector::setTimelineProfilingEnabled):
* WebInspector.h:
* WebView.cpp:
(WebView::WebView):
(WebView::close):
(WebView::initWithFrame):
(WebView::inspector):
* WebView.h:
2011-10-17 Antonio Gomes <agomes@rim.com>
Pass a Frame* parameter in EditorClient::respondToChangedSelection
https://bugs.webkit.org/show_bug.cgi?id=70248
Reviewed by Ryosuke Niwa.
* WebCoreSupport/WebEditorClient.cpp: Make use of the newly added Frame* parameter.
(WebEditorClient::respondToChangedSelection):
* WebCoreSupport/WebEditorClient.h:
2011-11-15 Jochen Eisinger <jochen@chromium.org>
Rename ReferrerPolicy to clarify its meaning
https://bugs.webkit.org/show_bug.cgi?id=72420
Reviewed by Nate Chapin.
* WebCoreSupport/WebContextMenuClient.cpp:
(WebContextMenuClient::searchWithGoogle):
2011-11-15 Anders Carlsson <andersca@apple.com>
HostWindow screenToWindow/windowToScreen should be screenToRootView/rootViewToScreen
https://bugs.webkit.org/show_bug.cgi?id=72397
Reviewed by Dan Bernstein.
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::rootViewToScreen):
(WebChromeClient::screenToRootView):
* WebCoreSupport/WebChromeClient.h:
2011-11-14 Anders Carlsson <andersca@apple.com>
HostWindow invalidation functions should use root view coordinates
https://bugs.webkit.org/show_bug.cgi?id=72338
Reviewed by Dan Bernstein.
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::invalidateRootView):
(WebChromeClient::invalidateContentsAndRootView):
* WebCoreSupport/WebChromeClient.h:
2011-11-07 Adam Barth <abarth@webkit.org>
Move static "policy" state from SecurityOrigin.cpp to SecurityPolicy.cpp
https://bugs.webkit.org/show_bug.cgi?id=71755
Reviewed by Eric Seidel.
* WebView.cpp:
(WebView::addOriginAccessWhitelistEntry):
(WebView::removeOriginAccessWhitelistEntry):
(WebView::resetOriginAccessWhitelists):
2011-11-07 Adam Barth <abarth@webkit.org>
Move DomainRelaxationForbidden scheme registry to SchemeRegistry
https://bugs.webkit.org/show_bug.cgi?id=71750
Reviewed by Eric Seidel.
* WebView.cpp:
(WebView::setDomainRelaxationForbiddenForURLScheme):
2011-11-07 Beth Dakin <bdakin@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=71490
Support uiStateTransitionProgress for scrollbars
-and corresponding-
<rdar://problem/9849612>
Reviewed by Sam Weinig.
Scrollbar::mouseUp() now takes a PlatformMouseEvent as a parameter.
* WebScrollBar.cpp:
(WebScrollBar::handleMouseEvent):
2011-11-02 Darin Adler <darin@apple.com>
Change remaining callers of releaseRef to call leakRef
https://bugs.webkit.org/show_bug.cgi?id=71422
Reviewed by Darin Fisher.
* WebCache.cpp:
(WebCache::statistics):
* WebDatabaseManager.cpp:
(WebDatabaseManager::origins):
(WebDatabaseManager::databasesWithOrigin):
* WebHistoryItem.cpp:
(WebHistoryItem::redirectURLs):
* WebKitClassFactory.cpp:
(leakRefFromCreateInstance):
(WebKitClassFactory::CreateInstance):
* WebScriptWorld.cpp:
(WebScriptWorld::standardWorld):
Use leakRef.
2011-11-02 Jon Lee <jonlee@apple.com>
Expand DragController to provide more information about the dragging session
https://bugs.webkit.org/show_bug.cgi?id=71324
<rdar://problem/10379175>
Reviewed by Darin Adler.
* WebView.cpp:
(WebView::DragEnter): Minor refactoring because operation is stored in
new DragSession struct.
(WebView::DragOver): Ditto.
2011-11-02 Tom Sepez <tsepez@chromium.org>
XSSAuditor is silent
https://bugs.webkit.org/show_bug.cgi?id=70973
Reviewed by Adam Barth.
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::didDetectXSS):
* WebCoreSupport/WebFrameLoaderClient.h:
2011-10-28 Jochen Eisinger <jochen@chromium.org>
Rename a number of methods mentioning JavaScript to just Script instead
https://bugs.webkit.org/show_bug.cgi?id=71105
Reviewed by Adam Barth.
* WebFrame.cpp:
(WebFrame::dispatchDidClearWindowObjectInWorld):
* WebView.cpp:
(WebView::notifyPreferencesChanged):
2011-10-24 Geoffrey Garen <ggaren@apple.com>
Build fix: removed some cases of threadsafeCopy() that I missed in
my previous patch.
* WebDatabaseManager.cpp:
(DidModifyOriginData::dispatchToMainThread):
* WebDownloadCFNet.cpp:
(WebDownload::initToResumeWithBundle):
* WebIconDatabase.cpp:
(WebIconDatabase::didImportIconURLForPageURL):
2011-10-24 Ryosuke Niwa <rniwa@webkit.org>
threadsafeCopy has been renamed to isolatedCopy.
* WebDatabaseManager.cpp:
(DidModifyOriginData::dispatchToMainThread):
2011-10-24 Adam Barth <abarth@webkit.org>
Attempt to fix Windows build by updating to the new interface.
* DOMEventsClasses.cpp:
(DOMEvent::createInstance):
2011-10-18 Adam Barth <abarth@webkit.org>
Always enable ENABLE(XPATH)
https://bugs.webkit.org/show_bug.cgi?id=70217
Reviewed by Eric Seidel.
* Interfaces/DOMWindow.idl:
2011-10-14 Julien Chaffraix <jchaffraix@webkit.org>
Remove layerX / layerY from the Windows API
https://bugs.webkit.org/show_bug.cgi?id=70051
Reviewed by Darin Adler.
Renamed layerX to unused1 and layerY to unused2 to keep the
binary compatibility.
* DOMEventsClasses.cpp:
(DOMUIEvent::unused1):
(DOMUIEvent::unused2):
* DOMEventsClasses.h:
(DOMKeyboardEvent::unused1):
(DOMKeyboardEvent::unused2):
(DOMMouseEvent::unused1):
(DOMMouseEvent::unused2):
(DOMWheelEvent::unused1):
(DOMWheelEvent::unused2):
* Interfaces/DOMEvents.idl:
2011-10-11 Simon Fraser <simon.fraser@apple.com>
Make custom scrollbar theme for use in DRT, to reduce pixel diffs between platforms
https://bugs.webkit.org/show_bug.cgi?id=68134
Reviewed by Darin Adler.
Use ScrollbarThemeMock when the setting to use mock scrollbars is enabled.
Make ScrollbarTheme::nativeTheme() private, and add a new static theme() method
that reads the setting, and returns the mock theme if set. All callers now use
theme() rther than nativeTheme(). Add the new ScrollbarTheme.cpp file to the build.
* WebScrollBar.cpp:
(WebScrollBar::requestedWidth):
(WebScrollBar::requestedHeight):
* WebView.cpp:
(WebView::WebViewWndProc):
2011-10-03 Anders Carlsson <andersca@apple.com>
Remove custom scrollbar painting hooks
https://bugs.webkit.org/show_bug.cgi?id=69163
Reviewed by Alexey Proskuryakov.
Remove now unused WebPreferences and ChromeClient overrides.
* Interfaces/IWebPreferences.idl:
* WebCoreSupport/WebChromeClient.cpp:
* WebCoreSupport/WebChromeClient.h:
* WebPreferenceKeysPrivate.h:
* WebPreferences.cpp:
(WebPreferences::unused3):
(WebPreferences::unused4):
* WebPreferences.h:
* WebView.cpp:
(WebView::notifyPreferencesChanged):
2011-09-23 Adam Roben <aroben@apple.com>
Remove WebKitAPITest
WebKit part of <http://webkit.org/b/66560> WebKitAPITest and TestWebKitAPI have duplicate
functionality (and names!)
Reviewed by Anders Carlsson.
* WebKit.vcproj/WebKit.sln: Removed WebKitAPITest.vcproj. Changed WebKitLauncherWin, which
formerly depended on WebKitAPITest, to now depend on DumpRenderTree, which WebKitAPITest
depended on.
2011-09-24 Adam Barth <abarth@webkit.org>
Always enable ENABLE(OFFLINE_WEB_APPLICATIONS)
https://bugs.webkit.org/show_bug.cgi?id=68767
Reviewed by Eric Seidel.
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::reachedApplicationCacheOriginQuota):
* WebCoreSupport/WebChromeClient.h:
2011-09-22 Adam Roben <aroben@apple.com>
Remove FindSafari from all our .sln files
It isn't used anymore, so there's no point in building it.
Part of <http://webkit.org/b/68628> Remove FindSafari
Reviewed by Steve Falkenburg.
* WebKit.vcproj/WebKit.sln: Also relinearized the build order while I was at it.
2011-09-22 Adam Roben <aroben@apple.com>
Add testRegExp.vcproj to WebKit.sln
Fixes <http://webkit.org/b/68403> Windows bots don't build testRegExp.vcproj
Reviewed by Brian Weinstein.
* WebKit.vcproj/WebKit.sln: Added testRegExp. Made it build just after jsc, just like it
does when built as part of JavaScriptCore.sln.
2011-09-21 Steve Falkenburg <sfalken@apple.com>
Branch builds don't launch on Windows when run against trunk WebKit
https://bugs.webkit.org/show_bug.cgi?id=68546
Reviewed by Darin Adler.
* Interfaces/IWebPreferences.idl: Swap avFoundation and pictographicFontFamily
in IDL for binary compatibility between branch and trunk.
2011-09-21 Andras Becsi <andras.becsi@nokia.com>
[Qt] Remove Qt specific code from css/SelectorChecker.cpp
https://bugs.webkit.org/show_bug.cgi?id=67702
Reviewed by Csaba Osztrogonác.
* WebCoreSupport/WebPlatformStrategies.cpp: Modify to match new prototype.
(WebPlatformStrategies::isLinkVisited):
* WebCoreSupport/WebPlatformStrategies.h: Ditto.
2011-09-17 Mihai Parparita <mihaip@chromium.org>
FrameLoaderClient BackForwardList-related methods are unsued
https://bugs.webkit.org/show_bug.cgi?id=68293
Reviewed by Darin Adler.
Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.
* WebCoreSupport/WebFrameLoaderClient.cpp:
* WebCoreSupport/WebFrameLoaderClient.h:
2011-09-15 Adam Barth <abarth@webkit.org>
Rename ENABLE(DATABASE) to ENABLE(SQL_DATABASE)
https://bugs.webkit.org/show_bug.cgi?id=68205
Reviewed by Eric Seidel.
* ForEachCoClass.h:
* WebCoreSupport/WebChromeClient.cpp:
* WebCoreSupport/WebChromeClient.h:
* WebDatabaseManager.cpp:
* WebDatabaseManager.h:
* WebSecurityOrigin.cpp:
(WebSecurityOrigin::usage):
(WebSecurityOrigin::quota):
(WebSecurityOrigin::setQuota):
* WebView.cpp:
(WebView::initWithFrame):
(WebView::notifyPreferencesChanged):
2011-09-15 Kentaro Hara <haraken@google.com>
A single line must not be split into two pages.
https://bugs.webkit.org/show_bug.cgi?id=65005
Reviewed by David Hyatt.
When the document width of a page is overflowed, the last line of the page can be
split into the next page. This is the regression caused by r88737. r88737 tried to
fix rounding errors in rendering calculations by expanding and shrinking a page
using one common method, resizePageRectsKeepingRatio(), but overlooked the case where
a document width gets overflowed.
Test: printing/single-line-must-not-be-split-into-two-pages.html
* WebFrame.cpp:
(WebFrame::setPrinting): Passes an original page size to setPrinting().
(WebFrame::setInPrintingMode): Ditto.
* WebFrame.h:
2011-09-06 Ryosuke Niwa <rniwa@webkit.org>
Rename confirmCompositionWithoutDisturbingSelection to cancelComposition
https://bugs.webkit.org/show_bug.cgi?id=67569
Reviewed by Antonio Gomes.
* WebView.cpp:
(WebView::resetIME):
2011-08-29 Alexey Proskuryakov <ap@apple.com>
DumpRenderTree should begin each test with an empty cookie store
https://bugs.webkit.org/show_bug.cgi?id=63545
<rdar://problem/5666907>
Reviewed by Darin Adler.
* WebCookieManagerCFNet.cpp:
(WebCookieManager::cookieStorage):
(WebCookieManager::setCookieStorage):
Changed the API to work with new functions in WebCore. It's a bit ugly, because cookieStorage()
returns an unretained reference, which we cannot provide any more, but it should not be a
practical issue.
* WebView.cpp: (updateSharedSettingsFromPreferencesIfNeeded): Updated to use currentCFHTTPCookieStorage()
instead of currentCookieStorage().
2011-08-30 Kaustubh Atrawalkar <kaustubh@motorola.com>
The unused ScrollView* argument can and should be removed from
scrollRectIntoView.
https://bugs.webkit.org/show_bug.cgi?id=67117
Reviewed by Darin Adler.
* WebCoreSupport/WebChromeClient.h:
(WebChromeClient::scrollRectIntoView):
2011-08-29 Ryosuke Niwa <rniwa@webkit.org>
Move setInnerTextValue from RenderTextControl to HTMLTextFormControlElement
https://bugs.webkit.org/show_bug.cgi?id=67152
Reviewed by Darin Adler.
Updated call sites of lastChangeWasUserEdit since it's moved from RenderTextControl
to HTMLTextFormControlElement.
* DOMHTMLClasses.cpp:
(DOMHTMLInputElement::isUserEdited):
(DOMHTMLTextAreaElement::isUserEdited):
2011-08-29 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r93987, r93992, r93995, r93998, and
r93999.
http://trac.webkit.org/changeset/93987
http://trac.webkit.org/changeset/93992
http://trac.webkit.org/changeset/93995
http://trac.webkit.org/changeset/93998
http://trac.webkit.org/changeset/93999
https://bugs.webkit.org/show_bug.cgi?id=67147
Many failing tests (Requested by ap on #webkit).
* WebCookieManagerCFNet.cpp:
(WebCookieManager::cookieStorage):
(WebCookieManager::setCookieStorage):
* WebView.cpp:
(updateSharedSettingsFromPreferencesIfNeeded):
2011-08-29 Alexey Proskuryakov <ap@apple.com>
Windows build fix.
* WebView.cpp:
(updateSharedSettingsFromPreferencesIfNeeded):
Updated for new function name and signature: currentCFHTTPCookieStorage().
2011-08-26 Alexey Proskuryakov <ap@apple.com>
DumpRenderTree should begin each test with an empty cookie store
https://bugs.webkit.org/show_bug.cgi?id=63545
<rdar://problem/5666907>
Reviewed by Darin Adler.
* WebCookieManagerCFNet.cpp:
(WebCookieManager::cookieStorage):
(WebCookieManager::setCookieStorage):
Changed the API to work with new functions in WebCore. It's a bit ugly, because cookieStorage()
returns an unretained reference, which we cannot provide any more, but it should not be a
practical issue.
2011-08-17 Adam Roben <aroben@apple.com>
Make WebCore keep track of the current device scale factor
Fixes <http://webkit.org/b/66413> WebCore requires every WebKit port to keep track of the
device scale factor
Reviewed by Darin Adler.
* WebCoreSupport/WebChromeClient.cpp:
* WebCoreSupport/WebChromeClient.h:
Removed deviceScaleFactor.
2011-08-15 Dmitry Titov <dimich@chromium.org>
FrameLoaderClient::transferLoadingResourceFromPage does not have enough parameters
https://bugs.webkit.org/show_bug.cgi?id=66165
Reviewed by Darin Fisher.
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::transferLoadingResourceFromPage):
* WebCoreSupport/WebFrameLoaderClient.h:
2011-08-15 Adam Roben <aroben@apple.com>
Touch a file to trigger a Windows build
I'm trying to ferret out some issues with our Debug builder.
* WebView.cpp: Sorted #includes.
2011-08-10 Adam Roben <aroben@apple.com>
Clear up scale factor terminology
WebKit by and large deals with two scale factors: one intrinsic to the device on which the
software is running, and one that is per-Page and can be controlled via API calls. This
patch names the former "deviceScaleFactor" and the latter "pageScaleFactor", and makes the
code use those names. It should introduce no behavior changes.
Fixes <http://webkit.org/b/55787> WebKit uses multiple conflicting names to refer to the
device scale factor
Reviewed by Simon Fraser.
* WebCoreSupport/WebChromeClient.cpp:
* WebCoreSupport/WebChromeClient.h:
2011-08-13 Dan Bernstein <mitz@apple.com>
Changed the value of WebKitShowsToolTipOverTruncatedTextPreferenceKey to match the naming everywhere else.
Reviewed by Joseph Pecoraro.
* WebPreferenceKeysPrivate.h:
2011-08-13 Dan Bernstein <mitz@apple.com>
Build fix.
* WebView.cpp:
(WebView::notifyPreferencesChanged):
2011-08-12 Dan Bernstein <mitz@apple.com>
Add an option to automatically show tooltips (with the full text) over truncated text
https://bugs.webkit.org/show_bug.cgi?id=66178
Reviewed by Simon Fraser.
* Interfaces/IWebPreferencesPrivate.idl: Added accessors.
* WebPreferenceKeysPrivate.h: Defined a preference key.
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings): Added a default value of
false for the ShowsToolTipOverTruncatedText preference.
(WebPreferences::showsToolTipOverTruncatedText): Added this getter.
(WebPreferences::setShowsToolTipOverTruncatedText): Added this setter.
* WebPreferences.h:
* WebView.cpp:
(WebView::notifyPreferencesChanged): Added call to Settings::setShowsToolTipOverTruncatedText().
2011-08-05 Brent Fulgham <bfulgham@webkit.org>
WebView::performLayeredWindowUpdate() crashes with
NULL pointer when using layered window updates.
https://bugs.webkit.org/show_bug.cgi?id=60618
Reviewed by Adam Roben.
During resize operations, the backing store will be destroyed if
the window's size (either height or width) is set to zero. The
bug was identified when a user first resized a WebView to zero
dimensions, then attempted to perform a MoveWindow. The paint
message triggered by the MoveWindow attempted to use the layered
window update logic, which encountered the nulled backing store.
* WebView.cpp:
(WebView::performLayeredWindowUpdate): Add an early
return when there is no backing store to blend with.
2011-08-05 Anders Carlsson <andersca@apple.com>
Remove PluginHalter
https://bugs.webkit.org/show_bug.cgi?id=65729
Reviewed by Darin Adler.
Remove plug-in halter and associated classes.
* Interfaces/IWebPluginHalterDelegate.idl: Removed.
* Interfaces/IWebPreferencesPrivate.idl:
* Interfaces/IWebViewPrivate.idl:
* Interfaces/WebKit.idl:
* WebCoreSupport/WebPluginHalterClient.cpp: Removed.
* WebCoreSupport/WebPluginHalterClient.h: Removed.
* WebKit.vcproj/Interfaces.vcproj:
* WebKit.vcproj/WebKit.vcproj:
* WebPreferenceKeysPrivate.h:
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
* WebPreferences.h:
* WebView.cpp:
(WebView::close):
(WebView::initWithFrame):
(WebView::notifyPreferencesChanged):
(WebView::unused1):
(WebView::unused2):
(WebView::unused3):
(WebView::unused4):
(WebView::unused5):
* WebView.h:
2011-08-04 Jeff Miller <jeffm@apple.com>
Add support for setting and getting whether AVFoundation is enabled to IWebPreferences
https://bugs.webkit.org/show_bug.cgi?id=65718
Reviewed by Adam Roben.
* Interfaces/IWebPreferences.idl: Added setAVFoundationEnabled() and avFoundationEnabled().
* WebPreferenceKeysPrivate.h: Added WebKitAVFoundationEnabledPreferenceKey.
* WebPreferences.cpp:
(WebPreferences::avFoundationEnabled): Added.
(WebPreferences::setAVFoundationEnabled): Added.
* WebPreferences.h: Added setAVFoundationEnabled() and avFoundationEnabled().
* WebView.cpp:
(WebView::notifyPreferencesChanged): Keep settings for AVFoundation being enabled in sync.
2011-08-03 Kent Tamura <tkent@chromium.org>
[Windows] Fix build without ENABLE_VIDEO.
* WebView.cpp:
(WebView::enterFullscreenForNode):
2011-08-03 Kent Tamura <tkent@chromium.org>
Fix incorrect checks for HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=65590
Reviewed by Dimitri Glazkov.
<video> and <audio> can be an HTMLElement instance instead of
HTMLMediaElement if MediaPlayer::isAvailable() returns false or
the media feature is disabled at runtime.
* WebView.cpp:
(WebView::enterFullscreenForNode):
2011-08-03 Joseph Pecoraro <joepeck@webkit.org>
Web Inspector: Remove InspectorFrontendHost load/saveSessionSetting
https://bugs.webkit.org/show_bug.cgi?id=65582
Reviewed by Pavel Feldman.
* WebCoreSupport/WebInspectorClient.cpp:
* WebCoreSupport/WebInspectorClient.h:
2011-08-03 Adam Roben <aroben@apple.com>
Windows nightly build fix after r91777
* Interfaces/IWebPreferences.idl: Moved [set]PictographFontFamily to the end of the
interface to maintain binary compatibility with Safari 5.1.
2011-08-03 Pavel Feldman <pfeldman@google.com>
Web Inspector: [Timeline] Hover on paint events and see rect outline around that area.
https://bugs.webkit.org/show_bug.cgi?id=65510
Reviewed by Yury Semikhatsky.
* WebNodeHighlight.cpp:
(WebNodeHighlight::update):
2011-08-03 Pavel Feldman <pfeldman@chromium.org>
Web Inspector: remove Node parameter from the InspectorClient::highlight
https://bugs.webkit.org/show_bug.cgi?id=65549
Reviewed by Yury Semikhatsky.
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::highlight):
* WebCoreSupport/WebInspectorClient.h:
2011-07-31 Daniel Bates <dbates@webkit.org>
Attempt to fix the WinCairo Debug build after r92059 (https://bugs.webkit.org/show_bug.cgi?id=65419).
* WebKit.vcproj/WebKit_Cairo.def: Export some symbols.
* WebKit.vcproj/WebKit_Cairo_debug.def: Ditto.
2011-07-30 Patrick Gansterer <paroga@webkit.org>
Remove inclusion of MainThread.h from Threading.h
https://bugs.webkit.org/show_bug.cgi?id=65081
Reviewed by Darin Adler.
Add missing include statements for MainThread.
* WebKitClassFactory.cpp:
* WebView.cpp:
2011-07-26 Sadrul Habib Chowdhury <sadrul@chromium.org>
Add support for download='filename' attribute in anchors.
https://bugs.webkit.org/show_bug.cgi?id=64580
Reviewed by Adam Barth.
* WebFrame.cpp:
(WebFrame::startDownload):
* WebFrame.h:
2011-07-26 Dan Bernstein <mitz@apple.com>
<rdar://problem/9842889> Add a generic pictograph font family
https://bugs.webkit.org/show_bug.cgi?id=65197
Reviewed by Anders Carlsson.
* Interfaces/IWebPreferences.idl: Added pictographFontFamily() and
setPictographFontFamily().
* WebPreferenceKeysPrivate.h: Added WebKitPictographFontPreferenceKey.
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings): Initialize the pictograph font
preference to "Times New Roman".
(WebPreferences::pictographFontFamily): Added this getter.
(WebPreferences::setPictographFontFamily): Added this setter.
* WebPreferences.h:
* WebView.cpp:
(WebView::notifyPreferencesChanged): Pass the preference value through to
WebCore.
2011-07-18 Dean Jackson <dino@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=64742
Expose WebPreferences for media playback requiring user gestures and inline playback
Reviewed by Simon Fraser.
Two new WebPreferences: MediaPlaybackRequiresUserGesture and
MediaPlaybackAllowsInline.
* Interfaces/IWebPreferencesPrivate.idl:
* WebPreferenceKeysPrivate.h:
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::setMediaPlaybackRequiresUserGesture):
(WebPreferences::mediaPlaybackRequiresUserGesture):
(WebPreferences::setMediaPlaybackAllowsInline):
(WebPreferences::mediaPlaybackAllowsInline):
* WebPreferences.h:
* WebView.cpp:
(WebView::notifyPreferencesChanged):
2011-07-16 Simon Fraser <simon.fraser@apple.com>
Add code to attempt to align compositing layers to pixel boundaries when page scale changes
https://bugs.webkit.org/show_bug.cgi?id=64658
Reviewed by Dan Bernstein.
Removed implementations of backingScaleFactor() and pageScaleFactor() now
that GraphicsLayerClient has default implementations.
* WebView.h:
2011-07-15 Simon Fraser <simon.fraser@apple.com>
Fix Windows build.
* WebView.h:
(WebView::backingScaleFactor):
(WebView::pageScaleFactor):
2011-07-15 Dan Bernstein <mitz@apple.com>
REGRESSION: Mouse cursor doesn’t hide when full screen video HUD hides
https://bugs.webkit.org/show_bug.cgi?id=64615
Reviewed by Anders Carlsson.
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::setCursorHiddenUntilMouseMoves): Added this stub.
* WebCoreSupport/WebChromeClient.h:
2011-07-12 Joseph Pecoraro <joepeck@webkit.org>
ApplicationCache update should not immediately fail when reaching per-origin quota
https://bugs.webkit.org/show_bug.cgi?id=64177
Reviewed by Alexey Proskuryakov.
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::reachedApplicationCacheOriginQuota):
* WebCoreSupport/WebChromeClient.h:
2011-07-11 Hironori Bono <hbono@chromium.org>
Reviewed by Adam Roben.
Implement layoutTestController.setTextDirection for WebKit2 and Windows.
https://bugs.webkit.org/show_bug.cgi?id=61931
This change implements layoutTextController.setTextDirection for WebKit2
and Windows so we can run a layout test added by r87770 on them. Each
implementation adds a wrapper function for Editor::setBaseWritingDirection()
so LayoutTestController can call it.
* Interfaces/IWebFramePrivate.idl: Added setTextDirection to allow
LayoutTestController to change the text direction.
* WebFrame.cpp: ditto.
(WebFrame::setTextDirection):
* WebFrame.h: ditto.
2011-07-08 Chang Shu <cshu@webkit.org>
Update calling sites after function renamed.
https://bugs.webkit.org/show_bug.cgi?id=59114
Reviewed by Alexey Proskuryakov.
* WebKitGraphics.cpp:
(WebDrawText):
2011-06-30 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
More ScrollableArea scaffolding
https://bugs.webkit.org/show_bug.cgi?id=63678
* WebScrollBar.h:
(WebScrollBar::enclosingScrollableArea):
Always return 0, WebScrollbar has no concept of an enclosing scrollable area.
2011-06-28 Ilya Sherman <isherman@chromium.org>
Reviewed by Adam Barth.
form.autocomplete="off" does not work
https://bugs.webkit.org/show_bug.cgi?id=35823
* WebFrame.cpp:
(WebFrame::elementDoesAutoComplete): Updated callsite.
2011-06-27 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
Avoid attempt to create a zero-size DIB.
https://bugs.webkit.org/show_bug.cgi?id=63484.
* WebNodeHighlight.cpp:
(WebNodeHighlight::update): Check for zero-height (or zero-width)
region for DIB, and exit early if attempting to create a zero-size
DIB/BITMAP.
2011-06-24 Dan Bernstein <mitz@apple.com>
Reviewed by Anders Carlsson.
Add an option to enable legacy rounding hacks
https://bugs.webkit.org/show_bug.cgi?id=63363
* WebKitGraphics.cpp:
(CenterTruncateStringToWidth): Enabled rounding hacks in the string truncator.
(RightTruncateStringToWidth): Ditto.
2011-06-24 Yuta Kitamura <yutak@chromium.org>
Reviewed by Adam Barth.
WebSocket: Add run-time flag for new HyBi protocol
https://bugs.webkit.org/show_bug.cgi?id=60348
Make a new flag (Setting::m_useHixie76WebSocketProtocol)
switchable from WebView and WebPreferences.
* Interfaces/IWebPreferencesPrivate.idl:
* WebPreferenceKeysPrivate.h:
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::setHixie76WebSocketProtocolEnabled):
(WebPreferences::hixie76WebSocketProtocolEnabled):
* WebPreferences.h:
* WebView.cpp:
(WebView::notifyPreferencesChanged):
2011-06-22 Dominic Cooney <dominicc@chromium.org>
Reviewed by Mark Rowe.
Add window.internals to WebKit2's WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=61073
* WebKit.vcproj/WebKit.sln: InjectedBundle depends on WebCoreTestSupport
2011-06-20 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Kent Tamura.
FileChooser should be only created when we need to choose files.
https://bugs.webkit.org/show_bug.cgi?id=63039
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::runOpenPanel): Changed to use settings.
2011-06-21 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r89354.
http://trac.webkit.org/changeset/89354
https://bugs.webkit.org/show_bug.cgi?id=63099
Broke tests on Mac (Requested by rniwa on #webkit).
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::WebInspectorClient):
(WebInspectorClient::openInspectorFrontend):
(WebInspectorFrontendClient::destroyInspectorView):
* WebCoreSupport/WebInspectorClient.h:
* WebInspector.cpp:
(WebInspector::createInstance):
(WebInspector::WebInspector):
(WebInspector::webViewClosed):
(WebInspector::showConsole):
(WebInspector::isDebuggingJavaScript):
(WebInspector::toggleDebuggingJavaScript):
(WebInspector::isProfilingJavaScript):
(WebInspector::toggleProfilingJavaScript):
(WebInspector::isJavaScriptProfilingEnabled):
(WebInspector::setJavaScriptProfilingEnabled):
(WebInspector::isTimelineProfilingEnabled):
(WebInspector::setTimelineProfilingEnabled):
* WebInspector.h:
* WebView.cpp:
(WebView::WebView):
(WebView::close):
(WebView::initWithFrame):
(WebView::inspector):
* WebView.h:
2011-06-20 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: introduce InspectorFrontendAPI for actions initiated from the application menu.
https://bugs.webkit.org/show_bug.cgi?id=62985
Both: inspector protocol and WebCore/InspectorController have a number of unnecessary
methods for plumbing the menu action handlers through the WebKit and WebCore.
I intend to remove this menu support from the protocol and WebCore/InspectorController API.
I am starting with exposing the new front-end API in the WebCore and using it in the WebKit/mac port.
WebKit/win and WebKit2 to follow.
* WebInspector.cpp:
(WebInspector::createInstance):
(WebInspector::WebInspector):
(WebInspector::webViewClosed):
(WebInspector::showConsole):
(WebInspector::isDebuggingJavaScript):
(WebInspector::toggleDebuggingJavaScript):
(WebInspector::isProfilingJavaScript):
(WebInspector::toggleProfilingJavaScript):
(WebInspector::isJavaScriptProfilingEnabled):
(WebInspector::setJavaScriptProfilingEnabled):
(WebInspector::isTimelineProfilingEnabled):
(WebInspector::setTimelineProfilingEnabled):
* WebInspector.h:
* WebView.cpp:
(WebView::WebView):
(WebView::close):
(WebView::initWithFrame):
(WebView::inspector):
* WebView.h:
2011-06-18 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Separate concerns of loading file icons and choosing files.
https://bugs.webkit.org/show_bug.cgi?id=62931
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::loadIconForFiles): Renamed.
* WebCoreSupport/WebChromeClient.h:
2011-06-16 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r89026.
http://trac.webkit.org/changeset/89026
https://bugs.webkit.org/show_bug.cgi?id=62804
These patches were likely correct. I'll investigate the
browser_test failures. (Requested by abarth on #webkit).
* FullscreenVideoController.cpp:
(FullscreenVideoController::play):
(FullscreenVideoController::pause):
2011-06-16 Vitaly Repeshko <vitalyr@chromium.org>
Unreviewed.
Revert Adam's user gesture patch series r89002, r89005, r89007, r89018
https://bugs.webkit.org/show_bug.cgi?id=62796
The patches broke chromium browser tests.
* FullscreenVideoController.cpp:
(FullscreenVideoController::play):
(FullscreenVideoController::pause):
2011-06-16 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove HTMLVideoElement::processingUserGesture
https://bugs.webkit.org/show_bug.cgi?id=62784
* FullscreenVideoController.cpp:
(FullscreenVideoController::play):
(FullscreenVideoController::pause):
2011-06-13 Kentaro Hara <haraken@google.com>
Reviewed by Alexey Proskuryakov.
Add resizePageRectsKeepingRatio(), which expands/shrinks a page, keeping the ratio of the original page
https://bugs.webkit.org/show_bug.cgi?id=61256
In order to prevent rounding error caused by expanding/shrinking a page
using different calculation here and there, I added a common calculation
method, resizePageRectsKeepingRatio(), which expands/shrinks a page,
keeping the ratio of width and height of the original page.
WebFrame::setInPrintingMode() uses resizePageRectsKeepingRatio() to
expand/shrink a page.
Test: printing/page-count-with-one-word.html
* WebFrame.cpp:
(WebFrame::setPrinting):
(WebFrame::setInPrintingMode):
* WebFrame.h:
2011-06-12 MORITA Hajime <morrita@google.com>
Unreviewed, rolling out r88625.
http://trac.webkit.org/changeset/88625
https://bugs.webkit.org/show_bug.cgi?id=61073
Breaks SL Webkit2 Tests
* WebKit.vcproj/WebKit.sln:
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Rename FrameLoaderClient::interruptForPolicyChangeError to use the past tense
https://bugs.webkit.org/show_bug.cgi?id=62516
* WebFrame.cpp:
(WebFrame::interruptedForPolicyChangeError):
* WebFrame.h:
2011-06-12 Dominic Cooney <dominicc@chromium.org>
Reviewed by Hajime Morita.
Add window.internals to WebKit2's WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=61073
* WebKit.vcproj/WebKit.sln: InjectedBundle depends on WebCoreTestSupport
2011-06-12 Adam Barth <abarth@webkit.org>
Reviewed by Alexey Proskuryakov.
Remove trival "forward-to-client" member functions from FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=62510
* WebCoreSupport/WebFrameNetworkingContext.cpp:
(WebFrameNetworkingContext::blockedError):
2011-06-06 Michael Saboff <msaboff@apple.com>
Reviewed by Geoffrey Garen.
Fonts returned by FontCache::getFontDataForCharacters() are never released
https://bugs.webkit.org/show_bug.cgi?id=61875
This change allows fonts allocated as system fallback fonts to be
released. Previously, the reference counts for these fonts grew
without bound. This is implemented as an auto release class that wraps
accesses to the cache for system fallback fonts. All such accesses are
via the method FontCache::getFontDataForCharacters. The new class is
called FontCachePurgePreventer. When such an object exists, it protects
these fonts from deletion.
See more comments for this defect in Source/WebCore/ChangeLog.
* WebKitGraphics.cpp:
(CenterTruncateStringToWidth):
(RightTruncateStringToWidth):
Wrapped code accessing fallback fonts with local
FontCachePurgePreventer in these methods.
2011-06-04 Dominic Cooney <dominicc@chromium.org>
Reviewed by Dimitri Glazkov.
Add WebCoreTestSupport project containing window.internals.
https://bugs.webkit.org/show_bug.cgi?id=61076
* WebKit.vcproj/WebKit.sln:
2011-05-18 Anthony Johnson <anthony.johnson@flexsim.com>
Reviewed by Brent Fulgham.
Implement the ability to add C++ event listeners to html dom
elements and dom window.
https://bugs.webkit.org/show_bug.cgi?id=60269
* DOMCoreClasses.cpp: Add new DOMWindow class and implementations.
(DOMNode::QueryInterface): Report that the DOMNode implements
the IDomEventTarget interface.
(DOMNode::addEventListener): Add implementation of a COM-based
event listener.
(DOMNode::removeEventListener):
(DOMNode::dispatchEvent):
(DOMDocument::createInstance):
(DOMWindow::QueryInterface): New implementation.
(DOMWindow::document): New implementation.
(DOMWindow::getComputedStyle): Stub.
(DOMWindow::getMatchedCSSRules): Stub.
(DOMWindow::devicePixelRatio): Stub.
(DOMWindow::addEventListener): New implementation.
(DOMWindow::removeEventListener): New implementation.
(DOMWindow::dispatchEvent): New implementation.
(DOMWindow::DOMWindow): New implementation.
(DOMWindow::~DOMWindow): New implementation.
(DOMWindow::createInstance): New implementation.
* DOMCoreClasses.h: Add new DOMWindow class and declarations.
(DOMWindow::AddRef): New declaration.
(DOMWindow::Release): New declaration.
(DOMWindow::throwException): New declaration.
(DOMWindow::callWebScriptMethod): New declaration.
(DOMWindow::evaluateWebScript): New declaration.
(DOMWindow::removeWebScriptKey): New declaration.
(DOMWindow::stringRepresentation): New declaration.
(DOMWindow::webScriptValueAtIndex): New declaration.
(DOMWindow::setWebScriptValueAtIndex): New declaration.
(DOMWindow::setException): New declaration.
(DOMWindow::window): New declaration.
* DOMEventsClasses.cpp: Add new WebEventListener and implementation.
(DOMEventListener::handleEvent): New implementation.
(WebEventListener::WebEventListener): New implementation.
(WebEventListener::~WebEventListener): New implementation.
(WebEventListener::operator==): New implementation.
(WebEventListener::handleEvent): New implementation.
(WebEventListener::create): New implementation.
* DOMEventsClasses.h: Add new WebEventListener class declaration.
* Interfaces/IWebFrame.idl: Add new DOMWindow accessor to the
main Web Frame interface.
* WebFrame.cpp: Add implementation of new DOMWindow creation method.
(WebFrame::DOMWindow):
* WebFrame.h: Add DOMWindow declaration.
2011-05-20 Simon Fraser <simon.fraser@apple.com>
Reviewed by Sam Weinig.
numberOfActiveAnimations() can include animations from documents in the page cache
https://bugs.webkit.org/show_bug.cgi?id=53641
Pass the Frame's document as the one to count animations on.
* WebFrame.cpp:
(WebFrame::numberOfActiveAnimations):
2011-05-20 Jer Noble <jer.noble@apple.com>
Reviewed by Maciej Stachowiak.
Win: non-full-screen content is briefly seen when entering full-screen mode (and vice versa)
https://bugs.webkit.org/show_bug.cgi?id=61108
* WebView.cpp:
(WebView::fullScreenClientForceRepaint): Repaint the view and immediately notify the
full screen controller.
* WebView.h:
2011-05-13 Jon Lee <jonlee@apple.com>
Reviewed by Simon Fraser.
Can't horizontally scroll iframes and overflow because wheel events are always accepted
https://bugs.webkit.org/show_bug.cgi?id=60779
* WebCoreSupport/WebChromeClient.h:
(WebChromeClient::shouldRubberBandInDirection): Default impl of new ChromeClient method
(WebChromeClient::numWheelEventHandlersChanged): Default impl of new ChromeClient method
2011-05-13 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Prune #includes from FrameView.h (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=60748
- Update files that were depending on FrameView.h #including Frame.h or
Page.h.
* WebCoreSupport/WebChromeClient.cpp:
* WebCoreSupport/WebDragClient.cpp:
* WebCoreSupport/WebFrameLoaderClient.cpp:
* WebFrame.cpp:
(WebFrame::setPrinting):
* WebView.cpp:
2011-05-12 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Barth.
Enable OwnPtr strict mode in PluginHalter
https://bugs.webkit.org/show_bug.cgi?id=60681
* WebView.cpp:
(WebView::initWithFrame):
2011-05-12 Adam Roben <aroben@apple.com>
A little gtest cleanup after r86287
* WebKit.vcproj/WebKit.sln:
- Move gtest into the Tools folder
- Make gtest build just before TestWebKitAPIGenerated
- Use gtest's new Debug_All and Production configurations as appropriate
2011-05-12 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Darin Adler.
String operator+ reallocates unnecessarily when concatting > 2 strings
https://bugs.webkit.org/show_bug.cgi?id=58420
Provide a faster String append operator. See Source/JavaScriptCore/ChangeLog for details.
* AccessibleBase.cpp:
(AccessibleBase::get_accKeyboardShortcut): Explicitely cast to Strings first, so operator BString() can be invoked.
2011-05-11 Dmitry Lomov <dslomov@google.com>
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=59561
Switch TestWebKitAPI to GTest
Fixes Makefiles and WinCairo build as well
* WebKit.vcproj/WebKit.sln:
2011-05-11 Jessie Berlin <jberlin@apple.com>
Reviewed by Steve Falkenburg.
[Windows WebKit2] Use cookies set in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=60274
* WebView.cpp:
(WebView::setCacheModel):
Pass 0 to wkCopyFoundationCacheDirectory so that it uses the default session.
2011-05-11 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r86255.
http://trac.webkit.org/changeset/86255
https://bugs.webkit.org/show_bug.cgi?id=60660
REGRESSION (r86255): Lots of tests crashing in
CFWriteStreamCreateWithAllocatedBuffers on Windows 7 Release
(WebKit2 Tests) (Requested by aroben on #webkit).
* WebView.cpp:
(WebView::setCacheModel):
2011-05-11 Jessie Berlin <jberlin@apple.com>
Reviewed by Steve Falkenburg.
[Windows WebKit2] Use cookies set in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=60274
* WebView.cpp:
(WebView::setCacheModel):
Pass 0 to wkCopyFoundationCacheDirectory so that it uses the default session.
2011-05-09 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r86108.
http://trac.webkit.org/changeset/86108
https://bugs.webkit.org/show_bug.cgi?id=60533
Broke makefile based builds and Cairo (Requested by weinig on
#webkit).
* WebKit.vcproj/WebKit.sln:
2011-05-09 Dmitry Lomov <dslomov@google.com>
Reviewed by Sam Weinig.
Switch TestWebKitAPI to GTest
https://bugs.webkit.org/show_bug.cgi?id=59561
* WebKit.vcproj/WebKit.sln:
2011-05-07 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r86016.
http://trac.webkit.org/changeset/86016
https://bugs.webkit.org/show_bug.cgi?id=60445
caused crashes on the WK2 Windows bots (Requested by
jessieberlin on #webkit).
* WebView.cpp:
(WebView::setCacheModel):
2011-05-07 Jessie Berlin <jberlin@apple.com>
Reviewed by Steve Falkenburg.
[Windows WebKit2] Use cookies set in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=60274
* WebView.cpp:
(WebView::setCacheModel):
Pass 0 to wkCopyFoundationCacheDirectory so that it uses the default session.
2011-05-06 Adam Roben <aroben@apple.com>
Touch WebKit.idl to fix the build
I needed this on my own machine. Maybe others will need it, too.
* Interfaces/WebKit.idl:
2011-05-04 Philippe Normand <pnormand@igalia.com>
Reviewed by Dimitri Glazkov.
Implement LayoutTestController::pseudoShadowId()
https://bugs.webkit.org/show_bug.cgi?id=60034
* DOMCoreClasses.cpp:
(DOMElement::shadowPseudoId):
* DOMCoreClasses.h:
2011-05-05 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Rename SelectionController to FrameSelection
https://bugs.webkit.org/show_bug.cgi?id=60234
* WebView.cpp:
2011-05-04 Ryosuke Niwa <rniwa@webkit.org>
Windows build fix attempt after r85823
* WebCoreSupport/WebChromeClient.h:
(WebChromeClient::webView):
* WebView.cpp:
(kit):
2011-05-04 Cris Neckar <cdn@chromium.org>
Reviewed by Adam Barth.
Expose WebView directly through ChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=49902
* WebCoreSupport/WebChromeClient.h:
(WebChromeClient::webView):
2011-05-04 Tao Bai <michaelbai@chromium.org>
Reviewed by David Kilzer.
Populate touch-icon url to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=59143
Respect the interface change in FrameLoaderClient.
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDidChangeIcons):
* WebCoreSupport/WebFrameLoaderClient.h:
2011-05-02 Jer Noble <jer.noble@apple.com>
Reviewed by Adam Roben.
Implement FULLSCREEN_API on Windows, Part 3: WebKit2
https://bugs.webkit.org/show_bug.cgi?id=59845
Implementation of WebFullScreenController has been moved into WebCore, and
required virutal functions of WebFullScreenControllerClient have been added to
WebView. These functions are mostly simple accessors of existing ivars, but
m_fullScreenElement and its accessors have also been added to WebView.
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::enterFullScreenForElement):
* WebFullScreenController.cpp: Removed.
* WebKit.vcproj/WebKit.vcproj:
* WebView.cpp:
(WebView::setFullScreenElement): Added accessor.
(WebVIew::fullScreenElement): Ditto.
(WebView::fullScreenClientWindow): Ditto.
(WebView::fullScreenClientParentWindow): Ditto.
(WebView::fullScreenClientSetParentWindow): Ditto.
(WebView::fullScreenClientWillEnterFullScreen): Pass through to Document.
(WebView::fullScreenClientDidEnterFullScreen): Ditto.
(WebView::fullScreenClientWillExitFullScreen): Ditto.
(WebView::fullScreenClientDidExitFullScreen): Ditto.
* WebView.h:
2011-05-03 Brian Weinstein <bweinstein@apple.com>
Reviewed by Steve Falkenburg.
REGRESSION(r84990): Nightly builds don't launch on Windows
https://bugs.webkit.org/show_bug.cgi?id=60081
<rdar://problem/9358635>
Fix nightlies on Window by moving the layered window functions to the bottom
of IWebViewPrivate and touch WebKit.idl to make sure Interfaces rebuild.
* Interfaces/IWebViewPrivate.idl: Move functions added in r84990 to the bottom of the file.
* Interfaces/WebKit.idl: Touch to force a rebuild.
2011-05-03 David Kilzer <ddkilzer@apple.com>
<http://webkit.org/b/59838> Implement HTTP pipelining for CoreFoundation-based networking
Reviewed by Antti Koivisto.
* Interfaces/IWebViewPrivate.idl:
(IWebViewPrivate::httpPipeliningEnabled): Added declaration.
(IWebViewPrivate::setHTTPPipeliningEnabled): Added declaration.
* WebView.cpp:
(WebView::httpPipeliningEnabled): Added.
(WebView::setHTTPPipeliningEnabled): Added.
* WebView.h:
(WebView::httpPipeliningEnabled): Added declaration.
(WebView::setHTTPPipeliningEnabled): Added declaration.
2011-05-03 Adam Roben <aroben@apple.com>
Add some missing virtual keywords on derived-class destructors
Darin Adler noticed one, I noticed the other. This doesn't change the generated code; it
just matches our style of explicitly marking overrides "virtual".
* WebCoreSupport/WebInspectorClient.h: Made the WebInspectorClient and
WebInspectorFrontendClient destructors explicitly virtual.
2011-05-03 Adam Roben <aroben@apple.com>
Fix most strict PassOwnPtr violations on Windows
Fixes <http://webkit.org/b/60025> Windows should (almost) build with strict PassOwnPtr
enabled
Reviewed by Anders Carlsson.
* WebCoreSupport/WebInspectorClient.h: Made the destructor public, which is required now
that this type is put into a PassOwnPtr. (Previously, only
WebCore::InspectorFrontendClientLocal was put into a [Pass]OwnPtr.)
* FullscreenVideoController.cpp:
* WebCoreSupport/WebFrameLoaderClient.cpp:
* WebCoreSupport/WebInspectorClient.cpp:
* WebHistory.cpp:
* WebHistoryItem.cpp:
* WebView.cpp:
2011-05-01 Sam Weinig <sam@webkit.org>
Fix windows build.
* WebFrame.cpp:
2011-05-01 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Barth.
Fix OwnPtr strict issues in windows build
https://bugs.webkit.org/show_bug.cgi?id=59878
* FullscreenVideoController.cpp:
(FullscreenVideoController::FullscreenVideoController):
(FullscreenVideoController::createHUDWindow):
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::highlight):
* WebElementPropertyBag.cpp:
(WebElementPropertyBag::WebElementPropertyBag):
* WebNodeHighlight.cpp:
(WebNodeHighlight::update):
* WebNotificationCenter.cpp:
(WebNotificationCenter::WebNotificationCenter):
* WebView.cpp:
(WebView::close):
(WebView::paint):
(WebView::handleMouseEvent):
(WebView::registerEmbeddedViewMIMEType):
2011-04-29 Jer Noble <jer.noble@apple.com>
Reviewed by Adam Roben.
Implement FULLSCREEN_API on Windows, Part 2: WebKit
https://bugs.webkit.org/show_bug.cgi?id=59785
Initial implementation of full screen API on windows. No animation
occurs when entering or exiting full screen. Re-use existing window
classes (MediaPlayerPrivateFullscreenWindow) to host the webView.
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::supportsFullScreenForElement): Call into WebView.
(WebChromeClient::enterFullScreenForElement): Call into WebFullScreenController.
(WebChromeClient::exitFullScreenForElement): Ditto.
* WebFullScreenController.cpp: Added.
(WebFullScreenController::Private::Private): Private data storage class.
(WebFullScreenController::Private::~Private):
(WebFullScreenController::Private::fullscreenClientWndProc): Handle window
message for full screen window.
(WebFullScreenController::WebFullScreenController):
(WebFullScreenController::~WebFullScreenController):
(WebFullScreenController::setElement): Added.
(WebFullScreenController::element): Added.
(WebFullScreenController::isFullScreen): Added.
(WebFullScreenController::enterFullScreen): Create and display full screen
window, moving webView as child window.
(WebFullScreenController::exitFullScreen): Destroy full screen window and
move webView back where we found it.
* WebFullScreenController.h: Added.
* WebKit.vcproj/WebKit.vcproj:
* WebView.cpp:
(WebView::keyDown): Handle the ESC key.
(WebView::notifyPreferencesChanged):
(WebView::supportsFullScreenForElement): Do not support full screen if
full screen preference is disabled, or if keyboard access is requested.
(WebView::isFullScreen): Added.
(WebView::fullScreenController): Added.
* WebView.h:
2011-04-28 Jer Noble <jer.noble@apple.com>
Reviewed by Jon Honeycutt.
Implement FULLSCREEN_API on Windows, Part 1: Stubs
https://bugs.webkit.org/show_bug.cgi?id=59778
Create all the stubs necessary to for enabling FULLSCREEN_API
on Windows. This includes the COM interfaces for preferences and
for overriding full screen behavior in a UI Delegate.
* Interfaces/IWebPreferencesPrivate.idl: Add functions for enabling
full screen preference.
* Interfaces/IWebUIDelegatePrivate.idl: Add functions for overriding
full screen behavior.
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::supportsFullScreenForElement): Added.
(WebChromeClient::enterFullScreenForElement): Added.
(WebChromeClient::exitFullScreenForElement): Added.
* WebCoreSupport/WebChromeClient.h:
* WebPreferenceKeysPrivate.h: Added WebKitFullScreenEnable key.
* WebPreferences.cpp:
(WebPreferences::isFullScreenEnabled): Added. Implements function
defined in IWebUIDelegatePrivate.
(WebPreferences::setFullScreenEnabled): Ditto.
* WebPreferences.h:
2011-04-28 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove WML
https://bugs.webkit.org/show_bug.cgi?id=59678
Remove WML-related enumeration.
* Interfaces/IWebFramePrivate.idl:
2011-04-26 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
Implement a transparent WebView under Windows. This feature
allows the user to create small web-based applications, similar
to the dashboard on Mac OS X.
https://bugs.webkit.org/show_bug.cgi?id=58300
* Interfaces/IWebViewPrivate.idl: Add new set/get accessors to
change the state of a WebView into a Layered Window, or back
into a standard window.
* Interfaces/WebKit.idl: touch to force clean build
* WebView.cpp:
(WebView::WebView): Set layered window state in constructor.
(WebView::updateBackingStore): Cleanup old bitmap when finished.
(WebView::performLayeredWindowUpdate): New method to do the work
of calling ::UpdateLayeredWindow for the WebView with proper
alpha blending.
(WebView::paint): Small change to prevent accelerated compositing
when using a layered window. DirectX is not compatible with
::UpdateLayeredWindow (at least currently).
(WebView::WebViewWndProc): Adjust main window procedure to avoid
painting a default background on a layered window (this is handled
by Windows during compositing), and to deal with paint messages
properly in the layered window case.
(WebView::active): The layered window is not a child window,
so the active state logic is slightly different.
(WebView::setUsesLayeredWindow): New set method for layered stated.
When called, it will convert a WebView into a Layered Window.
(WebView::usesLayeredWindow): Accessor
* WebView.h:
(WebView::setUsesLayeredWindow): Declare new accessor
(WebView::usesLayeredWindow): Declare new accessor
2011-04-21 Ryosuke Niwa <rniwa@webkit.org>
Windows build fix.
* WebCoreSupport/WebEditorClient.h:
2011-04-21 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Sam Weinig.
Add Frame* to the argument lists of canCopyCut and canPaste
https://bugs.webkit.org/show_bug.cgi?id=59153
* WebCoreSupport/WebEditorClient.cpp:
(WebEditorClient::canCopyCut):
(WebEditorClient::canPaste):
* WebCoreSupport/WebEditorClient.h:
2011-04-20 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Martin Robinson.
Provide missing implementation of WebMutableURLRequest::mutableCopy.
This was preventing DumpRenderTree from working properly under
the WinCairo port.
https://bugs.webkit.org/show_bug.cgi?id=59034
* WebMutableURLRequest.cpp:
(WebMutableURLRequest::mutableCopy): Implement cURL version of the
copy operation.
2011-04-19 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Rename lengthReceived to encodedDataLength/dataLength
https://bugs.webkit.org/show_bug.cgi?id=58883
* WebCoreSupport/WebFrameLoaderClient.h:
2011-04-18 Timothy Hatcher <timothy@apple.com>
Remove the two commands that make en.lproj and copy Localizable.strings.
Rubber-stamped by Adam Roben.
* WebKit.vcproj/WebKitLibPostBuild.cmd:
2011-04-18 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Roben.
Include <WebCore/COMPtr.h> instead of "COMPtr.h"
https://bugs.webkit.org/show_bug.cgi?id=58744
* DOMCoreClasses.cpp:
* DOMHTMLClasses.cpp:
* WebActionPropertyBag.cpp:
* WebBackForwardList.cpp:
* WebCoreSupport/WebGeolocationClient.h:
* WebDownload.h:
* WebDropSource.h:
* WebFrame.cpp:
* WebHistoryItem.cpp:
* WebIconDatabase.cpp:
* WebNavigationData.h:
* WebPreferences.cpp:
* WebResource.h:
* WebURLAuthenticationChallenge.cpp:
* WebURLAuthenticationChallengeSender.cpp:
* WebURLAuthenticationChallengeSenderCFNet.cpp:
* WebURLAuthenticationChallengeSenderCurl.cpp:
* WebView.h:
2011-04-17 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Barth.
Rename PLATFORM(CG) to USE(CG)
https://bugs.webkit.org/show_bug.cgi?id=58729
* WebFrame.cpp:
(WebFrame::spoolPages):
* WebFrame.h:
* WebPreferences.cpp:
(WebPreferences::setFontSmoothing):
(WebPreferences::setFontSmoothingContrast):
* WebView.cpp:
(systemParameterChanged):
2011-04-16 Sam Weinig <sam@webkit.org>
Reviewed by Simon Fraser.
Windows should use WebCore localized strings
<rdar://problem/9119405>
https://bugs.webkit.org/show_bug.cgi?id=58733
* WebCoreSupport/WebEditorClient.cpp:
(undoNameForEditAction):
(WebEditorClient::registerCommandForUndo):
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
* WebURLResponse.cpp:
(CFHTTPMessageCopyLocalizedShortDescriptionForStatusCode):
(WebURLResponse::localizedStringForStatusCode):
Change to use WEB_UI_STRING.
* WebCoreSupport/WebPlatformStrategies.cpp:
* WebCoreSupport/WebPlatformStrategies.h:
Remove the localization strategy in favor of using the default one.
2011-04-16 Patrick Gansterer <paroga@webkit.org>
Reviewed by Eric Seidel.
Rename PLATFORM(CAIRO) to USE(CAIRO)
https://bugs.webkit.org/show_bug.cgi?id=55192
* WebFrame.cpp:
(WebFrame::spoolPages):
* WebFrame.h:
2011-04-14 Adam Roben <aroben@apple.com>
Replace some known-to-fail assertions with FIXMEs
These assertions get hit during various layout tests. They indicate that we're sometimes
doing some extra work when a page goes into accelerated compositing mode, but otherwise
there's no bad effect.
See <http://webkit.org/b/58539> for more details.
Rubber-stamped by John Sullivan.
* WebView.cpp:
(WebView::paintIntoBackingStore):
(WebView::paintIntoWindow):
Replaced assertions with FIXMEs.
2011-04-13 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
Allow setting composited backing stores for scrollbars and scroll corners
https://bugs.webkit.org/show_bug.cgi?id=57202
Update WebScrollBar to reflect ScrollableArea interface changes.
* WebScrollBar.h:
(WebScrollBar::invalidateScrollCornerRect):
(WebScrollBar::scrollCornerPresent):
(WebScrollBar::scrollCornerRect):
2011-04-12 Alice Liu <alice.liu@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=58292
Provide new setting to allow site icon loading despite disabling automatic image loading in general.
* Interfaces/IWebPreferencesPrivate.idl: Added prefs.
* Interfaces/WebKit.idl: Touch file to force autogeneration
* WebPreferenceKeysPrivate.h: Add preference key.
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings): Initialize setting to false.
(WebPreferences::setLoadsSiteIconsIgnoringImageLoadingPreference): Added setter
(WebPreferences::loadsSiteIconsIgnoringImageLoadingPreference): Added getter
* WebPreferences.h:
* WebView.cpp:
(WebView::notifyPreferencesChanged): Add to settings that get propagated upon changes.
2011-04-11 Alexey Proskuryakov <ap@apple.com>
Reviewed by Maciej Stachowiak.
WebKit2: Cannot use Ctrl-Delete as a custom keyboard shortcut
https://bugs.webkit.org/show_bug.cgi?id=58265
<rdar://problem/9221468>
* WebView.cpp: (WebView::keyDown): Removed special handling of Backspace, which is unnecessary
now that WebCore implements it.
2011-04-06 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
WebKit2: Support Windows 7 Gestures
https://bugs.webkit.org/show_bug.cgi?id=49824
<rdar://problem/8689728>
Move WindowsTouch.h from WebKit/win to WebCore/platform/win, so it can be
used in both WebKit and WebKit2.
* WebKit.vcproj/WebKit.vcproj: Remove WindowsTouch.h.
* WebView.cpp: Include WindowsTouch.h from WebCore instead of WebKit.
* WindowsTouch.h: Removed.
2011-04-05 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[Cairo] Better separate the concerns of GraphicsContextCairo
https://bugs.webkit.org/show_bug.cgi?id=55150
* WebFrame.cpp:
(hdcFromContext): Modify this method to take PlatformContextCairo
instead of a cairo_t.
(WebFrame::spoolPage): Update to reflect new platform context.
(WebFrame::spoolPages): Ditto.
* WebFrame.h: Ditto.
2011-04-04 MORITA Hajime <morrita@google.com>
Reviewed by Ryosuke Niwa.
[Refactoring] SpellCheckingResult should be replaced with TextCheckingResult
https://bugs.webkit.org/show_bug.cgi?id=56085
* WebCoreSupport/WebEditorClient.h:
(WebEditorClient::requestCheckingOfString):
2011-04-04 Alexey Proskuryakov <ap@apple.com>
Reviewed by Dan Bernstein.
REGRESSION (WebKit2): Caps-Lock indicator sometimes doesn't appear in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=51230
<rdar://problem/8780989>
* WebView.cpp: (WebView::keyDown): Moved Caps Lock handling from WebKits to WebCore,
because WebKit shouldn't be smart.
2011-04-04 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Remove unused AnalyzeWithLargeStack code from Windows build files
https://bugs.webkit.org/show_bug.cgi?id=57771
This was used for us to build with prefast automatically,
but it is out-of-date and hasn't been used for some time.
Removing completely for now.
* WebKit.vcproj/WebKitLibPreBuild.cmd:
2011-04-01 Adam Roben <aroben@apple.com>
Remove the WebView's "this" pointer from its HWND when WM_DESTROY is received
This will ensure we don't try to process any window messages after the window has been
destroyed.
Covered by existing tests.
Fixes <http://webkit.org/b/55054>.
Reviewed by Steve Falkenburg and John Sullivan.
* WebView.cpp:
(WebView::setIsBeingDestroyed): Moved here from the header file, and added a call to clear
out the this pointer from the HWND.
(WebView::WebViewWndProc): Changed a runtime check into an assertion.
* WebView.h: Moved setIsBeingDestroyed from here to the .cpp file.
2011-03-31 Evan Martin <evan@chromium.org>
Reviewed by Eric Seidel.
<title> should support dir attribute
https://bugs.webkit.org/show_bug.cgi?id=50961
Update to new FrameLoaderClient interface.
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDidReceiveTitle):
* WebCoreSupport/WebFrameLoaderClient.h:
2011-03-30 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Share most vsprops between Release and Production builds in releaseproduction.vsprops
https://bugs.webkit.org/show_bug.cgi?id=57508
* WebKit.vcproj/InterfacesProduction.vsprops:
* WebKit.vcproj/InterfacesRelease.vsprops:
* WebKit.vcproj/InterfacesReleaseCairoCFLite.vsprops:
* WebKit.vcproj/WebKitGUIDProduction.vsprops:
* WebKit.vcproj/WebKitGUIDRelease.vsprops:
* WebKit.vcproj/WebKitGUIDReleaseCairoCFLite.vsprops:
* WebKit.vcproj/WebKitLibProduction.vsprops:
* WebKit.vcproj/WebKitLibRelease.vsprops:
* WebKit.vcproj/WebKitLibReleaseCairoCFLite.vsprops:
2011-03-30 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Update Windows production build logic for new production configurations
https://bugs.webkit.org/show_bug.cgi?id=57494
* WebKit.vcproj/InterfacesProduction.vsprops:
* WebKit.vcproj/WebKit.make:
* WebKit.vcproj/WebKitGUIDProduction.vsprops:
* WebKit.vcproj/WebKitLibProduction.vsprops:
2011-03-30 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Rename Windows configuration Release_LTCG to Production for clarity
https://bugs.webkit.org/show_bug.cgi?id=57465
* WebKit.vcproj/Interfaces.vcproj:
* WebKit.vcproj/InterfacesProduction.vsprops: Copied from Source/WebKit/win/WebKit.vcproj/InterfacesReleaseLTCG.vsprops.
* WebKit.vcproj/InterfacesReleaseLTCG.vsprops: Removed.
* WebKit.vcproj/WebKit.sln:
* WebKit.vcproj/WebKit.submit.sln:
* WebKit.vcproj/WebKit.vcproj:
* WebKit.vcproj/WebKitGUID.vcproj:
* WebKit.vcproj/WebKitGUIDProduction.vsprops: Copied from Source/WebKit/win/WebKit.vcproj/WebKitGUIDReleaseLTCG.vsprops.
* WebKit.vcproj/WebKitGUIDReleaseLTCG.vsprops: Removed.
* WebKit.vcproj/WebKitLibProduction.vsprops: Copied from Source/WebKit/win/WebKit.vcproj/WebKitLibReleaseLTCG.vsprops.
* WebKit.vcproj/WebKitLibReleaseLTCG.vsprops: Removed.
2011-03-29 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Roben.
[WIN] Remove unused GEN_DOMObject files
https://bugs.webkit.org/show_bug.cgi?id=57370
* GEN_DOMObject.cpp: Removed.
* GEN_DOMObject.h: Removed.
2011-03-29 Steve Falkenburg <sfalken@apple.com>
More build fix.
* WebCoreSupport/WebPlatformStrategies.h:
2011-03-29 Steve Falkenburg <sfalken@apple.com>
Build fix.
* WebCoreSupport/WebPlatformStrategies.cpp:
(WebPlatformStrategies::contextMenuItemTagLookUpInDictionary):
2011-03-29 Patrick Gansterer <paroga@webkit.org>
Unreviewed. Try to fix Windows build.
* DOMEventsClasses.cpp: Added initguid.h again.
2011-03-29 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Roben.
[WIN] Cleanup includes in WebKit files
https://bugs.webkit.org/show_bug.cgi?id=57381
Add missing includes to fix build without precompiled header.
Also fix paths in #include statements (e.g. WTF -> wtf).
* AccessibleBase.h:
* AccessibleDocument.h: Replace using statement with a qualified name.
* CFDictionaryPropertyBag.h:
* DOMEventsClasses.cpp:
* DOMHTMLClasses.h:
* DefaultDownloadDelegate.cpp:
* DefaultDownloadDelegate.h:
* DefaultPolicyDelegate.cpp:
* DefaultPolicyDelegate.h:
* WebCoreSupport/EmbeddedWidget.h:
* WebCoreSupport/WebInspectorDelegate.h:
* WebDataSource.h:
* WebDatabaseManager.h:
* WebElementPropertyBag.h:
* WebFramePolicyListener.h:
* WebGeolocationPolicyListener.h:
* WebHistory.h:
* WebKitClassFactory.h:
* WebScriptWorld.h:
* WebSerializedJSValue.h:
* WebUserContentURLPattern.h:
2011-03-29 Steve Falkenburg <sfalken@apple.com>
Reviewed by Darin Adler.
Use per-configuration vsprops in WebKit to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
https://bugs.webkit.org/show_bug.cgi?id=57383
Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
the IDE. To avoid this, add a separate vsprops file for each project configuration that
contains the required inherited property sheets.
* WebKit.vcproj/Interfaces.vcproj:
* WebKit.vcproj/InterfacesDebug.vsprops: Added.
* WebKit.vcproj/InterfacesDebugAll.vsprops: Added.
* WebKit.vcproj/InterfacesDebugCairoCFLite.vsprops: Added.
* WebKit.vcproj/InterfacesRelease.vsprops: Added.
* WebKit.vcproj/InterfacesReleaseCairoCFLite.vsprops: Added.
* WebKit.vcproj/InterfacesReleaseLTCG.vsprops: Added.
* WebKit.vcproj/WebKit.vcproj:
* WebKit.vcproj/WebKitGUID.vcproj:
* WebKit.vcproj/WebKitGUIDDebug.vsprops: Added.
* WebKit.vcproj/WebKitGUIDDebugAll.vsprops: Added.
* WebKit.vcproj/WebKitGUIDDebugCairoCFLite.vsprops: Added.
* WebKit.vcproj/WebKitGUIDRelease.vsprops: Added.
* WebKit.vcproj/WebKitGUIDReleaseCairoCFLite.vsprops: Added.
* WebKit.vcproj/WebKitGUIDReleaseLTCG.vsprops: Added.
* WebKit.vcproj/WebKitLibDebug.vsprops: Added.
* WebKit.vcproj/WebKitLibDebugAll.vsprops: Added.
* WebKit.vcproj/WebKitLibDebugCairoCFLite.vsprops: Added.
* WebKit.vcproj/WebKitLibRelease.vsprops: Added.
* WebKit.vcproj/WebKitLibReleaseCairoCFLite.vsprops: Added.
* WebKit.vcproj/WebKitLibReleaseLTCG.vsprops: Added.
2011-03-29 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Roben.
Remove #pragma warning push and pop statements
https://bugs.webkit.org/show_bug.cgi?id=57198
We do not need to disable warnings via #pragma since we started
compiling WebCore with the same compiler warnings flags as WebKit.
* DOMCSSClasses.cpp:
* DOMCoreClasses.cpp:
* DOMEventsClasses.cpp:
* DOMHTMLClasses.cpp:
* DefaultDownloadDelegate.cpp:
* DefaultPolicyDelegate.cpp:
* MarshallingHelpers.cpp:
* WebActionPropertyBag.cpp:
* WebActionPropertyBag.h:
* WebCache.cpp:
* WebCoreSupport/WebDragClient.cpp:
* WebCoreSupport/WebEditorClient.cpp:
* WebCoreSupport/WebEditorClient.h:
* WebCoreSupport/WebFrameLoaderClient.cpp:
* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebInspectorClient.cpp:
* WebDocumentLoader.h:
* WebDownload.cpp:
* WebDownloadCFNet.cpp:
* WebDownloadCurl.cpp:
* WebElementPropertyBag.cpp:
* WebError.cpp:
* WebError.h:
* WebFrame.cpp:
* WebFrame.h:
* WebFramePolicyListener.cpp:
* WebFramePolicyListener.h:
* WebHistory.cpp:
* WebHistoryItem.cpp:
* WebIconDatabase.cpp:
* WebIconDatabase.h:
* WebInspector.cpp:
* WebJavaScriptCollector.cpp:
* WebKitGraphics.cpp:
* WebKitSystemBits.cpp:
* WebLocalizableStrings.cpp:
* WebMutableURLRequest.cpp:
* WebMutableURLRequest.h:
* WebNodeHighlight.cpp:
* WebNodeHighlight.h:
* WebNotificationCenter.cpp:
* WebResource.cpp:
* WebResource.h:
* WebScrollBar.cpp:
* WebScrollBar.h:
* WebURLAuthenticationChallenge.cpp:
* WebURLAuthenticationChallenge.h:
* WebURLAuthenticationChallengeSender.cpp:
* WebURLAuthenticationChallengeSenderCFNet.cpp:
* WebURLAuthenticationChallengeSenderCurl.cpp:
* WebURLCredential.cpp:
* WebURLCredential.h:
* WebURLProtectionSpace.cpp:
* WebURLProtectionSpace.h:
* WebURLResponse.cpp:
* WebURLResponse.h:
2011-03-29 Brent Fulgham <bfulgham@webkit.org>
Unreviewed build fix after r82247.
* WebMutableURLRequest.cpp: The new CertificateCFWin routines
are not CFNetwork-specific. All CF-based ports can use them.
2011-03-29 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Roben.
[WIN] Use WCHAR instead of TCHAR
https://bugs.webkit.org/show_bug.cgi?id=57191
We always use the UNICODE versions of windows functions, so
the usage of TCHAR makes no sense and mixing them is bad style.
* DefaultDownloadDelegate.cpp:
* WebCoreSupport/WebChromeClient.cpp:
* WebCoreSupport/WebContextMenuClient.cpp:
* WebCoreSupport/WebInspectorClient.cpp:
* WebKitDLL.cpp:
* WebNotificationCenter.cpp:
* WebPreferences.cpp:
* WebURLResponse.cpp:
* WebView.cpp:
2011-03-29 Jeff Miller <jeffm@apple.com>
Reviewed by Jon Honeycutt.
Add WebCore::copyCertificateToData() on Windows
https://bugs.webkit.org/show_bug.cgi?id=57296
Remove duplicate code that implemented this functionality in WebMutableURLRequest.cpp and use WebCore::copyCertificateToData() instead.
* WebMutableURLRequest.cpp:
(WebMutableURLRequest::setClientCertificate): Use WebCore::copyCertificateToData().
2011-03-28 Patrick Gansterer <paroga@webkit.org>
Reviewed by Adam Roben.
[WIN] Remove unused DOMCreateInstance files
https://bugs.webkit.org/show_bug.cgi?id=57193
* DOMCreateInstance.cpp: Removed.
* DOMCreateInstance.h: Removed.
2011-03-28 Adele Peterson <adele@apple.com>
Build fix.
* WebFrame.cpp: (WebFrame::hasSpellingMarker):
Call new selectionStartHasMarkerFor method instead of selectionStartHasSpellingMarkerFor.
2011-03-28 Jeff Miller <jeffm@apple.com>
Reviewed by Adam Roben.
Include certificate when sending a WebCore::ResourceError to UI process on Windows
https://bugs.webkit.org/show_bug.cgi?id=57195
Rename callers of wkGetSSLPeerCertificateData() to use wkGetSSLPeerCertificateDataBytePtr(), since it returns a void*.
* WebError.cpp:
(WebError::sslPeerCertificate):
* WebURLResponse.cpp:
(WebURLResponse::sslPeerCertificate):
2011-03-28 Darin Adler <darin@apple.com>
Set eol-style to native on more files. I noticed the last check-in had an entire file
changing because of an EOL style change, and setting this property prevents that from
happening in future. We may want to do this systematically for more of WebKit later.
* AccessibleBase.cpp: Added property svn:eol-style.
* AccessibleBase.h: Added property svn:eol-style.
* AccessibleDocument.cpp: Added property svn:eol-style.
* AccessibleDocument.h: Added property svn:eol-style.
* AccessibleImage.cpp: Added property svn:eol-style.
* AccessibleImage.h: Added property svn:eol-style.
* COMVariantSetter.h: Added property svn:eol-style.
* FullscreenVideoController.cpp: Added property svn:eol-style.
* FullscreenVideoController.h: Added property svn:eol-style.
* WebCoreSupport/EmbeddedWidget.cpp: Added property svn:eol-style.
* WebCoreSupport/EmbeddedWidget.h: Added property svn:eol-style.
* WebCoreSupport/WebDesktopNotificationsDelegate.cpp: Added property svn:eol-style.
* WebCoreSupport/WebDesktopNotificationsDelegate.h: Added property svn:eol-style.
* WebCoreSupport/WebFrameLoaderClient.cpp: Added property svn:eol-style.
* WebCoreSupport/WebInspectorDelegate.cpp: Added property svn:eol-style.
* WebCoreSupport/WebInspectorDelegate.h: Added property svn:eol-style.
* WebCoreSupport/WebPlatformStrategies.cpp: Added property svn:eol-style.
* WebCoreSupport/WebPlatformStrategies.h: Added property svn:eol-style.
* WebCoreSupport/WebPluginHalterClient.cpp: Added property svn:eol-style.
* WebCoreSupport/WebPluginHalterClient.h: Added property svn:eol-style.
2011-03-28 Patrick Gansterer <paroga@webkit.org>
Unreviewed build fix.
* COMPropertyBag.h: Added missing include.
* WebKitCOMAPI.h: Ditto.
* WebCoreSupport/WebFrameLoaderClient.h: Added missing forward declaration.
2011-03-25 Sam Weinig <sam@webkit.org>
Reviewed by Jon Honeycutt.
WebScrollBar not updating when calling WebScrollBar::setValue.
<rdar://problem/9143871>
* WebScrollBar.cpp:
(WebScrollBar::setValue):
Call scrollToOffsetWithoutAnimation to actually update the scroll position.
2011-03-25 Andy Estes <aestes@apple.com>
Reviewed by Adele Peterson.
REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
https://bugs.webkit.org/show_bug.cgi?id=49016
Update objectContentType() implementation to handle the
shouldPreferPlugInsForImages flag.
* WebFrame.cpp:
(WebFrame::objectContentType):
* WebFrame.h:
2011-03-24 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r81916 and r81917.
http://trac.webkit.org/changeset/81916
http://trac.webkit.org/changeset/81917
https://bugs.webkit.org/show_bug.cgi?id=57071
broke a test on platforms that do not have QuickTime installed
(Requested by estes on #webkit).
* WebFrame.cpp:
(WebFrame::objectContentType):
* WebFrame.h:
2011-03-24 Andy Estes <aestes@apple.com>
Reviewed by Darin Adler.
REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
https://bugs.webkit.org/show_bug.cgi?id=49016
Update objectContentType() implementation to handle the
shouldPreferPlugInsForImages flag.
* WebFrame.cpp:
(WebFrame::objectContentType):
* WebFrame.h:
2011-03-23 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
Change IconDatabase opening to allow for arbitrary filenames
https://bugs.webkit.org/show_bug.cgi?id=56977
* WebIconDatabase.cpp:
(WebIconDatabase::startUpIconDatabase):
2011-03-22 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
<rdar://problem/8648311> and https://bugs.webkit.org/show_bug.cgi?id=56876
WK2 Icon DB: Expand IconDatabaseClient interface and move it to the main thread
Note that while the new client calls always come through on the main thread, our mechanisms to
route dispatches to the main thread are still valid and will still work.
Update to the new IconDatabaseClient interface:
* WebIconDatabase.cpp:
(WebIconDatabase::performImport):
(WebIconDatabase::didRemoveAllIcons):
(WebIconDatabase::didImportIconURLForPageURL):
(WebIconDatabase::didImportIconDataForPageURL):
(WebIconDatabase::didChangeIconForPageURL):
(WebIconDatabase::didFinishURLImport):
* WebIconDatabase.h:
2011-03-17 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=56425
More groundwork for WebKit2 IconDatabase
Update already-used function names:
* WebIconDatabase.cpp:
(WebIconDatabase::iconForURL):
(WebIconDatabase::iconURLForURL):
(WebIconDatabase::hasIconForURL):
2011-03-18 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: implement inspector session storage.
https://bugs.webkit.org/show_bug.cgi?id=56643
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::saveSessionSetting):
(WebInspectorClient::loadSessionSetting):
(WebInspectorFrontendClient::saveSessionSetting):
(WebInspectorFrontendClient::loadSessionSetting):
* WebCoreSupport/WebInspectorClient.h:
2011-03-11 Brady Eidson <beidson@apple.com>
More Windows build fix for https://bugs.webkit.org/show_bug.cgi?id=56216
* WebCoreStatistics.cpp:
* WebIconDatabase.cpp:
2011-03-09 Peter Kasting <pkasting@google.com>
Reviewed by Mihai Parparita.
Unify Windows version checks.
https://bugs.webkit.org/show_bug.cgi?id=55979
* WebView.cpp:
(WebView::standardUserAgentWithApplicationName):
(webKitVersionString):
2011-03-07 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
https://bugs.webkit.org/show_bug.cgi?id=55827
Renamed FrameLoaderClient::dispatchDecidePolicyForMIMEType to dispatchDecidePolicyForResponse
and pass the entire response, instead of just the MIMEType.
* WebFrame.cpp:
(WebFrame::dispatchDecidePolicyForResponse):
* WebFrame.h:
2011-03-04 Steve Falkenburg <sfalken@apple.com>
Reviewed by Darin Adler.
Adopt VersionStamper tool for Windows WebKit DLLs
https://bugs.webkit.org/show_bug.cgi?id=55784
Calculate the WebKit version for the useragent via autoversion.h
instead of reading it back from the DLL.
We now use a tool to stamp the version number onto the Apple WebKit DLLs
during the post-build step.
* WebKit.vcproj/WebKit.rc: Removed. This file wasn't used.
* WebKit.vcproj/WebKitLibCommon.vsprops: Fetch version from a string resource.
* WebView.cpp:
(WebView::standardUserAgentWithApplicationName): Use __BUILD_NUMBER_SHORT__ for the version.
(osVersion): Removed
2011-03-03 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Get rid of Page::globalHistoryItem
https://bugs.webkit.org/show_bug.cgi?id=55738
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::updateGlobalHistoryItemForPage):
Get the current history item and update it using WebView::setGlobalHistoryItem.
* WebCoreSupport/WebFrameLoaderClient.h:
* WebView.cpp:
(WebView::globalHistoryItem):
(WebView::setGlobalHistoryItem):
* WebView.h:
2011-03-03 Brent Fulgham <bfulgham@webkit.org>
Unreviewed build correction.
* WebFrame.cpp:
(scaleFactor): Update after 77286 to replace right/bottom
with new maxX/maxY terminology.
2011-03-03 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=55721
Global IconDatabase should be returned by reference, not as a pointer
* WebCoreStatistics.cpp:
(WebCoreStatistics::iconPageURLMappingCount):
(WebCoreStatistics::iconRetainedPageURLCount):
(WebCoreStatistics::iconRecordCount):
(WebCoreStatistics::iconsWithDataCount):
* WebIconDatabase.cpp:
(WebIconDatabase::init):
(WebIconDatabase::startUpIconDatabase):
(WebIconDatabase::iconForURL):
(WebIconDatabase::retainIconForURL):
(WebIconDatabase::releaseIconForURL):
(WebIconDatabase::removeAllIcons):
(WebIconDatabase::iconURLForURL):
(WebIconDatabase::isEnabled):
(WebIconDatabase::setEnabled):
(WebIconDatabase::hasIconForURL):
(WebIconDatabase::getOrCreateDefaultIconBitmap):
* WebKitDLL.cpp:
(shutDownWebKit):
2011-03-03 Alexey Proskuryakov <ap@apple.com>
Removing an include of WebCoreKeyboardUIMode.h that Ive just added. It's already included
via ChromeClient.h
* WebCoreSupport/WebChromeClient.h:
2011-03-02 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
REGRESSION (WebKit2): Tab keys no longer observe Full Keyboard Access
https://bugs.webkit.org/show_bug.cgi?id=55633
<rdar://problem/8963023>
* WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::keyboardUIMode):
* WebCoreSupport/WebChromeClient.h:
Implement keyboardUIMode() instead of tabsToLinks(). No change in functionality, since
this platform doesn't observe or have full keyboard access state.
2011-03-03 Peter Kasting <pkasting@google.com>
Reviewed by James Robinson.
Drop redundant "Windows; " from the Windows-specific User Agent string.
https://bugs.webkit.org/show_bug.cgi?id=54567
* WebView.cpp:
(WebView::standardUserAgentWithApplicationName):
2011-03-01 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
Part of WebKit2: Need a way to send notifications to client when cookies change
https://bugs.webkit.org/show_bug.cgi?id=55427
<rdar://problem/9056027>
Add stubs for CookiesStrategy on Windows WebKit1.
* WebCoreSupport/WebPlatformStrategies.cpp:
(WebPlatformStrategies::createCookiesStrategy):
(WebPlatformStrategies::notifyCookiesChanged):
* WebCoreSupport/WebPlatformStrategies.h:
2011-02-28 Chang Shu <cshu@webkit.org>
Reviewed by Ryosuke Niwa.
Remove the support of Frame::isContentEditable and its dependencies.
https://bugs.webkit.org/show_bug.cgi?id=54292
Remove the WebKit side implementation.
* WebCoreSupport/WebEditorClient.cpp:
* WebCoreSupport/WebEditorClient.h:
2011-02-28 Adam Roben <aroben@apple.com>
Build TestWebKitAPIInjectedBundle on Windows
Fixes <http://webkit.org/b/55420> run-api-tests doesn't run injected bundle tests on Windows
Reviewed by Darin Adler.
* WebKit.vcproj/WebKit.sln: Added TestWebKitAPIInjectedBundle. Let VS simplify the paths to
the project files.
2011-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r78789.
http://trac.webkit.org/changeset/78789
https://bugs.webkit.org/show_bug.cgi?id=55409
Incorrect canvas fallback implementation (Requested by
inferno-sec on #webkit).
* AccessibleBase.cpp:
(MSAARole):
2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874
Added clearOpener method to IWebFramePrivate.
Touched WebKit.idl to trigger build scripts.
* Interfaces/IWebFramePrivate.idl:
* Interfaces/WebKit.idl:
* WebFrame.cpp:
(WebFrame::clearOpener):
* WebFrame.h:
2011-02-26 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r79764.
http://trac.webkit.org/changeset/79764
https://bugs.webkit.org/show_bug.cgi?id=55295
"broke Chromium builds" (Requested by rniwa on #webkit).
* Interfaces/IWebFramePrivate.idl:
* Interfaces/WebKit.idl:
* WebFrame.cpp:
* WebFrame.h:
2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Pavel Feldman.
DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874
Added clearOpener method to IWebFramePrivate.
Touched WebKit.idl to trigger build scripts.
* Interfaces/IWebFramePrivate.idl:
* Interfaces/WebKit.idl:
* WebFrame.cpp:
(WebFrame::clearOpener):
* WebFrame.h:
2011-02-24 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
Drop the "U; " encryption level from the User Agent string.
https://bugs.webkit.org/show_bug.cgi?id=54566
* WebView.cpp:
(WebView::standardUserAgentWithApplicationName):
2011-02-24 Andrew Wilson <atwilson@chromium.org>
Unreviewed, rolling out r79570.
http://trac.webkit.org/changeset/79570
https://bugs.webkit.org/show_bug.cgi?id=54874
Breaks chromium build because glue/mocks/mock_web_frame.h/cc
was not updated
* Interfaces/IWebFramePrivate.idl:
* Interfaces/WebKit.idl:
* WebFrame.cpp:
* WebFrame.h:
2011-02-24 Vsevolod Vlasov <vsevik@chromium.org>
Reviewed by Alexey Proskuryakov.
DumpRenderTree should reset frame opener between tests.
https://bugs.webkit.org/show_bug.cgi?id=54874
Added clearOpener method to IWebFramePrivate.
Touched WebKit.idl to trigger build scripts.
* Interfaces/IWebFramePrivate.idl:
* Interfaces/WebKit.idl:
* WebFrame.cpp:
(WebFrame::clearOpener):
* WebFrame.h:
2011-02-23 Patrick Gansterer <paroga@webkit.org>
Reviewed by Darin Adler.
Rename PLATFORM(CF) to USE(CF)
https://bugs.webkit.org/show_bug.cgi?id=53540
* WebView.cpp:
2011-02-22 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Alexey Proskuryakov.
Drop the language tag part from the User Agent string
https://bugs.webkit.org/show_bug.cgi?id=54560
* WebView.cpp:
(WebView::standardUserAgentWithApplicationName):
2011-02-19 Charlie Reis <creis@chromium.org>
Reviewed by Mihai Parparita.
Ensure loading has stopped in HistoryController::goToItem
https://bugs.webkit.org/show_bug.cgi?id=54517
Add a FrameLoaderClient callback for whether to stop loading before goToItem.
Test: http/tests/navigation/forward-to-fragment-fires-onload.html
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::shouldStopLoadingForHistoryItem): Added.
* WebCoreSupport/WebFrameLoaderClient.h:
2011-02-16 David Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=54244
Convert the line box tree to floating point and eliminate font rounding hacks. This patch removes all of the rounding
hacks from the Font code and makes sure all Font APIs involving width measurement and width offsets use floats.
The line box tree's x, y and logicalWidth members have all been converted to floats and all of the line box APIs have
been changed as well.
In terms of pixel adjustments, overflow is using an enclosing model (so it will be enclosingIntRect of a line box's x/y/width/height).
Background and border painting is using a rounding model, so borders and backgrounds will round to the nearest pixel when painting.
Replaced elements still snap to integer positions on lines, and they use a rounding model as well, although their underlying line boxes
still have a precise floating point position.
Justification will now allow subpixel positioning to occur as well. Platforms that don't support subpixel positioning should already
be rounding justification spacing in their font code.
Many layout test results change on Mac, since rounding hacks were used there and are now gone.
* WebKitGraphics.cpp:
(CenterTruncateStringToWidth):
(RightTruncateStringToWidth):
2011-02-10 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Adam Roben.
HTML5 <details> and <summary>: localized text
https://bugs.webkit.org/show_bug.cgi?id=54260
The method defaultDetailsSummaryText was added to LocalizationStrategy class. It is used to
provide the default label to be used by a <details> tag that has no <summary> child.
* WebCoreSupport/WebPlatformStrategies.cpp:
(WebPlatformStrategies::defaultDetailsSummaryText):
* WebCoreSupport/WebPlatformStrategies.h:
2011-02-16 Dominic Mazzoni <dmazzoni@google.com>
Reviewed by Chris Fleizach.
Add new role for canvas elements.
https://bugs.webkit.org/show_bug.cgi?id=50126
Test: accessibility/canvas-fallback-content.html
* AccessibleBase.cpp:
(MSAARole):
2011-02-15 Kenneth Russell <kbr@google.com>
Unreviewed. Remove whitespace-only change from
http://trac.webkit.org/changeset/78620 (https://bugs.webkit.org/show_bug.cgi?id=54312)
now that the patch has passed the Windows build bots.
* Interfaces/WebKit.idl:
2011-02-15 Kenneth Russell <kbr@google.com>
Reviewed by Darin Fisher.
Allow controlling minimum DOMTimer interval on a per-page basis
https://bugs.webkit.org/show_bug.cgi?id=54312
Added needed methods to implement LayoutTestController's new
setMinimumTimerInterval method. Includes whitespace-only change to
WebKit.idl to trigger proper rebuild on bots; will be removed in
subsequent checkin.
* Interfaces/IWebViewPrivate.idl:
* Interfaces/WebKit.idl:
* WebView.cpp:
(WebView::initWithFrame):
(WebView::defaultMinimumTimerInterval):
(WebView::setMinimumTimerInterval):
* WebView.h:
2011-01-26 MORITA Hajime <morrita@google.com>
Reviewed by Ryosuke Niwa.
Refactoring: Extract TextCheckerClient from EditorClient
https://bugs.webkit.org/show_bug.cgi?id=53213
* WebCoreSupport/WebEditorClient.h:
(WebEditorClient::textChecker):
2011-02-07 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Adam Barth.
Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
https://bugs.webkit.org/show_bug.cgi?id=52417
Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
not implemented.
* WebCoreSupport/WebEditorClient.cpp:
(WebEditorClient::canCopyCut): Added.
(WebEditorClient::canPaste): Added.
* WebCoreSupport/WebEditorClient.h:
2011-02-14 Brian Weinstein <bweinstein@apple.com>
Reviewed by Brady Eidson.
Need WebKit API to determine whether we have a site icon for a given URL
https://bugs.webkit.org/show_bug.cgi?id=54400
This patch implements IWebIconDatabase::hasIconForURL which tells us whether or not
we have a site icon for the given URL.
* Interfaces/IWebIconDatabase.idl: Added new function.
* Interfaces/WebKit.idl: Touched to make sure Interfaces rebuilds.
* WebIconDatabase.cpp:
(WebIconDatabase::hasIconForURL): Call IconDatabase::iconForPageURL to make sure we
load the icon from disk, and call iconURLForPageURL to determine whether or not
we actually have an icon.
* WebIconDatabase.h:
2011-02-11 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
A little more encapsulation for the heap: Removed CollectorHeapIterator
https://bugs.webkit.org/show_bug.cgi?id=54298
* WebCoreStatistics.cpp:
(WebCoreStatistics::javaScriptProtectedObjectTypeCounts):
2011-02-09 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: follow up on InspectorAgent split -
removing unnecessary methods from InspectorController.
https://bugs.webkit.org/show_bug.cgi?id=54093
* WebInspector.cpp:
(WebInspector::showConsole):
(WebInspector::toggleProfilingJavaScript):
2011-02-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Remove orphan code from old parser
https://bugs.webkit.org/show_bug.cgi?id=53984
* WebCoreSupport/WebChromeClient.h:
2011-02-08 David Hyatt <hyatt@apple.com>
Reviewed by Adam Roben.
<rdar://problem/8932077> REGRESSION (5.0.3-ToT): United boarding pass has wrong layout when printed
Windows never got patched to pass in the page height to WebCore, so when WebCore's pagination got re-written to depend on this
value, Windows got broken. Patch setPrinting to be identical to WebKit1 on OS X and to have it take an extra minimum page height
argument.
* WebFrame.cpp:
(WebFrame::setPrinting):
(WebFrame::setInPrintingMode):
* WebFrame.h:
2011-02-02 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: move InspectorController's methods from InspectorAgent to InspectorController.
https://bugs.webkit.org/show_bug.cgi?id=53169
Minor change enforced by major changes in WebCore/inspector/InspectorController.
* WebInspector.cpp:
(WebInspector::isTimelineProfilingEnabled):
2011-02-07 Enrica Casucci <enrica@apple.com>
Reviewed Adam Roben and Darin Adler.
WebKit2: drag and drop support on Windows.
https://bugs.webkit.org/show_bug.cgi?id=52775
Removed createDragImageForLink from DragClient.
* WebCoreSupport/WebDragClient.cpp:
(WebDragClient::startDrag):
* WebCoreSupport/WebDragClient.h:
2011-02-06 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
https://bugs.webkit.org/show_bug.cgi?id=52867
* WebHistory.cpp:
(WebHistory::orderedLastVisitedDays): Calls adoptArrayPtr.
* WebPreferences.cpp:
(WebPreferences::copyWebKitPreferencesToCFPreferences): Ditto.
2011-02-03 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove settings related methods from InspectorClient
https://bugs.webkit.org/show_bug.cgi?id=53686
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::openInspectorFrontend):
(WebInspectorFrontendClient::WebInspectorFrontendClient):
* WebCoreSupport/WebInspectorClient.h:
2011-02-03 Adam Langley <agl@chromium.org>
Reviewed by Adam Barth.
Plumb mixed script URL to FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=52384
Regressions covered by http/tests/security/mixedContent/*
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::didRunInsecureContent):
* WebCoreSupport/WebFrameLoaderClient.h:
2011-02-02 David Hyatt <hyatt@apple.com>
Reviewed by Darin Adler.
Removal of right()/bottom(), converting to maxX()/maxY().
* DOMHTMLClasses.cpp:
(DOMHTMLInputElement::rectOnScreen):
* WebCoreSupport/EmbeddedWidget.cpp:
(EmbeddedWidget::frameRectsChanged):
* WebFrame.cpp:
(WebFrame::computePageRects):
* WebScrollBar.cpp:
(WebScrollBar::frameRect):
* WebView.cpp:
(WebView::addToDirtyRegion):
(WebView::visibleContentRect):
(WebView::prepareCandidateWindow):
2011-01-31 Brady Eidson <beidson@apple.com>
Reviewed by Adam Roben.
Fix the clean Windows build.
* WebKitGraphics.cpp:
(WebDrawText):
2011-01-28 Jon Honeycutt <jhoneycutt@apple.com>
Downloads in WK2 on Windows should write resume data to bundle
https://bugs.webkit.org/show_bug.cgi?id=53282
<rdar://problem/8753077>
Reviewed by Alice Liu.
* WebDownload.cpp:
(WebDownload::bundlePathForTargetPath):
Use the new WebCore::DownloadBundle function.
(WebDownload::request):
* WebDownload.h:
Removed declarations for functions that were moved to a new location.
* WebDownloadCFNet.cpp:
(WebDownload::initToResumeWithBundle):
Use the new WebCore::DownloadBundle function.
(WebDownload::cancelForResume):
Fix a leak of the resume data CFDataRef by using adoptCF(). Use the new
WebCore::DownloadBundle function.
2011-01-28 Dan Bernstein <mitz@apple.com>
Reviewed by Sam Weinig.
<select> can't display right-to-left (rtl) languages
https://bugs.webkit.org/show_bug.cgi?id=19785
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added.
* WebCoreSupport/WebChromeClient.h:
2011-01-27 Nate Chapin <japhet@chromium.org>
Reviewed by Adam Barth.
Use Document::url() instead of FrameLoader::url().
https://bugs.webkit.org/show_bug.cgi?id=41165
* WebFrame.cpp:
(WebFrame::url):
2011-01-27 Sam Weinig <sam@webkit.org>
Reviewed by Adam Roben.
Fix scrollbars in Safari's Downloads window and Bookmarks view by
implementing two needed functions from ScrollableArea.
* WebScrollBar.cpp:
(WebScrollBar::horizontalScrollbar): Return the WebCore::Scrollbar if
we are a horizontal scrollbar.
(WebScrollBar::verticalScrollbar): Return the WebCore::Scrollbar if we
are a vertical scrollbar.
* WebScrollBar.h:
2011-01-27 Adam Roben <aroben@apple.com>
Trim down #includes in WebView.h
Rubber-stamped by Steve Falkenburg.
* WebView.cpp: Moved some #includes here from the header file.
* WebView.h: Replaced some broader #includes with more specific ones, plus a
forward-declaration.
2011-01-25 Steve Falkenburg <sfalken@apple.com>
Windows production build fix.
Build correct configuration of Interfaces for Debug_All.
* WebKit.vcproj/WebKit.submit.sln:
2011-01-25 Steve Falkenburg <sfalken@apple.com>
Rubber-stamped by Adam Roben.
Windows production build fix.
Use correct environment variable escaping
* WebKit.vcproj/WebKit.make:
2011-01-24 Chris Marrin <cmarrin@apple.com>
Reviewed by Eric Seidel.
Change ENABLE_3D_CANVAS to ENABLE_WEBGL
https://bugs.webkit.org/show_bug.cgi?id=53041
* WebView.cpp:
(WebView::notifyPreferencesChanged):
2011-01-25 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: remove "attached" state related methods from InspectorAgent
https://bugs.webkit.org/show_bug.cgi?id=53086
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorFrontendClient::attachWindow):
(WebInspectorFrontendClient::detachWindow):
(WebInspectorFrontendClient::showWindowWithoutNotifications):
* WebCoreSupport/WebInspectorClient.h:
2011-01-24 Adam Roben <aroben@apple.com>
Windows Production build fix
* WebKit.vcproj/WebKit.make: Update for move of WebKit into Source.
2011-01-21 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Introduce FontMetrics abstraction
https://bugs.webkit.org/show_bug.cgi?id=51456
* FullscreenVideoController.cpp: Use FontMetrics instead of Font to access the metrics.
(FullscreenVideoController::draw):
* WebCoreSupport/WebDragClient.cpp: Ditto.
(WebDragClient::createDragImageForLink):
* WebKitGraphics.cpp: Ditto.
(FontMetrics):
2011-01-21 Chris Rogers <crogers@google.com>
Reviewed by Darin Fisher.
Add run-time enable support for the web audio API
https://bugs.webkit.org/show_bug.cgi?id=52741
* WebPreferenceKeysPrivate.h:
* WebView.cpp:
(WebView::notifyPreferencesChanged):
2011-01-21 Sam Weinig <sam@webkit.org>
Fix windows build.
* WebScrollBar.h:
2011-01-21 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Part 2 of "Cleanup Scrollbar/ScrollbarClient relationship"
https://bugs.webkit.org/show_bug.cgi?id=52779
Rename ScrollbarClient -> ScrollableArea.
* WebScrollBar.cpp:
(WebScrollBar::scroll):
* WebScrollBar.h:
2011-01-20 Adam Roben <aroben@apple.com>
Update for CACFLayerTreeHost changes
Fixes <http://webkit.org/b/52852> Flushing layer changes and rendering are intertwined in
CACFLayerTreeHost, but shouldn't be
Reviewed by Simon Fraser.
* WebView.cpp:
(WebView::paint): Changed to flush layer changes via CACFLayerTreeHost, which will call back
to our own flushing function if needed.
* WebView.h: Removed shouldRender, which is no longer used or needed.
2011-01-21 Adam Roben <aroben@apple.com>
Update for WKCACFLayerRenderer -> CACFLayerTreeHost rename
Also renamed WebView::m_layerRenderer to WebView::m_layerTreeHost to match.
Fixes <http://webkit.org/b/52898> WKCACFLayerRenderer sounds like a render object, but isn't
Reviewed by Simon Fraser.
* WebPreferences.cpp:
* WebView.cpp:
(WebView::setAcceleratedCompositing): Also made sure to remove our HWND from the layer tree
host before we get rid of the layer tree host itself.
* WebView.h:
2011-01-21 Adam Roben <aroben@apple.com>
Replace some "sync compositing state" terminology with "flush pending GraphicsLayer changes"
This seems to be the direction in which our code is moving. I chose "GraphicsLayer" as
opposed to just "layer" because there are cases where we flush changes to CACFLayers that
don't have a corresponding GraphicsLayer.
Fixes <http://webkit.org/b/52894> "Sync compositing state" terminology in
WKCACFLayerRenderer and friends is confusing
Reviewed by Simon Fraser.
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::scheduleCompositingLayerSync): Updated for WebView changes.
* WebView.cpp:
(WebView::paint): Updated for rename.
(WebView::flushPendingGraphicsLayerChangesSoon): Renamed from scheduleCompositingLayerSync.
(WebView::notifySyncRequired): Updated for rename.
(WebView::flushPendingGraphicsLayerChanges): Renamed from syncCompositingState.
* WebView.h: Did the renames.
2011-01-20 Sam Weinig <sam@webkit.org>
Reviewed by Dave Hyatt.
Cleanup Scrollbar/ScrollbarClient relationship
https://bugs.webkit.org/show_bug.cgi?id=52779
* WebScrollBar.cpp:
(WebScrollBar::WebScrollBar):
(WebScrollBar::setValue):
(WebScrollBar::value):
(WebScrollBar::scroll):
(WebScrollBar::scrollPosition):
(WebScrollBar::setScrollOffset):
* WebScrollBar.h:
2011-01-19 Adam Roben <aroben@apple.com>
Update for WKCACFLayerRenderer changes
Fixes <http://webkit.org/b/52749> WKCACFLayerRenderer should be
ref-counted
Reviewed by Simon Fraser.
* WebView.cpp:
(WebView::~WebView): Added some assertions to make sure we've gotten rid of our
compositing-related members. My biggest concern was making sure that m_layerRenderer was
gone, which would also mean we had nulled out its client pointer.
(WebView::setAcceleratedCompositing): Changed to call WKCACFLayerRenderer::setClient instead
of passing the client into create(), and to clear out the client before nulling out
m_layerRenderer.
* WebView.h: Changed m_layerRenderer from an OwnPtr to a RefPtr.
2011-01-19 Adam Roben <aroben@apple.com>
Teach WebView::scrollBackingStore about compositing mode
Test:
compositing/scroll-painted-composited-content.html
Fixes <http://webkit.org/b/52720> REGRESSION (r75987): Assertion failure in
WebView::scrollBackingStore when scrolling page with composited content
Reviewed by Anders Carlsson.
* WebView.cpp:
(WebView::scrollBackingStore): Do something sensible (though naive) when in compositing
mode, rather than incorrectly asserting that this function is never called in that case. For
now we just repaint the entire scrolled region; someday hopefully we can avoid having to
repaint the areas that have just been moved.
2011-01-19 Simon Fraser <simon.fraser@apple.com>
Reviewed by Sam Weinig.
GraphicsLayers in subframes can get sync'd multiple times
https://bugs.webkit.org/show_bug.cgi?id=52489
* WebView.cpp:
(WebView::syncCompositingState): syncCompositingStateRecursive()
was renamed to syncCompositingStateIncludingSubframes().
2011-01-17 Adam Roben <aroben@apple.com>
Update for WKCACFLayerRenderer changes
Fixes <http://webkit.org/b/52587> WKCACFLayerRenderer is hard to use
Reviewed by Chris Marrin.
* WebView.cpp:
(WebView::WebViewWndProc): Removed call to layerRendererBecameVisible
when handling WM_SHOWWINDOW. All this did was try to create the
renderer, but it had already been created in setAcceleratedCompositing,
so wasn't needed.
(WebView::setAcceleratedCompositing): Removed call to createRenderer;
setHostWindow does this for us now.
* WebView.h: Removed animationsStarted and layerRendererBecameVisible.
2011-01-17 Adam Roben <aroben@apple.com>
Paint directly into a GraphicsLayer when using accelerated compositing
Before this patch, we were painting into our normal backing store
HBITMAP, wrapping it in a CGImage, and handing it off to Core
Animation. This had at least two disadvantages:
1) The bitmap could be modified while Core Animation was using it.
2) It introduced extra complexity.
When entering accelerated compositing mode, WebView now creates a
GraphicsLayer to draw into. This GraphicsLayer sits between the root
layer (owned by WKCACFLayerRenderer) and the RenderView's layer. When
WebView invalidates, it just calls setNeedsDisplayInRect on its
GraphicsLayer. When WebView paints, it just tells its
WKCACFLayerRenderer to paint, which will call back to WebView to draw
into the GraphicsLayer if it has a dirty region. This is very similar
to the current implementation of LayerBackedDrawingArea in WebKit2.
Fixes <http://webkit.org/b/52582> WebView should paint directly into a
GraphicsLayer when in accelerated compositing mode
Reviewed by Simon Fraser and Chris Marrin.
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::attachRootGraphicsLayer):
(WebChromeClient::scheduleCompositingLayerSync):
Updated for WebView changes.
* WebView.cpp:
(WebView::repaint): When using accelerated compositing, just invalidate
our backing layer. This matches the behavior of LayerBackedDrawingArea.
(WebView::deleteBackingStore): Removed accelerated compositing code.
The WKCACFLayerRenderer doesn't need to know about our backing store
anymore; we don't use it at all when in accelerated compositing mode.
(WebView::addToDirtyRegion): When using accelerated compositing, just
invalidate our backing layer.
(WebView::scrollBackingStore): Added an assertion that this isn't
called in accelerated compositing mode.
(WebView::sizeChanged): Update our backing layer's size, too, and
invalidate it.
(WebView::updateBackingStore): Added an assertion that this isn't
called in accelerated compositing mode.
(WebView::paint): If we're in accelerated compositing mode, sync our
compositing state. If we're *still* in accelerated compositing mode,
just tell our WKCACFLayerRenderer to paint and clear our dirty region.
(The later changes in this function are just un-indenting code that
used to be inside an if.)
(WebView::paintIntoBackingStore):
(WebView::paintIntoWindow):
Added assertions that these aren't called in accelerated compositing
mode.
(WebView::WebViewWndProc): Updated WM_XP_THEMECHANGED handling for
removal of setRootLayerNeedsDisplay.
(WebView::setRootChildLayer): Changed to take a GraphicsLayer. We now
set the layer as a child of our own backing layer.
(WebView::scheduleCompositingLayerSync): Just call through to
WKCACFLayerRenderer.
(WebView::setAcceleratedCompositing): Create our backing layer and set
it as the child of WKCACFLayerRenderer's root layer.
(WebView::notifyAnimationStarted): Added. We never expect this
GraphicsLayerClient override to be called, as we don't use animations
on our backing layer.
(WebView::notifySyncRequired): Added. Just schedule a sync.
(WebView::paintContents): Added. Just clip and paint!
(WebView::showDebugBorders):
(WebView::showRepaintCounter):
Added. These just call through to Settings.
(WebView::syncCompositingState): Changed to first update layout, then
sync state for our backing layer, then sync WebCore's state. This
matches LayerBackedDrawingArea.
* WebView.h: WebView now implements the GraphicsLayerClient interface.
Removed setRootLayerNeedsDisplay; it's been replaced by calling
setNeedsDisplay on our backing layer and calling
syncCompositingStateSoon on WKCACFLayerRenderer as needed. Removed
updateRootLayerContents; that function was used to pass our backing
store to Core Animation, which we no longer do. Added m_backingLayer.
2011-01-17 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Alexey Proskuryakov.
Fix some headers with missing or misspelled #ifndef guards
https://bugs.webkit.org/show_bug.cgi?id=52545
* WebKitStatistics.h:
2011-01-17 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: simplify debugger enabling routine.
https://bugs.webkit.org/show_bug.cgi?id=52472
* WebInspector.cpp:
(WebInspector::toggleDebuggingJavaScript):
2011-01-16 Adam Barth <abarth@webkit.org>
Rubber-stamped by Eric Seidel.
Move WebKit into Source
https://bugs.webkit.org/show_bug.cgi?id=52530
* WebKit.vcproj/Interfaces.vcproj:
* WebKit.vcproj/WebKit.sln:
* WebKit.vcproj/WebKit.vcproj:
* WebKit.vcproj/WebKitGUID.vcproj:
2011-01-15 Adam Barth <abarth@webkit.org>
Rubber-stamped by Eric Seidel.
Move WebKit2 into Source
https://bugs.webkit.org/show_bug.cgi?id=52438
Update reference to WebKit2.
* WebKit.vcproj/WebKit.sln:
2011-01-14 Yuzo Fujishima <yuzo@google.com>
Reviewed by Antti Koivisto.
Rename cache() to memoryCache()
https://bugs.webkit.org/show_bug.cgi?id=52433
* WebCache.cpp:
(WebCache::statistics):
(WebCache::empty):
(WebCache::setDisabled):
(WebCache::disabled):
* WebView.cpp:
(WebView::setCacheModel):
2011-01-10 Geoffrey Garen <ggaren@apple.com>
Try to fix Windows build.
* WebJavaScriptCollector.cpp: Updated for rename to Heap.*. (Didn't catch
this one before because it was miscapitalized.)
2011-01-09 Xianzhu Wang <phnixwxz@gmail.com>
Reviewed by Darin Fisher.
https://bugs.webkit.org/show_bug.cgi?id=41441
createWindow method should only do window-creating without URL navigation
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::createWindow):
2011-01-07 Adam Barth <abarth@webkit.org>
Rubber-stamped by Eric Seidel.
Move WebCore to Source
https://bugs.webkit.org/show_bug.cgi?id=52050
* WebKit.vcproj/WebKit.sln:
2011-01-06 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Bug 52035 - Unregistering DOMWrapperWorlds is unsafe
The method DOMWrapperWorld::unregisterWorld() effectively calls the DOMWrapperWorld's
destructor early, in order to release wrappers once we know we no longer intend to use them.
Whilst it is okay to have a method to throw away wrappers (assuming we know we're willing to
lose any state stored on them) it is not okay to deregister the world from the JSGlobalData.
A sequence of events that triggers the bug would look like this:
(1) Create a DOMWrapperWorld.
(2) Register a timer in the world.
(3) Call unregisterWorld() on the world.
(4) Timer goes off, code is executed in the world, creates a Node not attached to a Document.
(5) We attempt to lookup a wrapper map for the world on the JSGlobalData, but because we've
called forgetWorld() none exists.
(6) Attempt to add a wrapper to a NULL map.
Fix the problem by not removing the JSGlobalData's wrapper map until the world really goes away.
* WebScriptWorld.cpp:
(WebScriptWorld::unregisterWorld):
2011-01-07 Chris Marrin <cmarrin@apple.com>
Rubber-stamped by Simon Fraser.
Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementations
https://bugs.webkit.org/show_bug.cgi?id=49388
Change client API for the fullscreen video controller. It now uses a
PlatformCALayerClient so it can use a PlaformCALayer directly. Also
updated how to connect the layer tree to the view to reflect the updated
hardware compositing logic.
* FullscreenVideoController.cpp:
(FullscreenVideoController::LayerClient::LayerClient):
(FullscreenVideoController::LayerClient::platformCALayerRespondsToLayoutChanges):
(FullscreenVideoController::LayerClient::platformCALayerAnimationStarted):
(FullscreenVideoController::LayerClient::platformCALayerContentsOrientation):
(FullscreenVideoController::LayerClient::platformCALayerPaintContents):
(FullscreenVideoController::LayerClient::platformCALayerShowDebugBorders):
(FullscreenVideoController::LayerClient::platformCALayerShowRepaintCounter):
(FullscreenVideoController::LayerClient::platformCALayerIncrementRepaintCount):
(FullscreenVideoController::LayerClient::platformCALayerContentsOpaque):
(FullscreenVideoController::LayerClient::platformCALayerDrawsContent):
(FullscreenVideoController::LayerClient::platformCALayerLayerDidDisplay):
(FullscreenVideoController::LayerClient::platformCALayerLayoutSublayersOfLayer):
(FullscreenVideoController::FullscreenVideoController):
(FullscreenVideoController::~FullscreenVideoController):
(FullscreenVideoController::enterFullscreen):
* FullscreenVideoController.h:
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::attachRootGraphicsLayer):
(WebChromeClient::scheduleCompositingLayerSync):
* WebView.cpp:
(WebView::setRootChildLayer):
(WebView::animationsStarted):
(WebView::syncCompositingState):
* WebView.h:
(WebView::setRootLayerNeedsDisplay):
2011-01-05 Steve Falkenburg <sfalken@apple.com>
Reviewed by Darin Adler.
Debug and Release builds on Windows clobber each other
https://bugs.webkit.org/show_bug.cgi?id=49185
Changes the structure of WebKitBuild build products directory so we
completely separate each build configuration into independent directories.
Although we previously had per-configuration directories for obj, this change adds
per-configuration directories for bin, lib, obj, and include. Each configuration's
build products are stored within a directory inside of WebKitBuild.
Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
* WebKit.vcproj/InterfacesCommon.vsprops:
* WebKit.vcproj/InterfacesPostBuild.cmd:
* WebKit.vcproj/InterfacesPreBuild.cmd:
* WebKit.vcproj/WebKit.make:
* WebKit.vcproj/WebKitGUID.vcproj:
* WebKit.vcproj/WebKitGUIDCommon.vsprops:
* WebKit.vcproj/WebKitGUIDPostBuild.cmd:
* WebKit.vcproj/WebKitGUIDPreBuild.cmd:
* WebKit.vcproj/WebKitLibCommon.vsprops:
* WebKit.vcproj/WebKitLibPostBuild.cmd:
* WebKit.vcproj/WebKitLibPreBuild.cmd:
2011-01-04 Chris Fleizach <cfleizach@apple.com>
Reviewed by Sam Weinig.
WK2: Support Accessibility
https://bugs.webkit.org/show_bug.cgi?id=51859
Use rootObject() method to get the top of the AX tree.
* AccessibleDocument.cpp:
(AccessibleDocument::AccessibleDocument):
2011-01-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move JavaScriptCore to Source
https://bugs.webkit.org/show_bug.cgi?id=51604
* WebKit.vcproj/WebKit.sln:
- Point to JavaScriptCore in its new location.
2010-12-22 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
WebKit2 needs to mirror the frame tree in the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=51546
- Add client functions to notify that a frame has been added or
removed from the page cache.
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::didSaveToPageCache):
(WebFrameLoaderClient::didRestoreFromPageCache):
* WebCoreSupport/WebFrameLoaderClient.h:
2010-12-22 Dan Bernstein <mitz@apple.com>
Changed WebKitTools to Tools.
* WebKit.vcproj/WebKit.sln:
2010-12-14 Adam Roben <aroben@apple.com>
Always record the last-set cursor, even when the UI delegate is
setting the cursor for us
Prior to r63339, the last-set cursor was recorded in Widget::setCursor.
r63339 moved that code up to WebChromeClient, but failed to call it
when the UI delegate was the one setting the cursor.
Fixes <http://webkit.org/b/45692> <rdar://problem/8423464> REGRESSION
(r63339): Mouse cursor disappears when holding mouse button down on
page
Reviewed by Ada Chan.
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::setCursor): After the cursor is set, regardless of
whether the UI delegate sets it or we set it, record the cursor that
was just set. That way we'll be able to use the cursor later when
responding to the WM_SETCURSOR message.
2010-12-13 Alexey Proskuryakov <ap@apple.com>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=50953
DNS Prefetch should be an opt-in feature
* WebPreferences.cpp: (WebPreferences::initializeDefaultSettings): Changed default to NO.
2010-10-28 MORITA Hajime <morrita@google.com>
Reviewed by Ojan Vafai.
spellcheck does not check pasted text
https://bugs.webkit.org/show_bug.cgi?id=40092
Added a stub implememntation.
* WebCoreSupport/WebEditorClient.h:
(WebEditorClient::requestCheckingOfString):
2010-12-10 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler.
AX: refactor AccessibilityRenderObject::doAccessibilityHitTest
https://bugs.webkit.org/show_bug.cgi?id=50574
* AccessibleBase.cpp:
(AccessibleBase::accHitTest):
2010-12-09 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
Prep for WebKit2: Context menu support on Windows
https://bugs.webkit.org/show_bug.cgi?id=50514
Update WebKit for the new CROSS_PLATFORM_CONTEXT_MENUS flag, and define customizeMenu
instead of getCustomMenuFromDefaultItems.
* WebCoreSupport/WebContextMenuClient.cpp:
(WebContextMenuClient::customizeMenu): getCustomMenuFromDefaultItems was turned into
this function, with refactoring using nativeMenu instead of platformDescription.
(WebContextMenuClient::contextMenuItemSelected): Use nativeMenu instead of platformDescription.
* WebCoreSupport/WebContextMenuClient.h:
* WebView.cpp:
(WebView::handleContextMenuEvent): Call nativeMenu instead of platformDescription.
(WebView::performContextMenuAction): Only call itemAtIndex with one argument, no need
for the second.
2010-12-07 Brian Weinstein <bweinstein@apple.com>
Reviewed by John Sullivan.
Layering Violation in ContextMenu - member variable of type HitTestResult
https://bugs.webkit.org/show_bug.cgi?id=50586
Update users of ContextMenu and ContextMenuController to match where the new functions
are located.
* WebCoreSupport/WebContextMenuClient.cpp:
(WebContextMenuClient::getCustomMenuFromDefaultItems): Get the HitTestResult and ContextMenu from the
ContextMenuController (from the page).
(WebContextMenuClient::contextMenuItemSelected): Get the HitTestResult from the ContextMenuController.
* WebView.cpp:
(WebView::handleContextMenuEvent): Ditto.
2010-12-07 Jessie Berlin <jberlin@apple.com>
Build fix. Unreviewed.
* WebCoreSupport/WebContextMenuClient.cpp:
(WebContextMenuClient::searchWithGoogle):
FrameLoader::urlSelected does not take a SecurityOrigin as a parameter.
2010-12-06 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
Pass security origin to make local file decision correctly
https://bugs.webkit.org/show_bug.cgi?id=48603
* WebCoreSupport/WebContextMenuClient.cpp:
(WebContextMenuClient::searchWithGoogle): Pass security origin.
2010-12-07 Kenichi Ishibashi <bashi@google.com>
Reviewed by Kent Tamura.
Let HTMLObjectElement be a form associated element
https://bugs.webkit.org/show_bug.cgi?id=48821
Modified to use FormAssociatedElement instead of HTMLFormControlElement.
* WebFrame.cpp:
(WebFrame::elementWithName): Modified to use FormAssociatedElement
instead of HTMLFormControlElement.
(WebFrame::controlsInForm): Ditto.
2010-12-05 Adam Roben <aroben@apple.com>
Windows production build fix
Put spaces after trailing backslashes when setting
%WebKitVSPropsRedirectionDir%. According to MSDN
<http://msdn.microsoft.com/en-us/library/2kzfk8c7(v=VS.80).aspx>:
A backslash ( \ ) followed by a newline character is interpreted as
a space in the command; use a backslash at the end of a line to
continue a command onto the next line. NMAKE interprets the
backslash literally if any other character, including a space or
tab, follows the backslash.
* WebKit.vcproj/WebKit.make:
2010-12-03 Sam Weinig <sam@webkit.org>
Reviewed by Maciej Stachowiak.
Enable <a ping> for Mac/Windows/WebKit2 builds
<rdar://problem/8504473>
https://bugs.webkit.org/show_bug.cgi?id=50488
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings): Enable "HyperlinkAuditing" by default.
2010-12-03 Brian Weinstein <bweinstein@apple.com>
Reviewed by Brady Eidson.
WebContextMenuClient::fixMenuReceivedFromOldSafari is no longer needed on Windows
https://bugs.webkit.org/show_bug.cgi?id=50486
Remove the static fixMenuReceivedFromOldSafari and isPreInspectElementTagSafari methods
from WebContextMenuClient. There were there for when WebKit had the Inspect Element context menu
item, but Safari didn't support it. We don't support that old Safari, so that code can go.
* WebCoreSupport/WebContextMenuClient.cpp:
(WebContextMenuClient::getCustomMenuFromDefaultItems):
2010-12-02 John Knottenbelt <jknotten@chromium.org>
Reviewed by Steve Block.
Move requestGeolocationPermissionForFrame to GeolocationClient
https://bugs.webkit.org/show_bug.cgi?id=50061
This change facilitates client-based geolocation implementation by
bringing together permission control into the geolocation client
interface.
Move method ChromeClient::requestGeolocationPermissionForFrame to
GeolocationClient::requestPermission. The moved code is unchanged
except that requestPermission now takes only one argument (Geolocation*),
the Frame parameter is retrieved from the Geolocation object and we need to
call m_webView.get() as it is a COMPtr in GeolocationClient.
* WebCoreSupport/WebChromeClient.cpp:
* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebGeolocationClient.cpp:
(WebGeolocationClient::requestPermission):
* WebCoreSupport/WebGeolocationClient.h:
(WebGeolocationClient::cancelPermissionRequest):
2010-12-01 Jia Pu <jpu@apple.com>
Reviewed by Darin Adler.
Support multiple correction candidates panel for misspelled word on Mac OS X.
https://bugs.webkit.org/show_bug.cgi?id=50137
<rdar://problem/8568059>
Adopted new function signature defined in base class.
* WebCoreSupport/WebEditorClient.cpp:
(WebEditorClient::getGuessesForWord):
* WebCoreSupport/WebEditorClient.h:
2010-12-01 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
WinCairo build should not use link-time code generation (LTCG)
https://bugs.webkit.org/show_bug.cgi?id=50353
* WebKit.vcproj/Interfaces.vcproj:
* WebKit.vcproj/WebKit.vcproj:
* WebKit.vcproj/WebKitGUID.vcproj:
2010-12-01 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
vcproj changes can't be applied cleanly by the Windows EWS bot
https://bugs.webkit.org/show_bug.cgi?id=50328
* WebKit.vcproj/Interfaces.vcproj: Modified property svn:eol-style.
* WebKit.vcproj/InterfacesCommon.vsprops: Added property svn:eol-style.
* WebKit.vcproj/WebKit.sln: Modified property svn:eol-style.
* WebKit.vcproj/WebKit.submit.sln: Modified property svn:eol-style.
* WebKit.vcproj/WebKit.vcproj: Modified property svn:eol-style.
* WebKit.vcproj/WebKitGUID.vcproj: Modified property svn:eol-style.
* WebKit.vcproj/WebKitGUIDCommon.vsprops: Added property svn:eol-style.
* WebKit.vcproj/WebKitLibCommon.vsprops: Added property svn:eol-style.
2010-11-30 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
All projects on Windows should use cmd files for build events
https://bugs.webkit.org/show_bug.cgi?id=50213
* WebKit.vcproj/InterfacesCommon.vsprops:
* WebKit.vcproj/InterfacesPostBuild.cmd: Added.
* WebKit.vcproj/InterfacesPreBuild.cmd: Added.
* WebKit.vcproj/WebKitGUIDCommon.vsprops:
* WebKit.vcproj/WebKitGUIDPostBuild.cmd: Added.
* WebKit.vcproj/WebKitGUIDPreBuild.cmd: Added.
* WebKit.vcproj/WebKitLibCommon.vsprops:
* WebKit.vcproj/WebKitLibPostBuild.cmd: Added.
* WebKit.vcproj/WebKitLibPreBuild.cmd: Added.
2010-11-29 Brent Fulgham <bfulgham@webkit.org>
Unreviewed build correction.
* WebKit.vcproj/WebKit.vcproj: Update WebKit project to
use WinCairo.vsprops definition for appropriate build targets.
2010-11-22 Adam Roben <aroben@apple.com>
Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
Apple's Windows build allows placing header files and import libraries for WebKit's
dependencies (CoreGraphics, CFNetwork, SQLite, etc.) outside the source tree via the
$WebKitLibrariesDir environment variable. This is both required for production builds and
convenient for Apple-internal developer builds. Apple's production builds also require that
WebKit's shared .vsprops files be accessed relative to $WebKitLibrariesDir. In production
builds, the files are copied into that directory tree by the
WebKitLibraries/win/tools/WinTools.make file. In Apple-internal developer builds, the
copying is done by
JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.
This .vsprops copying is problematic in one very important case: when a developer updates
their source tree and then tries to build. Visual Studio only reads .vsprops files when a
project is first loaded. So, when Visual Studio is first opened after the .vsprops files are
updated, it reads in the old files that were already residing in $WebKitLibrariesDir. When a
build is started, JavaScriptCoreGenerated.make copies the new .vsprops files into
$WebKitLibrariesDir, but Visual Studio will not pick up the changes. The rest of the build
will proceed with out-of-date .vsprops files, which will likely result in a build failure.
To fix this, we now use normal relative paths to access the .vsprops files in the source
tree rather than in $WebKitLibrariesDir, but prefix those paths with a new environment
variable, $WebKitVSPropsRedirectionDir. In developer builds, this environment variable is
unset, so the normal relative paths are used to read the .vsprops files out of the source
tree directly. In production builds, this environment variable is set to a fake directory
that will cause the .vsprops files in $WebKitLibrariesDir to be found when the relative path
is resolved.
For example, JavaScriptCore.vcproj uses this path for FeatureDefines.vsprops:
$(WebKitVSPropsRedirectionDir)..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
In developer builds, where $WebKitVSPropsRedirectionDir is unset, this will point to the
files in WebKitLibraries\win\tools\vsprops in the source tree. In production builds,
JavaScriptCore.make sets $WebKitVSPropsRedirectionDir to
"$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\", so the full path for
FeatureDefines.vsprops becomes:
$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
which resolves to:
$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
(We rely on the fact that Windows doesn't care whether the directories "1", "2", and "3"
actually exist since they are matched by an equal number of ".." path components.)
Note that Visual Studio still won't pick up changes made to .vsprops files while Visual
Studio is open, but that problem hasn't seemed to cause developers many headaches so far.
Fixes <http://webkit.org/b/49181> Windows build fails mysteriously when .vsprops files are
updated
Reviewed by Dave Hyatt.
* WebKit.vcproj/WebKit.make: Set $WebKitVSPropsRedirectionDir so that production builds can
find the .vsprops files.
* WebKit.vcproj/WebKit.vcproj:
* WebKit.vcproj/Interfaces.vcproj:
* WebKit.vcproj/WebKitGUID.vcproj:
Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
files.
2010-11-19 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
https://bugs.webkit.org/show_bug.cgi?id=49819
* WebKit.vcproj/Interfaces.vcproj:
* WebKit.vcproj/WebKit.sln:
* WebKit.vcproj/WebKit.vcproj:
* WebKit.vcproj/WebKitGUID.vcproj:
2010-11-19 Steve Falkenburg <sfalken@apple.com>
Reviewed by Darin Adler.
Normalize Cairo/CFLite project/solution configuration names
https://bugs.webkit.org/show_bug.cgi?id=49818
* WebKit.vcproj/WebKit.sln:
* WebKit.vcproj/WebKit.vcproj:
2010-11-18 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Windows vcproj configuration names should be normalized across projects
https://bugs.webkit.org/show_bug.cgi?id=49776
* WebKit.vcproj/Interfaces.vcproj:
* WebKit.vcproj/WebKit.sln:
2010-11-18 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Remove leftover Windows Debug_Internal configurations
https://bugs.webkit.org/show_bug.cgi?id=49758
* WebKit.vcproj/WebKit.vcproj:
* WebKit.vcproj/WebKitGUID.vcproj:
2010-11-18 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Debug_Internal Windows configuration is unnecessary, should be removed
https://bugs.webkit.org/show_bug.cgi?id=49753
* WebKitPrefix.h:
2010-11-17 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
WebKit Interfaces project should use vsprops file for common build settings
https://bugs.webkit.org/show_bug.cgi?id=49713
* WebKit.vcproj/Interfaces.vcproj:
* WebKit.vcproj/InterfacesCommon.vsprops: Added.
2010-11-16 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
https://bugs.webkit.org/show_bug.cgi?id=49632
* WebKit.vcproj/Interfaces.vcproj:
* WebKit.vcproj/WebKit.make:
* WebKit.vcproj/WebKit.sln:
* WebKit.vcproj/WebKit.submit.sln:
* WebKit.vcproj/WebKit.vcproj:
* WebKit.vcproj/WebKitGUID.vcproj:
2010-11-16 Dave Hyatt <hyatt@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=11004
font-size:0 is ignored. Remove the minimum font size of 1 in CSSStyleSelector.
Change the pref value for minimum font size from 1 to 0. Make sure to never use the NSFont's size,
since it doesn't honor a size of 0. Instead pass the size in to the FontPlatformData(NSFont*) version
of the constructor rather than using [NSFont pointSize].
https://bugs.webkit.org/show_bug.cgi?id=49582
Negative leading is not handled correctly. There are two bugs here. The first is that
maxAscent and maxDescent can be negative, so we need a notion of whether or not we have
set them before so that we can allow them to be < 0.
The second issue is that we should understand where fonts will end up relative to
our baseline (excluding line height), and only allow those boxes to impact ascent and
descent if the actual font box (without factoring in line height) is above or below the
root line box baseline.
Added fast/css/negative-leading.html
These two bug fixes have to land together to keep the Acid 3 test rendering correctly.
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
2010-11-16 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Use vsprops files for common settings in Windows WebKit
https://bugs.webkit.org/show_bug.cgi?id=49622
* WebKit.vcproj/WebKit.vcproj:
* WebKit.vcproj/WebKitCommon.vsprops: Added.
2010-11-16 Steve Falkenburg <sfalken@apple.com>
Rubber stamped by Adam Roben.
Remove unnecessary def file, remove outdated def files from vcproj.
* WebKit.vcproj/WebKit.vcproj:
* WebKit.vcproj/WebKit_debug.def: Removed.
2010-11-12 John Knottenbelt <jknotten@chromium.org>
Reviewed by Steve Block.
Rename GeolocationControllerClient to GeolocationClient.
https://bugs.webkit.org/show_bug.cgi?id=49259
* WebCoreSupport/WebGeolocationClient.cpp: Renamed from WebKit/win/WebCoreSupport/WebGeolocationControllerClient.cpp.
(WebGeolocationClient::WebGeolocationClient):
(WebGeolocationClient::geolocationDestroyed):
(WebGeolocationClient::startUpdating):
(WebGeolocationClient::stopUpdating):
(WebGeolocationClient::lastPosition):
* WebCoreSupport/WebGeolocationClient.h: Renamed from WebKit/win/WebCoreSupport/WebGeolocationControllerClient.h.
(WebGeolocationClient::setEnableHighAccuracy):
* WebKit.vcproj/WebKit.vcproj:
* WebView.cpp:
(WebView::initWithFrame):
2010-11-10 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by David Hyatt.
HTML5 Ruby support should be mandatory feature
https://bugs.webkit.org/show_bug.cgi?id=49272
* WebKitPrefix.h: Touch it to avoid incremental build failure on Windows.
2010-11-08 Alexey Proskuryakov <ap@apple.com>
Windows build fix.
* WebCoreSupport/WebChromeClient.h: Added namespace prefix.
2010-11-08 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=48685
Notify UI process about focused frame
Added an empty implementation of the new ChromeClient method.
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::focusedFrameChanged):
* WebCoreSupport/WebChromeClient.h:
2010-11-07 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Rename Cache to MemoryCache
https://bugs.webkit.org/show_bug.cgi?id=49159
* WebCache.cpp:
(WebCache::statistics):
* WebFrame.cpp:
* WebView.cpp:
2010-11-05 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
Move resumeAnimations/suspendAnimations from Frame to AnimationController.
https://bugs.webkit.org/show_bug.cgi?id=49073
* WebFrame.cpp:
(WebFrame::suspendAnimations):
(WebFrame::resumeAnimations):
2010-11-05 Brian Weinstein <bweinstein@apple.com>
Reviewed by Anders Carlsson.
Assertion failure in PluginStream::~PluginStream when running userscripts/user-script-plugin-document.html
https://bugs.webkit.org/show_bug.cgi?id=48751
<rdar://problem/8615536>
Always call committedLoad in WebFrameLoaderClient::finishedLoading, even if we have a manual loader. We were
running into a case where we were trying to load an empty plugin document, which uses a manual loader, and
PluginStream::didFinishLoading was never being called. The stream was never being stopped, making us fire
an assert in the PluginStream destructor.
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::finishedLoading):
2010-11-05 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
Make suspendAnimations/resumeAnimations and setCSSAnimations traverse through subframes and remember state
https://bugs.webkit.org/show_bug.cgi?id=46945
* WebFrame.cpp:
(WebFrame::suspendAnimations):
(WebFrame::resumeAnimations):
2010-11-05 Patrick Gansterer <paroga@webkit.org>
Reviewed by David Kilzer.
Replace ARRAYSIZE with WTF_ARRAY_LENGTH
https://bugs.webkit.org/show_bug.cgi?id=48903
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::exceededDatabaseQuota):
* WebKitDLL.cpp:
(DllGetClassObject):
* WebView.cpp:
(WebView::mouseWheel):
2010-11-02 Daniel Bates <dbates@rim.com>
Reviewed by Adam Barth.
For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751
Part 1 of 2.
Substitute FrameTree::uniqueName() for FrameTree::name() in the Apple Windows port.
* WebFrame.cpp:
(WebFrame::name):
2010-11-02 Brady Eidson <beidson@apple.com>
Reviewed by Anders Carlsson.
<rdar://problem/8346191> and https://bugs.webkit.org/show_bug.cgi?id=48868
Implement IMutableWebRequest::setTimeoutInterval
* WebMutableURLRequest.cpp:
(WebMutableURLRequest::setTimeoutInterval):
2010-11-02 Daniel Bates <dbates@rim.com>
Reviewed by Martin Robinson.
Set frame name before appending it to the frame tree in the Apple Windows,
GTK, and EFL ports
https://bugs.webkit.org/show_bug.cgi?id=48806
Make the frame creation process in the Apple Windows-port consistent
with the Mac, Qt, and Haiku ports. In particular, set the name of
the new frame before it's appended to the frame tree.
At this time we cannot test this change since it is being masked by
HTMLFrameElementBase::setName() <http://trac.webkit.org/browser/trunk/WebCore/html/HTMLFrameElementBase.cpp?rev=70976#L160>.
We'll be able to test this once we fix bug #6751.
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::createFrame):
2010-11-01 Jenn Braithwaite <jennb@chromium.org>
Reviewed by Adam Roben.
Windows: Update resource tracking when moving a frame between documents
https://bugs.webkit.org/show_bug.cgi?id=48364
* Interfaces/IWebResourceLoadDelegatePrivate2.idl:Added
Added removeIdentifierForRequest.
* Interfaces/WebKit.idl:
Added IWebResourceLoadDelegatePrivate2.idl.
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::transferLoadingResourceFromPage):
2010-11-01 Brady Eidson <beidson@apple.com>
Reviewed by Anders Carlsson.
<rdar://problem/7660547> and https://bugs.webkit.org/show_bug.cgi?id=48699
Context menu support for WebKit 2.
* WebCoreSupport/WebChromeClient.h:
(WebChromeClient::showContextMenu):
2010-11-01 Adam Roben <aroben@apple.com>
Cancel main resource loads after we hand them off to the media engine
This is the Windows equivalent of r51104. Clearly this code should be
moved to a cross-platform location someday.
Fixes <http://webkit.org/b/48531> <rdar://problem/8606635> Assertion
failure in DocumentLoader::commitData when loading a media document in
WebKit1 on Windows
Reviewed by Dan Bernstein.
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::committedLoad): Cancel the main resource load
after handing off the load to the media engine. This code originally
came from -[WebHTMLRepresentation receivedData:withDataSource:].
* WebFrame.cpp:
(WebFrame::shouldFallBack): Don't fall back when handing the resource
load off to the media engine or a plugin. Added error domain checking
so that we don't rely on error codes being unique.
2010-10-29 Daniel Bates <dbates@rim.com>
No review, rolling out 70971.
http://trac.webkit.org/changeset/70971
https://bugs.webkit.org/show_bug.cgi?id=6751
Rolling out changeset 70971 <http://trac.webkit.org/changeset/70971> since
it caused layout test failures on all bots. In particular, the
child count in a generated frame name differs after this patch. We need
to look into this further.
* WebFrame.cpp:
(WebFrame::name):
2010-10-28 Antonio Gomes <agomes@rim.com>
Reviewed by Ojan Vafai.
Needs a "LinuxEditingBehavior", perhaps with a better name
https://bugs.webkit.org/show_bug.cgi?id=36627
Added the corresponding GTK+ setting to WebCore's EditingUnixBehavior: WebKitEditingUnixBehavior.
* Interfaces/IWebPreferences.idl:
2010-10-29 Daniel Bates <dbates@rim.com>
Reviewed by Adam Barth.
For unnamed frames, window.name returns a generated name
https://bugs.webkit.org/show_bug.cgi?id=6751
Modified Apple Windows-port to use FrameTree::uniqueName().
* WebFrame.cpp:
(WebFrame::name):
2010-10-29 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
Change BackForwardList clients to use BackForwardListImpl to prepare for further refactoring
https://bugs.webkit.org/show_bug.cgi?id=48574
* WebBackForwardList.cpp:
(backForwardListWrappers):
(WebBackForwardList::WebBackForwardList):
(WebBackForwardList::createInstance):
* WebBackForwardList.h:
* WebView.cpp:
(WebView::backForwardList):
Use BackForwardListImpl.
2010-10-29 Adam Roben <aroben@apple.com>
Windows build fix
* WebKitPrefix.h: Touched to force a rebuild.
2010-10-29 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=48576
Let WebKit2 client know when a frame is a frameset
Added a blank implementation of the new FrameLoaderClient method.
* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDidBecomeFrameset):
2010-10-26 Brent Fulgham <bfulgham@webkit.org>
Unreviewed build fix.
* WebView.cpp: Conditionalize includes for CFNetwork-specific
Cookie implementation.
* WebView.h: Conditionalize includes for ACCELERATED_COMPOSITION.
WinCairo doesn't use CoreAnimation.
2010-10-26 Jenn Braithwaite <jennb@chromium.org>
Reviewed by Dmitry Titov.
Resource tracking failure when trying to move a frame between documents
https://bugs.webkit.org/show_bug.cgi?id=44713
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::transferLoadingResourceFromPage):
Empty method.
* WebCoreSupport/WebFrameLoaderClient.h:
2010-10-25 Patrick Gansterer <paroga@webkit.org>
Reviewed by David Kilzer.
Replace _countof with WTF_ARRAY_LENGTH
https://bugs.webkit.org/show_bug.cgi?id=48229
* WebCoreSupport/WebContextMenuClient.cpp:
(isPreInspectElementTagSafari):
* WebView.cpp:
(WebView::interpretKeyEvent):
2010-10-24 Dan Bernstein <mitz@apple.com>
Build fix.
* Interfaces/WebKit.idl: Touched.
2010-10-24 Dan Bernstein <mitz@apple.com>
Reviewed by Anders Carlsson.
Expose HitTestResult::absoluteMediaURL() via WebKit API
https://bugs.webkit.org/show_bug.cgi?id=48219
* Interfaces/IWebView.idl: Added WebElementMediaURLKey.
* WebElementPropertyBag.cpp:
(WebElementPropertyBag::Read): Map WebElementMediaURLKey to absoluteMediaURL().
2010-10-22 Andy Estes <aestes@apple.com>
Fix the Windows build.
* WebCookieManagerCFNet.cpp: Rename CookieStorageWin.h to CookieStorageCFNet.h.
* WebView.cpp: Ditto.
2010-10-22 Jenn Braithwaite <jennb@chromium.org>
Reviewed by Adam Roben.
Windows client needs updating when live iframe element is moved between pages
https://bugs.webkit.org/show_bug.cgi?id=46915
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::didTransferChildFrameToNewDocument):
Update WebView in WebFrame to match that of the current page.
* WebFrame.cpp:
(WebFrame::setWebView):
Added.
* WebFrame.h:
2010-10-22 Sam Weinig <sam@webkit.org>
Fix windows build.
* WebCoreSupport/WebChromeClient.h:
2010-10-22 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
WebKit2 needs to pass the current event modifier flags when requesting a new window
https://bugs.webkit.org/show_bug.cgi?id=48140
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::createWindow):
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchCreatePage):
* WebCoreSupport/WebFrameLoaderClient.h:
Add NavigationAction parameter.
2010-10-21 MORITA Hajime <morrita@google.com>
Unreviewed, touched it to fix the build.
* Interfaces/WebKit.idl:
2010-10-21 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
[Win][DRT] should have LayoutTestController.hasSpellingMarker()
https://bugs.webkit.org/show_bug.cgi?id=47885
Added IWebFramePrivate::hasSpellingMarker() and impelmented it for
LayoutTestController.
* Interfaces/IWebFramePrivate.idl:
* WebFrame.cpp:
(WebFrame::hasSpellingMarker):
* WebFrame.h:
2010-10-20 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by David Levin.
Repost the DatabaseTracker notifications to the main thread, if needed.
https://bugs.webkit.org/show_bug.cgi?id=40655
* WebDatabaseManager.cpp:
(DidModifyOriginData::dispatchToMainThread):
(DidModifyOriginData::DidModifyOriginData):
(DidModifyOriginData::dispatchDidModifyOriginOnMainThread):
(WebDatabaseManager::dispatchDidModifyOrigin):
(WebDatabaseManager::dispatchDidModifyDatabase):
2010-10-20 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Merge ColorSpace and ImageColorSpace enums
https://bugs.webkit.org/show_bug.cgi?id=47922
Renamed ColorSpace enum entries DeviceColorSpace and sRGBColorSpace to ColorSpaceDeviceRGB and ColorSpaceSRGB
to follow webkit style rules.
* FullscreenVideoController.cpp:
(HUDButton::draw):
(HUDSlider::draw):
(FullscreenVideoController::draw):
* WebCoreSupport/WebDragClient.cpp:
(WebDragClient::createDragImageForLink):
* WebKitGraphics.cpp:
(WebDrawText):
2010-10-18 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: disable private browsing for inspector
https://bugs.webkit.org/show_bug.cgi?id=47827
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::openInspectorFrontend):
2010-10-17 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
FrameLoader doesn't need an explicit userGesture parameter
https://bugs.webkit.org/show_bug.cgi?id=47777
Update for the new API.
* WebCoreSupport/WebContextMenuClient.cpp:
(WebContextMenuClient::searchWithGoogle):
2010-10-15 Brian Weinstein <bweinstein@apple.com>
Reviewed by Sam Weinig.
REGRESSION(r69850) Loading apple.com/startpage in WebKit on Windows gets a bad request.
https://bugs.webkit.org/show_bug.cgi?id=47753
<rdar://problem/8558242>
VerQueryValue returns a null terminated string, but we need to strip off the null terminating character
when we turn it into a WebCore string, or else concatenation using this string will break.
* WebView.cpp:
2010-10-15 Jessie Berlin <jberlin@apple.com>
Windows build fix. Unreviewed.
* WebCoreSupport/WebInspectorClient.cpp:
Add a missing include.
2010-10-15 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Replace some String::format() usages by StringConcatenate in WebKit
https://bugs.webkit.org/show_bug.cgi?id=47714
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorFrontendClient::updateWindowTitle):
* WebView.cpp:
(WebView::standardUserAgentWithApplicationName):
(osVersion):
2010-10-14 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: inspector settings/properties/states management
should be extracted into separate class.
We have a lot of flags/values in InspectorController.
Some flags are persisting into profile.
Others are part of inspector state for frontend.
All these flags should keep their values after navigation.
It'd be better to extract these flags/values into separate
class which will care about theirs lifetime.
https://bugs.webkit.org/show_bug.cgi?id=47275
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorFrontendClient::attachWindow):
(WebInspectorFrontendClient::detachWindow):
(WebInspectorFrontendClient::showWindowWithoutNotifications):
2010-10-13 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=43987
Switch XMLHttpRequest, FileReader, and FileReaderSync to use a Stringbuilder
to construct their internal result string. Remove ScriptString (this is now
redundant).
* WebCoreSupport/WebFrameLoaderClient.cpp:
2010-10-12 Adam Roben <aroben@apple.com>
Build TestWebKitAPI on Windows
Fixes <http://webkit.org/b/47552> <rdar://problem/8541708> Make
TestWebKitAPI work on Windows
Reviewed by Sam Weinig.
* WebKit.vcproj/WebKit.sln: Added TestWebKitAPI and
TestWebKitAPIGenerated and made them build just after
WebKitTestRunner.
2010-10-11 Shinichiro Hamaji <hamaji@chromium.org>
Attempt to fix windows build failure.
Remove WebIconFetcher from WebKit and IconFetcher from WebCore
https://bugs.webkit.org/show_bug.cgi?id=47523
* Interfaces/IWebFramePrivate.idl: s/unused1/unused2/
* Interfaces/WebKit.idl: Touched.
* WebFrame.cpp: s/unused1/unused2/
(WebFrame::unused2):
* WebFrame.h: s/unused1/unused2/
2010-10-11 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Remove WebIconFetcher from WebKit and IconFetcher from WebCore
https://bugs.webkit.org/show_bug.cgi?id=47523
Remove all traces of the WebKit WebIconFetcher class. It's SPI that nobody uses.
* Interfaces/IWebFramePrivate.idl:
* Interfaces/IWebIconFetcher.idl: Removed.
* Interfaces/WebKit.idl:
* WebFrame.cpp:
(WebFrame::unused1):
* WebFrame.h:
* WebIconFetcher.cpp: Removed.
* WebIconFetcher.h: Removed.
* WebKit.vcproj/Interfaces.vcproj:
* WebKit.vcproj/WebKit.vcproj:
2010-10-11 Jessie Berlin <jberlin@apple.com>
Reviewed by Darin Adler.
Add Private API for creating a WebKit2 WebSerializedScriptValue from the internal
representation of a WebKit1 WebSerializedJSValue.
https://bugs.webkit.org/show_bug.cgi?id=47439
* Interfaces/IWebSerializedJSValuePrivate.idl:
Because it is taking a void** parameter, getInternalRepresentation must be declared [local].
* WebSerializedJSValue.cpp:
(WebSerializedJSValue::getInternalRepresentation):
* WebSerializedJSValue.h:
2010-10-07 Jessie Berlin <jberlin@apple.com>
Reviewed by Sam Weinig.
Add Private API for creating a WebKit1 WebSerializedJSValue from the internal
representation of a WebKit2 WebSerializedScriptValue.
https://bugs.webkit.org/show_bug.cgi?id=47390
* Interfaces/WebKit.idl:
Generate IWebSerializedJSValuePrivate.
* Interfaces/IWebSerializedJSValuePrivate.idl: Added.
Because it is taking a void* parameter, setInternalRepresentation must be declared [local].
* WebKit.vcproj/Interfaces.vcproj:
Add IWebSerializedJSValue.idl and IWebSerializedJSValuePrivate.idl.
* WebSerializedJSValue.cpp:
(WebSerializedJSValue::QueryInterface):
Since there are now two interfaces that inherit from IUnknown, do not try to cast to
IUnknown* anymore. Cast to IWebSerializedJSValue* instead.
(WebSerializedJSValue::setInternalRepresentation):
Only set the internal representation if it hasn't already been set.
* WebSerializedJSValue.h:
2010-10-04 Jon Honeycutt <jhoneycutt@apple.com>
Prevent an assertion failure when trying to create a protection space
for file/data URLs.
Reviewed by Sam Weinig.
* WebURLProtectionSpace.cpp:
(WebURLProtectionSpace::initWithHost):
Remove the ASSERT_NOT_REACHED().
2010-10-05 Brent Fulgham <bfulgham@webkit.org>
Unreviewed build correction.
* WebKit.vcproj/WebKit.sln: Turn the QTMovieWin project
off for WinCairo release builds. Somehow this was
incorrectly turned on.
2010-10-01 Mark Rowe <mrowe@apple.com>
Build fix.
Clear the executable bit from a number of source files.
* WebView.cpp:
* WebView.h:
2010-09-30 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
Remove remaining calls to deprecatedParseURL
https://bugs.webkit.org/show_bug.cgi?id=26599
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDidFailToStartPlugin):
Call stripLeadingAndTrailingHTMLSpaces instead of deprecatedParseURL.
2010-09-28 Jenn Braithwaite <jennb@chromium.org>
Reviewed by Dmitry Titov.
Added oldPage param to FrameLoaderClient::didTransferChildFrameToNewDocument.
https://bugs.webkit.org/show_bug.cgi?id=46663
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::didTransferChildFrameToNewDocument):
* WebCoreSupport/WebFrameLoaderClient.h:
2010-09-27 Andrey Kosyakov <caseq@chromium.org>
Unreviewed build fix (win; broken in r68371)
* WebFrame.cpp: remove include <WebCore/ResourceHandleWin.h>
2010-09-23 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Reduce minimum DOMTimer interval
https://bugs.webkit.org/show_bug.cgi?id=45362
* WebView.cpp:
Updating set interval call to use Settings' static version inside
one time init block.
2010-09-23 Nate Chapin <japhet@chromium.org>
Unreviewed, build fix.
Move hyperlinkAuditingEnabled to IWebPreferencesPrivate.idl
and touch WebKit.idl
* Interfaces/IWebPreferences.idl:
* Interfaces/IWebPreferencesPrivate.idl:
* Interfaces/WebKit.idl:
* WebView.cpp:
(WebView::notifyPreferencesChanged):
2010-09-23 Nate Chapin <japhet@chromium.org>
Unreviewed, build fix.
Look for hyperlinkAuditingEnabled in the right set of preferences.
* WebView.cpp:
(WebView::notifyPreferencesChanged):
2010-09-23 Nate Chapin <japhet@chromium.org>
Reviewed by Darin Fisher.
Add hyperlink auditing settings (i.e., <a ping>).
https://bugs.webkit.org/show_bug.cgi?id=30458
* Interfaces/IWebPreferences.idl:
* WebPreferenceKeysPrivate.h:
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::hyperlinkAuditingEnabled):
(WebPreferences::setHyperlinkAuditingEnabled):
* WebPreferences.h:
* WebView.cpp:
(WebView::notifyPreferencesChanged):
2010-09-23 Matthew Delaney <mdelaney@apple.com>
Reviewed by Adam Roben.
Create one time initialization block for WebView's initWithFrame
https://bugs.webkit.org/show_bug.cgi?id=46307
* WebView.cpp: Added one time initialization block for webview code
that needs only be run once and not for each webview. This is just as
the mac version WebView.mm does.
2010-09-22 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Martin Robinson.
[WinCairo] Part 2: Update WebKitTestRunner and DumpRenderTree Build.
https://bugs.webkit.org/show_bug.cgi?id=46303.
* WebKit.vcproj/WebKit.sln: Update overall Debug_Cairo and
Release_Cairo configurations to select appropriate build
targets for WebKitTestRunner and MiniBrowser.
2010-09-22 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Martin Robinson.
[WinCairo] Update WebKitTestRunner and DumpRenderTree Build.rt
https://bugs.webkit.org/show_bug.cgi?id=46303.
* WebKit.vcproj/WebKit.sln: Update overall Debug_Cairo and
Release_Cairo configurations to select appropriate build
targets for InjectionBundle.
2010-09-22 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Kenneth Rohde Christiansen.
PluginStrategy should satisfy the needs of Qt
https://bugs.webkit.org/show_bug.cgi?id=45857
No new functionality so no new tests.
* WebCoreSupport/WebPlatformStrategies.cpp:
(WebPlatformStrategies::getPluginInfo):
* WebCoreSupport/WebPlatformStrategies.h:
2010-09-20 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Carlson.
[GTK] enhanced context menu for media elements
https://bugs.webkit.org/show_bug.cgi?id=45021
New localized strings for the media element context-menu.
* WebCoreSupport/WebPlatformStrategies.cpp:
(WebPlatformStrategies::contextMenuItemTagOpenVideoInNewWindow):
(WebPlatformStrategies::contextMenuItemTagOpenAudioInNewWindow):
(WebPlatformStrategies::contextMenuItemTagCopyVideoLinkToClipboard):
(WebPlatformStrategies::contextMenuItemTagCopyAudioLinkToClipboard):
(WebPlatformStrategies::contextMenuItemTagToggleMediaControls):
(WebPlatformStrategies::contextMenuItemTagToggleMediaLoop):
(WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen):
(WebPlatformStrategies::contextMenuItemTagMediaPlay):
(WebPlatformStrategies::contextMenuItemTagMediaPause):
(WebPlatformStrategies::contextMenuItemTagMediaMute):
* WebCoreSupport/WebPlatformStrategies.h:
2010-09-17 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
REGRESSION (r60104): Zoom level is unexpectedly reset on page reload
https://bugs.webkit.org/show_bug.cgi?id=42863
* WebView.cpp:
(WebView::setZoomMultiplier):
Call functions on Frame instead of FrameView.
2010-09-17 Matthew Delaney <mdelaney@apple.com>
Reviewed by Simon Fraser.
Reduce minimum DOMTimer interval
https://bugs.webkit.org/show_bug.cgi?id=45362
* WebView.cpp: Added in a call to set the mimimum allowed DOMTimer to 4ms.
2010-09-17 Simon Fraser <simon.fraser@apple.com>
Reviewed by Chris Marrin.
Remove scroll and clip layers for WKCACFLayerRenderer
https://bugs.webkit.org/show_bug.cgi?id=45922
WKCACFLayerRenderer no longer needs its own layers for managing scrolling
and clipping, because RenderLayerCompositor provides this functionality.
* WebView.cpp:
(WebView::sizeChanged): Moved code that handles the WM_SIZE message
into this method. Use it to resize the layer renderer.
(WebView::WebViewWndProc): Call sizeChanged().
(WebView::updateRootLayerContents): No need to call setScrollFrame() any more.
(WebView::layerRendererBecameVisible): Move this from the header (no need to be inline).
* WebView.h:
2010-09-16 Darin Adler <darin@apple.com>
Reviewed by Andreas Kling.
Reduce use of HTMLInputElement::inputType so we can remove it later
https://bugs.webkit.org/show_bug.cgi?id=45903
* WebFrame.cpp:
(WebFrame::elementDoesAutoComplete): Use isPasswordField.
(WebFrame::elementIsPassword): Use isPasswordField.
2010-09-14 Ada Chan <adachan@apple.com>
Reviewed by Adam Roben.
Add an IWebFramePrivate API to load string as plain text into the WebFrame.
https://bugs.webkit.org/show_bug.cgi?id=45782
* Interfaces/IWebFramePrivate.idl:
* Interfaces/WebKit.idl: Touch the file.
* WebFrame.cpp:
(WebFrame::loadPlainTextString):
* WebFrame.h:
2010-09-13 Enrica Casucci <enrica@apple.com>
Reviewed by Sam Weinig.
Paste should be implemented in WebCore like Copy and Cut for Mac also.
https://bugs.webkit.org/show_bug.cgi?id=45494
<rdar://problem/7660537>
On the Mac platform, the implementation of the paste operation is all done
at the WebKit level. In order to support it on WebKit2 it is necessary to
refactor the code and move this functionality at the level of WebCore like
we already have on Windows.
The original code relies on some in AppKit functions that call back into
WebKit causing problems in WebKit2. All this functionality has been moved
at the level of the editor client where it can be dealt with appropriately.
* WebFrame.cpp:
(WebFrame::canShowMIMETypeASHTML): Added.
2010-09-11 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Make SecurityOrigin::canDisplay an instance function
https://bugs.webkit.org/show_bug.cgi?id=45219
* WebFrame.cpp:
(WebFrame::allowsFollowingLink):
2010-09-10 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Darin Adler.
Add NetworkingContext to avoid layer violations
https://bugs.webkit.org/show_bug.cgi?id=42292
* WebCoreSupport/WebFrameNetworkingContext.cpp:
(WebFrameNetworkingContext::blockedError):
* WebCoreSupport/WebFrameNetworkingContext.h:
2010-09-10 Jer Noble <jer.noble@apple.com>
Reviewed by Simon Fraser.
Movies with track or movie matrices don't display in <video> elements (Safari 5/Windows)
https://bugs.webkit.org/show_bug.cgi?id=45333
The rootChild layer must be set as flipped, otherwise transformed movies will appear
incorrectly rotated.
* FullscreenVideoController.cpp:
(FullscreenVideoController::enterFullscreen):
2010-09-10 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom.
Precursor to <rdar://problem/7660657>
https://bugs.webkit.org/show_bug.cgi?id=45522
* WebFrame.cpp:
* WebFrame.h:
Remove dead code.
* WebView.cpp:
(WebView::WebView):
(WebView::setZoomMultiplier):
(WebView::zoomMultiplier):
(WebView::canMakeTextLarger):
(WebView::makeTextLarger):
(WebView::canMakeTextSmaller):
(WebView::makeTextSmaller):
(WebView::notifyPreferencesChanged):
* WebView.h:
Move tracking of text only zoom here from WebCore.
2010-09-10 Brian Weinstein <bweinstein@apple.com>
Windows Build Fix. Fix some fallout from r67238, currentForm is now off of
SelectionController instead of frame. Also fix a style issue.
* WebFrame.cpp:
(WebFrame::currentForm):
2010-09-10 Adam Barth <abarth@webkit.org>
Reviewed by Darin Fisher.
Move code from WebKit-layer to DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=45569
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::committedLoad):
* WebCoreSupport/WebFrameLoaderClient.h:
2010-09-09 Darin Adler <darin@apple.com>
Reviewed by Adam Barth.
Move functions from Frame to SelectionController as planned
https://bugs.webkit.org/show_bug.cgi?id=45508
* WebView.cpp:
(WebView::selectionRect):
(WebView::centerSelectionInVisibleArea):
Call functions on selection().
2010-09-10 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Main resource bytes shouldn't bounce through FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=45496
Now return the bytes to the DocumentLoader.
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::receivedData):
2010-09-09 Simon Fraser <simon.fraser@apple.com>
Reviewed by Adam Roben.
Scrollbars fail to render in composited iframes.
https://bugs.webkit.org/show_bug.cgi?id=45335
Use LocalWindowsContext when painting scrollbars.
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::paintCustomScrollbar):
(WebChromeClient::paintCustomScrollCorner):
2010-09-08 Darin Adler <darin@apple.com>
Reviewed by Adam Barth.
Move functions from Frame to Editor as planned
https://bugs.webkit.org/show_bug.cgi?id=45218
* WebCoreSupport/WebContextMenuClient.cpp:
(WebContextMenuClient::searchWithGoogle):
* WebFrame.cpp:
(WebFrame::selectedString):
* WebView.cpp:
(WebView::selectedText):
(WebView::prepareCandidateWindow):
(WebView::onIMERequestCharPosition):
Changed call sites to use editor().
2010-09-08 Peter Kasting <pkasting@google.com>
Not reviewed, build fix.
* WebScrollBar.cpp:
(WebScrollBar::setScrollOffsetFromAnimation):
2010-09-08 Peter Kasting <pkasting@google.com>
Not reviewed, build fix.
* WebScrollBar.cpp:
(WebScrollBar::scrollSize):
(WebScrollBar::setScrollOffsetFromAnimation):
2010-09-08 Peter Kasting <pkasting@google.com>
Not reviewed, build fix.
* WebScrollBar.cpp:
(WebScrollBar::setValue):
(WebScrollBar::scrollSize):
(WebScrollBar::setScrollOffsetFromAnimation):
* WebScrollBar.h:
2010-09-08 Adam Barth <abarth@webkit.org>
Attempted Window build fix.
* WebDataSource.cpp:
(WebDataSource::subresourceForURL):
2010-09-08 Adam Barth <abarth@webkit.org>
Rubber-stamped by Eric Seidel.
Rename DocLoader to CachedResourceLoader because that's what it does.
* WebDataSource.cpp:
2010-09-07 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
Clean up a potential resource leak.
https://bugs.webkit.org/show_bug.cgi?id=45198
Several bitmap device context were being created and used,
and destroyed without returning the context to its original
state. This showed up as bitmap leaks in BoundsChecker.
* FullscreenVideoController.cpp:
* WebView.cpp:
(WebView::scrollBackingStore):
(WebView::paint):
2010-09-06 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Rename SecurityOrigin::canLoad to canDisplay
https://bugs.webkit.org/show_bug.cgi?id=45214
Propagate name change.
* WebFrame.cpp:
(WebFrame::allowsFollowingLink):
2010-09-03 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Darin Adler.
Add NetworkingContext to avoid layer violations
https://bugs.webkit.org/show_bug.cgi?id=42292
Add Win's specific implementation of NetworkingContext.
* WebCoreSupport/WebFrameNetworkingContext.cpp:
(WebFrameNetworkingContext::create):
(WebFrameNetworkingContext::userAgent):
(WebFrameNetworkingContext::referrer):
* WebFrame.cpp:
(WebFrame::createNetworkingContext):
* WebFrame.h:
2010-09-03 Adam Roben <aroben@apple.com>
Attempt to fixing Windows nightlies again
The fix in r66438 should be sufficient, but we have to touch
WebKit.idl to force that change to be picked up by the build.
* Interfaces/WebKit.idl: Touched this file to force a build.
2010-09-02 Yury Semikhatsky <yurys@chromium.org>
Reviewed by PavelFeldman.
REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
https://bugs.webkit.org/show_bug.cgi?id=44230
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorFrontendClient::~WebInspectorFrontendClient):
(WebInspectorFrontendClient::closeWindow):
(WebInspectorFrontendClient::disconnectFromBackend):
(WebInspectorFrontendClient::closeWindowWithoutNotifications):
(WebInspectorFrontendClient::destroyInspectorView):
* WebCoreSupport/WebInspectorClient.h:
2010-09-01 Jessie Berlin <jberlin@apple.com>
Reviewed by Adam Roben.
WebViews should allow their parent windows to handle WM_MOUSEACTIVATE messages.
https://bugs.webkit.org/show_bug.cgi?id=45047
* WebView.cpp:
(WebView::WebViewWndProc):
2010-08-31 Dave Hyatt <hyatt@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=44863, disentangle style recalc from layout, so that
the former can occur in more places without having to do the latter.
* WebFrame.cpp:
(WebFrame::paintDocumentRectToContext):
* WebView.cpp:
(WebView::updateBackingStore):
2010-08-30 Adam Roben <aroben@apple.com>
Fix crash on launch on Windows due to changing IWebFramePrivate's
vtable
This regressed in r65107.
Fixes <http://webkit.org/b/44755>.
Rubber-stamped by Jon Honeycutt.
* Interfaces/IWebFramePrivate.idl: Moved suspendAnimations and
resumeAnimations to the end of the interface so that the vtable will
match what Safari expects.
2010-08-30 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r66198.
http://trac.webkit.org/changeset/66198
https://bugs.webkit.org/show_bug.cgi?id=44856
It made tests crash on Qt bot (Requested by Ossy_ on #webkit).
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorFrontendClient::~WebInspectorFrontendClient):
(WebInspectorFrontendClient::closeWindow):
(WebInspectorFrontendClient::closeWindowWithoutNotifications):
(WebInspectorFrontendClient::destroyInspectorView):
* WebCoreSupport/WebInspectorClient.h:
2010-08-27 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
https://bugs.webkit.org/show_bug.cgi?id=44230
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorFrontendClient::~WebInspectorFrontendClient):
(WebInspectorFrontendClient::closeWindow):
(WebInspectorFrontendClient::disconnectFromBackend):
(WebInspectorFrontendClient::closeWindowWithoutNotifications):
(WebInspectorFrontendClient::destroyInspectorView):
* WebCoreSupport/WebInspectorClient.h:
2010-08-26 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Revert r66103 since Qt tests are failing.
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorFrontendClient::~WebInspectorFrontendClient):
(WebInspectorFrontendClient::closeWindow):
(WebInspectorFrontendClient::closeWindowWithoutNotifications):
(WebInspectorFrontendClient::destroyInspectorView):
* WebCoreSupport/WebInspectorClient.h:
2010-08-26 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
REGRESSION: Crash occurs at objc_msgSend when closing a window that is displaying the web inspector
https://bugs.webkit.org/show_bug.cgi?id=44230
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorFrontendClient::~WebInspectorFrontendClient):
(WebInspectorFrontendClient::closeWindow):
(WebInspectorFrontendClient::disconnectFromBackend):
(WebInspectorFrontendClient::closeWindowWithoutNotifications):
(WebInspectorFrontendClient::destroyInspectorView):
* WebCoreSupport/WebInspectorClient.h:
2010-08-24 Ada Chan <adachan@apple.com>
Reviewed by Steve Falkenburg.
<rdar://problem/8185379> Possible null dereference in WebView::canShowMIMEType.
https://bugs.webkit.org/show_bug.cgi?id=44564
* WebView.cpp:
(WebView::canShowMIMEType): Null check m_page->pluginData() since that can return NULL
if plugins are disabled.
2010-08-22 Daniel Bates <dbates@rim.com>
Reviewed by Eric Seidel.
Encapsulate document marker management into DocumentMarkerController
https://bugs.webkit.org/show_bug.cgi?id=44383
Modify call sites in the Apple Windows port to use DocumentMarkerController.
No functionality was changed, so no new tests.
* WebFrame.cpp:
(WebFrame::unmarkAllMisspellings):
(WebFrame::unmarkAllBadGrammar):
* WebView.cpp:
(WebView::rectsForTextMatches):
2010-08-18 Jessie Berlin <jberlin@apple.com>
Reviewed by Adam Roben.
Bug 44180 - WebView::paint fails to paint a child WebView of a Layered Window.
https://bugs.webkit.org/show_bug.cgi?id=44180
Decide to end painting if the m_backingStoreBitmap is null after the call to
ensureBackingStore() instead of when the rcPaint rect filled by BeginPaint is empty.
The rcPaint rect filled by BeginPaint is always empty for a child WebView of a Layered
Window, even if GetUpdateRect and GetUpdateRgn report a non-empty region that needs
painting.
* WebView.cpp:
(WebView::paint):
2010-08-17 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Darin Adler.
Add NetworkingContext to avoid layer violations
https://bugs.webkit.org/show_bug.cgi?id=42292
Preparation: Just add the files to the build system.
* WebCoreSupport/WebFrameNetworkingContext.cpp: Added.
Empty placeholder for now.
* WebCoreSupport/WebFrameNetworkingContext.h: Added.
Placeholder with tentative code that might be changed when landing
the rest of it.
* WebKit.vcproj/WebKit.vcproj: Added new files.
2010-08-17 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
Navigating back/forward during a modal dialog causes a crash when the modal dialog is dismissed.
<rdar://problem/8313579> and https://bugs.webkit.org/show_bug.cgi?id=44131
* WebView.cpp:
(WebView::canGoBack): Return false if loads are deferred.
(WebView::canGoForward): Ditto.
2010-08-16 Kinuko Yasuda <kinuko@chromium.org>
Unreviewed; build fix attempt for Windows.
* DefaultDownloadDelegate.cpp:
2010-08-12 Jeremy Orlow <jorlow@chromium.org>
Revert for now
https://bugs.webkit.org/show_bug.cgi?id=43794
* WebView.cpp:
(WebView::initWithFrame):
2010-08-12 Jeremy Orlow <jorlow@chromium.org>
Build fix. Matches solutions in qt and mac ports for
https://bugs.webkit.org/show_bug.cgi?id=43794
* WebView.cpp:
(WebView::initWithFrame):
2010-08-10 Gavin Barraclough <barraclough@apple.com>
Build fix (update more includes)
* WebKitDLL.h:
* WebLocalizableStrings.cpp:
* WebNotificationCenter.cpp:
* WebPreferences.cpp:
2010-08-10 Chris Marrin <cmarrin@apple.com>
Reviewed by Oliver Hunt.
Add suspendAnimations/resumeAnimation API to DRT
https://bugs.webkit.org/show_bug.cgi?id=43733
Win specific API
* Interfaces/IWebFramePrivate.idl:
* WebFrame.cpp:
(WebFrame::suspendAnimations):
(WebFrame::resumeAnimations):
* WebFrame.h:
2010-08-06 Gavin Barraclough <barraclough@apple.com>
Rubber stamped by Sam Weinig
Bug 43594 - Add string forwards to Forward.h
This allows us to remove forward declarations for these classes from
WebCore/WebKit (a step in moving these class from WebCore:: to WTF::).
* COMVariantSetter.h:
* MarshallingHelpers.h:
* WebCoreSupport/WebContextMenuClient.h:
* WebCoreSupport/WebPluginHalterClient.h:
* WebHistory.h:
2010-08-06 Jessie Berlin <jberlin@apple.com>
Roll out http://trac.webkit.org/changeset/64801, which broke the Safari Windows Build.
Unreviewed.
* COMVariantSetter.h:
* MarshallingHelpers.h:
* WebCoreSupport/WebContextMenuClient.h:
* WebCoreSupport/WebPluginHalterClient.h:
* WebHistory.h:
2010-08-05 Jessie Berlin <jberlin@apple.com>
Reviewed by Jon Honeycutt.
Bug 43593 - WebView::backingStore should check if m_backingStoreBitmap is NULL.
https://bugs.webkit.org/show_bug.cgi?id=43593
* WebView.cpp:
(WebView::backingStore):
If m_backingStoreBitmap is NULL, return E_FAIL.
2010-08-05 Gavin Barraclough <barraclough@apple.com>
Rubber stamped by Sam Weinig
Bug 43594 - Add string forwards to Forward.h
This allows us to remove forward declarations for these classes from
WebCore/WebKit (a step in moving these class from WebCore:: to WTF::).
* COMVariantSetter.h:
* MarshallingHelpers.h:
* WebCoreSupport/WebContextMenuClient.h:
* WebCoreSupport/WebPluginHalterClient.h:
* WebHistory.h:
2010-08-03 Adam Roben <aroben@apple.com>
Turn on PLATFORM_STRATEGIES on Windows
Fixes <http://webkit.org/b/43431>.
Reviewed by Anders Carlsson.
* WebCoreLocalizedStrings.cpp: Removed.
* WebCoreSupport/WebPlatformStrategies.cpp: Added. Based on the Mac
equivalent.
(WebPlatformStrategies::initialize): Creates the singleton instance.
(WebPlatformStrategies::WebPlatformStrategies): Registers the
singleton instance as the PlatformStrategies instance for WebCore.
(WebPlatformStrategies::createPluginStrategy):
(WebPlatformStrategies::createLocalizationStrategy):
(WebPlatformStrategies::createVisitedLinkStrategy):
Return ourselves as the strategy.
(WebPlatformStrategies::refreshPlugins):
(WebPlatformStrategies::getPluginInfo):
Moved code here from WebCore's PluginDataWin.cpp file.
(WebPlatformStrategies::searchableIndexIntroduction):
(WebPlatformStrategies::submitButtonDefaultLabel):
(WebPlatformStrategies::inputElementAltText):
(WebPlatformStrategies::resetButtonDefaultLabel):
(WebPlatformStrategies::fileButtonChooseFileLabel):
(WebPlatformStrategies::fileButtonNoFileSelectedLabel):
(WebPlatformStrategies::contextMenuItemTagOpenLinkInNewWindow):
(WebPlatformStrategies::contextMenuItemTagDownloadLinkToDisk):
(WebPlatformStrategies::contextMenuItemTagCopyLinkToClipboard):
(WebPlatformStrategies::contextMenuItemTagOpenImageInNewWindow):
(WebPlatformStrategies::contextMenuItemTagDownloadImageToDisk):
(WebPlatformStrategies::contextMenuItemTagCopyImageToClipboard):
(WebPlatformStrategies::contextMenuItemTagOpenFrameInNewWindow):
(WebPlatformStrategies::contextMenuItemTagCopy):
(WebPlatformStrategies::contextMenuItemTagGoBack):
(WebPlatformStrategies::contextMenuItemTagGoForward):
(WebPlatformStrategies::contextMenuItemTagStop):
(WebPlatformStrategies::contextMenuItemTagReload):
(WebPlatformStrategies::contextMenuItemTagCut):
(WebPlatformStrategies::contextMenuItemTagPaste):
(WebPlatformStrategies::contextMenuItemTagNoGuessesFound):
(WebPlatformStrategies::contextMenuItemTagIgnoreSpelling):
(WebPlatformStrategies::contextMenuItemTagLearnSpelling):
(WebPlatformStrategies::contextMenuItemTagSearchWeb):
(WebPlatformStrategies::contextMenuItemTagLookUpInDictionary):
(WebPlatformStrategies::contextMenuItemTagOpenLink):
(WebPlatformStrategies::contextMenuItemTagIgnoreGrammar):
(WebPlatformStrategies::contextMenuItemTagSpellingMenu):
(WebPlatformStrategies::contextMenuItemTagCheckSpelling):
(WebPlatformStrategies::contextMenuItemTagCheckSpellingWhileTyping):
(WebPlatformStrategies::contextMenuItemTagCheckGrammarWithSpelling):
(WebPlatformStrategies::contextMenuItemTagFontMenu):
(WebPlatformStrategies::contextMenuItemTagBold):
(WebPlatformStrategies::contextMenuItemTagItalic):
(WebPlatformStrategies::contextMenuItemTagUnderline):
(WebPlatformStrategies::contextMenuItemTagOutline):
(WebPlatformStrategies::contextMenuItemTagWritingDirectionMenu):
(WebPlatformStrategies::contextMenuItemTagTextDirectionMenu):
(WebPlatformStrategies::contextMenuItemTagDefaultDirection):
(WebPlatformStrategies::contextMenuItemTagLeftToRight):
(WebPlatformStrategies::contextMenuItemTagRightToLeft):
(WebPlatformStrategies::contextMenuItemTagShowSpellingPanel):
(WebPlatformStrategies::contextMenuItemTagInspectElement):
(WebPlatformStrategies::searchMenuNoRecentSearchesText):
(WebPlatformStrategies::searchMenuRecentSearchesText):
(WebPlatformStrategies::searchMenuClearRecentSearchesText):
(WebPlatformStrategies::AXWebAreaText):
(WebPlatformStrategies::AXLinkText):
(WebPlatformStrategies::AXListMarkerText):
(WebPlatformStrategies::AXImageMapText):
(WebPlatformStrategies::AXHeadingText):
(WebPlatformStrategies::AXDefinitionListTermText):
(WebPlatformStrategies::AXDefinitionListDefinitionText):
(WebPlatformStrategies::AXButtonActionVerb):
(WebPlatformStrategies::AXRadioButtonActionVerb):
(WebPlatformStrategies::AXTextFieldActionVerb):
(WebPlatformStrategies::AXCheckedCheckBoxActionVerb):
(WebPlatformStrategies::AXUncheckedCheckBoxActionVerb):
(WebPlatformStrategies::AXLinkActionVerb):
(WebPlatformStrategies::AXMenuListActionVerb):
(WebPlatformStrategies::AXMenuListPopupActionVerb):
(WebPlatformStrategies::unknownFileSizeText):
(WebPlatformStrategies::uploadFileText):
(WebPlatformStrategies::allFilesText):
(WebPlatformStrategies::missingPluginText):
(WebPlatformStrategies::crashedPluginText):
(WebPlatformStrategies::imageTitle):
(WebPlatformStrategies::multipleFileUploadText):
(WebPlatformStrategies::mediaElementLoadingStateText):
(WebPlatformStrategies::mediaElementLiveBroadcastStateText):
(WebPlatformStrategies::localizedMediaControlElementString):
(WebPlatformStrategies::localizedMediaControlElementHelpText):
(WebPlatformStrategies::localizedMediaTimeDescription):
(WebPlatformStrategies::validationMessageValueMissingText):
(WebPlatformStrategies::validationMessageTypeMismatchText):
(WebPlatformStrategies::validationMessagePatternMismatchText):
(WebPlatformStrategies::validationMessageTooLongText):
(WebPlatformStrategies::validationMessageRangeUnderflowText):
(WebPlatformStrategies::validationMessageRangeOverflowText):
(WebPlatformStrategies::validationMessageStepMismatchText):
Moved code here from WebCoreLocalizedStrings.cpp (and slightly cleaned
it up).
(WebPlatformStrategies::isLinkVisited):
(WebPlatformStrategies::addVisitedLink):
Copied code from WebKit/mac/WebCoreSupport/WebPlatformStrategies.mm.
* WebCoreSupport/WebPlatformStrategies.h: Added.
* WebKit.vcproj/WebKit.vcproj: Removed WebCoreLocalizedStrings, added
WebPlatformStrategies.
* WebView.cpp:
(WebView::initWithFrame): Initialize WebPlatformStrategies.
2010-08-03 Alexey Proskuryakov <ap@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=42939
WebEditorClient::didBeginEditing is never called in WebKit2
* WebView.cpp: (WebView::WebViewWndProc): Removed a call to setFocusedFrame. WebCore will
now set it to main frame, and besides, this call should have been before setFocused(), not
after it. My understanding is that we weren't getting all the same editing delegates on Windows,
so this change may make WebKit1 on Windows behave more like Mac - but I haven't tested it.
2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Fisher.
PopupMenu refactoring in preparation to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42592
As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::selectItemWritingDirectionIsNatural):
(WebChromeClient::createPopupMenu):
(WebChromeClient::createSearchPopupMenu):
* WebCoreSupport/WebChromeClient.h:
2010-08-02 Jon Honeycutt <jhoneycutt@apple.com>
Move InjectedBundle.vcproj to where the other WebKitTestRunner vcprojs live.
Reviewed by Sam Weinig.
* WebKit.vcproj/WebKit.sln:
2010-08-02 Jeremy Orlow <jorlow@chromium.org>
Speculative revert of 64425 due to Chromium instability
https://bugs.webkit.org/show_bug.cgi?id=43347
* WebCoreSupport/WebChromeClient.cpp:
* WebCoreSupport/WebChromeClient.h:
* WebView.cpp:
(WebView::mouseWheel):
2010-07-31 Luiz Agostini <luiz.agostini@openbossa.org>
Build fix: Windows.
* WebView.cpp:
(WebView::mouseWheel):
2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Fisher.
PopupMenu refactoring in preparation to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42592
As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::selectItemWritingDirectionIsNatural):
(WebChromeClient::createPopupMenu):
(WebChromeClient::createSearchPopupMenu):
* WebCoreSupport/WebChromeClient.h:
2010-07-31 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r64422.
http://trac.webkit.org/changeset/64422
https://bugs.webkit.org/show_bug.cgi?id=43304
Build fixes are needed for Snow Leopard and Windows.
(Requested by lca on #webkit).
* WebCoreSupport/WebChromeClient.cpp:
* WebCoreSupport/WebChromeClient.h:
2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org>
Reviewed by Darin Fisher.
PopupMenu refactoring in preparation to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42592
As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
instances, concrete classes that inherit from ChromeClient needed to be changed to
implement the new methods.
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::selectItemWritingDirectionIsNatural):
(WebChromeClient::createPopupMenu):
(WebChromeClient::createSearchPopupMenu):
* WebCoreSupport/WebChromeClient.h:
2010-07-31 Daniel Bates <dbates@rim.com>
Attempt to fix the Windows build after changeset 64409 <http://trac.webkit.org/changeset/64409>.
* WebFrame.cpp:
(WebFrame::setPrinting):
2010-07-30 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
<rdar://problem/8257783> Short documents may print a second blank page
https://bugs.webkit.org/show_bug.cgi?id=43271
* WebFrame.cpp:
(WebFrame::setPrinting): Updated for changes to Frame::setPrinting(). Passing 0 for the
page height, which maintains existing behavior.
2010-07-30 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by David Kilzer.
Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)
https://bugs.webkit.org/show_bug.cgi?id=40627
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::reachedApplicationCacheOriginQuota):
* WebCoreSupport/WebChromeClient.h:
2010-07-26 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Page clients should be passed to Page constructor via structure of pointers
https://bugs.webkit.org/show_bug.cgi?id=42834
* WebView.cpp:
(WebView::initWithFrame):
2010-07-27 Steve Block <steveblock@google.com>
Reviewed by Alexey Proskuryakov.
Client-based Geolocation does not pass enableHighAccuracy option to controller and client
https://bugs.webkit.org/show_bug.cgi?id=40374
Stub out setEnableHighAccuracy method for the Win port.
* WebCoreSupport/WebGeolocationControllerClient.h:
(WebGeolocationControllerClient::setEnableHighAccuracy):
2010-07-22 Sam Weinig <sam@webkit.org>
Reviewed by Maciej Stachowiak.
Fix for <rdar://problem/8222626>
Send textDidChangeInTextField delegate callback only in response to typing or other forms of user text input.
The function name no longer perfectly matches the behavior, but I didn't want to break any existing clients. Maybe we
should migrate to a new function name eventually
* WebCoreSupport/WebEditorClient.cpp:
(WebEditorClient::textDidChangeInTextField):
2010-07-21 Brady Eidson <beidson@apple.com>
Reviewed by Geoffrey Garen.
Break out "scheme registration" functionality from SecurityOrigin to a SchemeRegistry
https://bugs.webkit.org/show_bug.cgi?id=42783
* WebView.cpp:
(WebView::registerURLSchemeAsLocal):
(WebView::registerURLSchemeAsSecure):
2010-07-20 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
WebKit on Windows should build optionally with an unversioned ICU DLL
https://bugs.webkit.org/show_bug.cgi?id=42722
<rdar://problem/8211767> WebKit needs to link against unversioned ICU
To get the proper value for U_DISABLE_RENAMING into all source files, we force
the include of ICUVersion.h (our generated header) via the compiler options.
* WebKit.vcproj/WebKit.vcproj: Add forced include of ICUVersion.h.
2010-07-21 Adam Roben <aroben@apple.com>
Update WebKit.sln for InjectedBundle's Debug_Internal configuration
Fixes <http://webkit.org/b/42749> InjectedBundle's build
configurations are screwy
Reviewed by Darin Adler.
* WebKit.vcproj/WebKit.sln: Build the Debug_Internal variant of
InjectedBundle when we're using the Debug_Internal solution
configuration.
2010-07-21 Adam Roben <aroben@apple.com>
Add MiniBrowser to WebKit.sln
It is the last project to build.
Fixes <http://webkit.org/b/42747> build-webkit should build
MiniBrowser
Reviewed by Darin Adler.
* WebKit.vcproj/WebKit.sln: Added MiniBrowser, and made it depend on
WebKitTestRunner.
2010-07-20 Adam Roben <aroben@apple.com>
Add WebKitTestRunner and friends to WebKit.sln
We added these projects to WebKit2.sln in r63585, but removed them
again in r63600 because WebKitTestRunner required getopt, which
doesn't exist in WebKitAuxiliaryLibrary. r63700 and r63788 removed the
use of getopt in WebKitTestRunner, so we can now add it to WebKit.sln
(which has replaced WebKit2.sln).
Fixes <http://webkit.org/b/42711> WebKit.sln should build
WebKitTestRunner
Reviewed by Steve Falkenburg.
* WebKit.vcproj/WebKit.sln: Added the following projects to the end of
the build order (in first-built to last-built order):
InjectedBundleGenerated, InjectedBundle, WebKitTestRunner. Also
removed an unnecessary dependency from testapi on WebKit2WebProcess.
2010-07-19 Daniel Bates <dbates@rim.com>
Reviewed by Adam Roben.
[Win] Implement LayoutTestController::markerTextForListItem()
https://bugs.webkit.org/show_bug.cgi?id=37930
Implements support for markerTextForListItem in the Windows port.
* DOMCoreClasses.cpp:
(DOMElement::markerTextForListItem): Added.
* DOMCoreClasses.h:
* Interfaces/DOMPrivate.idl: Added declaration for markerTextForListItem().
* Interfaces/IWebViewPrivate.idl: Added declaration for elementFromJS().
* Interfaces/WebKit.idl: Touch it to force a rebuild (and for good luck :-)).
* WebView.cpp:
(WebView::elementFromJS): Added.
* WebView.h:
2010-07-16 Zhe Su <suzhe@chromium.org>
Reviewed by Darin Adler.
REGRESSION(r61484): Broke focus behaviour on Qt and probably other platforms
https://bugs.webkit.org/show_bug.cgi?id=42253
Dummy implementation of EditorClient::willSetInputMethodState.
* WebCoreSupport/WebEditorClient.cpp:
(WebEditorClient::willSetInputMethodState):
* WebCoreSupport/WebEditorClient.h:
2010-07-16 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Make JS memory stats available via 'Performance' object (Web Timing).
This statistics is populated only if 'WebKitMemoryInfoEnabled'
preference is set.
'console.memory' is kept until Web Timing object becomes visible by
default (currently it is hidden under compile-time flag). These stats
are guarded with the same preference.
https://bugs.webkit.org/show_bug.cgi?id=41617
* Interfaces/IWebPreferencesPrivate.idl:
* WebPreferenceKeysPrivate.h:
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::memoryInfoEnabled):
(WebPreferences::setMemoryInfoEnabled):
* WebPreferences.h:
* WebView.cpp:
(WebView::notifyPreferencesChanged):
2010-07-14 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Steve Falkenburg.
Patch for https://bugs.webkit.org/show_bug.cgi?id=42299
Correct WinCairo build for new WebKit2 project structure.
* WebKit.vcproj/WebKit.sln:
2010-07-14 Sam Weinig <sam@webkit.org>
Reviewed by Darin Adler.
Patch for https://bugs.webkit.org/show_bug.cgi?id=42232
Make changing Cursors work in WebKit2.
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::setCursor):
We now need to grab the native cursor out of the WebCore cursor.
(WebChromeClient::setLastSetCursorToCurrentCursor):
Sets the WebView's "last set cursor" to be the current cursor so that
the cursor is set correctly for plugins.
* WebCoreSupport/WebChromeClient.h:
* WebView.cpp:
(WebView::WebView):
(WebView::WebViewWndProc):
* WebView.h:
(WebView::setLastCursor):
Change the "last set cursor" to be stored as a member instead of a global.
2010-07-13 Steve Falkenburg <sfalken@apple.com>
Windows build fix.
Make WebKit.sln build WebKit.dll as it used to in the past.
(sln is updated to include necessary projects)
* WebKit.vcproj/WebKit.sln:
2010-07-13 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Windows build fix
* Interfaces/WebKit.idl: Touched to force a build
2010-07-07 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Darin Adler.
Prevent assertion/duplicate loads for non-deferred subtitute-data loads
https://bugs.webkit.org/show_bug.cgi?id=30879
MainResourceLoader uses the member m_initialRequest to store requests for future
deferred loads. When doing the actual load in handleDataLoadNow(), we therefore
have to clear this request so that subsequent entries into the loader will not
start yet another load.
This can happen as a result of a PageGroupLoadDeferrer going out of scope when
returning from Chrome::runJavaScriptAlert(), which calls setDeferredLoading(false),
but only in the case of using both substitute-data and non-deferred main resource
load together. That's why two new DRT functions were added:
* queueLoadHTMLString()
* setDeferMainResourceLoad()
The change adds DRT hooks for Mac, Win and Qt for these two functions. For Mac
and Win the hook uses new SPI in WebDataSource. For Qt a new static member was
added to the FrameLoaderClientQt and accessed though DumpRenderTreeSupportQt.
* Interfaces/IWebDataSource.idl:
* WebDataSource.cpp:
(WebDataSource::setDeferMainResourceDataLoad):
* WebDataSource.h:
2010-07-12 Steve Falkenburg <sfalken@apple.com>
Reviewed by Alice Liu.
<rdar://problem/8113038> WebKit1 and WebKit2 should build as a single DLL
https://bugs.webkit.org/show_bug.cgi?id=40921
Pre-WebKit2 WebKit now builds into a static library named WebKitLib.lib.
WebKit.dll now links in WebCore.lib, WebKitLib.lib and WebKit2 code.
This is a first step. We'll likely want to migrate the remainder of
the non-deprecated WebKit code (strings, DLLMain, resources) into WebKit2.
* WebKit.vcproj/WebKit.def: Removed.
* WebKit.vcproj/WebKit.make: Don't fail if WebKit doesn't produce a DLL.
* WebKit.vcproj/WebKit.vcproj: Build WebKit as a static lib.
Renamed project name to WebKitLib to avoid confusion and naming conflicts.
Generate intermediate pdb file for debuggability of static lib.
Removed DLL-related options.
* WebKit.vcproj/deleteButton.png: Removed.
* WebKit.vcproj/deleteButtonPressed.png: Removed.
* WebKit.vcproj/fsVideoAudioVolumeHigh.png: Removed.
* WebKit.vcproj/fsVideoAudioVolumeLow.png: Removed.
* WebKit.vcproj/fsVideoExitFullscreen.png: Removed.
* WebKit.vcproj/fsVideoPause.png: Removed.
* WebKit.vcproj/fsVideoPlay.png: Removed.
* WebKit.vcproj/missingImage.png: Removed.
* WebKit.vcproj/nullplugin.png: Removed.
* WebKit.vcproj/panEastCursor.png: Removed.
* WebKit.vcproj/panIcon.png: Removed.
* WebKit.vcproj/panNorthCursor.png: Removed.
* WebKit.vcproj/panNorthEastCursor.png: Removed.
* WebKit.vcproj/panNorthWestCursor.png: Removed.
* WebKit.vcproj/panSouthCursor.png: Removed.
* WebKit.vcproj/panSouthEastCursor.png: Removed.
* WebKit.vcproj/panSouthWestCursor.png: Removed.
* WebKit.vcproj/panWestCursor.png: Removed.
* WebKit.vcproj/searchCancel.png: Removed.
* WebKit.vcproj/searchCancelPressed.png: Removed.
* WebKit.vcproj/searchMagnifier.png: Removed.
* WebKit.vcproj/searchMagnifierResults.png: Removed.
* WebKit.vcproj/textAreaResizeCorner.png: Removed.
* WebKit.vcproj/verticalTextCursor.png: Removed.
* WebKit.vcproj/zoomInCursor.png: Removed.
* WebKit.vcproj/zoomOutCursor.png: Removed.
2010-07-08 Aaron Boodman <aa@chromium.org>
Reviewed by Timothy Hatcher.
Add the ability for user scripts and user styles to affect just the top frame.
https://bugs.webkit.org/show_bug.cgi?id=41529
* WebView.cpp:
(WebView::addUserScriptToGroup):
(WebView::addUserStyleSheetToGroup):
2010-07-08 Adele Peterson <adele@apple.com>
Reviewed by Jon Honeycutt, Adam Roben, and Darin Adler.
Fix for https://bugs.webkit.org/show_bug.cgi?id=41721
<rdar://problem/8158561> Missing plug-in indicator should have a pressed state
Implement shouldMissingPluginMessageBeButton.
* WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::shouldMissingPluginMessageBeButton):
* WebCoreSupport/WebChromeClient.h:
2010-07-07 Anders Carlsson <andersca@apple.com>
Reviewed by Simon Fraser.
Rename TestNetscapePlugin.subproj and move platform specific files to subdirectories
https://bugs.webkit.org/show_bug.cgi?id=41781
* WebKit.vcproj/WebKit.sln:
2010-07-07 Sam Weinig <sam@webkit.org>
Reviewed by Anders Carlsson.
Patch for https://bugs.webkit.org/show_bug.cgi?id=41772
Add basic piping for BackForwardControllerClient.
* WebView.cpp:
(WebView::initWithFrame):
2010-07-07 Adam Roben <aroben@apple.com>
Windows build fix
* Interfaces/WebKit.idl: Touched to force a build.
2010-07-06 Steve Falkenburg <sfalken@apple.com>
Reviewed by Simon Fraser.
Expose URL matching from WebUserContentURLPattern
https://bugs.webkit.org/show_bug.cgi?id=41726
<rdar://problem/7910144>
We previously had a way to construct WebUserContentURLPattern
instances via WebKit, but no way for callers to perform matching.
This patch adds the matchesURL functionality to allow for this.
* Interfaces/IWebUserContentURLPattern.idl: Added matchesURL.
* Interfaces/IWebView.idl: Touch to force a build.
* WebUserContentURLPattern.cpp:
(WebUserContentURLPattern::matchesURL): Added. Calls through to WebCore::UserContentURLPattern::matches.
* WebUserContentURLPattern.h: Added matchesURL.
2010-07-03 Jon Honeycutt <jhoneycutt@apple.com>
The missing plug-in indicator should be clickable
https://bugs.webkit.org/show_bug.cgi?id=41550
<rdar://problem/8132162>
From an original patch by Kevin Decker.
Reviewed by Darin Adler.
* Interfaces/IWebUIDelegatePrivate.idl:
Added a new delegate interface, and declare a function
didPressMissingPluginButton().
* Interfaces/WebKit.idl:
Touch this file to force interfaces to be rebuilt.
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::missingPluginButtonClicked):
Get the UI delegate, and query it for IWebUIDelegatePrivate3. Call its
didPressMissingPluginButton() function.
* WebCoreSupport/WebChromeClient.h:
Declare an override of missingPluginButtonClicked().
2010-07-03 Erik Arvidsson <arv@chromium.org>
Reviewed by Ojan Vafai.
Fix issue where a contextmenu event was reporting the wrong target
if the context menu was shown due to pressing the context menu key
(or Shift+F10).
* WebView.cpp:
(WebView::handleContextMenuEvent):
2010-07-01 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adele Peterson.
Provide a WebView preference to disable DNS prefetching on Windows
https://bugs.webkit.org/show_bug.cgi?id=41504
<rdar://problem/8151939>
* Interfaces/IWebPreferencesPrivate.idl: Added isDNSPrefetchingEnabled, setDNSPrefetchingEnabled.
* Interfaces/WebKit.idl: Touched to force IDL build.
* WebPreferenceKeysPrivate.h: Added WebKitDNSPrefetchingEnabledPreferenceKey.
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings): Default prefetch to true.
(WebPreferences::setDNSPrefetchingEnabled): Added.
(WebPreferences::isDNSPrefetchingEnabled): Added.
* WebPreferences.h: Added isDNSPrefetchingEnabled, setDNSPrefetchingEnabled.
* WebView.cpp:
(WebView::notifyPreferencesChanged): Propagate prefetch pref into settings.
2010-06-21 Nate Chapin <japhet@chromium.org>
Unreviewed, Windows build fix.
Update WebFrame to use FrameLoaderStateMachine in
firstLayoutDone().
* WebFrame.cpp:
(WebFrame::firstLayoutDone):
2010-06-15 Dumitru Daniliuc <dumi@chromium.org>
Reviewed by Adam Barth.
Move isAvailable()/setIsAvailable() from Database/DatabaseSync to AbstractDatabase.
https://bugs.webkit.org/show_bug.cgi?id=39041
* WebView.cpp:
(WebView::notifyPreferencesChanged):
2010-06-16 Adam Roben <aroben@apple.com>
Add a "forPrinting" boolean parameter to
IWebFramePrivate::renderTreeAsExternalRepresentation
Fixes <http://webkit.org/b/40727> Respect
LayoutTestController::isPrinting on Windows.
Reviewed by Dan Bernstein.
* Interfaces/IWebFramePrivate.idl: Renamed the current
renderTreeAsExternalRepresentation to unused1, and added a new version
that takes a boolean "forPrinting" parameter.
* Interfaces/WebKit.idl: Touched to force a build.
* WebFrame.cpp:
(WebFrame::renderTreeAsExternalRepresentation): Added a boolean
"forPrinting" parameter, and used it to tell externalRepresentation
what kind of behavior to use.
* WebFrame.h: Renamed the old renderTreeAsExternalRepresentation and
added the new one.
2010-06-15 Darin Adler <darin@apple.com>
Reviewed by Adam Barth.
Move functions out of Frame class that were marked "move to Chrome"
https://bugs.webkit.org/show_bug.cgi?id=39636
* WebView.cpp:
(WebView::shouldClose): Call shouldClose on FrameLoader instead of
going through Frame.
2010-06-14 Adam Roben <aroben@apple.com>
Add WebKitLauncherWin to WebKit.sln
Fixes <http://webkit.org/b/40583>.
Reviewed by Darin Adler.
* WebKit.vcproj/WebKit.sln: Added WebKitLauncherWin.vcproj. It depends
on WebKitAPITest, so is the last project to build. (Also removed
QTMovieWin's direct dependency on JavaScriptCore, since it already has
an indirect dependency on it.)
2010-06-14 Chang Shu <chang.shu@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[win] Make windows compile after API changes.
https://bugs.webkit.org/show_bug.cgi?id=40434
* WebKitGraphics.cpp:
(WebDrawText):
2010-06-14 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: On the way to Remote Debugging we want to transfer dom/timeline/etc
data from inspected page to WebInspector as JSON string via http. The native
serialization to JSON string is supported by InspectorValue's classes. This patch
has the implementation of sendMessageToFrontend function. WebKit version of it still
uses ScriptFunctionCall and will be switched to another transport a little bit later.
https://bugs.webkit.org/show_bug.cgi?id=40134
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::WebInspectorClient):
(WebInspectorClient::~WebInspectorClient):
(WebInspectorClient::openInspectorFrontend):
* WebCoreSupport/WebInspectorClient.h:
2010-06-10 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Reduce FrameView.h includes to speed up build times
https://bugs.webkit.org/show_bug.cgi?id=40408
Another fix for Windows.
* WebView.cpp:
2010-06-09 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r60889.
http://trac.webkit.org/changeset/60889
https://bugs.webkit.org/show_bug.cgi?id=40365
gtk bot has some kind of memory corruption (Requested by
loislo on #webkit).
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::WebInspectorClient):
(WebInspectorClient::~WebInspectorClient):
(WebInspectorClient::openInspectorFrontend):
* WebCoreSupport/WebInspectorClient.h:
(WebInspectorClient::frontendClosing):
2010-06-07 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
WebInspector: On the way to Remote Debugging we want to transfer dom/timeline/etc
data from inspected page to WebInspector as JSON string via http. The native
serialization to JSON string is supported by InspectorValue's classes. This patch
has the implementation of sendMessageToFrontend function. WebKit version of it still
uses ScriptFunctionCall and will be switched to another transport a little bit later.
https://bugs.webkit.org/show_bug.cgi?id=40134
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::WebInspectorClient):
(WebInspectorClient::~WebInspectorClient):
(WebInspectorClient::openInspectorFrontend):
* WebCoreSupport/WebInspectorClient.h:
2010-06-08 Antonio Gomes <tonikitoo@webkit.org>
Reviewed by Ojan Vafai and Darin Adler.
Refactor platform dependent editing behavior code out of Settings
https://bugs.webkit.org/show_bug.cgi?id=39854
EditingBehavior enum was renamed to EditingBehaviorTypes and moved out from Settings.h to
EditingBehaviorTypes.h . Call sites in WebKit/ adjusted accordingly.
* WebView.cpp:
(WebView::notifyPreferencesChanged):
2010-06-04 Alice Liu <alice.liu@apple.com>
Reviewed by Jon Honeycutt.
WebFrame::paintDocumentRectToContextAtPoint doesn't paint scrollbars
https://bugs.webkit.org/show_bug.cgi?id=40034
<rdar://problem/7799848>
* WebFrame.cpp:
(WebFrame::paintScrollViewRectToContextAtPoint): Renamed from paintDocumentRectToContextAtPoint.
Call paint() instead of paintContents(). Also move the dirtyRect to counteract the moving that happens in paint().
Just renaming changes:
* Interfaces/IWebFramePrivate.idl:
* Interfaces/IWebViewPrivate.idl:
* WebFrame.h:
* WebView.cpp:
(WebView::paintScrollViewRectToContextAtPoint):
* WebView.h:
* Interfaces/WebKit.idl: Touched for rebuild.
2010-05-30 Daniel Bates <dbates@rim.com>
Unreviewed, attempt to fix the build after http://trac.webkit.org/changeset/60418.
* WebFrame.cpp:
(WebFrame::elementWithName):
(WebFrame::controlsInForm):
2010-05-22 Jer Noble <jer.noble@apple.com>
Reviewed by Adam Roben.
Full screen doesn't work for video elements
https://bugs.webkit.org/show_bug.cgi?id=39557
rdar://problem/8011813
Modified FullscreenVideoController to work with MediaPlayerPrivateFullscreenWindow. The FullscreenVideoController
is now MediaPlayerPrivate agnostic..
* FullscreenVideoController.cpp:
(FullscreenVideoController::LayoutClient::LayoutClient): New helper class which implements WKCACFLayerLayoutClient.
(FullscreenVideoController::LayoutClient::layoutSublayersOfLayer):
(FullscreenVideoController::FullscreenVideoController):
(FullscreenVideoController::~FullscreenVideoController):
(FullscreenVideoController::enterFullscreen):
(FullscreenVideoController::exitFullscreen):
(FullscreenVideoController::fullscreenClientWndProc): Handle WM_KEYDOWN.
(FullscreenVideoController::createHUDWindow):
(FullscreenVideoController::hudWndProc): Handle WM_KEYDOWN.
(FullscreenVideoController::onChar):
(FullscreenVideoController::onKeyDown): New function: handles the VK_ESCAPE case more reliably than WM_CHAR.
* FullscreenVideoController.h:
* WebView.h:
(WebView::viewWindow): Added a simple viewWindow() accessor.
2010-05-25 Brady Eidson <beidson@apple.com>
Reviewed by Darin Adler.
Database origins aren't populated at launch (missing db in prefs sheet, possible other symptoms)
<rdar://problem/8013233> and https://bugs.webkit.org/show_bug.cgi?id=39486
* WebDatabaseManager.cpp:
(WebKitInitializeWebDatabasesIfNecessary): Call initializeTracker() instead of trying to set the path on
an already created tracker that already has its origins populated.
* WebDatabaseManager.h:
* WebView.cpp:
(WebView::initWithFrame): Call a renamed method instead.
2010-05-25 Ada Chan <adachan@apple.com>
Reviewed by Steve Falkenburg.
https://bugs.webkit.org/show_bug.cgi?id=39651
Make m_closeWindowTimer a SuspendableTimer, so it is properly suspended
when page loading is deferred.
* WebView.cpp:
(WebView::WebView): m_closeWindowTimer is now a pointer to a SuspendableTimer.
(WindowCloseTimer::create):
(WindowCloseTimer::WindowCloseTimer):
(WindowCloseTimer::contextDestroyed): Make sure we delete the WindowCloseTimer in the end.
(WindowCloseTimer::fired):
(WebView::closeWindowSoon):
(WebView::closeWindowTimerFired):
(WebView::notifyPreferencesChanged): Can just check for the existence m_closeWindowTimer, since
we only create it when we need to start the timer.
* WebView.h:
2010-05-24 Darin Adler <darin@apple.com>
Reviewed by Eric Seidel.
Move view-related functions from Frame to FrameView
https://bugs.webkit.org/show_bug.cgi?id=39366
* WebFrame.cpp:
(WebFrame::setTextSizeMultiplier): Call function on FrameView.
* WebView.cpp:
(WebView::setZoomMultiplier): Ditto.
2010-05-24 Anders Carlsson <andersca@apple.com>
Yet another Windows build fix.
* WebView.cpp:
(WebView::canShowMIMEType):
Use the right capitalizatinon of 'MIME' (which also happens to be incorrect according to our guidelines).
2010-05-24 Anders Carlsson <andersca@apple.com>
Another Windows build fix.
* WebView.cpp:
Don't include PlugInInfoStore.h, instead include PluginData.h
2010-05-24 Anders Carlsson <andersca@apple.com>
Fix Windows build.
* WebView.cpp:
(WebView::canShowMIMEType):
2010-05-21 Steve Block <steveblock@google.com>
Reviewed by Jeremy Orlow.
Add DeviceOrientation and DeviceOrientationClient
https://bugs.webkit.org/show_bug.cgi?id=39479
* WebView.cpp:
(WebView::initWithFrame):
2010-05-20 Simon Fraser <simon.fraser@apple.com>
Build fix, no review.
Fix the non-accelerated-compositing Windows build with some
#if USE(ACCELERATED_COMPOSITING) loving.
* WebView.cpp:
* WebView.h:
2010-05-20 Simon Fraser <simon.fraser@apple.com>
Reviewed by Adam Roben.
Avoid flushing CA layers when a layout is pending
https://bugs.webkit.org/show_bug.cgi?id=39463
<rdar://problem/7999463>
Avoid rendering the compositing layers to the screen if there's a layout pending,
since the layer tree not in a state that should be presented to the user.
This fixes flashes in some types of content that dynamically add and remove layers.
Have the WebView implement WKCACFLayerRendererClient so that the
WKCACFLayerRenderer can ask whether it's a good time to render. If the FrameView
has a layout pending, say no.
* WebView.h:
* WebView.cpp:
(WebView::setAcceleratedCompositing):
(WebView::shouldRender):
2010-05-18 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
[WinCairo] Correct scaling for print preview
https://bugs.webkit.org/show_bug.cgi?id=39329
Cairo does not properly deal with Windows HDCs that have been
scaled using MM_ANISOTROPIC mapping mode, and a WindowExt and
ViewportExt setting.
(see http://bugs.freedesktop.org/show_bug.cgi?id=28161)
Instead, reset the HDC's WorldTransform to be unscaled, then
scale the cairo context to the desired scaling, and perform
the drawing operation.
* WebFrame.cpp:
(WebFrame::drawHeader): Use pre-positioned context to simplify
this method.
(WebFrame::drawFooter): Use pre-positioned context to simplify
this method.
(WebFrame::spoolPage): Revise scaling logic to turn off HDC
scaling, and scale using only Cairo. Revert scaling at end
so that user-defined GDI-based routines (e.g., header/footer)
will draw in the right position.
(WebFrame::spoolPages): Identify print preview case, and
retrieve scaling factors from preview context. Set the
Cairo context to use these factors during the spoolPage
operation.
2010-05-20 Martin Robinson <mrobinson@igalia.com>
Unreviewed.
Touch WebKit.idl to ensure that interfaces rebuild.
* Interfaces/WebKit.idl: Touched.
2010-05-20 Martin Robinson <mrobinson@igalia.com>
Reviewed by Adam Roben.
Fix the Windows build and move new IDL declarations to the bottom of the file.
* Interfaces/IWebPreferences.idl: Move new API to the bottom of the IDL file to prevent vtable mismatch.
* WebPreferences.cpp:
(WebPreferences::setEditingBehavior): Change the type of the parameter to setEditingBehavior to the proper type.
2010-05-20 Martin Robinson <mrobinson@igalia.com>
Unreviewed.
Fix the Windows build.
* WebView.cpp:
(WebView::notifyPreferencesChanged): Change behavior to 'editingBehavior'.
2010-05-20 Martin Robinson <mrobinson@webkit.org>
Reviewed by Ojan Vafai.
Expose the editing behavior setting in DRT to test all editing code paths
https://bugs.webkit.org/show_bug.cgi?id=38603
Expose the EditingBehavior setting in the Windows API.
* Interfaces/IWebPreferences.idl: Add the API point for setting the editing behavior.
* WebPreferenceKeysPrivate.h: Add a key for the editing behavior setting.
* WebPreferences.cpp:
(WebPreferences::editingBehavior): Added.
(WebPreferences::setEditingBehavior): Added.
* WebPreferences.h: Add method declarations.
* WebView.cpp:
(WebView::notifyPreferencesChanged): Update the WebCore setting based on the WebPreferences setting.
2010-05-20 Chris Jerdonek <cjerdonek@webkit.org>
Reviewed by Eric Seidel.
Modified FrameLoader::urlSelected() to accept a KURL instead of a
ResourceRequest.
https://bugs.webkit.org/show_bug.cgi?id=39320
Since ResourceRequest has non-explicit single-parameter constructors for
String and KURL, urlSelected() previously accepted any of String, KURL,
and ResourceRequest. This revision changes urlSelected() to accept only
a KURL to make the API tighter and easier to refactor.
* WebCoreSupport/WebContextMenuClient.cpp:
(WebContextMenuClient::searchWithGoogle):
- Updated the call to urlSelected().
2010-05-13 Brian Weinstein <bweinstein@apple.com>
Reviewed by Tim Hatcher.
<rdar://problem/7982652>
Allow reporting exceptions that occur when using JavaScriptCore APIs to the Web Inspector.
* Interfaces/IWebViewPrivate.idl: Add a reportException function off of IWebViewPrivate.
* Interfaces/WebKit.idl: Touch WebKit.idl to make sure Interfaces rebuild.
* WebView.cpp:
(WebView::reportException): Make sure the function was called with a context from a WebView, and call
WebCore::reportException.
* WebView.h:
2010-05-12 Jer Noble <jer.noble@apple.com>
Reviewed by Darin Adler.
Bug 38689: #34005 will break fullscreen video playback
https://bugs.webkit.org/show_bug.cgi?id=38689
Use the new definition of PlatformMedia to check the actual type
returned by MediaPlayer.
* FullscreenVideoController.cpp:
(FullscreenVideoController::movie):
2010-05-11 Jer Noble <jer.noble@apple.com>
No Review.
Fix build error: The QTMovieWin project is dependent on the JavaScriptCore project.
* WebKit.vcproj/WebKit.sln:
2010-05-11 Alice Liu <alice.liu@apple.com>
Rubber-stamped by Gavin Barraclough.
Fix build error when enabling debugging block in WebKit win painting code
* WebView.cpp:
(WebView::paintIntoBackingStore):
2010-05-11 Alice Liu <alice.liu@apple.com>
Reviewed by Steve Falkenburg.
https://bugs.webkit.org/show_bug.cgi?id=38937
W7 window preview paints content at the wrong location
* WebFrame.cpp:
(WebFrame::paintDocumentRectToContext): Revert r58895
(WebFrame::paintDocumentRectToContextAtPoint): Added
* Interfaces/IWebFramePrivate.idl: Added paintDocumentRectToContextAtPoint
* Interfaces/IWebViewPrivate.idl: ditto
* Interfaces/WebKit.idl: touch to rebuild
* WebFrame.h: ditto
* WebView.cpp: ditto
(WebView::paintDocumentRectToContextAtPoint): ditto
* WebView.h: ditto
2010-05-07 Jer Noble <jer.noble@apple.com>
Reviewed by Adele Peterson.
Safari pegs CPU and drops tons of frames using HTML5 Vimeo player
https://bugs.webkit.org/show_bug.cgi?id=34005
QTMovieWin is now QTMovieGWorld.
* FullscreenVideoController.cpp:
(FullscreenVideoController::movie):
* FullscreenVideoController.h:
2010-05-06 Adam Roben <aroben@apple.com>
Bail out of WebView::paint when there's nothing to paint
Fixes <http://webkit.org/b/38670> <rdar://problem/7947105> REGRESSION
(r58067): Crash in WebView::paint when Web Inspector is docked and
window is resized so small that WebView disappears
When the WebView is 0-sized, ensureBackingStore() bails out without
creating a bitmap, leaving m_backingStoreBitmap null. Before r58067,
m_backingStoreBitmap was an HBITMAP, so we were happily passing along
a null HBITMAP to various Windows APIs. These calls would fail but not
crash. r58067 changed m_backingStoreBitmap to a RefCountedHBITMAP, and
dereferencing a null RefCountedHBITMAP* of course crashes.
Reviewed by Steve Falkenburg.
* WebView.cpp:
(WebView::paint): Bail if the rect to paint is empty.
2010-05-06 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
WebFrame::paintDocumentRectToContext paints content at the wrong location
https://bugs.webkit.org/show_bug.cgi?id=38651
* WebFrame.cpp:
(WebFrame::paintDocumentRectToContext):
2010-05-05 Stuart Morgan <stuartmorgan@chromium.org>
Reviewed by Darin Fisher.
Update setFocus for the new boolean argument; no behavioral change.
https://bugs.webkit.org/show_bug.cgi?id=37961
* WebCoreSupport/EmbeddedWidget.cpp:
(EmbeddedWidget::setFocus):
* WebCoreSupport/EmbeddedWidget.h:
2010-05-03 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
https://bugs.webkit.org/show_bug.cgi?id=27751
* Interfaces/IWebPreferencesPrivate.idl:
* WebPreferenceKeysPrivate.h:
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::javaScriptCanAccessClipboard):
(WebPreferences::setJavaScriptCanAccessClipboard):
* WebPreferences.h:
* WebView.cpp:
(WebView::notifyPreferencesChanged):
2010-05-03 Jens Alfke <snej@chromium.org>
Reviewed by Darin Fisher.
[chromium] Add "willSendSubmitEvent" hook to WebFrameClient and FrameLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=38397
No tests (functionality is exposed only through native WebKit API.)
* WebFrame.h:
2010-04-30 Jon Honeycutt <jhoneycutt@apple.com>
Caret may fail to blink if a focus handler brings up a modal dialog
https://bugs.webkit.org/show_bug.cgi?id=38372
Reviewed by Darin Adler.
* WebView.cpp:
(WebView::handleMouseEvent):
If the message is WM_CANCELMODE, which indicates that we our capturing
of mouse events has been cancelled, tell the EventHandler.
It's possible to re-enter this function if handling a mouse event allows
the message loop to run; moved up the call to setMouseActivated(), so
that if we do re-enter this function, the later mouse event will not be
considered as activating the window.
(WebView::WebViewWndProc):
Handle WM_CANCELMODE by calling handleMouseEvent().
2010-04-29 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
First part of
https://bugs.webkit.org/show_bug.cgi?id=20784
move npapi.h to C99 integer types.
* WebKit.vcproj/WebKit.vcproj:
2010-04-28 Beth Dakin <bdakin@apple.com>
Reviewed by Darin Adler.
Fix for <rdar://problem/7474349>
Add a synchronous display mechanism for WKCACFLayerRenderer.
* Interfaces/IWebViewPrivate.idl:
* Interfaces/WebKit.idl:
* WebView.cpp:
(WebView::WebView):
(WebView::updateRootLayerContents):
(WebView::nextDisplayIsSynchronous):
* WebView.h:
2010-04-28 Steve Falkenburg <sfalken@apple.com>
Reviewed by Maciej Stachowiak.
WebView drawing code may access null backing store dirty region
https://bugs.webkit.org/show_bug.cgi?id=38245
<rdar://problem/7916101> REGRESSION (r58067): All loaded pages fail to display after running iBench HTML test (intermittent)
* WebView.cpp:
(WebView::updateBackingStore): Add null check for m_backingStoreDirtyRegion.
2010-04-27 Jon Honeycutt <jhoneycutt@apple.com>
<rdar://problem/7911140> Hitting the "delete" key goes back twice
Reviewed by Maciej Stachowiak.
* WebView.cpp:
(WebView::keyDown):
Return true if we navigated back or forward from the key event to
prevent the event from being propagated further.
2010-04-25 Sam Weinig <sam@webkit.org>
Reviewed by Maciej Stachowiak.
Fix for https://bugs.webkit.org/show_bug.cgi?id=38097
Disentangle initializing the main thread from initializing threading
* WebKitClassFactory.cpp:
(WebKitClassFactory::WebKitClassFactory): Add call to initializeMainThread.
* WebView.cpp:
(WebView::WebView): Ditto.
2010-04-25 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: inspector client shouldn't check if it can be opened
docked if it is already in that state.
https://bugs.webkit.org/show_bug.cgi?id=37946
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorFrontendClient::WebInspectorFrontendClient):
(WebInspectorFrontendClient::showWindowWithoutNotifications):
* WebCoreSupport/WebInspectorClient.h:
2010-04-24 Steve Falkenburg <sfalken@apple.com>
Reviewed by Sam Weinig.
Typo in Geolocation code causes crashes when updates are stopped
https://bugs.webkit.org/show_bug.cgi?id=38089
<rdar://problem/7904104> Crash closing geolocation tab after allowing to use geolocation
* WebCoreSupport/WebGeolocationControllerClient.cpp:
(WebGeolocationControllerClient::stopUpdating): Call unregister instead of register.
2010-04-23 Andy Estes <aestes@apple.com>
Rubber stamped by Steve Falkenburg.
Roll out http://trac.webkit.org/changeset/55385.
<rdar://problem/7884444>
* Interfaces/IWebUIDelegatePrivate.idl:
* Interfaces/WebKit.idl:
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::createPlugin):
2010-04-22 Dave Moore <davemoore@chromium.org>
Reviewed by Dimitri Glazkov.
Added notification when the favicons for a page are changed
from a script.
The Document object will notify the frame loader, which will
notify the client. Implementations of FrameLoaderClient will
have to add one method; dispatchDidChangeIcons().
https://bugs.webkit.org/show_bug.cgi?id=33812
* Interfaces/IWebFrameLoadDelegatePrivate2.idl:
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDidChangeIcons):
* WebCoreSupport/WebFrameLoaderClient.h:
* WebFrame.cpp:
(WebFrame::didChangeIcons):
* WebFrame.h:
2010-04-22 Adam Barth <abarth@webkit.org>
Unreviewed, rolling out r58069.
http://trac.webkit.org/changeset/58069
https://bugs.webkit.org/show_bug.cgi?id=27751
Broke compile on Windows.
* Interfaces/IWebPreferencesPrivate.idl:
* WebPreferenceKeysPrivate.h:
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
* WebPreferences.h:
* WebView.cpp:
(WebView::notifyPreferencesChanged):
2010-04-22 Abhishek Arya <inferno@chromium.org>
Reviewed by Adam Barth.
Add support for controlling clipboard access from javascript.
Clipboard access from javascript is disabled by default.
https://bugs.webkit.org/show_bug.cgi?id=27751
* Interfaces/IWebPreferencesPrivate.idl:
* WebPreferenceKeysPrivate.h:
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::javaScriptCanAccessClipboard):
(WebPreferences::setJavaScriptCanAccessClipboard):
* WebPreferences.h:
* WebView.cpp:
(WebView::notifyPreferencesChanged):
2010-04-21 Andy Estes <aestes@apple.com>
Reviewed by Maciej Stachowiak.
Reference count WebView's backing store bitmap to prevent
deleteBackingStore() from freeing the bitmap while it is still being
referenced by Core Animation.
https://bugs.webkit.org/show_bug.cgi?id=37954
* WebView.cpp:
(WebView::ensureBackingStore):
(WebView::addToDirtyRegion):
(WebView::scrollBackingStore):
(WebView::updateBackingStore):
(WebView::paint):
(WebView::backingStore):
(releaseBackingStoreCallback): deref m_backingStoreBitmap once Core
Animation has dropeed its reference to the memory.
(WebView::updateRootLayerContents): ref m_backingStoreBitmap before
passing the memory to Core Animation to prevent deleteBackingStore()
from freeing it while it is still referenced by CA.
* WebView.h: Make m_backingStoreBitmap a RefCountedGDIHandle<HBITMAP>,
and make m_backingStoreDirtyRegion a RefCountedGDIHandle<HRGN>.
2010-04-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Factor DocumentWriter out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37175
Update these callsites because the method moved to DocumentWriter.
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::receivedData):
2010-04-20 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Change a parameter type of chooseIconForFiles()
https://bugs.webkit.org/show_bug.cgi?id=37504
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::chooseIconForFiles):
* WebCoreSupport/WebChromeClient.h:
2010-04-16 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (Windows build fix).
* WebFrame.cpp:
(WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
* WebView.cpp:
(WebView::stringByEvaluatingJavaScriptFromString):
2010-04-16 Adam Roben <aroben@apple.com>
Make it possible for clients to instantiate a WebUserContentURLPattern
Reviewed by Tim Hatcher.
* ForEachCoClass.h: Added WebUserContentURLPattern to the FOR_EACH_COCLASS macro, which
lists all our instantiatable classes.
* WebKitClassFactory.cpp: Added a now-required #include.
2010-04-15 Adam Roben <aroben@apple.com>
Expose UserContentURLPattern as WebKit SPI
Fixes <http://webkit.org/b/37354>.
Reviewed by Tim Hatcher.
* Interfaces/IWebUserContentURLPattern.idl: Added.
* Interfaces/WebKit.idl: Added WebUserContentURLPattern.
* WebKit.vcproj/Interfaces.vcproj: Added IWebUserContentURLPattern.
* WebKit.vcproj/WebKit.vcproj: Added WebUserContentURLPattern.
* WebUserContentURLPattern.cpp: Added.
(WebUserContentURLPattern::WebUserContentURLPattern):
(WebUserContentURLPattern::~WebUserContentURLPattern):
(WebUserContentURLPattern::createInstance):
(WebUserContentURLPattern::AddRef):
(WebUserContentURLPattern::Release):
(WebUserContentURLPattern::QueryInterface):
Standard COM implementations.
(WebUserContentURLPattern::parse): Parse the string into a
UserContentURLPattern and store it.
(WebUserContentURLPattern::isValid):
(WebUserContentURLPattern::scheme):
(WebUserContentURLPattern::host):
(WebUserContentURLPattern::matchesSubdomains):
Call through to UserContentURLPattern.
* WebUserContentURLPattern.h: Added.
2010-04-14 Adam Roben <aroben@apple.com>
Expose DOMWrapperWorld::unregisterWorld as WebKit SPI on Windows
Fixes <http://webkit.org/b/37619>.
Reviewed by Steve Falkenburg.
* Interfaces/IWebScriptWorld.idl: Added unregisterWorld.
* Interfaces/WebKit.idl: Touched to force a build.
* WebScriptWorld.cpp:
(WebScriptWorld::unregisterWorld):
* WebScriptWorld.h:
Added. Just calls through to DOMWrapperWorld::unregisterWorld.
2010-04-12 Timothy Hatcher <timothy@apple.com>
SecurityOrigin needs a way to remove individual OriginAccessEntries
https://bugs.webkit.org/show_bug.cgi?id=37449
Reviewed by Dave Hyatt.
* Interfaces/IWebViewPrivate.idl:
* WebView.cpp:
(WebView::removeOriginAccessWhitelistEntry): Call SecurityOrigin::removeOriginAccessWhitelistEntry.
* WebView.h: Added removeOriginAccessWhitelistEntry.
2010-04-13 Timothy Hatcher <timothy@apple.com>
Rename SecurityOrigin::whiteListAccessFromOrigin to addOriginAccessWhitelistEntry.
And SecurityOrigin::resetOriginAccessWhiteLists to resetOriginAccessWhitelists.
SecurityOrigin needs a way to remove individual OriginAccessEntries
https://bugs.webkit.org/show_bug.cgi?id=37449
Reviewed by Dave Hyatt.
* Interfaces/IWebViewPrivate.idl:
* WebView.cpp:
(WebView::addOriginAccessWhitelistEntry):
(WebView::resetOriginAccessWhitelists):
* WebView.h:
2010-04-11 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r57468.
http://trac.webkit.org/changeset/57468
https://bugs.webkit.org/show_bug.cgi?id=37433
Broke the world... Must have applied the patch wrong
(Requested by abarth on #webkit).
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::receivedData):
2010-04-11 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Factor DocumentWriter out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=37175
Update these callsites because the method moved to DocumentWriter.
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::receivedData):
2010-04-09 Adam Roben <aroben@apple.com>
Windows Debug/Release build fix after r57244
* WebKit.vcproj/WebKit.vcproj: Don't delay-load QuartzCore.dll or
QuartzCoreInterface.dll in any configurations. r57244 made this change
only for Debug_Internal.
2010-04-08 Steve Falkenburg <sfalken@apple.com>
Reviewed by Darin Adler.
WebView::isLoading should null check m_mainFrame
https://bugs.webkit.org/show_bug.cgi?id=37294
* WebView.cpp:
(WebView::isLoading):
2010-04-07 Chris Marrin <cmarrin@apple.com>
Reviewed by Steve Falkenburg.
Remove QuartzCoreInterface from the build
No longer needed since QuartzCore.dll is now included in the latest Safari release (4.0.5).
* WebKit.vcproj/WebKit.vcproj:Removed delay load for QuartzCore and QuartzCoreInterface
2010-04-07 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Removed redundant FrameLoaderClient::dispatchDidLoadResourceByXMLHttpRequest()
https://bugs.webkit.org/show_bug.cgi?id=36949
* WebCoreSupport/WebFrameLoaderClient.cpp:
* WebCoreSupport/WebFrameLoaderClient.h:
2010-04-05 Peter Nelson <charn.opcode@gmail.com>
Reviewed by Eric Seidel.
Fixed style errors in DOMCoreClasses.h to bring it up to scratch
for https://bugs.webkit.org/show_bug.cgi?id=34979.
* DOMCoreClasses.h:
(DOMObject::throwException):
(DOMObject::callWebScriptMethod):
(DOMObject::evaluateWebScript):
(DOMObject::removeWebScriptKey):
(DOMObject::stringRepresentation):
(DOMObject::webScriptValueAtIndex):
(DOMObject::setWebScriptValueAtIndex):
(DOMObject::setException):
(DOMNodeList::throwException):
(DOMNodeList::callWebScriptMethod):
(DOMNodeList::evaluateWebScript):
(DOMNodeList::removeWebScriptKey):
(DOMNodeList::stringRepresentation):
(DOMNodeList::webScriptValueAtIndex):
(DOMNodeList::setWebScriptValueAtIndex):
(DOMNodeList::setException):
(DOMDocument::throwException):
(DOMDocument::callWebScriptMethod):
(DOMDocument::evaluateWebScript):
(DOMDocument::removeWebScriptKey):
(DOMDocument::stringRepresentation):
(DOMDocument::webScriptValueAtIndex):
(DOMDocument::setWebScriptValueAtIndex):
(DOMDocument::setException):
(DOMDocument::nodeName):
(DOMDocument::nodeValue):
(DOMDocument::setNodeValue):
(DOMDocument::nodeType):
(DOMDocument::parentNode):
(DOMDocument::childNodes):
(DOMDocument::firstChild):
(DOMDocument::lastChild):
(DOMDocument::previousSibling):
(DOMDocument::nextSibling):
(DOMDocument::attributes):
(DOMDocument::ownerDocument):
(DOMDocument::insertBefore):
(DOMDocument::replaceChild):
(DOMDocument::removeChild):
(DOMDocument::appendChild):
(DOMDocument::hasChildNodes):
(DOMDocument::cloneNode):
(DOMDocument::isSupported):
(DOMDocument::namespaceURI):
(DOMDocument::prefix):
(DOMDocument::setPrefix):
(DOMDocument::localName):
(DOMDocument::hasAttributes):
(DOMDocument::isSameNode):
(DOMDocument::isEqualNode):
(DOMDocument::textContent):
(DOMDocument::setTextContent):
(DOMElement::throwException):
(DOMElement::callWebScriptMethod):
(DOMElement::evaluateWebScript):
(DOMElement::removeWebScriptKey):
(DOMElement::stringRepresentation):
(DOMElement::webScriptValueAtIndex):
(DOMElement::setWebScriptValueAtIndex):
(DOMElement::setException):
(DOMElement::nodeName):
(DOMElement::nodeValue):
(DOMElement::setNodeValue):
(DOMElement::nodeType):
(DOMElement::parentNode):
(DOMElement::childNodes):
(DOMElement::firstChild):
(DOMElement::lastChild):
(DOMElement::previousSibling):
(DOMElement::nextSibling):
(DOMElement::attributes):
(DOMElement::ownerDocument):
(DOMElement::insertBefore):
(DOMElement::replaceChild):
(DOMElement::removeChild):
(DOMElement::appendChild):
(DOMElement::hasChildNodes):
(DOMElement::cloneNode):
(DOMElement::isSupported):
(DOMElement::namespaceURI):
(DOMElement::prefix):
(DOMElement::setPrefix):
(DOMElement::localName):
(DOMElement::hasAttributes):
(DOMElement::isSameNode):
(DOMElement::isEqualNode):
(DOMElement::textContent):
(DOMElement::setTextContent):
2010-04-05 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=37111
<rdar://problem/7790327> Draw replacement text when plug-in host crashes
* WebCoreLocalizedStrings.cpp: (WebCore::crashedPluginText): Added a stub string for plug-in
failure.
2010-04-02 Rafael Weinstein <rafaelw@chromium.org>
Reviewed by Adam Barth.
Clean up unused calls after changes to checkPermission and requestPermission argument lists.
* WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
(WebDesktopNotificationsDelegate::requestPermission):
* WebCoreSupport/WebDesktopNotificationsDelegate.h:
2010-04-01 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
Added layerTreeAsText function to DRT (for Mac)
https://bugs.webkit.org/show_bug.cgi?id=36782
This is the WebKit side for Windows. It plumbs the
call from WebCore to DRT.
* Interfaces/IWebFramePrivate.idl:
* WebFrame.cpp:WebKit (Windows) side of plumbing
(WebFrame::layerTreeAsText):
* WebFrame.h:
2010-03-31 Marcus Bulach <bulach@chromium.org>
Reviewed by Jeremy Orlow.
Adds Geolocation param for cancelGeolocationPermissionRequestForFrame.
https://bugs.webkit.org/show_bug.cgi?id=35031
* WebCoreSupport/WebChromeClient.h:
(WebChromeClient::cancelGeolocationPermissionRequestForFrame):
2010-03-30 Gavin Barraclough <barraclough@apple.com>
Rubber stamped by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=36866
Move CString to WTF
* WebDownload.cpp:
* WebDownloadCFNet.cpp:
* WebDownloadCurl.cpp:
* WebHistoryItem.cpp:
* WebLocalizableStrings.cpp:
* WebMutableURLRequest.cpp:
* WebPreferences.cpp:
(WebPreferences::migrateWebKitPreferencesToCFPreferences):
* WebView.cpp:
2010-03-30 Adam Roben <aroben@apple.com>
Windows build fix
* Interfaces/WebKit.idl: Touched this to force a build.
2010-03-29 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adele Peterson.
Default value of accelerated compositing should be false for Windows
https://bugs.webkit.org/show_bug.cgi?id=36805
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
2010-03-29 Rafael Weinstein <rafaelw@chromium.org>
Reviewed by Adam Barth.
Change NotificationPresenter::checkPermission() to take the source frames full KURL,
rather than its SecurityOrigin. This will aid chromium in having more fine grained
permissions to control notification spam.
* WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
(WebDesktopNotificationsDelegate::checkPermission):
* WebCoreSupport/WebDesktopNotificationsDelegate.h:
2010-03-26 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Antti Koivisto.
Change method name due to it dealing with both flattening
of frame sets and inner frames.
* Interfaces/IWebPreferencesPrivate.idl:
* WebPreferenceKeysPrivate.h:
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::isFrameFlatteningEnabled):
(WebPreferences::setFrameFlatteningEnabled):
* WebPreferences.h:
* WebView.cpp:
(WebView::notifyPreferencesChanged):
2010-03-24 Jon Honeycutt <jhoneycutt@apple.com>
<rdar://problem/7780798> Missing plug-ins should be represented by text
only, instead of lego block
https://bugs.webkit.org/show_bug.cgi?id=36583
Reviewed by Dan Bernstein.
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::createPlugin):
Return 0 if we failed to initialize the plug-in, which causes the new
"missing plug-in" text to draw.
2010-03-24 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Make Icon::createIconForFiles() optional.
https://bugs.webkit.org/show_bug.cgi?id=35072
- Rename iconForFiles() to chooseIconForFiles().
- Call Icon::createIconForFiles() from chooseIconForFiles().
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::chooseIconForFiles):
* WebCoreSupport/WebChromeClient.h:
2010-03-22 Darin Adler <darin@apple.com>
* WebCoreLocalizedStrings.cpp:
(WebCore::missingPluginText): Fixed localization helper text to match the same
string from Mac WebKit.
2010-03-22 Kevin Decker <kdecker@apple.com>
Reviewed by John Sullivan.
https://bugs.webkit.org/show_bug.cgi?id=36328
* WebCoreLocalizedStrings.cpp:
(WebCore::missingPluginText): Added.
2010-03-17 Enrica Casucci <enrica@apple.com>
Reviewed by Darin Adler.
Missing support for showing compositing layers borders and repaint count on Windows.
<rdar://problem/7760736>
<https://bugs.webkit.org/show_bug.cgi?id=36197>
* Interfaces/IWebPreferencesPrivate.idl:
* WebPreferenceKeysPrivate.h:
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::showDebugBorders):
(WebPreferences::setShowDebugBorders):
(WebPreferences::showRepaintCounter):
(WebPreferences::setShowRepaintCounter):
* WebPreferences.h:
* WebView.cpp:
(WebView::notifyPreferencesChanged):
2010-03-16 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Introduce InspectorFrontendClient that provides InspectorFrontend with an interface to the embedder. InspectorClient now serves as a delegate for InspectorController and does not contain methods for managing inspector frontend window. That allows to create remote InspectorFrontendHost.
Introduce InspectorFrontendClient that would provide InspectorFrontend with an interface to the embedder
https://bugs.webkit.org/show_bug.cgi?id=35036
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::WebInspectorClient):
(WebInspectorClient::~WebInspectorClient):
(WebInspectorClient::openInspectorFrontend):
(WebInspectorClient::highlight):
(WebInspectorClient::hideHighlight):
(WebInspectorClient::updateHighlight):
(WebInspectorFrontendClient::WebInspectorFrontendClient):
(WebInspectorFrontendClient::~WebInspectorFrontendClient):
(WebInspectorFrontendClient::frontendLoaded):
(WebInspectorFrontendClient::localizedStringsURL):
(WebInspectorFrontendClient::hiddenPanels):
(WebInspectorFrontendClient::bringToFront):
(WebInspectorFrontendClient::closeWindow):
(WebInspectorFrontendClient::attachWindow):
(WebInspectorFrontendClient::detachWindow):
(WebInspectorFrontendClient::setAttachedWindowHeight):
(WebInspectorFrontendClient::inspectedURLChanged):
(WebInspectorFrontendClient::closeWindowWithoutNotifications):
(WebInspectorFrontendClient::showWindowWithoutNotifications):
(WebInspectorFrontendClient::destroyInspectorView):
(WebInspectorFrontendClient::updateWindowTitle):
(WebInspectorFrontendClient::onGetMinMaxInfo):
(WebInspectorFrontendClient::onSize):
(WebInspectorFrontendClient::onClose):
(WebInspectorFrontendClient::onSetFocus):
(WebInspectorFrontendClient::onWebViewWindowPosChanging):
(WebInspectorWndProc):
(WebInspectorFrontendClient::windowReceivedMessage):
* WebCoreSupport/WebInspectorClient.h:
(WebInspectorClient::frontendClosing):
* WebInspector.cpp:
(WebInspector::attach):
(WebInspector::detach):
2010-03-14 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
WebKit part of removing support for legacy versions of Core Graphics
* WebKitClassFactory.cpp:
(WebKitClassFactory::WebKitClassFactory): Removed call to populateFontDatabase().
* WebKitGraphics.cpp:
(makeFont): Ditto.
* WebTextRenderer.cpp:
(WebTextRenderer::registerPrivateFont): Removed call to wkAddFontsAtPath().
2010-03-12 Enrica Casucci <enrica@apple.com>
Fixed broken build on Windows.
Added contditional compilation for accelerated compositing.
* WebView.cpp:
(WebView::deleteBackingStore):
(WebView::addToDirtyRegion):
(WebView::updateBackingStore):
2010-03-12 Beth Dakin <bdakin@apple.com>
Reviewed by Simon Fraser.
Fix for https://bugs.webkit.org/show_bug.cgi?id=34942 Fullscreen
API naming is inconsistent
-and corresponding-
<rdar://problem/7729165>
This patch changes all occurrences of "fullScreen" to the more
popular "fullscreen."
* FullscreenVideoController.cpp:
(FullscreenVideoController::onMouseDown):
(FullscreenVideoController::onMouseMove):
(FullscreenVideoController::onMouseUp):
* FullscreenVideoController.h:
(FullscreenVideoController::fullscreenToHUDCoordinates):
2010-03-12 Beth Dakin <bdakin@apple.com>
Reviewed by Adam Roben.
Fix for https://bugs.webkit.org/show_bug.cgi?id=33739 Fullscreen
video HUD stays on top when switching to another window (e.g. via
Alt-Tab)
-and corresponding-
<rdar://problem/7547574>
The HUD was always on top because it had the WS_EX_TOPMOST style.
So I removed the style and made m_videoWindow the owner of
m_hudWindow. This keeps m_hudWindow on top only when m_videoWindow
is the focused window.
* FullscreenVideoController.cpp:
(FullscreenVideoController::exitFullscreen): ASSERT that movie()->exitFullscreen() also destroyed the hud.
(FullscreenVideoController::createHUDWindow):
2010-03-12 Enrica Casucci <enrica@apple.com>
Reviewed by Simon Fraser.
Content of 3D tests appears at the bottom right corner sometimes.
<rdar://problem/7556244>
<https://bugs.webkit.org/show_bug.cgi?id=36027>
See detailed comments in WebCore/ChangeLog.
* WebView.cpp:
(WebView::deleteBackingStore): Reset the dirty flag when deleting the backing store.
(WebView::addToDirtyRegion): Set the dirty flag when adding dirty rectangles to the
backing store dirty region.
(WebView::updateBackingStore): Reset the dirty flag after painting into the backing store.
(WebView::setAcceleratedCompositing): Removed unnecessary call to updateRootLayerContents.
(WebView::updateRootLayerContents): Changed the way we pass parameters to setScrollFrame.
We are passing width and height of the view content together with the offset for the scrolling.
It was confusing to pass it all as a rectangle, when it is not a rectangle.
2010-03-11 Aaron Boodman <aa@chromium.org>
Kill WebDocument::applicationID() (part 1).
Modify interface to WebCore::NotificationPresenter::checkPermission()
and remove implementation of WebDocument::applicationID(). Breaking
API changes will be in a subsequent change.
https://bugs.webkit.org/show_bug.cgi?id=35846
* WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
(WebDesktopNotificationsDelegate::checkPermission):
* WebCoreSupport/WebDesktopNotificationsDelegate.h:
2010-03-11 Anders Carlsson <andersca@apple.com>
Reviewed by David Hyatt.
Remove invalidateContents, it isn't used and it never makes sense to only invalidate the contents.
* WebCoreSupport/WebChromeClient.cpp:
* WebCoreSupport/WebChromeClient.h:
2010-03-10 Eric Uhrhane <ericu@chromium.org>
Reviewed by David Levin.
The build fix for my patch on bug #35763 wasn't quite right--it removed
the call entirely, instead of replacing it with the new API. This adds
the call to Database::setIsAvailable.
https://bugs.webkit.org/show_bug.cgi?id=35763
* WebView.cpp: Added a call to Database::setIsAvailable where change 55667 removed the old Settings API call <http://trac.webkit.org/changeset/55667>.
(WebView::notifyPreferencesChanged):
2010-03-10 John Sullivan <sullivan@apple.com>
Reviewed by Tim Hatcher.
<rdar://problem/7735387> input type other than text won't work with autofill
<https://bugs.webkit.org/show_bug.cgi?id=35963>
* WebFrame.cpp:
(WebFrame::elementDoesAutoComplete):
Return true for any text field that's not a password, rather than only
for TEXT type.
2010-03-09 Brady Eidson <beidson@apple.com>
Reviewed by Tim Hatcher.
REGRESSION: WebInspector docking busted on Windows
<rdar://problem/7728433> and https://bugs.webkit.org/show_bug.cgi?id=35953
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::attachWindow): Use the InspectorController:: copy of the should attach settings key.
(WebInspectorClient::detachWindow): Ditto.
(WebInspectorClient::showWindowWithoutNotifications): Ditto.
2010-03-09 John Sullivan <sullivan@apple.com>
Fixed localized string key collision. update-webkit-localized-strings now
runs without errors.
Reviewed by Adam Roben.
* WebCoreLocalizedStrings.cpp:
(WebCore::AXMenuListPopupActionVerb):
Used LPCTSTR_UI_STRING_KEY for the 2nd use of "press".
2010-03-08 Adam Treat <atreat@rim.com>
Unreviewed build fix for Windows.
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::invalidateContents):
2010-03-02 Adam Treat <atreat@rim.com>
Reviewed by Dave Hyatt.
Adapt the win port to the refactoring of repaint methods.
https://bugs.webkit.org/show_bug.cgi?id=34214
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::invalidateContents):
(WebChromeClient::invalidateWindow):
(WebChromeClient::invalidateContentsAndWindow):
(WebChromeClient::invalidateContentsForSlowScroll):
* WebCoreSupport/WebChromeClient.h:
2010-03-08 Daniel Bates <dbates@rim.com>
Unreviewed, build fix.
Attempt to fix the Windows builds by applying the corresponding change
made in bug #35763 <https://bugs.webkit.org/show_bug.cgi?id=35763>.
* WebView.cpp: Removed call to settings->setDatabasesEnabled since this
setting no longer exists following changeset 55666 <http://trac.webkit.org/changeset/55666>.
(WebView::notifyPreferencesChanged):
2010-03-07 Mark Rowe <mrowe@apple.com>
Windows build fix.
* WebKitPrefix.h: Include CoreFoundation/CoreFoundation.h from the Windows prefix header
since some WebCore headers rely on the types declared within being available via the prefix
header.
2010-03-05 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
Got rid of platformLayer use in WebView.
https://bugs.webkit.org/show_bug.cgi?id=35798
WKCACFLayer no longer depends on GraphicsLayer, so I got rid of
that dependency on WebView. Now WebChromeClient casts platformLayer
to WKCACFLayer which will always be the case on Windows.
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::attachRootGraphicsLayer):
* WebView.cpp:
(WebView::setRootChildLayer):
* WebView.h:
2010-03-04 Beth Dakin <bdakin@apple.com>
Reviewed by Anders Carlsson.
WebCore::Page::setInstanceHandle() is now just
WebCore::setInstanceHandle()
* WebKitDLL.cpp:
(DllMain):
2010-03-03 Alice Liu <alice.liu@apple.com>
Reviewed by Jon Honeycutt.
Add a way to get an iframe's content frame
* DOMCoreClasses.cpp:
(DOMElement::createInstance):
Added case for DOMHTMLIFrameElement
* DOMHTMLClasses.cpp:
Adding the few DOMHTMLIFrameElement functions definitions that have
distinct implementations (all others just call parent implementation)
(DOMHTMLIFrameElement::QueryInterface):
(DOMHTMLIFrameElement::contentFrame):
* DOMHTMLClasses.h:
Most of these function declarations have definitions that just call the parent implementation
(DOMHTMLIFrameElement::DOMHTMLIFrameElement):
(DOMHTMLIFrameElement::AddRef):
(DOMHTMLIFrameElement::Release):
(DOMHTMLIFrameElement::throwException):
(DOMHTMLIFrameElement::callWebScriptMethod):
(DOMHTMLIFrameElement::evaluateWebScript):
(DOMHTMLIFrameElement::removeWebScriptKey):
(DOMHTMLIFrameElement::stringRepresentation):
(DOMHTMLIFrameElement::webScriptValueAtIndex):
(DOMHTMLIFrameElement::setWebScriptValueAtIndex):
(DOMHTMLIFrameElement::setException):
(DOMHTMLIFrameElement::nodeName):
(DOMHTMLIFrameElement::nodeValue):
(DOMHTMLIFrameElement::setNodeValue):
(DOMHTMLIFrameElement::nodeType):
(DOMHTMLIFrameElement::parentNode):
(DOMHTMLIFrameElement::childNodes):
(DOMHTMLIFrameElement::firstChild):
(DOMHTMLIFrameElement::lastChild):
(DOMHTMLIFrameElement::previousSibling):
(DOMHTMLIFrameElement::nextSibling):
(DOMHTMLIFrameElement::attributes):
(DOMHTMLIFrameElement::ownerDocument):
(DOMHTMLIFrameElement::insertBefore):
(DOMHTMLIFrameElement::replaceChild):
(DOMHTMLIFrameElement::removeChild):
(DOMHTMLIFrameElement::appendChild):
(DOMHTMLIFrameElement::hasChildNodes):
(DOMHTMLIFrameElement::cloneNode):
(DOMHTMLIFrameElement::normalize):
(DOMHTMLIFrameElement::isSupported):
(DOMHTMLIFrameElement::namespaceURI):
(DOMHTMLIFrameElement::prefix):
(DOMHTMLIFrameElement::setPrefix):
(DOMHTMLIFrameElement::localName):
(DOMHTMLIFrameElement::hasAttributes):
(DOMHTMLIFrameElement::isSameNode):
(DOMHTMLIFrameElement::isEqualNode):
(DOMHTMLIFrameElement::textContent):
(DOMHTMLIFrameElement::setTextContent):
(DOMHTMLIFrameElement::tagName):
(DOMHTMLIFrameElement::getAttribute):
(DOMHTMLIFrameElement::setAttribute):
(DOMHTMLIFrameElement::removeAttribute):
(DOMHTMLIFrameElement::getAttributeNode):
(DOMHTMLIFrameElement::setAttributeNode):
(DOMHTMLIFrameElement::removeAttributeNode):
(DOMHTMLIFrameElement::getElementsByTagName):
(DOMHTMLIFrameElement::getAttributeNS):
(DOMHTMLIFrameElement::setAttributeNS):
(DOMHTMLIFrameElement::removeAttributeNS):
(DOMHTMLIFrameElement::getAttributeNodeNS):
(DOMHTMLIFrameElement::setAttributeNodeNS):
(DOMHTMLIFrameElement::getElementsByTagNameNS):
(DOMHTMLIFrameElement::hasAttribute):
(DOMHTMLIFrameElement::hasAttributeNS):
(DOMHTMLIFrameElement::focus):
(DOMHTMLIFrameElement::blur):
(DOMHTMLIFrameElement::idName):
(DOMHTMLIFrameElement::setIdName):
(DOMHTMLIFrameElement::title):
(DOMHTMLIFrameElement::setTitle):
(DOMHTMLIFrameElement::lang):
(DOMHTMLIFrameElement::setLang):
(DOMHTMLIFrameElement::dir):
(DOMHTMLIFrameElement::setDir):
(DOMHTMLIFrameElement::className):
(DOMHTMLIFrameElement::setClassName):
(DOMHTMLIFrameElement::innerHTML):
(DOMHTMLIFrameElement::setInnerHTML):
(DOMHTMLIFrameElement::innerText):
(DOMHTMLIFrameElement::setInnerText):
* Interfaces/DOMHTML.idl:
Added IDOMHTMLIFrameElement interface
2010-03-03 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
Export acceleratedCompositing flag in IWebPreferences.
https://bugs.webkit.org/show_bug.cgi?id=35610
* Interfaces/IWebPreferences.idl:
2010-03-02 Beth Dakin <bdakin@apple.com>
Reviewed by Darin Adler and Adam Roben.
Tiny WebKit portion of fix for <rdar://problem/7485289> WebKit
crashes on systems that don't support CoreAnimation
setHostWindow() no longer calls createRenderer(), so now that has
to be called manually.
* WebView.cpp:
(WebView::setAcceleratedCompositing):
2010-03-02 Adam Roben <aroben@apple.com>
Add IWebViewPrivate::registerURLSchemeAsSecure
Fixes <http://webkit.org/b/35580> <rdar://problem/7706407> Expose
SecurityOrigin::registerURLSchemeAsSecure as WebKit SPI
Reviewed by Tim Hatcher.
* Interfaces/WebKit.idl: Touched to force a build.
* Interfaces/IWebViewPrivate.idl:
* WebView.cpp:
(WebView::registerURLSchemeAsSecure):
* WebView.h:
Added. Calls through to SecurityOrigin::registerURLSchemeAsSecure.
2010-03-01 Jon Honeycutt <jhoneycutt@apple.com>
Remove Windows line endings from some files.
Rubber-stamped by Alice Liu.
* Interfaces/IWebEmbeddedView.idl:
* WebCoreSupport/EmbeddedWidget.cpp:
(EmbeddedWidget::create):
(EmbeddedWidget::~EmbeddedWidget):
(EmbeddedWidget::createWindow):
(EmbeddedWidget::invalidateRect):
(EmbeddedWidget::setFrameRect):
(EmbeddedWidget::frameRectsChanged):
(EmbeddedWidget::setFocus):
(EmbeddedWidget::show):
(EmbeddedWidget::hide):
(EmbeddedWidget::windowClipRect):
(EmbeddedWidget::setParent):
(EmbeddedWidget::attachToWindow):
(EmbeddedWidget::detachFromWindow):
(EmbeddedWidget::didReceiveResponse):
(EmbeddedWidget::didReceiveData):
(EmbeddedWidget::didFinishLoading):
(EmbeddedWidget::didFail):
* WebCoreSupport/EmbeddedWidget.h:
(EmbeddedWidget::EmbeddedWidget):
2010-03-01 Jon Honeycutt <jhoneycutt@apple.com>
Some WebKit DOMNode API is unimplemented.
https://bugs.webkit.org/show_bug.cgi?id=35554
Reviewed by Alice Liu.
* DOMCoreClasses.cpp:
(DOMNode::nextSibling):
Create a DOMNode to wrap m_node's next sibling, and assign it to the
out param 'result'.
(DOMNode::insertBefore):
Query for the DOMNode for newChild, and return early if we fail. Query
refChild for DOMNode. Call insertBefore(), passing the newChild's
WebCore node and refChild's WebCore node (if refChild is non-null). If
we successfully insert the child, fill the result out param with
newChild, ref it, and return S_OK. Otherwise, return E_FAIL.
(DOMNode::removeChild):
Query oldChild for DOMNode. If we fail, return E_FAIL. Call
removeChild(), passing the node's WebCore node. If this fails, return
E_FAIL. Otherwise, fill the result out param with oldChild, ref it, and
return S_OK.
2010-03-01 Jakob Petsovits <jpetsovits@rim.com>
Reviewed by Adam Barth.
Adapt to the new ZoomMode enum.
https://bugs.webkit.org/show_bug.cgi?id=35347
* WebFrame.cpp:
(WebFrame::setTextSizeMultiplier):
* WebView.cpp:
(WebView::setZoomMultiplier):
(WebView::zoomMultiplier):
(WebView::canMakeTextLarger):
(WebView::makeTextLarger):
(WebView::canMakeTextSmaller):
(WebView::makeTextSmaller):
(WebView::notifyPreferencesChanged):
2010-02-26 Jon Honeycutt <jhoneycutt@apple.com>
<rdar://problem/7703368> IWebUIDelegatePrivate::embeddedViewWithArguments
is passed wrong arguments
Reviewed by Adam Roben.
* Interfaces/IWebUIDelegatePrivate.idl:
Update copyright strings. Added a new key for the plug-in source URL.
* Interfaces/WebKit.idl:
Update copyright strings.
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::createPlugin):
Pass the URL of the plug-in as the source URL. Pass the document's
base URI for the base URL.
2010-02-23 Brady Eidson <beidson@apple.com>
Reviewed by Tim Hatcher and Pavel Feldman.
Regression (r55107) - WebInspector docking is busted.
https://bugs.webkit.org/show_bug.cgi?id=35274
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::showWindowWithoutNotifications): Swap the order of the "should attach?" check
to get the expected behavior.
2010-02-23 Steve Block <steveblock@google.com>
Reviewed by Darin Adler.
Adds ChromeClient::cancelGeolocationPermissionRequestForFrame
https://bugs.webkit.org/show_bug.cgi?id=34962
This method is required so that a Geolocation object can cancel an
asynchronous permission request. This allows the chrome client to cancel
any UI it is showing for the permission request.
* WebCoreSupport/WebChromeClient.h:
(WebChromeClient::cancelGeolocationPermissionRequestForFrame):
2010-02-22 Steve Falkenburg <sfalken@apple.com>
Reviewed by Darin Adler.
WebKit on Windows should pick up system setting changes without requiring explicit API calls
https://bugs.webkit.org/show_bug.cgi?id=35269
* WebKit.vcproj/WebKit.def: Removed WebKitSystemParameterChanged.
* WebKit.vcproj/WebKit_debug.def: Removed WebKitSystemParameterChanged.
* WebKitGraphics.cpp: Removed WebKitSystemParameterChanged.
* WebKitGraphics.h: Removed WebKitSystemParameterChanged.
* WebView.cpp:
(systemParameterChanged): Call through to wkSystemFontSmoothingChanged for font changes.
(WebView::windowReceivedMessage): Pick up WM_SETTINGCHANGE from windowReceivedMessage.
2010-02-22 Brady Eidson <beidson@apple.com>
Reviewed by Tim Hatcher.
Disable WebView docking to views that are too small.
<rdar://problem/7248409> and https://bugs.webkit.org/show_bug.cgi?id=35254
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::showWindowWithoutNotifications): No matter the preference, don't open the inspector
window attached if WebCore says it shouldn't be attached.
2010-02-17 Steve Falkenburg <sfalken@apple.com>
Reviewed by Dan Bernstein.
WebKit on Windows needs a mechanism to listen for WM_SETTINGCHANGED messages
https://bugs.webkit.org/show_bug.cgi?id=35076
* WebKit.vcproj/WebKit.def: Added WebKitSystemParameterChanged.
* WebKit.vcproj/WebKit_debug.def: Added WebKitSystemParameterChanged.
* WebKitGraphics.cpp:
(WebKitSystemParameterChanged): Call through to wkSystemFontSmoothingChanged for font smoothing changes.
* WebKitGraphics.h: Added WebKitSystemParameterChanged.
2010-02-17 Dmitry Titov <dimich@chromium.org>
Reviewed by David Levin, Darin Fisher, Simon Hausmann.
When a live iframe element is moved between pages, it still depends on the old page.
https://bugs.webkit.org/show_bug.cgi?id=34382
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::didTransferChildFrameToNewDocument):
Added empty implementation of a new virtual method.
* WebCoreSupport/WebFrameLoaderClient.h:
2010-02-17 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
Introduces new Icon loading interface in order to support
asynchronous loading.
https://bugs.webkit.org/show_bug.cgi?id=32054
Add an empty implementation of ChromeClient::iconForFiles().
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::iconForFiles):
* WebCoreSupport/WebChromeClient.h:
2010-02-17 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed. Touch WebKit.idl to fix the build.
[Win] Implement test functions for printing
https://bugs.webkit.org/show_bug.cgi?id=34570
* Interfaces/WebKit.idl:
2010-02-17 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Eric Seidel.
[Win] Implement test functions for printing
https://bugs.webkit.org/show_bug.cgi?id=34570
* Interfaces/IWebFramePrivate.idl:
* WebFrame.cpp:
(WebFrame::pageNumberForElementById):
(WebFrame::numberOfPages):
* WebFrame.h:
2010-02-16 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
Generalize delayed plug-in start for background tabs for use for other media
https://bugs.webkit.org/show_bug.cgi?id=34981
* WebView.cpp:
(WebView::setCanStartPlugins): Change to call setCanStartMedia.
In a later patch we can change the of the public function in the IDL file too,
but for now this should be enough.
2010-02-15 Adam Roben <aroben@apple.com>
Add IWebFramePrivate::visibleContentRect
Fixes <http://webkit.org/b/34956> Add API to get a WebFrame's visible
content rect
Reviewed by Jon Honeycutt.
* Interfaces/IWebFramePrivate.idl: Added visibleContentRect.
* Interfaces/WebKit.idl: Touched to force a build.
* WebFrame.cpp:
(WebFrame::visibleContentRect):
* WebFrame.h:
Added. Calls through to FrameView::visibleContentRect.
2010-02-12 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
onmouseout fired when moving over tooltip on Windows
https://bugs.webkit.org/show_bug.cgi?id=16794
<rdar://5762038>.
Add WS_EX_TRANSPARENT to out tooltip HWND so it isn't subject to hit testing, and when
you mouse over the tooltip, it doesn't send a mouseout to the web content.
* WebView.cpp:
(WebView::initializeToolTipWindow): Add WS_EX_TRANSPARENT.
2010-02-10 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
Reviewed by Kenneth Rohde Christiansen.
Support frameset flattening
https://bugs.webkit.org/show_bug.cgi?id=32717
Add support for enabling/disabling FrameSet Flattening on the Windows port.
* Interfaces/IWebPreferencesPrivate.idl:
* WebPreferenceKeysPrivate.h:
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::isFrameSetFlatteningEnabled):
(WebPreferences::setFrameSetFlatteningEnabled):
* WebPreferences.h:
* WebView.cpp:
(WebView::notifyPreferencesChanged):
2010-02-10 Adam Roben <aroben@apple.com>
Remove unnecessary #include of shfolder.h
shfolder.h has been deprecated in newer versions of the Windows SDK.
Fixes <http://webkit.org/b/34803> WebPreferences.cpp fails to compile
under VS2010 RC due to #include of shfolder.h.
Reviewed by Darin Adler.
* WebPreferences.cpp: Removed #include.
2010-02-08 Charlie Reis <creis@chromium.org>
Reviewed by Darin Adler.
onbeforeunload not called at window close + frame or iframe focused
https://bugs.webkit.org/show_bug.cgi?id=27481
Chromium and WebKit on Windows will now fire beforeunload handlers
even if an inner frame is focused.
Layout tests aren't able to test this bug, since it requires closing
the actual browser window, not calling window.close(). Instead,
test with WebCore/manual-tests/onbeforeunload-focused-iframe.html.
* WebView.cpp:
(WebView::shouldClose):
2010-02-08 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
Include header position in World Transform used for plugin positioning.
https://bugs.webkit.org/show_bug.cgi?id=34709
* WebFrame.cpp:
(WebFrame::spoolPage): Correct WinCairo plugin print positioning to
account for header size. Existing code ignored this, causing
plugins to overlay other elements.
2010-02-04 Alice Liu <alice.liu@apple.com>
Reviewed by Jon Honeycutt.
https://bugs.webkit.org/show_bug.cgi?id=34612 " MSAA: accSelect returns error
codes for most elements that arent listbox or menupopup related"
<rdar://problem/7436861>
* AccessibleBase.cpp:
(AccessibleBase::accSelect):
- Stop sending E_INVALIDARG for elements that request TAKE_SELECTION that
aren't beneath listboxes or menupopups. This was too restrictive since
any element can be selectable.
- Correct the misinterpretation of MSDN's stipulation of situations involving
adding, removing, and extending selection on single-select elements
2010-02-04 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
Properly handle margin settings when printing Plugins in WinCairo.
https://bugs.webkit.org/show_bug.cgi?id=34613
* WebFrame.cpp:
(WebFrame::spoolPage): Adjust the GraphicsContext passed to the
paintContents method so that the World Transform is properly
positioned to account for margin settings at the time that
PluginViewWin.cpp processes the drawing operations.
2010-02-04 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
Properly handle margin settings in WinCairo.
https://bugs.webkit.org/show_bug.cgi?id=34545
* WebFrame.cpp:
(scaleFactor): Require the margin information as an input
parameter, and use them when computing the scaling factor.
(WebFrame::drawHeader): Pass margin size to scaleFactor.
(WebFrame::drawFooter): Pass margin size to scaleFactor.
(WebFrame::spoolPage):
1. Pass margin size to scaleFactor.
2. Recognize that the return value of printerMarginRect is
already in device units, and therefore scale it so that
the Cairo drawing is correct.
3. Remove scaling call for margins in GDI code, as it is
already in scaled units.
2010-02-03 Brian Weinstein <bweinstein@apple.com>
Reviewed by Steve Falkenburg.
Scroll does not work with IBM Thinkpad.
<https://bugs.webkit.org/show_bug.cgi?id=14227>
<rdar://7142545>
When initializing the WebView, add two scrollbar Windows inside of
our WebView, to allow it to receive WM_VSCROLL and WM_HSCROLL events.
(similar to what Firefox did in: <https://bugzilla.mozilla.org/show_bug.cgi?id=507222>.
Only do this if the user has installed some kind of Trackpoint driver, using an algorithm
like <https://bugzilla.mozilla.org/show_bug.cgi?id=514927>.
Also, add code to handle WM_HSCROLL and WM_VSCROLL messages to scroll
the WebView.
* WebView.cpp:
(WebView::verticalScroll): Handle the WM_VSCROLL messages, and scroll up and down
by lines or pages.
(WebView::horizontalScroll): Handle the WM_HSCROLL messages, and scroll left or right
by lines or pages.
(WebView::WebViewWndProc): Add cases for WM_VSCROLL and WM_HSCROLL.
(WebView::initWithFrame): Call shouldInitializeTrackPointHack, and if we should, create
vertical and horizontal scrollbars to receive WM_VSCROLL and WM_HSCROLL messages.
(WebView::shouldInitializeTrackPointHack): Check if there is a registry key for
the some kind of IBM Trackpoint driver.
* WebView.h:
2010-02-02 Steve Falkenburg <sfalken@apple.com>
Reviewed by Darin Adler.
Copyright year updating for Windows version resources should be automatic
https://bugs.webkit.org/show_bug.cgi?id=34503
* WebKit.vcproj/WebKit.rc:
2010-02-02 Adam Roben <aroben@apple.com>
Stop copying WebCore's IDL files from SRCROOT to OBJROOT
WebKit doesn't use these anymore (as of r52921).
Part of Bug 34496: Clean up WebCore's IDL/script copying
<https://bugs.webkit.org/show_bug.cgi?id=34496>
Reviewed by Steve Falkenburg.
* WebKit.vcproj/WebKit.make:
2010-01-29 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig + Oliver Hunt.
Bug 34346 - With JSC bindings, make processingUserGesture work with events in Isolated Worlds
Pass processeing user gensture flag to media play/pause methods.
* FullscreenVideoController.cpp:
(FullscreenVideoController::play):
(FullscreenVideoController::pause):
2010-01-29 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
Drag and Drop: Windows uses "stop" sign as cursor when dragging
https://bugs.webkit.org/show_bug.cgi?id=34305
<rdar://problem/7589672>
Add a preference in WebKit (that defaults to false), for whether or not
we should show the custom cursors during drag and drop. However, this is
currently only used on Windows, and only used to hide the "drop not allowed"
icon inside the WebView is the preference is set to true.
This will be off by default, so no change in behavior.
* Interfaces/IWebPreferencesPrivate.idl: Added new functions.
* Interfaces/WebKit.idl: Touched to force Interfaces build.
* WebDropSource.cpp:
(WebDropSource::GiveFeedback): Implementation of conditional showing cursor
logic.
* WebPreferenceKeysPrivate.h: Added new preference key.
* WebPreferences.cpp: Added new functions.
(WebPreferences::setCustomDragCursorsEnabled):
(WebPreferences::customDragCursorsEnabled):
* WebPreferences.h: Added new functions.
2010-01-28 Jon Honeycutt <jhoneycutt@apple.com>
MSAA: Crash when posting a notification for a detached object
https://bugs.webkit.org/show_bug.cgi?id=34309
<rdar://problem/7409759>
Reviewed by Darin Adler.
* AccessibleBase.cpp:
(AccessibleBase::QueryService):
If an unrecognized service ID is passed, return early. Otherwise, return
the result of QueryInterface.
(AccessibleBase::QueryInterface):
Add static_casts. Check for new UUIDs.
(AccessibleBase::isSameObject):
Query the object for AccessibleBase. Return whether the pointers or the
wrapped objects match.
* AccessibleBase.h:
Give the class a UUID so we can query for it in isSameObject(). Inherit
from IAccessibleComparable; inherit from IServiceProvider so clients can
use QueryService to query for a custom interface.
* Interfaces/AccessibleComparable.idl: Added. Declares a function that
can be called to compare to accessible objects.
* Interfaces/WebKit.idl:
Include the new IDL.
* WebKit.vcproj/Interfaces.vcproj:
Add the new IDL to the project.
2010-01-27 Aaron Boodman <aa@chromium.org>
Expand NotificationCenter::checkPermission() interface.
It now passes the full URL instead of just the origin.
https://bugs.webkit.org/show_bug.cgi?id=34238
* WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
(WebDesktopNotificationsDelegate::checkPermission):
* WebCoreSupport/WebDesktopNotificationsDelegate.h:
2010-01-27 Adam Roben <aroben@apple.com>
Make it possible to instantiate WebSerializedJSValue using
WebKitCreateInstance
Reviewed by Dave Hyatt.
* ForEachCoClass.h:
* WebKitClassFactory.cpp:
Added WebSerializedJSValue.
2010-01-26 Steve Falkenburg <sfalken@apple.com>
Reviewed by Oliver Hunt.
Windows build references non-existent include paths
https://bugs.webkit.org/show_bug.cgi?id=34175
* WebKit.vcproj/WebKit.vcproj:
2010-01-25 Steve Falkenburg <sfalken@apple.com>
Reviewed by Simon Fraser.
A WebGeolocationControllerClient is leaked for every WebView
https://bugs.webkit.org/show_bug.cgi?id=34145
* WebCoreSupport/WebGeolocationControllerClient.cpp:
(WebGeolocationControllerClient::geolocationDestroyed): Added.
* WebCoreSupport/WebGeolocationControllerClient.h:
2010-01-23 Dan Bernstein <mitz@apple.com>
Reviewed by Maciej Stachowiak.
<rdar://problem/7569820> svg/custom/text-zoom.xhtml fails on Windows
https://bugs.webkit.org/show_bug.cgi?id=34006
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings): Added WebKitZoomsTextOnlyPreferenceKey
with a default value of true.
2010-01-20 Steve Falkenburg <sfalken@apple.com>
Reviewed by Sam Weinig.
Add missing implementation for WebGeolocationPosition::initWithTimestamp.
* WebGeolocationPosition.cpp:
(WebGeolocationPosition::initWithTimestamp): Implemented.
2010-01-20 Jon Honeycutt <jhoneycutt@apple.com>
MSAA: accSelect() is not implemented
https://bugs.webkit.org/show_bug.cgi?id=33918
<rdar://problem/7436861>
Reviewed by Darin Adler.
* AccessibleBase.cpp:
(AccessibleBase::accSelect):
If there is an invalid combination of state flags, return early. If the
caller passed the "take focus" flag, focus the object. If the "take
selection" flag was passed, check whether the parent object is an
AccessibilityListBox; if so, call the object's setSelectedChildren()
function. If the parent is an AccessibilityMenuListPopup, call the
child object's setSelected() function. Otherwise, if the parent is some
other, unsupported object, return early.
If the selection flags include "add", "remove", or "extend" selection,
and the parent object is not multi-selectable, return early. Otherwise,
set or unset the child's selected flag based on the passed flag.
2010-01-20 Steve Falkenburg <sfalken@apple.com>
Reviewed by Darin Adler and Adam Roben.
Feature defines are difficult to maintain on Windows builds
https://bugs.webkit.org/show_bug.cgi?id=33883
FeatureDefines.vsprops are now maintained in a way similar to
Configurations/FeatureDefines.xcconfig, with the added advantage
of having a single FeatureDefines file across all projects.
* WebKit.vcproj/Interfaces.vcproj: Add FeatureDefines.vsprops inherited property sheet.
* WebKit.vcproj/WebKit.sln: Set up Cairo configuration for WebCoreGenerated.
* WebKit.vcproj/WebKit.vcproj: Remove ENABLE_ preprocessor definitions.
Add FeatureDefines.vsprops inherited property sheet.
* WebKit.vcproj/WebKitGUID.vcproj: Add FeatureDefines.vsprops inherited property sheet.
2010-01-17 Jon Honeycutt <jhoneycutt@apple.com>
MSAA: The child <option> elements of a non-multiple <select> are not
exposed
https://bugs.webkit.org/show_bug.cgi?id=33773
<rdar://problem/7550556>
Reviewed by Alice Liu.
* AccessibleBase.cpp:
(AccessibleBase::get_accState):
If the object is invisible, set the invisible state flag. If the object
is collapsed, set the collapsed state. If the object is a combo box,
set the has popup flag, and if it's not collapsed, set the expanded
flag.
(MSAARole):
Add new WebCore to MSAA role mappings.
* WebCoreLocalizedStrings.cpp:
(WebCore::AXMenuListActionVerb):
Return the action verb that Firefox uses for <select> elements with
popups.
(WebCore::AXMenuListPopupActionVerb):
Return the verb that Firefox uses for a popup list.
2010-01-19 John Sullivan <sullivan@apple.com>
https://bugs.webkit.org/show_bug.cgi?id=33854
Would like a variant of WebHTMLRepresentation's searchForLabelsBeforeElement that returns
more info about where the result was found
Reviewed by Darin Adler
* Interfaces/IWebHTMLRepresentation.idl:
Created variant of searchForLabels that includes additional in/out parameters resultDistance and resultIsInCellAbove.
* Interfaces/WebKit.idl:
Touched in order to get other idl change to propagate correctly.
* WebHTMLRepresentation.cpp:
(WebHTMLRepresentation::deprecatedSearchForLabels):
Renamed since iDL doesn't support two functions with the same name but different signatures.
(WebHTMLRepresentation::searchForLabels):
Implemented variant of searchForLabels that includes additional in/out parameters resultDistance and resultIsInCellAbove.
* WebHTMLRepresentation.h:
Declared variant of searchForLabels that includes additional in/out parameters resultDistance and resultIsInCellAbove.
2010-01-19 Adam Roben <aroben@apple.com>
Windows build fix
* WebScriptWorld.cpp: Added missing #include.
2010-01-19 Dave Hyatt <hyatt@apple.com>
Build bustage fix. Make sure the newly added scriptWorldForGlobalContext function is [local] in the IDL.
* Interfaces/IWebScriptWorld.idl:
2010-01-19 Dave Hyatt <hyatt@apple.com>
Reviewed by Adam Roben.
Add an API to obtain a WebScriptWorld from a JSGlobalContextRef.
* Interfaces/IWebScriptWorld.idl:
* WebScriptWorld.cpp:
(WebScriptWorld::scriptWorldForGlobalContext):
* WebScriptWorld.h:
2010-01-18 Adam Roben <aroben@apple.com>
Add IWebViewPrivate::setDomainRelaxationForbiddenForURLScheme
WebKit/win part of fixing <http://webkit.org/b/33806>
<rdar://problem/7552837> Would like API to disallow setting of
document.domain for pages with certain URL schemes
Reviewed by Sam Weinig.
* Interfaces/IWebViewPrivate.idl: Added
setDomainRelaxationForbiddenForURLScheme.
* Interfaces/WebKit.idl: Touched to force a build.
* WebView.cpp:
(WebView::setDomainRelaxationForbiddenForURLScheme):
* WebView.h:
Added. Calls through to SecurityOrigin.
2010-01-18 Chris Marrin <cmarrin@apple.com>
Reviewed by Darin Adler.
Use new setScrollFrame API
https://bugs.webkit.org/show_bug.cgi?id=32279
* WebView.cpp:
(WebView::updateRootLayerContents):
2010-01-15 Jon Honeycutt <jhoneycutt@apple.com>
MSAA: Screen rect for <option> elements is always the zero rect
https://bugs.webkit.org/show_bug.cgi?id=33758
Reviewed by Oliver Hunt.
* AccessibleBase.cpp:
(AccessibleBase::accLocation):
Use elementRect() rather than boundingBoxRect(), which
AccessibilityListBoxOption overrides.
2010-01-15 Jon Honeycutt <jhoneycutt@apple.com>
get_accParent should try to retrieve parent AccessibilityObject, before
calling upon window
https://bugs.webkit.org/show_bug.cgi?id=22893
Reviewed by Darin Adler.
* AccessibleBase.cpp:
(AccessibleBase::get_accParent):
If the object has a parent object, return it. If not, return the
accessible for the WebView window.
2010-01-12 Jon Honeycutt <jhoneycutt@apple.com>
MSAA: selected, selectable, extended selectable, and multiple
selectable states are not reported
https://bugs.webkit.org/show_bug.cgi?id=33574
<rdar://problem/7536826>
Reviewed by Darin Adler.
* AccessibleBase.cpp:
(AccessibleBase::get_accState):
Remove the call to isMultiSelect(). Call the correctly-named
isMultiSelectable(), and if it returns true, set both the "extended
selectable" and "multiple selectable" states. Check whether the object
is selected or selectable, and report those states.
2010-01-13 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Add additional Geolocation interfaces in WebKit for Windows.
* Interfaces/IWebGeolocationPolicyListener.idl: Added.
* Interfaces/IWebUIDelegatePrivate.idl: Add decidePolicyForGeolocationRequest to IWebUIDelegatePrivate2.
Append since this version hasn't shipped.
* Interfaces/WebKit.idl: Add include of IWebGeolocationPolicyListener.idl.
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::requestGeolocationPermissionForFrame): Call into decidePolicyForGeolocationRequest.
* WebCoreSupport/WebGeolocationControllerClient.cpp:
(WebGeolocationControllerClient::WebGeolocationControllerClient): Moved *.
* WebGeolocationPolicyListener.cpp: Added.
* WebGeolocationPolicyListener.h: Added.
* WebKit.vcproj/Interfaces.vcproj: Added IWebGeolocationPolicyListener.
* WebKit.vcproj/WebKit.vcproj: Added WebGeolocationPolicyListener, WebGeolocationPolicyListener.
* WebView.cpp:
(WebView::setGeolocationProvider): Removed extraneous STDMETHODCALLTYPE.
(WebView::geolocationProvider): Removed extraneous STDMETHODCALLTYPE.
(WebView::geolocationDidChangePosition): Removed extraneous STDMETHODCALLTYPE.
(WebView::geolocationDidFailWithError): Removed extraneous STDMETHODCALLTYPE.
2010-01-12 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben, Sam Weinig.
Add Geolocation interfaces in WebKit for Windows.
* ForEachCoClass.h: Added WebGeolocationPosition.
* Interfaces/IWebError.idl:
* Interfaces/IWebGeolocationPosition.idl: Added.
* Interfaces/IWebGeolocationProvider.idl: Added.
* Interfaces/IWebViewPrivate.idl:
* Interfaces/WebKit.idl:
* WebCoreSupport/WebGeolocationControllerClient.cpp: Added.
(WebGeolocationControllerClient::WebGeolocationControllerClient):
(WebGeolocationControllerClient::startUpdating):
(WebGeolocationControllerClient::stopUpdating):
(WebGeolocationControllerClient::lastPosition):
* WebCoreSupport/WebGeolocationControllerClient.h: Added.
* WebGeolocationPosition.cpp: Added IWebGeolocationPosition implementation.
* WebGeolocationPosition.h: Added IWebGeolocationPosition implementation.
* WebKit.vcproj/Interfaces.vcproj: Added IWebGeolocationPosition.idl, IWebGeolocationProvider.idl,
relocated JavaScriptCoreAPITypes.idl, WebScrollbarTypes.idl
* WebKit.vcproj/WebKit.vcproj: Added WebGeolocationPosition.h/.cpp, WebGeolocationControllerClient.h/cpp,
* WebKitClassFactory.cpp: Add WebGeolocationPosition include.
* WebView.cpp:
(WebView::initWithFrame): Create WebGeolocationControllerClient if Geolocation is enabled.
(WebView::setGeolocationProvider): Added Geolocation-specific method.
(WebView::geolocationProvider): Added Geolocation-specific method.
(WebView::geolocationDidChangePosition): Added Geolocation-specific method.
(WebView::geolocationDidFailWithError): Added Geolocation-specific method.
* WebView.h: Added setGeolocationProvider, geolocationProvider, geolocationDidChangePosition, geolocationDidFailWithError.
2010-01-11 Jon Honeycutt <jhoneycutt@apple.com>
MSAA: Accessibility role of <select multiple> elements is wrong
https://bugs.webkit.org/show_bug.cgi?id=33522
Reviewed by Darin Adler.
* AccessibleBase.cpp:
(MSAARole):
Map the WebCore::ListBox and WebCore::ListBoxOption roles to the MSAA
"list" and "list item" roles.
2010-01-08 Brent Fulgham <bfulgham@webkit.org>
Build fix, no review.
Protect video control logic inside ENABLE(VIDEO).
* WebView.cpp:
(WebView::enterFullscreenForNode):
(WebView::exitFullscreen):
* WebView.h:
2010-01-08 Chris Marrin <cmarrin@apple.com>
Reviewed by Adam Roben.
Implement full-screen video for Windows
https://bugs.webkit.org/show_bug.cgi?id=31318
This adds a full-screen controller, FullscreenVideoController,
which manages going in and out of full-screen. The actual
full-screen window is created and managed by logic added
to QTMovieWin. FullscreenVideoController also creates and
manages a HUD. The HUD renders and manages events to
control the playing video. Movie controller events go to
FullscreenVideoController which then sends them to HTMLMediaElement,
which is passed to the controller by WebView, which gets the call
to go into full-screen mode from HTMLMediaElement via
ChromeClient.
I've also updated the icons so the related sets (Play/Pause and
volume high/volume low/exit fullscreen) are the same size. This
allows me to position them using common code.
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::supportsFullscreenForNode):
(WebChromeClient::enterFullscreenForNode):
(WebChromeClient::exitFullscreenForNode):
* WebCoreSupport/WebChromeClient.h:
* WebKit.vcproj/WebKit.vcproj:
* WebKit.vcproj/fsVideoAudioVolumeHigh.png:
* WebKit.vcproj/fsVideoAudioVolumeLow.png:
* WebKit.vcproj/fsVideoExitFullscreen.png:
* WebKit.vcproj/fsVideoPause.png:
* WebKit.vcproj/fsVideoPlay.png:
* WebKitDLL.cpp:
(loadResourceIntoBuffer):
* FullscreenVideoController.cpp: Added.
* FullscreenVideoController.h: Added.
* WebView.cpp:
(WebView::enterFullscreenForNode):
(WebView::exitFullscreen):
* WebView.h:
2010-01-08 Brent Fulgham <bfulgham@webkit.org>
Unreviewed correction.
Accidentally left unnecessary modification to hdcFromContext
in when landing r52995.
* WebFrame.cpp:
(hdcFromContext): Back out unneeded modification.
2010-01-08 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
Use correct cairo surface data type for handling print operations.
https://bugs.webkit.org/show_bug.cgi?id=33022.
* WebFrame.cpp:
(scaleFactor): Handle 'scale = 0' case.
(WebFrame::spoolPage): Use scaleFactor helper function. Account for
margin size in region passed to header/footer routines.
(WebFrame::spoolPages): Properly clean up Cairo surface.
2010-01-07 Kent Tamura <tkent@chromium.org>
Reviewed by Maciej Stachowiak.
Remove COM code generation files.
https://bugs.webkit.org/show_bug.cgi?id=32854
* WebKit.vcproj/DerivedSources.make: Removed.
* WebKit.vcproj/build-generated-files.sh: Removed.
2010-01-05 Adam Roben <aroben@apple.com>
Make IWebView::close and destroying a WebView's HWND optional for
WebKit clients
WebView will now take care of these operations itself when its last
reference is released, if they haven't already been done.
IWebView::close now also destroys the WebView's HWND. All WebKit
clients were already performing these operations in succession anyway,
or were attempting to by calling IWebView::close then destroying the
WebView's host window (which actually resulted in the WebView's HWND
leaking, and the crash in the below bug).
Fixes <rdar://problem/7374218> <http://webkit.org/b/32827> Crash when
calling IWebView::close, then releasing the WebView, without calling
DestroyWindow
Fixes a few WebViewDestruction tests, too.
Reviewed by Steve Falkenburg.
* WebView.cpp:
(WebView::~WebView): Don't try to destroy m_viewWindow here. That
should already have happened. Assert that this is the case.
(WebView::close): If m_viewWindow isn't already being destroyed,
destroy it now. Moved the call to revokeDragDrop() here from our
WM_DESTROY handler because it needs to be done before m_viewWindow is
nulled out.
(WebView::WebViewWndProc): Removed call to revokeDragDrop() that
close() now performs.
(WebView::Release): If our last reference is being released, call
close() so that clients don't have to. (It's harmless to call close()
multiple times.) We do this here instead of in the destructor because
close() can cause AddRef() and Release() to be called, and calling
those from within the destructor leads to double-destruction.
(WebView::setHostWindow): Removed an unnecessary (and now harmful)
null-check.
(WebView::revokeDragDrop): Changed an assertion into a run-time check,
since this will now sometimes be called when m_viewWindow hasn't been
created yet. Changed the IsWindow call to a null-check because we
never hold onto a destroyed m_viewWindow.
(WebView::windowAncestryDidChange): If we don't have a view window,
stop tracking changes to our parent's active state.
2010-01-05 Adam Roben <aroben@apple.com>
Make it safe to call IWebView::close when IWebView::initWithFrame
hasn't been called
Part of <rdar://problem/7374218> <http://webkit.org/b/32827> Crash
when IWebView::close, then releasing the WebView, without calling
DestroyWindow
Reviewed by Steve Falkenburg.
* WebView.cpp:
(WebView::close): Null-check m_page and m_preferences before using
them. They will be null if initWithFrame was never called.
2010-01-05 Adam Roben <aroben@apple.com>
Add assertions to catch double-destruction of WebViews earlier
I basically copied the m_deletionHasBegun logic from WTF::RefCounted.
Fixes <http://webkit.org/b/33219>.
Reviewed by Darin Adler.
* WebView.cpp:
(WebView::WebView): Initialize m_deletionHasBegun
(WebView::AddRef): Assert that deletion hasn't already begun.
(WebView::Release): Assert that deletion hasn't already begun, then
record when deletion *does* begin.
* WebView.h: Added m_deletionHasBegun.
2010-01-05 Adam Roben <aroben@apple.com>
Remove dead code in WebViewWndProc
Fixes <http://webkit.org/b/33218>.
Reviewed by Darin Adler.
* WebView.cpp:
(WebView::WebViewWndProc): Removed a redundant isBeingDestroyed check.
We bail out much earlier in this function if isBeingDestroyed is true.
2010-01-04 Jon Honeycutt <jhoneycutt@apple.com>
MSAA: Accessibility role of <select> elements is wrong
https://bugs.webkit.org/show_bug.cgi?id=33192
Reviewed by Sam Weinig.
* AccessibleBase.cpp:
(MSAARole):
Map WebCore::PopUpButtonRole to MSAA's ROLE_SYSTEM_COMBOBOX.
2010-01-04 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=33181
The first letter is not removed properly from inline input hole
* WebView.cpp: (WebView::onIMEEndComposition): If composition is ended before it was
confirmed, cancel it.
2010-01-04 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=33161
Assertion failure in WebView when using Chinese Simplified IME
* WebView.cpp: (WebView::onIMERequestCharPosition): Changed the assertion into release mode
check. We can't make assertions about arguments passed from outside WebKit.
2010-01-04 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=33157
Implement TextInput logging channel on Windows
* WebKitLogging.cpp: (WebKitInitializeLoggingChannelsIfNecessary):
* WebKitLogging.h:
Added a TextInput channel in place of unused Network one.
* WebView.cpp:
(WebView::WebViewWndProc): Changed onIMERequest to return result directly. We never forward
it to DefWindowProc, so there is no need to return an unused boolean result for "handled".
(WebView::onIMEStartComposition): Added logging.
(imeCompositionArgumentNames): A helper function for detailed logging in onIMEComposition.
(imeNotificationName): A helper function for detailed logging in onIMENotify.
(imeRequestName): A helper function for detailed logging in onIMERequest.
(WebView::onIMEComposition): Added logging.
(WebView::onIMEEndComposition): Ditto.
(WebView::onIMEChar): Ditto.
(WebView::onIMENotify): Ditto.
(WebView::onIMERequestCharPosition): Changed to return result directly.
(WebView::onIMERequestReconvertString): Ditto.
(WebView::onIMERequest): Changed to return result directly. Added logging.
(WebView::onIMESelect): Added logging.
(WebView::onIMESetContext): Added logging.
* WebView.h: onIMERequest functions now return result directly.
2010-01-04 Adam Roben <aroben@apple.com>
Add WebKitAPITest
Fixes <http://webkit.org/b/33167>.
Reviewed by Sam Weinig.
* WebKit.vcproj/WebKit.sln: Added WebKitAPITest.vcproj. It builds just
after DumpRenderTree.vcproj.
2010-01-04 Dan Bernstein <mitz@apple.com>
Reviewed by Ada Chan and Mark Rowe.
Updated copyright string
* WebKit.vcproj/WebKit.rc:
2009-12-22 Darin Adler <darin@apple.com>
Another try at fixing Windows build.
* WebKitPrefix.cpp: Touch it.
2009-12-22 Darin Adler <darin@apple.com>
Reviewed by Mark Rowe.
Turn off datagrid by default, at least for all platforms Apple ships.
The datagrid implementation isn't ready for general web use yet.
* WebKit.vcproj/WebKit.vcproj: Turn off datagrid by default.
2009-12-21 Adam Roben <aroben@apple.com>
Fix non-ACCELERATED_COMPOSITING builds
* WebPreferences.cpp:
(WebPreferences::acceleratedCompositingEnabled): Guard use of
WKCACFLayerRenderer with USE(ACCELERATED_COMPOSITING).
2009-12-18 Adam Roben <aroben@apple.com>
Add IWebPreferencesPrivate::[set]AcceleratedCompositingEnabled
Fixes <http://webkit.org/b/32745>.
Reviewed by Ada Chan.
* Interfaces/IWebPreferencesPrivate.idl: Added
[set]AcceleratedCompositingEnabled.
* Interfaces/WebKit.idl: Touched to force a build.
* WebPreferenceKeysPrivate.h: Added
WebKitAcceleratedCompositingEnabledPreferenceKey.
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings): Make accelerated
compositing be on by default.
(WebPreferences::setAcceleratedCompositingEnabled): Store the new
value.
(WebPreferences::acceleratedCompositingEnabled): If accelerated
compositing isn't available, return false. Otherwise, return the value
stored in preferences.
* WebPreferences.h: Added [set]AcceleratedCompositingAvailable.
* WebView.cpp:
(WebView::notifyPreferencesChanged): Just pass the value from
WebPreferences on down.
2009-12-17 Jon Honeycutt <jhoneycutt@apple.com>
MSAA: Accessibility role of list items is wrong
https://bugs.webkit.org/show_bug.cgi?id=32688
Reviewed by Adam Roben.
* AccessibleBase.cpp:
(MSAARole):
Make the WebCore list item role map to the MSAA list item role.
2009-12-17 Jon Honeycutt <jhoneycutt@apple.com>
MSAA: Accessibility role of list markers is wrong
https://bugs.webkit.org/show_bug.cgi?id=32687
Reviewed by Adam Roben.
* AccessibleBase.cpp:
(MSAARole):
Make the WebCore list marker role map to the MSAA static text role.
2009-12-18 Adam Roben <aroben@apple.com>
Add #includes needed after WebCore clean-up
Rubber-stamped by Anders Carlsson.
Fixes <http://webkit.org/b/32718>.
* WebCoreSupport/WebContextMenuClient.cpp:
* WebDataSource.cpp:
* WebHTMLRepresentation.cpp:
* WebView.cpp:
* WebView.h:
2009-12-17 Benjamin Otte <otte@gnome.org>
Reviewed by Adam Roben.
Don't include all JSC headers everywhere
https://bugs.webkit.org/show_bug.cgi?id=32663
* WebCoreLocalizedStrings.cpp: Added now-needed #include of
MathExtras.h.
2009-12-17 Adam Roben <aroben@apple.com>
Remove WebKit.sln's Debug_All and Debug_Internal configurations
These configurations aren't buildable by people outside of Apple, and
Apple doesn't use this solution file.
Fixes <http://webkit.org/b/31000> Windows WebKit Build Configuration
should default to Debug instead of Debug_all.
Rubber-stamped by Dan Bernstein.
* WebKit.vcproj/WebKit.sln:
2009-12-16 Jon Honeycutt <jhoneycutt@apple.com>
MSAA: Accessibility role of text nodes is wrong
https://bugs.webkit.org/show_bug.cgi?id=32631
<rdar://problem/7369084>
Reviewed by Alice Liu.
* AccessibleBase.cpp:
(MSAARole):
If the role is WebCore::EditableTextRole, return ROLE_SYSTEM_TEXT.
(AccessibleBase::role):
Call roleValueForMSAA().
2009-12-14 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
Provide working printing support for WinCairo port.
* WebFrame.cpp:
(WebFrame::spoolPage): Conditionalize initialization of
PlatformGraphicsContext handling for CG vs. Cairo.
(scaleFactor): Add helper function.
(hdcFromContext): Add helper function.
(WebFrame::drawHeader): Correct Cairo variation.
(WebFrame::drawFooter): Correct Cairo variation.
(WebFrame::spoolPages): Correct Cairo variation.
2009-12-13 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Fix for https://bugs.webkit.org/show_bug.cgi?id=32499
Add client based Geolocation provider
Add first cut of a client based Geolocation provider. This is guarded by
ENABLE(CLIENT_BASED_GEOLOCATION) and is off by default for now. This adds a
GeolocationControllerClient interface that no-one currently implements,
but will in a subsequent patch.
* WebView.cpp:
(WebView::initWithFrame):
2009-12-14 Adam Roben <aroben@apple.com>
Change IWebFramePrivate's vtable to be compatible with Safari 4.0.4
Reviewed by Steve Falkenburg.
Fixes <http://webkit.org/b/32433> REGRESSION (r51567): Right click on
a link element crashes WebKit nightly
* Interfaces/IWebFramePrivate.idl: Moved pauseSVGAnimation to the end
of the interface so the vtable that Safari 4.0.4 sees is unchanged.
2009-12-14 Adam Roben <aroben@apple.com>
Build fix
* WebKit.vcproj/WebKit.vcproj: Added $(DXSDK_DIR)\Lib\x86 to the
libpath for all non-Cairo configurations (it was missing from most of
them).
2009-12-11 Chris Marrin <cmarrin@apple.com>
Reviewed by Jon Honeycutt.
Added icons for full-screen video on Windows
https://bugs.webkit.org/show_bug.cgi?id=31318
* WebKit.vcproj/WebKit.rc:
* WebKit.vcproj/WebKit.vcproj:
* WebKit.vcproj/fsVideoAudioVolumeHigh.png: Added.
* WebKit.vcproj/fsVideoAudioVolumeLow.png: Added.
* WebKit.vcproj/fsVideoExitFullscreen.png: Added.
* WebKit.vcproj/fsVideoPause.png: Added.
* WebKit.vcproj/fsVideoPlay.png: Added.
* WebKit.vcproj/resource.h:
2009-12-11 Chris Marrin <cmarrin@apple.com>
Reviewed by Adam Roben.
Delay load DLLs for accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=31856
If the DLLs (d3d9 and QuartzCore). are not present it
turns off accelerated compositing and avoids calling
any of the functions in the DLLs.
* WebView.cpp:
(WebView::notifyPreferencesChanged):
2009-12-10 Jon Honeycutt <jhoneycutt@apple.com>
Pass more information about a plug-in to the PluginHalterDelegate
Reviewed by Adam Roben.
* Interfaces/IWebPluginHalterDelegate.idl:
Add new parameters.
* WebCoreSupport/WebPluginHalterClient.cpp:
(WebPluginHalterClient::shouldHaltPlugin):
Update for new parameters. Pass them when making the delegate call.
* WebCoreSupport/WebPluginHalterClient.h:
Update for new parameters.
2009-12-09 Brent Fulgham <bfulgham@webkit.org>
Revert incorrect commit-box update r51911.
It mistakenly set the selectAll implementation in the
deslectAll method.
* WebFrame.cpp:
(WebFrame::deselectAll):
2009-12-09 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Darin Adler.
Provide an implementation for 'selectAll'
https://bugs.webkit.org/show_bug.cgi?id=32296
* WebFrame.cpp:
(WebFrame::selectAll): Implement "SelectAll" command.
2009-12-09 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Darin Adler.
Provide an implementation for 'selectAll'
https://bugs.webkit.org/show_bug.cgi?id=32296
* WebFrame.cpp:
(WebFrame::selectAll): Implement "SelectAll" command.
2009-12-08 Chris Marrin <cmarrin@apple.com>
Reviewed by Adam Roben.
Delay load DLLs for accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=31856
If the DLLs (d3d9 and QuartzCore). are not present it
turns off accelerated compositing and avoids calling
any of the functions in the DLLs.
* WebView.cpp:
* WebView.h:
2009-12-08 Adam Roben <aroben@apple.com>
Windows build fix
* Interfaces/WebKit.idl: Touched this to force Interfaces.vcproj to rebuild.
2009-12-08 John Sullivan <sullivan@apple.com>
Reviewed by Dan Bernstein
Split two-clause assertions into two separate assertions.
* DOMHTMLClasses.cpp:
(DOMHTMLInputElement::isTextField):
Split a two-clause assertion into two separate assertions.
(DOMHTMLInputElement::rectOnScreen):
Added the two assertions here that all other functions in this group shared.
(DOMHTMLInputElement::selectedRange):
Split a two-clause assertion into two separate assertions.
(DOMHTMLInputElement::setAutofilled):
Split a two-clause assertion into two separate assertions.
(DOMHTMLInputElement::isAutofilled):
Split a two-clause assertion into two separate assertions.
2009-12-08 Nikolas Zimmermann <nzimmermann@rim.com>
Rubber-stamped by Maciej Stachowiak.
Turn on (SVG) Filters for Win.
https://bugs.webkit.org/show_bug.cgi?id=32224
* WebKit.vcproj/WebKit.vcproj:
2009-12-08 John Sullivan <sullivan@apple.com>
Add isAutofilled getter to match existing setter.
Reviewed by Ada Chan.
* DOMHTMLClasses.cpp:
(DOMHTMLInputElement::isAutofilled):
Implemented new cover function.
* DOMHTMLClasses.h:
Declared new cover function.
* Interfaces/DOMPrivate.idl:
Declared new interface.
2009-12-07 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (Windows build fix part III).
* WebView.cpp:
(WebView::stringByEvaluatingJavaScriptFromString):
2009-12-07 Gavin Barraclough <barraclough@apple.com>
Reviewed by NOBODY (Windows build fix part II).
* WebView.cpp:
(WebView::stringByEvaluatingJavaScriptFromString):
2009-12-03 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
<rdar://problem/7214236> and http://webkit.org/b/32052 - Implement HTML5 state object history API
* Interfaces/IWebFrameLoadDelegatePrivate2.idl:
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDidPushStateWithinPage):
(WebFrameLoaderClient::dispatchDidReplaceStateWithinPage):
(WebFrameLoaderClient::dispatchDidPopStateWithinPage):
* WebCoreSupport/WebFrameLoaderClient.h:
2009-12-03 Pavel Feldman <pfeldman@dhcp-172-28-174-220.spb.corp.google.com>
Reviewed by Timothy Hatcher.
Web Inspector: Simplify the settings support in inspector controller.
https://bugs.webkit.org/show_bug.cgi?id=32076
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::attachWindow):
(WebInspectorClient::detachWindow):
(WebInspectorClient::showWindowWithoutNotifications):
* WebCoreSupport/WebInspectorClient.h:
2009-12-03 Ben Murdoch <benm@google.com>
Reviewed by Brady Eidson.
[Android] The FrameLoaderClient is unaware of BackForwardList changes.
https://bugs.webkit.org/show_bug.cgi?id=31914
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDidAddBackForwardItem): Add an empty implementation. Method added to FrameLoaderClient by Android (see bug).
(WebFrameLoaderClient::dispatchDidRemoveBackForwardItem): ditto.
(WebFrameLoaderClient::dispatchDidChangeBackForwardIndex): ditto.
* WebCoreSupport/WebFrameLoaderClient.h:
2009-12-02 Timothy Hatcher <timothy@apple.com>
Move setValueForUser to the end of the DOMHTMLInputElement interface
so it is fine for binary compatibility.
Directed by Steve Falkenburg.
* Interfaces/DOMHTML.idl:
2009-12-02 Timothy Hatcher <timothy@apple.com>
Expose setValueForUser for the COM DOMHTMLInputElement.
<rdar://problem/6760590> Would like a way to detect a login form AutoFill from JavaScript
Reviewed by Dan Bernstein.
* DOMHTMLClasses.cpp:
(DOMHTMLInputElement::setValueForUser):
* Interfaces/DOMHTML.idl:
2009-12-01 Nikolas Zimmermann <nzimmermann@rim.com>
Not reviewed. Try to fix windows build.
* WebFrame.cpp:
2009-12-01 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Simon Fraser.
Add SVG animation test framework with 'snapshot' functionality
https://bugs.webkit.org/show_bug.cgi?id=31897
Add API used by the new 'sampleSVGAnimationForElementAtTime' DRT method,
forwarding the call to SVGDocumentExtensions, if SVG is enabled.
Implemented just like the existing pauseAnimation* methods for CSS animations.
* Interfaces/IWebFramePrivate.idl:
* WebFrame.cpp:
(WebFrame::pauseSVGAnimation):
* WebFrame.h:
2009-11-30 Adam Roben <aroben@apple.com>
Fix double-free of BSTRs passed to WebNavigationData::createInstance
WebFrameLoaderClient::updateGlobalHistory was converting
WebCore::Strings to WebCore::BStrings, then passing them to
WebNavigationData::createInstance. But the latter function takes BSTR
parameters and adopts them into WebCore::BStrings. So the end result
was that two WebCore::BStrings would end up freeing each underlying
BSTR.
The fix is to only convert to WebCore::BString inside
WebNavigationData.
Fixes <http://webkit.org/b/31998> <rdar://problem/7383452> REGRESSION
(r49564): Crash in updateGlobalHistory when running Javascript iBench
test
I couldn't find a way to reproduce this in DumpRenderTree.
Reviewed by Steve Falkenburg.
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::updateGlobalHistory): Pass WebCore::Strings to
WebNavigationData::createInstance.
* WebNavigationData.cpp:
(WebNavigationData::WebNavigationData):
(WebNavigationData::createInstance):
* WebNavigationData.h:
Changed to take const WebCore::String&s instead of BSTRs and to
convert the Strings to BStrings at this level.
2009-11-30 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
WebKit clients that don't implement didClearWindowObjectForFrameInScriptWorld should fall back to didClearWindowObject
https://bugs.webkit.org/show_bug.cgi?id=31986
* WebFrame.cpp:
(WebFrame::dispatchDidClearWindowObjectInWorld): Fall back if E_NOTIMPL returned.
2009-11-24 Chris Marrin <cmarrin@apple.com>
Another Windows build fix
Got rid of d3d.lib and d3dx9.lib dependency. Not needed until
we turn on ACCELERATED_COMPOSITING
* WebKit.vcproj/WebKit.vcproj:
2009-11-24 Chris Marrin <cmarrin@apple.com>
Fixed Windows build
Got rid of QuartzCore.lib dependency. Not needed until
we turn on ACCELERATED_COMPOSITING
* WebKit.vcproj/WebKit.vcproj:
2009-11-24 Chris Marrin <cmarrin@apple.com>
Reviewed by Simon Fraser.
Implement accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=27314
This is the WebKit side of the implementation. It plumbs the root layer
from WebCore. It also makes changes to WebView which places the
backing store of the page into the root compositing layer so it is
properly composited with all the other layers. This deals with resizing,
scrolling, and incremental repaint of the page.
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::attachRootGraphicsLayer):
(WebChromeClient::scheduleCompositingLayerSync):
* WebCoreSupport/WebChromeClient.h:
(WebChromeClient::setNeedsOneShotDrawingSynchronization):
* WebKit.vcproj/WebKit.vcproj:
* WebView.cpp:
(WebView::WebView):
(WebView::close):
(WebView::repaint):
(WebView::scrollBackingStore):
(WebView::paint):
(WebViewWndProc):
(WebView::setRootChildLayer):
(WebView::setAcceleratedCompositing):
(WebView::setRootLayerContents):
* WebView.h:
(WebView::isAcceleratedCompositing):
(WebView::resizeLayerWindow):
(WebView::layerWindowBecameVisible):
(WebView::setRootLayerNeedsDisplay):
2009-11-23 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Include "config.h" to meet Coding Style Guidelines
https://bugs.webkit.org/show_bug.cgi?id=31792
* GEN_DOMObject.cpp:
* WebScriptObject.cpp:
2009-11-21 Jon Honeycutt <jhoneycutt@apple.com>
Windows build fix. Unreviewed.
* Interfaces/IWebSerializedJSValue.idl:
2009-11-20 Jon Honeycutt <jhoneycutt@apple.com>
DOMElement::tagName() is unimplemented
https://bugs.webkit.org/show_bug.cgi?id=31746
Reviewed by Darin Adler.
* DOMCoreClasses.cpp:
(DOMElement::tagName):
Create a BString from the element's tag name, and release its BSTR
into result.
2009-11-20 Jon Honeycutt <jhoneycutt@apple.com>
DOMNode::childNodes() is unimplemented
https://bugs.webkit.org/show_bug.cgi?id=31745
Reviewed by Darin Adler.
* DOMCoreClasses.cpp:
(DOMNode::childNodes):
Create a DOMNodeList from the node's child nodes.
2009-11-20 Dave Hyatt <hyatt@apple.com>
Reviewed by Jon Honeycutt.
Change WebSerializedJSValue on Windows to have a zero-argument createInstance call. Move the
serialization into a separate serialize() function that can be called after the object has been
created.
Fix a typo in serialize() caused when fixing build bustage (put a ! back in).
* Interfaces/IWebSerializedJSValue.idl:
* WebSerializedJSValue.cpp:
(WebSerializedJSValue::WebSerializedJSValue):
(WebSerializedJSValue::createInstance):
(WebSerializedJSValue::serialize):
(WebSerializedJSValue::deserialize):
* WebSerializedJSValue.h:
2009-11-20 Brian Weinstein <bweinstein@apple.com>
Reviewed by Dave Hyatt.
Another go at the Windows Build Fix - this is a couple steps of it,
so a little more involved than most build fixes.
* Interfaces/IWebSerializedJSValue.idl:
* Interfaces/JavaScriptCoreAPITypes.idl:
* WebKit.vcproj/Interfaces.vcproj:
* WebSerializedJSValue.cpp:
(WebSerializedJSValue::deserialize):
* WebSerializedJSValue.h:
2009-11-20 Brian Weinstein <bweinstein@apple.com>
Reviewed by Dave Hyatt.
Build fix for Windows - only declare JSContextRef once, instead
of in two different idl files. Create a new file to hold the
definition of JSContextRef.
* Interfaces/IWebFrameLoadDelegate.idl:
* Interfaces/IWebSerializedJSValue.idl:
* Interfaces/JavaScriptCoreAPITypes.idl: Added.
* Interfaces/WebKit.idl:
* WebKit.vcproj/Interfaces.vcproj:
2009-11-20 Dave Hyatt <hyatt@apple.com>
Reviewed by Oliver Hunt and Jon Honeycutt.
Add support for WebSerializedJSValue to WebKit. This object wraps the SerializedScriptValue functionality in WebCore
and exposes the ability to do JS value serialization/deserialization to WebKit clients.
* Interfaces/IWebSerializedJSValue.idl: Added.
* Interfaces/WebKit.idl:
* WebKit.vcproj/WebKit.vcproj:
* WebSerializedJSValue.cpp: Added.
(WebSerializedJSValue::WebSerializedJSValue):
(WebSerializedJSValue::~WebSerializedJSValue):
(WebSerializedJSValue::createInstance):
(WebSerializedJSValue::AddRef):
(WebSerializedJSValue::Release):
(WebSerializedJSValue::QueryInterface):
(WebSerializedJSValue::deserialize):
* WebSerializedJSValue.h: Added.
2009-11-19 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=31690
Make SocketStreamHandleCFNet work on Windows
* WebDownloadCFNet.cpp:
(WebDownload::init):
(WebDownload::initWithRequest):
(WebDownload::initToResumeWithBundle):
Update for loaderRunLoop() now being in its own header.
2009-11-19 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/7035231>
Support closed caption in <video> element
* WebCoreLocalizedStrings.cpp:
(WebCore::localizedMediaControlElementString):
(WebCore::localizedMediaControlElementHelpText):
Add accessibility help strings for media controller closed caption button.
2009-11-18 Michelangelo De Simone <micdesim@gmail.com>
Reviewed by Darin Adler.
Fix for <https://bugs.webkit.org/show_bug.cgi?id=27959>.
Support for validationMessage attribute, as per HTML5 specs.
* WebCoreLocalizedStrings.cpp:
(WebCore::validationMessageValueMissingText):
(WebCore::validationMessageTypeMismatchText):
(WebCore::validationMessagePatternMismatchText):
(WebCore::validationMessageTooLongText):
(WebCore::validationMessageRangeUnderflowText):
(WebCore::validationMessageRangeOverflowText):
(WebCore::validationMessageStepMismatchText):
2009-11-18 Daniel Bates <dbates@webkit.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=31186
Changes associated with renaming RenderTextControl::isUserEdited.
* DOMHTMLClasses.cpp:
(DOMHTMLInputElement::isUserEdited): Formerly named isUserEdited.
(DOMHTMLTextAreaElement::isUserEdited): Ditto.
2009-11-12 Jon Honeycutt <jhoneycutt@apple.com>
Implement DOMHTMLInputElement::replaceCharactersInRange().
https://bugs.webkit.org/show_bug.cgi?id=31492
Reviewed by Dan Bernstein.
* DOMHTMLClasses.cpp:
(DOMHTMLInputElement::replaceCharactersInRange):
Get the text of the input field. Replace the given range with the
replacement text, and set this new string as the input element's value.
Select from index to the end of the field. This matches the
implementation in the Obj-C bindings.
2009-11-12 Jon Honeycutt <jhoneycutt@apple.com>
DOMHTMLOptionElement is missing some functionality.
https://bugs.webkit.org/show_bug.cgi?id=31491
Reviewed by Dan Bernstein.
* DOMHTMLClasses.cpp:
(DOMHTMLOptionElement::text):
Cast m_element to an HTMLOptionElement, and call its text() function.
(DOMHTMLOptionElement::label):
Ditto, for label().
2009-11-12 Jon Honeycutt <jhoneycutt@apple.com>
DOMHTMLSelectElement is missing some implementation.
https://bugs.webkit.org/show_bug.cgi?id=31489
Reviewed by Dan Bernstein.
* DOMHTMLClasses.cpp:
(DOMHTMLSelectElement::options):
Cast m_element to an HTMLSelectElement. If it has no options, return
E_FAIL. Otherwise, create a DOMHTMLOptionsCollection to wrap the
options, and return it.
(DOMHTMLSelectElement::activateItemAtIndex):
If the index is out of bounds, return E_FAIL. Otherwise, select the
item.
2009-11-12 Jon Honeycutt <jhoneycutt@apple.com>
DOMHTMLOptionsCollection is missing some implementation.
https://bugs.webkit.org/show_bug.cgi?id=31488
Reviewed by Dan Bernstein.
* DOMHTMLClasses.cpp:
(DOMHTMLOptionsCollection::DOMHTMLOptionsCollection):
Initialize m_collection.
(DOMHTMLOptionsCollection::createInstance):
Create a DOMHTMLOptionsCollection. If we fail to query for
IDOMHTMLOptionsCollection, delete it, and return 0. Otherwise, return
the result.
(DOMHTMLOptionsCollection::length):
(DOMHTMLOptionsCollection::item):
Create a DOMNode for the WebCore Node. If this is 0, return E_FAIL.
(DOMHTMLOptionsCollection::namedItem):
Correct the signature of this function.
* DOMHTMLClasses.h:
Declare DOMHTMLOptionsCollection::createInstance(). Correct the
signature of namedItem() to match IDOMHTMLOptionsCollection. Add a
member to DOMHTMLOptionsCollection to hold the WebCore object.
2009-11-12 Jon Honeycutt <jhoneycutt@apple.com>
DOMHTMLInputElement::rectOnScreen() returns the wrong rect
https://bugs.webkit.org/show_bug.cgi?id=31487
Reviewed by Darin Adler.
* DOMHTMLClasses.cpp:
(DOMHTMLInputElement::rectOnScreen):
Return the rect on screen, not the rect in the window.
2009-11-17 Brent Fulgham <bfulgham@webkit.org>
Reviewed by NOBODY - Build Fix.
Correct build error in Debug_Cairo target after @49705.
* WebKit.vcproj/WebKit.vcproj: Revise JavaScriptCore.lib
dependency to have proper "_debug" suffix needed by
the Debug_Cairo target.
2009-11-17 Brian Weinstein <bweinstein@apple.com>
Reviewed by NOBODY - Build Fix.
Touch files to try to fix the build.
* Interfaces/IWebInspector.idl:
* Interfaces/WebKit.idl:
* WebKit.vcproj/Interfaces.vcproj:
2009-11-17 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Make DRT show web inspector for tests in inspector/ folder.
- Updated DRT to show/close inspector for all tests under /inspector
- Introduced LayoutTestController::setTimelineProfilingEnabled and
WebInspector::setTimelineProfilingEnabled beside setJavaScriptProfilingEnabled
- Removed reload on each inspector test
- Renamed fast/inspector to fast/inspector-support in order not to trigger
inspector for those.
- Reimplemented timeline tests in order to get rid of reload there.
- Moved tests that don't require harness into the fast group.
https://bugs.webkit.org/show_bug.cgi?id=31472
* Interfaces/IWebInspector.idl:
* WebInspector.cpp:
(WebInspector::isTimelineProfilingEnabled):
(WebInspector::setTimelineProfilingEnabled):
* WebInspector.h:
2009-11-13 Adam Roben <aroben@apple.com>
Build fix
* Interfaces/WebKit.idl: Touch this to force interfaces to rebuild.
2009-11-13 Adam Roben <aroben@apple.com>
Tell the WebFrameLoadDelegate when window objects in isolated worlds
are cleared
Fixes <http://webkit.org/b/31124>.
Reviewed by Dave Hyatt.
* Interfaces/IWebFrameLoadDelegatePrivate2.idl: Added
didClearWindowObjectForFrameInScriptWorld.
* WebFrame.cpp:
(WebFrame::dispatchDidClearWindowObjectInWorld):
* WebFrame.h:
Replaced windowObjectCleared with this function. If the delegate
implements IWebFrameLoadDelegatePrivate2, call
didClearWindowObjectForFrameInScriptWorld. Otherwise, if the passed-in
world is the mainThreadNormalWorld(), call
didClearWindowObjectForFrame.
* WebScriptWorld.cpp:
(allWorlds): Added. Returns a HashMap of all the WebScriptWorlds in
existence.
(WebScriptWorld::WebScriptWorld): Add ourselves to allWorlds().
(WebScriptWorld::~WebScriptWorld): Remove ourselves from allWorlds().
(WebScriptWorld::standardWorld): Added this non-COM getter for the
standard world, which the COM getter now calls through to.
(WebScriptWorld::findOrCreateWorld): Added. Returns the existing
WebScriptWorld for this DOMWrapperWorld, or a new one if one doesn't
already exist.
* WebScriptWorld.h: Added new standardWorld overload, made one
overload of createInstance private, and added findOrCreateWorld.
2009-11-13 Adam Roben <aroben@apple.com>
Build fix
* Interfaces/WebKit.idl: Un-sort the #includes again. Apparently they
are order-dependent!
2009-11-13 Adam Roben <aroben@apple.com>
Touch WebKit.idl to fix the Windows build
* Interfaces/WebKit.idl: Sorted #includes.
2009-11-13 Adam Roben <aroben@apple.com>
Finish replacing worldIDs with world objects
The only remaining use of worldIDs was in a method only used by DRT
for the isolated worlds tests.
Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
Reviewed by Mark Rowe.
* Interfaces/IWebFramePrivate.idl:
* WebFrame.cpp:
(WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
* WebFrame.h:
Renamed from stringByEvaluatingJavaScriptInIsolatedWorld. Now takes an
IWebScriptWorld instead of a worldID, so we don't need to maintain a
map of worldID -> world anymore.
2009-11-12 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
externalRepresentation should take Frame as the argument
https://bugs.webkit.org/show_bug.cgi?id=31393
No new tests as this is just a refactoring.
* WebFrame.cpp:
(WebFrame::renderTreeAsExternalRepresentation):
2009-11-12 Adam Roben <aroben@apple.com>
Replace worldIDs with world objects
WebScriptWorld is the new object that represents a world. The only
place worldID is still used is in
IWebFramePrivate::stringByEvaluatingJavaScriptInIsolatedWorld, but
that will change soon.
Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
user scripts/stylesheets and isolated worlds
Reviewed by Sam Weinig.
* ForEachCoClass.h: Added WebScriptWorld.
* Interfaces/IWebFramePrivate.idl: Replaced contextForWorldID with
contextForWorld.
* Interfaces/IWebScriptWorld.idl: Added.
* Interfaces/IWebViewPrivate.idl: Changed the user script/stylesheet
functions to take an IWebScriptWorld instead of a worldID.
* Interfaces/WebKit.idl: Added WebScriptWorld.
* WebFrame.cpp:
(WebFrame::contextForWorld): Renamed from contextForWorldID. Now takes
an IWebScriptWorld.
(WebFrame::stringByEvaluatingJavaScriptInIsolatedWorld): Moved the
bizarre world caching/creation logic that DRT depends on here from the
findWorld function in ScriptController.cpp. Updated to use
ScriptController::executeScriptInWorld instead of
ScriptController::executeScriptInIsolatedWorld.
* WebFrame.h: Replaced contextForWorldID with contextForWorld.
* WebScriptWorld.cpp: Added.
(WebScriptWorld::WebScriptWorld):
(WebScriptWorld::~WebScriptWorld):
(WebScriptWorld::createInstance):
(WebScriptWorld::AddRef):
(WebScriptWorld::Release):
(WebScriptWorld::QueryInterface):
Standard COM class implementations.
(WebScriptWorld::standardWorld): Returns a shared instance that represents
WebCore's mainThreadNormalWorld().
* WebScriptWorld.h: Added.
(WebScriptWorld::world): Simple getter.
* WebKit.vcproj/Interfaces.vcproj: Added IWebScriptWorld.idl.
* WebKit.vcproj/WebKit.vcproj: Added WebScriptWorld.
* WebKitClassFactory.cpp: Added WebScriptWorld.
* WebView.cpp:
(WebView::addUserScriptToGroup):
(WebView::addUserStyleSheetToGroup):
(WebView::removeUserScriptFromGroup):
(WebView::removeUserStyleSheetFromGroup):
(WebView::removeUserScriptsFromGroup):
(WebView::removeUserStyleSheetsFromGroup):
* WebView.h:
Changed these functions to take an IWebScriptWorld instead of a worldID.
2009-11-12 Adam Roben <aroben@apple.com>
Small clean-up in WebView's user content functions
Preparation for <http://webkit.org/b/31414> Implement new SPI for
dealing with user scripts/stylesheets and isolated worlds
Reviewed by Dave Hyatt.
* WebView.cpp:
(toString):
(toKURL):
Added these helper functions to convert BSTRs to WebCore types.
(toStringVector):
(WebView::addUserScriptToGroup):
(WebView::addUserStyleSheetToGroup):
(WebView::removeUserScriptFromGroup):
(WebView::removeUserStyleSheetFromGroup):
(WebView::removeUserScriptsFromGroup):
(WebView::removeUserStyleSheetsFromGroup):
(WebView::removeAllUserContentFromGroup):
Use the new helper functions.
2009-11-11 Beth Dakin <bdakin@apple.com>
Build fix. No review needed.
* WebKitGraphics.cpp:
(WebDrawText):
2009-11-10 Daniel Bates <dbates@webkit.org>
Reviewed by Oliver Hunt.
https://bugs.webkit.org/show_bug.cgi?id=30754
Modified WebDropSource::QueryContinueDrag so as to not call EventHandler::dragSourceMovedTo.
* WebDropSource.cpp:
(WebDropSource::QueryContinueDrag): Removed call to EventHandler::dragSourceMovedTo.
2009-11-10 Alexey Proskuryakov <ap@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=31312
Decouple authentication panel callbacks from ResourceHandle
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
* WebURLAuthenticationChallenge.cpp:
(WebURLAuthenticationChallenge::initWithAuthenticationChallenge):
(WebURLAuthenticationChallenge::sender):
* WebURLAuthenticationChallengeSender.cpp:
(WebURLAuthenticationChallengeSender::WebURLAuthenticationChallengeSender):
(WebURLAuthenticationChallengeSender::createInstance):
(WebURLAuthenticationChallengeSender::authenticationClient):
* WebURLAuthenticationChallengeSender.h:
* WebURLAuthenticationChallengeSenderCFNet.cpp:
(WebURLAuthenticationChallengeSender::cancelAuthenticationChallenge):
(WebURLAuthenticationChallengeSender::continueWithoutCredentialForAuthenticationChallenge):
(WebURLAuthenticationChallengeSender::useCredential):
Adjusted for WebCore changes.
2009-11-10 Brian Weinstein <bweinstein@apple.com>
Reviewed by NOBODY - Build Fix.
Updated fillRoundedRect to take a ColorSpace argument.
* WebCoreSupport/WebDragClient.cpp:
(WebDragClient::createDragImageForLink):
2009-11-08 Janne Koskinen <janne.p.koskinen@digia.com>
Reviewed by Holger Freyther.
ResourceRequest to be class instead of struct
https://bugs.webkit.org/show_bug.cgi?id=30670
Started as a compilation fix for Symbian where the compiler makes a distinction between
class and struct in function argument signatures.
Changed forward declaration of ResourceRequest to have class in the forward
declaration instead of struct.
* WebDownload.h:
2009-11-05 Adam Roben <aroben@apple.com>
Make CFDictionaryPropertyBag::createInstance return a COMPtr
I also cleaned up CFDictionaryPropertyBag's class declaration a little
while I was at it.
Part of <http://webkit.org/b/25294> <rdar://problem/6803127> All
WebKit/win classes should return COMPtrs from their static constructor
members
Reviewed by Steve Falkenburg.
* CFDictionaryPropertyBag.cpp:
(CFDictionaryPropertyBag::CFDictionaryPropertyBag): Changed to
initialize m_refCount to 0. m_refCount gets increased to 1 by
createInstance.
(CFDictionaryPropertyBag::createInstance): Changed to return a COMPtr.
* CFDictionaryPropertyBag.h:
- Updated copyright years
- Fixed header guard to match current style
- Replaced #include of CoreFoundation.h with forward-declaration of
CFMutableDictionaryRef
- Added #include of COMPtr.h
- Fixed opening brace placement in class declaration
- Made createInstance return a COMPtr
- Made constructor/destructor private
- Made QueryInterface and IPropertyBag functions private
- Removed unnecessary parameter names and MIDL comments
* WebCache.cpp:
(WebCache::statistics): Updated for change to
CFDictionaryPropertyBag::createInstance. Now uses releaseRef to place
the IPropertyBag pointers into the s array.
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDidFailToStartPlugin):
* WebDatabaseManager.cpp:
(WebDatabaseManager::dispatchDidModifyDatabase):
* WebFrame.cpp:
(WebFrame::createJavaAppletWidget):
Updated for change to CFDictionaryPropertyBag::createInstance.
* WebHistory.cpp: Removed releaseUserInfo, which is no longer needed.
That function was also doing an unnecessary call to setDictionary(0).
(createUserInfoFromArray):
(createUserInfoFromHistoryItem):
Changed to return COMPtr.
(WebHistory::loadFromURL): Updated for change to
CFDictionaryPropertyBag::createInstance.
(WebHistory::removeAllItems): Updated for change to
CFDictionaryPropertyBag::createInstance, which fixed a leak! We had
forgotten to call releaseUserInfo here.
(WebHistory::removeItem):
(WebHistory::addItem):
(WebHistory::visitedURL):
* WebIconDatabase.cpp:
(postDidAddIconNotification):
Updated for change to CFDictionaryPropertyBag::createInstance.
* WebKitClassFactory.cpp:
(releaseRefFromCreateInstance): Added this overloaded function
template to abstract away the difference between createInstance
functions that return a ref'd pointer and createInstance functions
that return a COMPtr.
(WebKitClassFactory::CreateInstance): Changed to use
releaseRefFromCreateInstance.
2009-11-03 Brian Weinstein <bweinstein@apple.com>
Reviewed by Steve Falkenburg.
WebActionModifierFlagsKey should return an unsigned, because
flags imply a bitmask, and that is what other classes expect from
it.
* WebActionPropertyBag.cpp:
(WebActionPropertyBag::Read):
2009-11-02 Eric Carlson <eric.carlson@apple.com>
Reviewed by John Sullivan and Mark Rowe.
<rdar://problem/7356733> Voiceover does not read correct media controller time values
* WebCoreLocalizedStrings.cpp:
(WebCore::localizedMediaTimeDescription):
2009-10-29 Jon Honeycutt <jhoneycutt@apple.com>
MSAA: Accessibility of headings is not correct
https://bugs.webkit.org/show_bug.cgi?id=30937
Reviewed by Alice Liu.
* AccessibleBase.cpp:
(AccessibleBase::get_accDescription):
Call the object's descriptionForMSAA(). Moved the comment to the
WebCore file.
(AccessibleBase::get_accRole):
If the object has a string role, return that. Otherwise, return the
integer role.
* AccessibleBase.h:
Removed description(), as this was moved to WebCore.
2009-10-29 Jon Honeycutt <jhoneycutt@apple.com>
MSAA: Accessibility of links is wrong
https://bugs.webkit.org/show_bug.cgi?id=30928
Reviewed by Darin Adler.
* AccessibleBase.cpp:
(AccessibleBase::get_accState):
Check whether the element is linked, instead of whether the node is an
anchor, so the child "linkable" elements of anchor elements will also
be "linked".
(AccessibleBase::name):
Return the name for MSAA.
(AccessibleBase::value):
Return the string value for MSAA.
2009-10-30 Evan Stade <estade@chromium.org>
Reviewed by David Levin.
Notify the chrome when the focused node has changed.
https://bugs.webkit.org/show_bug.cgi?id=30832
Added stub implementation for new ChromeClient function.
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::focusedNodeChanged):
* WebCoreSupport/WebChromeClient.h:
2009-10-30 Roland Steiner <rolandsteiner@chromium.org>
Reviewed by Eric Seidel.
Remove ENABLE_RUBY guards as discussed with Dave Hyatt and Maciej Stachowiak.
Bug 28420 - Implement HTML5 <ruby> rendering
(https://bugs.webkit.org/show_bug.cgi?id=28420)
No new tests (no functional change).
* WebKit.vcproj/WebKit.vcproj:
2009-10-29 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Dan Bernstein.
<http://webkit.org/b/30938> REGRESSION(r50233): Windows nightlies crash on launch due to changes
to IWebFramePrivate vtable ordering
* Interfaces/IWebFramePrivate.idl: Move the newly-added method to the end of the interface so that
it doesn't affect the ordering of the vtable.
2009-10-28 Steve Falkenburg <sfalken@apple.com>
Reviewed by Sam "Horatio" Weinig.
Should not generate/build COM DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=30880
* Interfaces/WebKit.idl: Remove generated interfaces.
* WebKit.vcproj/InterfacesGenerated.vcproj: Removed.
* WebKit.vcproj/WebKit.sln: Remove InterfacesGenerated.vcproj.
* WebKit.vcproj/WebKit.submit.sln: Remove InterfacesGenerated.vcproj.
* WebKit.vcproj/WebKit.vcproj: Remove generated interfaces.
2009-10-27 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
Provide a way to get counter values with layoutTestContoller
https://bugs.webkit.org/show_bug.cgi?id=30555
* Interfaces/IWebFramePrivate.idl:
* WebFrame.cpp:
(WebFrame::counterValueForElementById):
* WebFrame.h:
2009-10-28 Joe Mason <jmason@rim.com>
Reviewed by Adam Treat.
Call the shared FrameLoader::defaultObjectContentType instead of
copying code into FrameLoaderClient::objectContentType. This causes no
behavioural change.
* WebFrame.cpp:
(WebFrame::objectContentType):
2009-10-28 Holger Hans Peter Freyther <zecke@selfish.org>
Speculative build-fix for WebElementPropertyBag.cpp
* WebElementPropertyBag.cpp: Include RenderObject.h
2009-10-27 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Simon Fraser.
Change HitTestResult methods to use (3d) transformation aware methods
https://bugs.webkit.org/show_bug.cgi?id=27347
The HitTestResult::boundingBox method was removed. The
RenderObject must be used directly. In contrast to the
old HitTestResult::boundingBox method this code must use
a (3d) transformation aware method to not run into an
assert in SVGRenderBase::mapLocalToContainer.
* WebElementPropertyBag.cpp:
(WebElementPropertyBag::Read): Replace HitTestResult::boundingBox()
2009-10-26 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Darin Adler.
Make .rc files compile on Windows without depending on MFC headers
https://bugs.webkit.org/show_bug.cgi?id=30750
* WebKit.vcproj/WebKit.rc: Use winresrc.h because it exists even
when MFC is not installed, and is all that's needed here.
2009-10-26 Sam Weinig <sam@webkit.org>
Rubber-stamped by Darin Adler.
Rollout r50041-50043. The HTML5 spec changed to make HTMLOptionsCollection
inherit from HTMLCollection.
* DOMCreateInstance.cpp:
2009-10-25 Dan Bernstein <mitz@apple.com>
Reviewed by John Sullivan.
Add contextForWorldID to the IWebFramePrivate interface.
* Interfaces/IWebFramePrivate.idl:
* WebFrame.h:
2009-10-25 Sam Weinig <sam@webkit.org>
Another try at fixing windows.
* DOMCreateInstance.cpp:
2009-10-25 Sam Weinig <sam@webkit.org>
Touch WebKit.idl in an effort to try and regenerate the COM bindings.
* Interfaces/WebKit.idl:
2009-10-23 Mark Rowe <mrowe@apple.com>
Build fix. Include config.h before including other files.
* AccessibleImage.cpp:
2009-10-23 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
https://bugs.webkit.org/show_bug.cgi?id=30729
Provide private API to request the global context for a specific world.
Used to initialize parameters on the global object.
* WebFrame.cpp:
(WebFrame::contextForWorldID):
* WebFrame.h:
2009-10-23 Brian Weinstein <bweinstein@apple.com>
Reviewed by John Sullivan.
Pan-scrolling pointer shows up in other tabs or windows, can't "fix" it.
<http://webkit.org/b/30732> and <rdar://7332018>.
Turns off pan-scrolling on a WebView when it is about to lose focus.
* WebView.cpp:
(WebViewWndProc):
2009-10-23 Jon Honeycutt <jhoneycutt@apple.com>
MSAA: Name for image elements should use alt attribute text
https://bugs.webkit.org/show_bug.cgi?id=30727
<rdar://problem/7328291>
Reviewed by Alice Liu.
* AccessibleBase.cpp:
(AccessibleBase::createInstance):
If the AccessibilityObject is an image, return an AccessibleImage.
* AccessibleImage.cpp: Added.
(AccessibleImage::AccessibleImage):
Call the base constructor.
(AccessibleImage::name):
If the object is not an AccessibilityRenderObject, return the base's
name(). Look first for an ARIA "labeled-by" attribute, then look for an
alternate text attribute. Fall back to the base's name().
* AccessibleImage.h: Added.
(AccessibleImage::~AccessibleImage):
* WebKit.vcproj/WebKit.vcproj:
Add AccessibleImage to the project.
2009-10-23 Sam Weinig <sam@webkit.org>
Try and fix the windows build.
* Interfaces/WebKit.idl:
2009-10-22 Gavin Barraclough <barraclough@apple.com>
Reviewed by Sam Weinig & Geoff Garen.
https://bugs.webkit.org/show_bug.cgi?id=30696
Update to incorporate support for IsolatedWorlds in JSC bindings.
* Interfaces/IWebFramePrivate.idl:
* WebFrame.cpp:
(WebFrame::globalContext):
(WebFrame::windowObjectCleared):
(WebFrame::stringByEvaluatingJavaScriptInIsolatedWorld):
* WebFrame.h:
2009-10-20 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by David Levin.
Removed WebSocket runtime settings.
https://bugs.webkit.org/show_bug.cgi?id=29896
WebSocket runtime configuration is supported by chromium/v8 only.
* Interfaces/IWebPreferencesPrivate.idl:
* WebPreferenceKeysPrivate.h:
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::experimentalNotificationsEnabled):
* WebPreferences.h:
* WebView.cpp:
(WebView::notifyPreferencesChanged):
2009-10-19 Adam Roben <aroben@apple.com>
Fix crashes/assertions when calling WebLocalizedString from multiple
threads concurrently
Fixes <http://webkit.org/b/30534> WebLocalizedString asserts if called
from multiple threads concurrently
Reviewed by John Sullivan.
* WebLocalizableStrings.cpp:
(mainBundleLocStringsMutex):
(frameworkLocStringsMutex):
Added these new getters.
(findCachedString):
(cacheString):
Lock the relevant mutex before accessing each string map. Otherwise
bad things could happen if two threads end up here at the same time.
2009-10-19 Adam Roben <aroben@apple.com>
Get rid of a few static initializers/exit-time destructors in
WebLocalizableStrings
Reviewed by Dan Bernstein.
* WebLocalizableStrings.cpp:
(mainBundleLocStrings):
(frameworkLocStrings):
Added these functions instead of file-scope variables.
(findCachedString):
(cacheString):
Updated to use the new functions.
2009-10-19 Nate Chapin <japhet@chromium.org>
Unreviewed, build fix.
Update call to FrameLoader::urlSelected().
* WebCoreSupport/WebContextMenuClient.cpp:
(WebContextMenuClient::searchWithGoogle):
2009-10-16 Steve Falkenburg <sfalken@apple.com>
Reviewed by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=30456
Fixes for new Debug_All Windows build configuration.
* WebKitClassFactory.cpp: Use new DEBUG_ALL preprocessor define for library naming.
2009-10-16 Jon Honeycutt <jhoneycutt@apple.com>
Add SPI to determine whether a plug-in has ever been halted.
Part of <rdar://problem/7312158>.
Reviewed by Dan Bernstein.
* Interfaces/IWebViewPrivate.idl:
Add hasPluginForNodeBeenHalted().
* WebView.cpp:
(pluginViewForNode):
Code factored out of isNodeHaltedPlugin().
(WebView::isNodeHaltedPlugin):
Remove STDMETHODCALLTYPE, as it has no use at the definition. Use
pluginViewForNode().
(WebView::restartHaltedPluginForNode):
Ditto.
(WebView::hasPluginForNodeBeenHalted):
Get the PluginView for the given node. Return the result of
PluginView::hasBeenHalted().
* WebView.h:
Declare hasPluginForNodeBeenHalted().
2009-10-16 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Add a Debug_All configuration to build entire stack as debug.
Change Debug_Internal to:
- stop using _debug suffix for all WebKit/Safari binaries
- not use _debug as a DLL naming suffix
- use non-debug C runtime lib.
* WebKit.vcproj/InterfacesGenerated.vcproj: Renamed single configuration from "Release" to "all".
* WebKit.vcproj/WebKit.make: Debug build in makefile should build Debug_All.
* WebKit.vcproj/WebKit.sln: Add Debug_All configuration.
* WebKit.vcproj/WebKit.submit.sln: Add Debug_All configuration.
* WebKit.vcproj/WebKit.vcproj:
Remove extraneous OutputDirectory/IntermediateDirectory in Debug_Cairo.
Add Debug_All configuration.
* WebKit.vcproj/WebKitGUID.vcproj: Add Debug_All configuration.
2009-10-15 Jon Honeycutt <jhoneycutt@apple.com>
Add SPI to restart a halted plug-in.
Part of <rdar://problem/7273354> Halted plug-ins should restart on
mouseover
https://bugs.webkit.org/show_bug.cgi?id=30151
Reviewed by Kevin Decker.
* Interfaces/IWebViewPrivate.idl:
Add restartHaltedPluginForNode().
* WebView.cpp:
(WebView::restartHaltedPluginForNode):
From the IDOMNode, query for the DOMNode. From the DOMNode, get the
WebCore::Node. Get the node's renderer, and check whether it is a
RenderWidget. If so, get its Widget, and check whether it's a
PluginView. If so, call PluginView::restart().
* WebView.h:
Declare restartHaltedPluginForNode().
2009-10-14 Jon Honeycutt <jhoneycutt@apple.com>
Add SPI to determine whether a node is a halted plug-in.
Part of <rdar://problem/7273354> Halted plug-ins should restart on
mouseover
https://bugs.webkit.org/show_bug.cgi?id=30151
Reviewed by Darin Adler.
* Interfaces/IWebViewPrivate.idl:
Add isNodehaltedPlugin().
* WebView.cpp:
(WebView::isNodeHaltedPlugin):
From the IDOMNode, query for the DOMNode. From the DOMNode, get the
WebCore::Node. Get the node's renderer, and check whether it is a
RenderWidget. If so, get its Widget, and check whether it's a
PluginView. If so, return the result of PluginView::isHalted().
* WebView.h:
Declare isNodeHaltedPlugin().
2009-10-15 Daniel Bates <dbates@webkit.org>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=24731
And
rdar://problem/5015961
Implements support for DHTML drag-and-drop operations (i.e. ondragstart, ondragend)
in the Windows build so that it conforms to the Mac OS X build. Hence, dropEffect is
correctly set.
The WebView and WebDropSource drag-and-drop functions, as called by function
DoDragDrop in its event loop, neither used the drop effect as specified by
event.dataTransfer.dropEffect nor respected event.dataTransfer.effectsAllowed.
Instead, these functions defaulted to some hardcoded drop effect and set of
allowed drop effects, respectively.
Tests: fast/events/drag-and-drop.html
* WebCoreSupport/WebDragClient.cpp:
(WebDragClient::startDrag):
* WebDropSource.cpp:
(WebDropSource::QueryContinueDrag): Moved call to EventHandler::dragSourceEndedAt
into method WebDragClient::startDrag.
* WebDropSource.h:
* WebView.cpp:
(WebView::keyStateToDragOperation): Fixes <rdar://problem/5015961>. Determines
appropriate drop effect from state of keyboard and allowed effects
m_page->dragController()->sourceDragOperation().
(WebView::DragEnter):
(WebView::DragOver):
(WebView::Drop):
* WebView.h:
2009-10-14 Adam Roben <aroben@apple.com>
Windows build fix
* WebKit.vcproj/Interfaces.vcproj: Exclude IWebHistoryDelegate and
IWebNavigationData from the build (they get #imported via WebKit.idl).
2009-10-14 Brady Eidson <beidson@apple.com>
Reviewed by Sam Weinig.
WebKit Win API should provide a delegate interface for global history.
https://bugs.webkit.org/show_bug.cgi?id=29905
-Add IWebHistoryDelegate for clients to implement.
-Add (I)WebNavigationData for the history delegate's use.
-When it exists, call the history delegate instead of using WebHistory.
* Interfaces/IWebHistoryDelegate.idl: Added.
* Interfaces/IWebHistoryPrivate.idl:
* Interfaces/IWebNavigationData.idl: Added.
* Interfaces/IWebViewPrivate.idl:
* Interfaces/WebKit.idl:
* WebKit.vcproj/Interfaces.vcproj:
* WebKit.vcproj/WebKit.vcproj:
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::populateVisitedLinks):
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::updateGlobalHistory):
(WebFrameLoaderClient::updateGlobalHistoryRedirectLinks):
(WebFrameLoaderClient::setTitle):
* WebView.cpp:
(WebView::close):
(WebView::mainFrameURL):
(WebView::setHistoryDelegate):
(WebView::historyDelegate):
(WebView::addVisitedLinks):
* WebView.h:
* WebHistory.cpp:
(WebHistory::setVisitedLinkTrackingEnabled):
(WebHistory::removeAllVisitedLinks):
* WebHistory.h:
* WebNavigationData.cpp: Added.
(WebNavigationData::QueryInterface):
(WebNavigationData::AddRef):
(WebNavigationData::Release):
(WebNavigationData::WebNavigationData):
(WebNavigationData::~WebNavigationData):
(WebNavigationData::createInstance):
(WebNavigationData::url):
(WebNavigationData::title):
(WebNavigationData::originalRequest):
(WebNavigationData::response):
(WebNavigationData::hasSubstituteData):
(WebNavigationData::clientRedirectSource):
* WebNavigationData.h: Added.
2009-10-13 Dave Hyatt <hyatt@apple.com>
Fix more WebView bustage.
* WebView.cpp:
(WebView::addUserScriptToGroup):
(WebView::addUserStyleSheetToGroup):
(WebView::removeUserScriptsFromGroup):
(WebView::removeUserStyleSheetsFromGroup):
2009-10-13 Dave Hyatt <hyatt@apple.com>
Fix build bustage on Windows.
* WebView.cpp:
(WebView::addUserScriptToGroup):
(WebView::addUserStyleSheetToGroup):
(WebView::removeUserScriptsFromGroup):
(WebView::removeUserStyleSheetsFromGroup):
2009-10-13 Dave Hyatt <hyatt@apple.com>
Reviewed by Adam Roben..
Split removal functions for user scripts and stylehseets based on type.
* Interfaces/IWebViewPrivate.idl:
* WebView.cpp:
(WebView::removeUserScriptFromGroup):
(WebView::removeUserStyleSheetFromGroup):
* WebView.h:
2009-10-09 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Factor HistoryController out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30246
Update API call.
* WebView.cpp:
(WebView::loadBackForwardListFromOtherView):
2009-10-08 Jon Honeycutt <jhoneycutt@apple.com>
Remove the WebKitPluginHalterEnabledPreferenceKey in favor of checking
for the existence of a PluginHalterDelegate.
Reviewed by Dan Bernstein.
* Interfaces/IWebPreferencesPrivate.idl:
Remove the getter and setter.
* WebCoreSupport/WebPluginHalterClient.cpp:
(WebPluginHalterClient::enabled):
Return true if the delegate exists.
* WebCoreSupport/WebPluginHalterClient.h:
Declare implementation of enabled().
* WebPreferenceKeysPrivate.h:
Removed the pref key.
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
Removed initialization of the pref.
* WebPreferences.h:
Removed declaration of the getter/setter.
* WebView.cpp:
(WebView::notifyPreferencesChanged):
Don't propagate the pref.
2009-10-08 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move executeScript from FrameLoader to ScriptController
https://bugs.webkit.org/show_bug.cgi?id=30200
Update API call.
* WebView.cpp:
(WebView::stringByEvaluatingJavaScriptFromString):
2009-10-08 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Remove the shouldLoadMediaElementURL implementation.
* Interfaces/IWebPolicyDelegatePrivate.idl:
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::shouldUsePluginDocument):
* WebCoreSupport/WebFrameLoaderClient.h:
2009-10-08 Adam Roben <aroben@apple.com>
Make IWebInspectorPrivate be accessed in a more standard way
IWebViewPrivate::inspectorPrivate has been removed. Callers should
instead use IWebViewPrivate::inspector and then use QueryInterface to
get the IWebInspectorPrivate interface. This matches how our other COM
classes work.
Fixes <http://webkit.org/b/30215> Make IWebInspectorPrivate be
accessed in a more standard way
Reviewed by John Sullivan and Tim Hatcher.
* Interfaces/IWebViewPrivate.idl: Removed inspectorPrivate.
* WebInspector.cpp:
(WebInspector::QueryInterface): Support querying to
IWebInspectorPrivate.
* WebView.cpp:
* WebView.h:
Removed inspectorPrivate.
2009-10-08 Adam Roben <aroben@apple.com>
Move the new IWebViewPrivate::inspectorPrivate function after all
functions that existed when Safari 4.0.3 was released
Fixes <http://webkit.org/b/30085> REGRESSION (r49091): run-safari
crashes in Safari.dll
Reviewed by John Sullivan.
* Interfaces/IWebViewPrivate.idl: Moved inspectorPrivate to the end of
the interface, so it won't modify the vtable that Safari 4.0.3 sees.
2009-10-07 Adam Roben <aroben@apple.com>
Expose origin whitelisting in the WebKit API on Windows
Fixes <http://webkit.org/b/30185>.
Reviewed by Eric Seidel.
* Interfaces/IWebViewPrivate.idl: Added whiteListAccessFromOrigin and
resetOriginAccessWhiteLists, to match the Mac SPI.
* WebView.cpp:
(WebView::whiteListAccessFromOrigin):
(WebView::resetOriginAccessWhiteLists):
* WebView.h:
Added. These just call through to SecurityOrigin.
2009-10-07 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
Factor PolicyChecker out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=30155
Move the policy callback to the policy object.
* WebFrame.cpp:
(WebFrame::dispatchWillSubmitForm):
(WebFrame::receivedPolicyDecision):
(WebFrame::dispatchDecidePolicyForMIMEType):
(WebFrame::dispatchDecidePolicyForNewWindowAction):
(WebFrame::dispatchDecidePolicyForNavigationAction):
2009-10-07 Daniel Bates <dbates@webkit.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=30102
And
<rdar://problem/5015957>
Fixes an issue (in the Windows build) where the cursor does not change to the
not-allowed cursor when the drag-and-drop operation is not allowed.
The allowed effects in WebDragClient::startDrag are hard-coded to be
DROPEFFECT_COPY | DROPEFFECT_LINK | DROPEFFECT_MOVE. Instead, the list of
allowed drop effects should be determined by the allowed operations of the
drag source.
We cannot test this using DRT because DRT looks at the programmatic drop
cursor and until bug #24731 is fixed this value is hard-coded to DragOperationCopy.
That is, there is a discrepancy in the Windows build between the Windows API-based
drop effect and the WebKit drop effect. Because DRT cannot read the screen buffer
to determine the cursor, a manual test is needed.
* WebCoreSupport/WebDragClient.cpp:
(draggingSourceOperationMaskToDragCursors): Added method.
(WebDragClient::startDrag):
2009-10-07 Steve Falkenburg <sfalken@apple.com>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=30176
<rdar://problem/7281553> Extra information in UA causes problems with gmail
* WebKit.vcproj/WebKit.rc: Restore PRODUCTVERSION to build number only. Remove extra space.
2009-10-06 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: default to an attached inspector window on Windows (as on Mac).
https://bugs.webkit.org/show_bug.cgi?id=30134
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::showWindowWithoutNotifications):
2009-10-06 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move FrameLoader::canLoad to SecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=30111
* WebFrame.cpp:
(WebFrame::allowsFollowingLink):
2009-10-06 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: close inspector client view on
InspectorController::close API call.
In order to run batch web inspector layout tests (and not affect
subsequent tests) we should close inspector client's view upon
InspectorController::close API call.
https://bugs.webkit.org/show_bug.cgi?id=30009
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::createPage):
2009-10-06 David Levin <levin@chromium.org>
Reviewed by NOBODY (windows build fix).
Speculative build fix for windows (due to r49160).
* WebDownloadCFNet.cpp:
(WebDownload::initToResumeWithBundle):
* WebIconDatabase.cpp:
(WebIconDatabase::dispatchDidAddIconForPageURL):
2009-10-05 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: add testing harness for Web Inspector.
https://bugs.webkit.org/show_bug.cgi?id=30010
* Interfaces/IWebInspectorPrivate.idl: Added.
* Interfaces/IWebViewPrivate.idl:
* Interfaces/WebKit.idl:
* WebInspector.cpp:
(WebInspector::evaluateInFrontend):
* WebInspector.h:
* WebView.cpp:
(WebView::inspectorPrivate):
* WebView.h:
2009-10-02 Dave Hyatt <hyatt@apple.com>
Reviewed by Adam Roben.
Add support for blacklist patterns to user stylesheets and scripts in addition to whitelist patterns.
* Interfaces/IWebViewPrivate.idl:
* WebView.cpp:
(toStringVector):
(WebView::addUserScriptToGroup):
(WebView::addUserStyleSheetToGroup):
* WebView.h:
2009-10-02 Steve Falkenburg <sfalken@apple.com>
Reviewed by Mark Rowe.
<https://bugs.webkit.org/show_bug.cgi?id=29989>
Safari version number shouldn't be exposed in WebKit code
For a WebKit version of 532.3.4:
Product version is: 5.32.3.4 (was 4.0.3.0)
File version is: 5.32.3.4 (was 4.532.3.4)
* WebKit.vcproj/WebKit.rc:
2009-09-30 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Fix for <rdar://problem/7259706>
Need WebKit API or SPI on Mac and Windows to test whether it's safe to load a page in a new tab/window
* Interfaces/IWebFramePrivate.idl:
* WebFrame.cpp:
(WebFrame::allowsFollowingLink):
* WebFrame.h:
2009-09-30 Dave Hyatt <hyatt@apple.com>
Reviewed by Adam Roben.
Add the ability to remove user stylesheets and scripts by URL.
* Interfaces/IWebViewPrivate.idl:
* WebView.cpp:
(WebView::removeUserContentWithURLFromGroup):
* WebView.h:
2009-09-29 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
Add support for run-time flag for 3D canvas
https://bugs.webkit.org/show_bug.cgi?id=29826
* WebView.cpp:
(WebView::notifyPreferencesChanged): Enable experimental WebGL
flag when 3D_CANVAS is enabled in the build.
2009-09-28 Alexey Proskuryakov <ap@apple.com>
Reviewed by Darin Adler and Sam Weinig.
Onclick not fired for an element copied with cloneContents() or cloneNode()
https://bugs.webkit.org/show_bug.cgi?id=25130
* DOMCreateInstance.cpp: GEN_DOMEventListener is a pure interface now.
* WebKit.vcproj/WebKit.vcproj: Removed GEN_DOMEventListener.cpp.
2009-09-28 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by Eric Seidel.
Add experimentalWebSocketsEnabled in WebPreferences.
https://bugs.webkit.org/show_bug.cgi?id=28941
* Interfaces/IWebPreferencesPrivate.idl:
* WebPreferenceKeysPrivate.h:
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::setExperimentalWebSocketsEnabled):
(WebPreferences::experimentalWebSocketsEnabled):
* WebPreferences.h:
* WebView.cpp:
(WebView::notifyPreferencesChanged):
(core):
2009-09-25 Darin Adler <darin@apple.com>
Reviewed by Steve Falkenburg.
Speed up access to history items by caching date computation.
* History/WebHistory.mm:
(getDayBoundaries): Refactored from timeIntervalForBeginningOfDay.
Returns the beginning of the day that the passed time is within and
the beginning of the next day.
(beginningOfDay): Added. Uses getDayBoundaries so it can be fast for
multiple dates within the same day, which is the common case.
(dateKey): Added. Calls beginningOfDay and converts to an integer.
(WebHistory::findKey): Changed to call dateKey instead of
timeIntervalForBeginningOfDay.
2009-09-25 Adam Roben <aroben@apple.com>
Add SPI to invalidate a WebView's backing store
This is useful in conjunction with
IWebUIDelegatePrivate2::drawBackground. This provides a way for the UI
delegate to force WebView to get its background redrawn.
Fixes <http://webkit.org/b/29737> Need SPI to invalidate a WebView's
backing store
Reviewed by Anders Carlsson.
* Interfaces/IWebViewPrivate.idl: Added invalidateBackingStore.
* WebView.cpp:
(WebView::invalidateBackingStore): If rect is 0, invalidate our whole
client rect. Otherwise invalidate the intersection of rect with our
client rect.
* WebView.h:
2009-09-24 Jon Honeycutt <jhoneycutt@apple.com>
Add a mechanism for automatically halting plug-ins.
Reviewed by Oliver Hunt.
* Interfaces/IWebPluginHalterDelegate.idl: Added. Defines an interface
for a delegate that determines whether plug-ins should be halted.
* Interfaces/IWebPreferencesPrivate.idl:
Declare functions to get and set the enabled state of the plug-in
halter and the plug-in allowed run time.
* Interfaces/IWebViewPrivate.idl:
Declare functions to get and set the IWebPluginHalterDelegate.
* Interfaces/WebKit.idl:
* WebCoreSupport/WebPluginHalterClient.cpp: Added.
(WebPluginHalterClient::WebPluginHalterClient):
(WebPluginHalterClient::shouldHaltPlugin):
Get the IWebPluginHalterDelegate for the WebView. Create a WebKit
DOMNode for the WebCore Node. Call the delegate's shouldHaltPlugin().
If the call fails, return false. Otherwise, return the result of the
call.
* WebCoreSupport/WebPluginHalterClient.h: Added.
* WebKit.vcproj/Interfaces.vcproj:
Add IWebPluginHalterDelegate.idl.
* WebKit.vcproj/WebKit.vcproj:
Add WebPluginHalterClient.{h,cpp}.
* WebPreferenceKeysPrivate.h:
Define WebKitPluginHalterEnabledPreferenceKey and
WebKitPluginAllowedRunTimePreferenceKey.
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
Leave plug-in halting disabled by default. Set the default value for
the plug-in allowed run time to the max value of an unsigned int.
(WebPreferences::setPluginHalterEnabled):
(WebPreferences::pluginHalterEnabled):
(WebPreferences::setPluginAllowedRunTime):
(WebPreferences::pluginAllowedRunTime):
* WebPreferences.h:
* WebView.cpp:
(WebView::close):
Clear the IWebPluginHalterDelegate.
(WebView::initWithFrame):
Pass a WebPluginHalterClient when creating the Page.
(WebView::notifyPreferencesChanged):
Set the new settings when the preferences changed notification is
received.
(WebView::setPluginHalterDelegate):
(WebView::pluginHalterDelegate):
* WebView.h:
Declare overrides of setPluginHalterDelegate() and
pluginHalterDelegate(). Added a member to track the
IWebPluginHalterDelegate.
2009-09-14 John Gregg <johnnyg@google.com>
Reviewed by Eric Seidel.
Enable switch for notifications (experimental) in Page Settings
https://bugs.webkit.org/show_bug.cgi?id=28930
Adds support for the experimentalNotificationsEnabled flag in Settings through
WebPreferencesPrivate interface. Also cleans up some issues accessing the
notification delegate through DumpRenderTree.
* Interfaces/IWebPreferencesPrivate.idl:
* WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
(WebDesktopNotificationsDelegate::hasNotificationDelegate):
(WebDesktopNotificationsDelegate::notificationDelegate):
* WebPreferenceKeysPrivate.h:
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::setExperimentalNotificationsEnabled):
(WebPreferences::experimentalNotificationsEnabled):
* WebPreferences.h:
* WebView.cpp:
(WebView::notifyPreferencesChanged):
2009-09-23 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
<rdar://problem/7243354>
REGRESSION(48580-48636): Crash clicking embedded QT preview button on apple.com/trailers
Check for a null IWebPolicyDelegatePrivate.
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::shouldLoadMediaElementURL):
2009-09-22 Sam Weinig <sam@webkit.org>
Rubber-stamped by Adam Roben.
Remove accidentally left in declaration of reloadFromOrigin in IWebFramePrivate.idl
* Interfaces/IWebFramePrivate.idl:
2009-09-22 Sam Weinig <sam@webkit.org>
Reviewed by Steve Falkenburg.
Fix for <rdar://problem/6451745>
Windows WebKit needs to implement reloadFromOrigin()
* Interfaces/IWebFrame.idl:
* Interfaces/IWebFramePrivate.idl:
* Interfaces/IWebView.idl:
* WebFrame.cpp:
(WebFrame::reloadFromOrigin):
* WebFrame.h:
* WebView.cpp:
(WebView::reloadFromOrigin):
* WebView.h:
2009-09-22 Adam Roben <aroben@apple.com>
Manage refcounts correctly in DefaultDownloadDelegate::willSendRequest
Fixes <http://webkit.org/b/29650> Crash in
WebDownload::willSendRequest when using DefaultDownloadDelegate
Reviewed by Brady Eidson.
* DefaultDownloadDelegate.cpp:
(DefaultDownloadDelegate::willSendRequest): Call AddRef() on the
object we're returning via the finalRequest out-parameter.
2009-09-21 Anders Carlsson <andersca@apple.com>
Reviewed by Adam Roben.
<rdar://problem/7135588> HTMLMediaElement should ask WebPolicyLoadDelegate before loading resource
Implement WebFrameLoaderClient::shouldLoadMediaElementURL and have it call the new private policy
delegate method.
* Interfaces/IWebPolicyDelegatePrivate.idl: Added.
* Interfaces/WebKit.idl:
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::shouldLoadMediaElementURL):
* WebCoreSupport/WebFrameLoaderClient.h:
* WebKit.vcproj/Interfaces.vcproj:
2009-09-17 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Simon Hausmann.
Make PlatformWindow return something else than PlatformWidget
https://bugs.webkit.org/show_bug.cgi?id=29085
Reflect the rename of platformWindow and it's return type.
* AccessibleBase.cpp:
(AccessibleBase::get_accParent):
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::platformPageClient):
* WebCoreSupport/WebChromeClient.h:
2009-09-17 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
Remove assertions that were being hit by calls to
m_verticalScrollbar->invalidate(). These assertions were valid,
but they were causing tests to fail, so replacing with a FIXME
until we can find out the real cause/solution that is being tracked
by http://webkit.org/b/29350.
* WebView.cpp:
(WebView::addToDirtyRegion):
(WebView::paintIntoBackingStore):
2009-09-17 Ada Chan <adachan@apple.com>
Post WebViewDidChangeSelectionNotification when the text selection changes.
Fixes <http://webkit.org/b/29321>
Reviewed by Adam Roben.
* Interfaces/IWebView.idl:
* WebCoreSupport/WebEditorClient.cpp:
(WebEditorClient::respondToChangedSelection):
2009-09-17 Adam Roben <aroben@apple.com>
Fix a crash when a WebView's HWND is destroyed before IWebView::close
is called
WebView's HWND was being sent a WM_TIMER message after the WebView was
destroyed. This normally isn't possible (we call DestroyWindow inside
WebView's destructor to ensure the HWND doesn't outlive the WebView),
but r48060 changed WebView to call SetParent(m_viewWindow,
HWND_MESSAGE) while handling WM_DESTROY, and apparently this puts the
HWND into some weird half-destroyed state where it can still receive
WM_TIMER messages.
Fixes <http://webkit.org/b/29337> <rdar://problem/7209897> REGRESSION
(r48060): unrepro but frequent crash in WebViewWndProc
Reviewed by Steve Falkenburg.
* WebView.cpp:
(WebViewWndProc): When handling WM_DESTROY, call setIsBeingDestroyed()
before calling close(). This allows setHostWindow to detect that we're
handling WM_DESTROY. No other code in close() cared whether
isBeingDestroyed() was true or not.
(WebView::setHostWindow): If our host window is being set to 0 and
we're being destroyed, don't become a message-only window. Doing this
while handling WM_DESTROY seems to lead to crashes.
2009-09-16 Adam Roben <aroben@apple.com>
Add a UI delegate callback to let the delegate draw a WebView's
background
Fixes <http://webkit.org/b/29315>.
Reviewed by Dave Hyatt.
* Interfaces/IWebUIDelegatePrivate.idl: Added
IWebUIDelegatePrivate2::drawBackground.
* WebView.cpp:
(WebView::paintIntoBackingStore): After clearing or filling with
white, let the delegate draw whatever background it wants. Also added
an assertion that the dirty rect is within our bounds.
2009-09-16 Adam Roben <aroben@apple.com>
Prevent WebView from painting over sibling windows
Fixes <http://webkit.org/b/29300> <rdar://problem/7227960> WebView can
paint over sibling windows
Reviewed by Darin Adler.
* WebView.cpp:
(WebView::initWithFrame): Create the WebView's HWND with the
WS_CLIPSIBLINGS style.
2009-09-14 Brady Eidson <beidson@apple.com>
Reviewed by Alexey Proskuryakov.
Safari 4 cannot be used to update firmware on Linksys routers.
<rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160
Adopt the new WebCore::CredentialStorage in WebKit/Win.
* WebDownloadCFNet.cpp:
(WebDownload::didReceiveAuthenticationChallenge):
2009-09-11 Steve Falkenburg <sfalken@apple.com>
Reviewed by Dan Bernstein.
Properly propagate preference from WebPreferences to WebCore::Settings.
https://bugs.webkit.org/show_bug.cgi?id=29192
* WebView.cpp:
(WebView::initWithFrame): Apply setting when creating a new WebView.
(WebView::notifyPreferencesChanged): Apply setting when preferences change.
2009-09-11 Steve Falkenburg <sfalken@apple.com>
Reviewed by Darin Adler.
Allow WebKit clients to opt out of high resolution timers on Windows.
https://bugs.webkit.org/show_bug.cgi?id=29192
* Interfaces/IWebPreferencesPrivate.idl: Added getter/setter.
Put this just after last 4.0.3 method for future merging.
* Interfaces/WebKit.idl: Touched to force a rebuild.
* WebPreferenceKeysPrivate.h: Added prefs key for high res timers.
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings): Initialize high res timers to enabled.
(WebPreferences::setShouldUseHighResolutionTimers): Added.
(WebPreferences::shouldUseHighResolutionTimers): Added.
* WebPreferences.h: Added getter/setter.
2009-09-11 Adam Roben <aroben@apple.com>
Get user script/stylesheet tests running on Windows
Fixes <http://webkit.org/b/29181> User script/stylesheet tests are
skipped on Windows
Reviewed by John Sullivan.
* Interfaces/IWebViewPrivate.idl: Added addUserScriptToGroup,
addUserStyleSheetToGroup, removeUserContentFromGroup,
removeAllUserContentFromGropu to match the Mac SPI.
* WebView.cpp:
(WebView::addUserScriptToGroup):
(WebView::addUserStyleSheetToGroup):
(WebView::removeUserContentFromGroup):
(WebView::removeAllUserContentFromGroup):
* WebView.h:
Added. Implementation was based on similar methods in WebView.mm.
2009-09-11 Jon Honeycutt <jhoneycutt@apple.com>
Fix crash on launch on Windows.
Rubber-stamped by Mark Rowe.
* WebKit.vcproj/WebKit.vcproj:
Define ENABLE_WEB_SOCKETS for all configurations.
2009-09-07 Drew Wilson <atwilson@google.com>
Reviewed by David Levin.
Enable SHARED_WORKERS by default.
https://bugs.webkit.org/show_bug.cgi?id=28959
* WebKit.vcproj/WebKit.vcproj:
2009-09-04 Adam Roben <aroben@apple.com>
Make WebView function without a parent window
When WebView has no parent window, it becomes a message-only window,
which hides it from the screen and prevents it from appearing on the
taskbar.
Fixes <http://webkit.org/b/28971> <rdar://problem/4976998>
WebView::initWithFrame fails if there's no host window
Reviewed by Dave Hyatt.
* WebView.cpp:
(WebView::initWithFrame): m_hostWindow is null, use HWND_MESSAGE as
our parent window, which will make us a message-only window.
(WebView::setHostWindow): If he new host window is null, use
HWND_MESSAGE as our parent window, which will make us a message-only
window.
2009-09-04 Adam Barth <abarth@webkit.org>
Unreviewed attempt at a build fix.
Added missing include.
* WebCoreSupport/WebFrameLoaderClient.cpp:
2009-09-04 Adam Barth <abarth@webkit.org>
Unreviewed attempt at a build fix.
Fix typo of IWebFrameLoadDelegatePrivate2 and make
IWebFrameLoadDelegatePrivate inherit from IWebFrameLoadDelegatePrivate
as requestd by Adam Roben.
* Interfaces/IWebFrameLoadDelegatePrivate2.idl:
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::didDisplayInsecureContent):
(WebFrameLoaderClient::didRunInsecureContent):
2009-09-04 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=24696
Plumb mixed content notifications to IWebFrameLoadDelegatePrivate.
* Interfaces/IWebFrameLoadDelegatePrivate2.idl: Added.
* Interfaces/WebKit.idl:
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::didDisplayInsecureContent):
(WebFrameLoaderClient::didRunInsecureContent):
* WebKit.vcproj/Interfaces.vcproj:
2009-09-03 Adam Barth <abarth@webkit.org>
Reviewed by eric@webkit.org.
https://bugs.webkit.org/show_bug.cgi?id=24696
Stub implementations of mixed content methods of FrameLoaderClient.
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::didDisplayInsecureContent):
(WebFrameLoaderClient::didRunInsecureContent):
* WebCoreSupport/WebFrameLoaderClient.h:
2009-09-01 Adam Roben <aroben@apple.com>
Post a notification when a WebView is closing
This is useful for situations where some code wants to react to the
WebView closing but isn't in charge of the WebView and can't otherwise
be notified. This notification could replace
IWebUIDelegatePrivate::webViewClosing if we decide that the
notification system isn't too burdensome.
<http://webkit.org/b/28875>
Reviewed by John Sullivan.
* Interfaces/IWebViewPrivate.idl: Added the
WebViewWillCloseNotification string constant.
* WebKit.vcproj/WebKit.vcproj: Link against comsuppw.lib in all
configurations so that we can use _bstr_t.
* WebView.cpp:
(WebView::close): Post the WebViewWillCloseNotification.
2009-08-31 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=28852
Rename KURL single argument constructor to avoid confusion
* WebURLResponse.cpp: (WebURLResponse::createInstance): Adapt to the change.
2009-08-20 Adam Roben <aroben@apple.com>
Give WebKit clients access to the window features specified in
window.open
Reviewed by Steve Falkenburg.
* COMVariantSetter.h: Added COMVariantSetters for bool and float.
* Interfaces/IWebUIDelegatePrivate.idl: Added IWebUIDelegatePrivate2,
which contains a new version of createWebViewWithRequest that also
passes the window features as an IPropertyBag. This is analagous to
the -createWebViewWithRequest:windowFeatures: method added to
WebUIDelegate on Mac in r27452. Also added key strings for use with
the window features property bag.
* WebCoreSupport/WebChromeClient.cpp:
(createWindowFeaturesPropertyBag): Added this helper function to turn
a WebCore::WindowFeatures into an IPropertyBag for passing to WebKit
clients.
(WebChromeClient::createWindow): If the UI delegate implements
IWebUIDelegatePrivate2, call the new createWebViewWithRequest function
that takes a window features property bag. If the delegate doesn't
implement the new function, fall back to the old functions.
2009-08-20 Adam Roben <aroben@apple.com>
A little clean-up in WebChromeClient::createWindow
Reviewed by Steve Falkenburg.
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::createWindow): Refactored to share more code between
the dialog and non-dialog cases.
2009-08-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=25889
[GTK] scrollbar policy for main frame is not implementable
Add empty implementation for new ChromeClient method.
* WebCoreSupport/WebChromeClient.h:
(WebChromeClient::scrollbarsModeDidChange):
2009-08-27 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
Modify Release_Cairo target to build testapi using the
Release_CFLite target so that the correct CoreFoundation
(in this case, CFLite.dll) is linked.
* WebKit.vcproj/WebKit.sln:
2009-08-26 Adam Barth <abarth@webkit.org>
Reviewed by Oliver Hunt.
Don't let local files access web URLs
https://bugs.webkit.org/show_bug.cgi?id=28480
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
2009-08-26 David Levin <levin@chromium.org>
Reviewed by Darin Fisher.
ResourceRequestBase::*[Aa]llowHTTPCookies shouldn't mention http.
https://bugs.webkit.org/show_bug.cgi?id=28735
* WebMutableURLRequest.cpp:
(WebMutableURLRequest::setHTTPShouldHandleCookies):
2009-08-25 Eric Carlson <eric.carlson@apple.com>
Reviewed by Oliver Hunt.
<video> and <audio> controller should be accessible
https://bugs.webkit.org/show_bug.cgi?id=28081
* WebCoreLocalizedStrings.cpp:
(WebCore::localizedMediaControlElementString):
(WebCore::localizedMediaControlElementHelpText):
(WebCore::localizedMediaTimeDescription):
New.
2009-08-25 Brent Fulgham <bfulgham@webkit.org>
Build fix for Windows.
Revise Debug_Cairo build target to build testapi, jsc, WinLauncher,
DumpRenderTree, and TestNetscapeAPI using WinCairo debug build
settings so they link against the proper libraries.
* WebKit.vcproj/WebKit.sln:
2009-08-25 David Levin <levin@chromium.org>
Reviewed by Adam Roben.
PLATFORM(CFNETWORK) should be USE(CFNETWORK).
https://bugs.webkit.org/show_bug.cgi?id=28713
Also, moved the #if header section after the other #includes.
* WebError.cpp:
(WebError::localizedDescription):
2009-08-24 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Steve Falkenburg.
Revise CFLite Debug build to emit DLL's with _debug label.
https://bugs.webkit.org/show_bug.cgi?id=28695.
* WebKit.vcproj/WebKit.vcproj: Modify Debug_Cairo target to
inherit from new debug_wincairo property sheet, instead of
the current debug sheet.
2009-08-22 Adam Barth <abarth@webkit.org>
Revert 47684. We're going to do this later once clients have had a
chance to opt into the setting they like.
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
2009-08-22 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Don't let local files access web URLs
https://bugs.webkit.org/show_bug.cgi?id=28480
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
2009-08-20 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
Fix of <http://webkit.org/b/27850>. Panning by emulating Mouse Wheel Events breaks Google Maps.
Switched to using RenderLayer::scrollByRecursively instead of emulating a mouse wheel,
and switched to handling the hit testing in WebView from doing it as part of the mouse wheel event.
One downside of this fix is that panning will not jump out of frames anymore (same behavior as pan-scrolling), but
this is tracked in <http://webkit.org/b/28237>.
* WebView.cpp:
(WebView::gestureNotify): Added hit testing here to figure out the node the user started the gesture on.
(WebView::gesture): Switched from emulating mouse wheel events for panning to calling RenderLayer::scrollByRecursively.
* WebView.h:
2009-08-18 Brian Weinstein <bweinstein@apple.com>
Reviewed by Oliver Hunt.
Fix of <https://bugs.webkit.org/show_bug.cgi?id=28326> DRT on Windows doesn't support
LayoutTestController::setQuota or print a callback on UIDelegate::exceededDatabaseQuota.
Added a setQuota interface method to IWebDatabaseManager and implemented it.
* Interfaces/IWebDatabaseManager.idl:
* WebDatabaseManager.cpp:
(WebDatabaseManager::setQuota):
* WebDatabaseManager.h:
2009-08-18 Drew Wilson <atwilson@google.com>
Unreviewed (build break).
Added missing include for WebWorkersPrivate.h.
* WebKitClassFactory.cpp:
2009-08-18 Peter Kasting <pkasting@google.com>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=28415
Set svn:eol-style CRLF on all .sln and .vcproj files that don't already
have it.
* WebKit.vcproj/InterfacesGenerated.vcproj:
2009-08-18 Drew Wilson <atwilson@google.com>
Reviewed by Eric Seidel.
Need to extend DumpRenderTree to expose number of worker threads
https://bugs.webkit.org/show_bug.cgi?id=28292
Defined/implemented COM interfaces to expose WorkerThread::workerThreadCount() for DumpRenderTree.
* ForEachCoClass.h:
Added WebWorkersPrivate.
* Interfaces/IWebWorkersPrivate.idl: Added.
* Interfaces/WebKit.idl:
Added WebWorkersPrivate.
* WebKit.vcproj/Interfaces.vcproj:
* WebKit.vcproj/WebKit.vcproj:
* WebWorkersPrivate.cpp: Added.
Implementation of the IWebWorkersPrivate COM interface, to expose workerThreadCount() for DumpRenderTree.
(WebWorkersPrivate::QueryInterface):
(WebWorkersPrivate::AddRef):
(WebWorkersPrivate::Release):
(WebWorkersPrivate::workerThreadCount):
(WebWorkersPrivate::createInstance):
(WebWorkersPrivate::WebWorkersPrivate):
(WebWorkersPrivate::~WebWorkersPrivate):
* WebWorkersPrivate.h: Added.
2009-08-17 Peter Kasting <pkasting@google.com>
Reviewed by Steve Falkenburg.
https://bugs.webkit.org/show_bug.cgi?id=27323
Only add Cygwin to the path when it isn't already there. This avoids
causing problems for people who purposefully have non-Cygwin versions of
executables like svn in front of the Cygwin ones in their paths.
* WebKit.vcproj/Interfaces.vcproj:
* WebKit.vcproj/InterfacesGenerated.vcproj:
* WebKit.vcproj/WebKit.vcproj:
* WebKit.vcproj/WebKitGUID.vcproj:
2009-08-17 Simon Fraser <simon.fraser@apple.com>
Speculative fix for Windows build bustage.
* DOMHTMLClasses.cpp:
(DOMHTMLElement::idName):
2009-08-13 Jon Honeycutt <jhoneycutt@apple.com>
Part of <rdar://problem/6218721> No MSAA focus events fired for Webkit
nightly (20866)
https://bugs.webkit.org/show_bug.cgi?id=20866
Reviewed by Oliver Hunt.
* AccessibleBase.cpp:
(AccessibleBase::getAccessibilityObjectForChild):
If the child ID is negative, negate it and treat it as an AXID.
2009-08-12 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
Fix of <rdar://6728361> Mouse wheel scrolling on a page with expanded drop down
list detaches drop down.
Added a check in mouseWheel to see if our focus is currently in a popup, if so, close
the popup (matches other browser behavior).
* WebView.cpp:
(WebView::mouseWheel):
2009-08-12 Adam Roben <aroben@apple.com>
Make WebPreferenceKeysPrivate.h available for client use
Reviewed by Dave Hyatt.
Fixes <http://webkit.org/b/28227>.
* WebKit.vcproj/WebKit.vcproj: Copy WebPreferenceKeysPrivate.h to
$WebKitOutputDir, just like we do for a few other headers. Also let VS
reorder some XML attributes.
* WebPreferenceKeysPrivate.h: Touched this file to force a build.
2009-08-11 Adam Roben <aroben@apple.com>
Remove support for a window resizer within the WebView
Starting with Safari 4, there is never a window resizer inside the
WebView, so we no longer need to support that functionality.
Fixes <http://webkit.org/b/28190> Remove support for a window resizer
within the WebView
Reviewed by Dave Hyatt.
* Interfaces/IWebUIDelegatePrivate.idl: Replaced the delegate
functions related to the window resizer with unused*() functions. We
can't remove them entirely because we need to keep the vtable
unchanged so new versions of WebKit will work with old versions of
Safari (e.g., for nightlies and WebKit development).
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::windowResizerRect): Now always returns an empty
rect.
* WebView.cpp:
(WebView::paint):
(WebView::handleMouseEvent):
* WebView.h:
Removed window-resizer-related code.
2009-08-11 John Gregg <johnnyg@google.com>
Reviewed by Maciej Stachowiak.
Move the accessor for notifications presenter from WebUIDelegate
to WebUIDelegate2 which extends it. When making this call from
WebCoreSupport, check using QueryInterface before calling.
https://bugs.webkit.org/show_bug.cgi?id=28198
* Interfaces/IWebUIDelegate.idl:
* Interfaces/IWebUIDelegate2.idl: Added.
* Interfaces/WebKit.idl:
* WebCoreSupport/WebDesktopNotificationsDelegate.cpp:
(WebDesktopNotificationsDelegate::show):
(WebDesktopNotificationsDelegate::cancel):
(WebDesktopNotificationsDelegate::notificationObjectDestroyed):
(WebDesktopNotificationsDelegate::requestPermission):
(WebDesktopNotificationsDelegate::checkPermission):
(WebDesktopNotificationsDelegate::hasNotificationDelegate):
(WebDesktopNotificationsDelegate::notificationDelegate):
* WebCoreSupport/WebDesktopNotificationsDelegate.h:
2009-08-11 Drew Wilson <atwilson@google.com>
Reviewed by NOBODY (build break).
Speculative Windows build fix - undo previous unnecessary change.
* WebCoreSupport/WebDesktopNotificationsDelegate.h:
2009-08-11 Brian Weinstein <bweinstein@apple.com>
Reviewed by Steve Falkenburg.
Refactored MIMETypeforExtension to be a member of IWebViewPrivate
instead of IWebView.
* Interfaces/IWebView.idl:
* Interfaces/IWebViewPrivate.idl:
* WebView.cpp:
(WebView::MIMETypeForExtension):
* WebView.h:
2009-08-11 Drew Wilson <atwilson@google.com>
Reviewed by NOBODY (build break)
Speculative fix for windows build break.
* WebKitSupport/WebDesktopNotificationsDelegate.h:
WebCore/Notification*.h => WebCore/notifications/Notification*.h
2009-08-11 John Gregg <johnnyg@google.com>
Reviewed by Maciej Stachowiak.
Desktop Notifications API
https://bugs.webkit.org/show_bug.cgi?id=25643
Adds test hooks for notification features to WebCoreSupport for
use in DumpRenderTree.
* Interfaces/IWebDesktopNotificationsDelegate.idl: Added.
* Interfaces/IWebUIDelegate.idl:
* Interfaces/WebKit.idl:
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::WebChromeClient):
* WebCoreSupport/WebChromeClient.h:
(WebChromeClient::notificationPresenter):
* WebCoreSupport/WebDesktopNotificationsDelegate.cpp: Added.
(NotificationCOMWrapper::create):
(NotificationCOMWrapper::NotificationCOMWrapper):
(NotificationCOMWrapper::QueryInterface):
(NotificationCOMWrapper::AddRef):
(NotificationCOMWrapper::Release):
(NotificationCOMWrapper::isHTML):
(NotificationCOMWrapper::contentsURL):
(NotificationCOMWrapper::iconURL):
(NotificationCOMWrapper::title):
(NotificationCOMWrapper::text):
(NotificationCOMWrapper::notifyDisplay):
(NotificationCOMWrapper::notifyError):
(NotificationCOMWrapper::notifyClose):
(WebDesktopNotificationsDelegate::WebDesktopNotificationsDelegate):
(WebDesktopNotificationsDelegate::show):
(WebDesktopNotificationsDelegate::cancel):
(WebDesktopNotificationsDelegate::notificationObjectDestroyed):
(WebDesktopNotificationsDelegate::requestPermission):
(WebDesktopNotificationsDelegate::checkPermission):
(WebDesktopNotificationsDelegate::notificationDelegate):
* WebCoreSupport/WebDesktopNotificationsDelegate.h: Added.
* WebCoreSupport/WebInspectorDelegate.h:
(WebInspectorDelegate::desktopNotificationsDelegate):
* WebKit.vcproj/Interfaces.vcproj:
* WebKit.vcproj/WebKit.vcproj:
2009-08-11 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
Fix of <rdar://5016504> SVG file cannot be dragged to webview,
but can be opened via Open File.
Added a new function to IWebView that gets the MIME type for a given
extension from the MIMETypeRegistry.
* Interfaces/IWebView.idl:
* WebView.cpp:
(WebView::MIMETypeForExtension):
* WebView.h:
2009-08-11 Dmitry Titov <dimich@chromium.org>
Reviewed by Adam Roben.
Originally implemented by Glenn Wilson <gwilson@chromium.org>.
Added support for overriding default preferences per-test.
See https://bugs.webkit.org/show_bug.cgi?id=20534
* Interfaces/IWebPreferencesPrivate.idl: added new method setPreferenceForTest
* WebPreferences.cpp: same.
* WebPreferences.h: same.
2009-08-10 Dan Bernstein <mitz@apple.com>
Reviewed by Darin Adler.
Link drag images specify Lucida Grande on Windows and end up using Times
New Roman
<rdar://problem/7117835>
* WebCoreSupport/WebDragClient.cpp:
(dragLabelFont): Added a RenderingMode parameter and changed to use the
same typeface as the Windows small caption font.
(WebDragClient::createDragImageForLink): Changed to respect the
page’s rendering mode.
2009-08-10 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=28048.
Move various WinCairo build settings into *.vsprops file.
* WebKit.vcproj/WebKit.vcproj: Add new cURL.vsprops property sheet
(which contains link settings for cURL and its dependencies), and
remove the corresponding entries from the vcproj file. Remove
png, jpeg, cairo library linking flags from vcproj, now that they
are in the WinCairo.vsprops file.
2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by George Staikos.
[WML] Deck access control is completly broken
https://bugs.webkit.org/show_bug.cgi?id=27721
Synchronize WebFrameLoadType with FrameLoadType enum. Append 'WebFrameLoadTypeBackWMLDeckNotAccessible'.
* Interfaces/IWebFramePrivate.idl:
2009-08-09 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com>
Reviewed by Maciej Stachowiak.
FrameLoadType / WebFrameLoadType enums are out of sync
https://bugs.webkit.org/show_bug.cgi?id=28132
Synchronize FrameLoadType <-> WebFrameLoadType enums (append missing 'WebFrameLoadTypeReloadFromOrigin' value)
* Interfaces/IWebFramePrivate.idl:
2009-08-06 Adam Barth <abarth@webkit.org>
Unreviewed revert.
http://bugs.webkit.org/show_bug.cgi?id=27879
Revert 46877 because it broke GTK.
* COMPropertyBag.h:
2009-08-06 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Adam Barth.
Change Noncopyable inheriting to public
http://bugs.webkit.org/show_bug.cgi?id=27879
Since Noncopyable is inherited from FastAllocBase,
Noncopyable's inheriting has been changed to public.
* COMPropertyBag.h:
2009-08-04 Alice Liu <alice.liu@apple.com>
"Shift + Enter" should behave like "Enter" in editable fields.
Affects backward search in find-in-page in Safari for Windows
Reviewed by Jon Honeycutt.
* WebView.cpp:
Register shift+enter as InsertNewline command, similar to other
modifier+Enter combinations.
2009-07-29 Jon Honeycutt <jhoneycutt@apple.com>
Part of <rdar://problem/5698113> Safari shouldn't auto-activate
plug-ins in background tabs (make Win consistent with Mac)
https://bugs.webkit.org/show_bug.cgi?id=27855
Reviewed by Adam Roben and Anders Carlsson.
* Interfaces/IWebViewPrivate.idl:
Add setCanStartPlugins().
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDidFailToStartPlugin):
Added; code moved from createPlugin(). Modified to obtain the plug-in's
page URL, the plug-ins "plug-ins page" parameter value, and the
plug-in's MIME type by calling getter functions on the passed
PluginView.
(WebFrameLoaderClient::createPlugin):
If the plug-in status is not "success," call
dispatchDidFailToStartPlugin().
* WebCoreSupport/WebFrameLoaderClient.h:
Declare an override of dispatchDidFailToStartPlugin().
* WebView.cpp:
(WebViewWndProc):
Add a missing ) to a comment.
(WebView::setCanStartPlugins):
Call the Page's setCanStartPlugins() function.
* WebView.h:
2009-07-30 Darin Adler <darin@apple.com>
Reviewed by David Levin.
Use checked casts for render tree
https://bugs.webkit.org/show_bug.cgi?id=23522
* DOMHTMLClasses.cpp:
(DOMHTMLInputElement::isUserEdited):
(DOMHTMLTextAreaElement::isUserEdited):
Use checked casts.
2009-07-31 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
-Fix <rdar://problem/7104097>
Make EmbeddedWidget::create return a PassRefPtr so it will have the correct ref count.
* WebCoreSupport/EmbeddedWidget.cpp:
(EmbeddedWidget::create):
* WebCoreSupport/EmbeddedWidget.h:
2009-07-29 Brian Weinstein <bweinstein@apple.com>
Was doing the build fix wrong, NotImplemented.h is in WebCore.
* WebCoreSupport/WebInspectorClient.cpp:
2009-07-29 Brian Weinstein <bweinstein@apple.com>
Windows build fix.
* WebCoreSupport/WebInspectorClient.cpp:
2009-07-29 Kevin McCullough <kmccullough@apple.com>
Reviewed by Darin Adler.
Added foundation work to allow a testing infrastructure for the Web
Inspector.
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::inspectorWindowObjectCleared): Empty definition
to let Windows compile but we should implement this at some point so
that the tests can be run on Windows too.
* WebCoreSupport/WebInspectorClient.h:
2009-07-28 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
Reviewed by Steve Falkenburg.
Add output directory for VS pre-build steps to enable out-of-tree builds
https://bugs.webkit.org/show_bug.cgi?id=27700
The tmp.obj file is now placed in the intermediate build directory.
* WebKit.vcproj/WebKit.vcproj:
2009-07-27 Brian Weinstein <bweinstein@apple.com>
Build fix for Windows.
* WebView.cpp:
(WebView::stringByEvaluatingJavaScriptFromString):
2009-07-27 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=27735
Give a helpful name to JSLock constructor argument
* WebCoreStatistics.cpp:
(WebCoreStatistics::javaScriptObjectsCount):
(WebCoreStatistics::javaScriptGlobalObjectsCount):
(WebCoreStatistics::javaScriptProtectedObjectsCount):
(WebCoreStatistics::javaScriptProtectedGlobalObjectsCount):
(WebCoreStatistics::javaScriptProtectedObjectTypeCounts):
* WebJavaScriptCollector.cpp:
(WebJavaScriptCollector::objectCount):
* WebView.cpp:
(WebView::stringByEvaluatingJavaScriptFromString):
2009-07-25 Kwang Yul Seo <skyul@company100.net>
Reviewed by Darin Adler.
Windows build break due to warning C4819
https://bugs.webkit.org/show_bug.cgi?id=27416
Disable C4819 warning to fix build.
* WebKit.vcproj/WebKit.vcproj:
2009-07-24 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Dave Hyatt.
Clean up dependencies on Apple support libraries for non-Apple build.
http://bugs.webkit.org/show_bug.cgi?id=27532.
* DefaultDownloadDelegate.h: Conditionalize include of CFNetwork.h
* WebDownload.h: Conditionalize include of CFNetwork.h
* WebMutableURLRequest.cpp: Conditionalize include of CFNetwork.h
2009-07-24 Andrei Popescu <andreip@google.com>
Reviewed by Anders Carlsson.
ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::reachedMaxAppCacheSize):
Adds empty implementation of the reachedMaxAppCacheSize callback.
* WebCoreSupport/WebChromeClient.h:
2009-07-23 Brady Eidson <beidson@apple.com>
Reviewed by Geoff Garen.
WebFrameLoaderClient on Windows doesn't gracefully handle a null request returned from willSendRequest.
https://bugs.webkit.org/show_bug.cgi?id=27595
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchWillSendRequest):
2009-07-22 Takeshi Yoshino <tyoshino@google.com>
Reviewed by Darin Adler.
VC++ 2005 Express failed to build WebKit due to raw UTF-8 string in WebKit/win/WebCoreLocalizedStrings.cpp
https://bugs.webkit.org/show_bug.cgi?id=26375
Replace a multiplication sign (U+00D7) encoded in UTF-8 (0xC3 0x97) in WebCoreLocalizedStrings.cpp
with hex escape sequences.
VC2005 failed to build due to this raw UTF-8 data in source code. Here's the warning message (
treated as an error and stopped build).
WebCoreLocalizedStrings.cpp : warning C4819: The file contains a character that cannot be
represented in the current code page (932). Save the file in Unicode format to prevent data loss
A change on WebKitTools/Scripts/extract-localizable-strings is attached to this change not to break
localized string generation process.
* WebCoreLocalizedStrings.cpp:
(WebCore::imageTitle):
2009-07-21 Roland Steiner <rolandsteiner@google.com>
Reviewed by David Levin.
Add ENABLE_RUBY to list of build options
https://bugs.webkit.org/show_bug.cgi?id=27324
* WebKit.vcproj/WebKit.vcproj: Added flag ENABLE_RUBY.
2009-07-20 Peter Kasting <pkasting@google.com>
Reviewed by Mark Rowe.
https://bugs.webkit.org/show_bug.cgi?id=27468
Back out r46060, which caused problems for some Apple developers.
* WebKit.vcproj/Interfaces.vcproj:
* WebKit.vcproj/InterfacesGenerated.vcproj:
* WebKit.vcproj/WebKit.vcproj:
* WebKit.vcproj/WebKitGUID.vcproj:
2009-07-17 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
Fix of <rdar://problem/5712795> Win: Cannot change the height of the docked Web Inspector (14272)
https://bugs.webkit.org/show_bug.cgi?id=14272
Implemented resizing of inspector window when it is in attached mode. Implemented setAttachedWindowHeight
to set window sizes and redraw the inspector and the inspected web view, and used stored preferences
in InspectorController.cpp to remember user's preferred height.
* WebCoreSupport/WebInspectorClient.cpp:
2009-07-17 Peter Kasting <pkasting@google.com>
Reviewed by Steve Falkenburg.
https://bugs.webkit.org/show_bug.cgi?id=27323
Only add Cygwin to the path when it isn't already there. This avoids
causing problems for people who purposefully have non-Cygwin versions of
executables like svn in front of the Cygwin ones in their paths.
* WebKit.vcproj/Interfaces.vcproj:
* WebKit.vcproj/InterfacesGenerated.vcproj:
* WebKit.vcproj/WebKit.vcproj:
* WebKit.vcproj/WebKitGUID.vcproj:
2009-07-16 Fumitoshi Ukai <ukai@chromium.org>
Reviewed by David Levin.
Add --web-sockets flag and ENABLE_WEB_SOCKETS define.
https://bugs.webkit.org/show_bug.cgi?id=27206
Add ENABLE_WEB_SOCKETS
* WebKit.vcproj/WebKit.vcproj: add ENABLE_WEB_SOCKETS
2009-07-16 Xiaomei Ji <xji@chromium.org>
Reviewed by Darin Adler.
Fix tooltip does not get its directionality from its element's directionality.
https://bugs.webkit.org/show_bug.cgi?id=24187
Per mitz's suggestion in comment #6, while getting the plain-text
title, we also get the directionality of the title. How to handle
the directionality is up to clients. Clients could ignore it,
or use attribute or unicode control characters to display the title
as what they want.
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::setToolTip): Add directionality as 2nd parameter to setToopTip() (without handling it yet).
* WebCoreSupport/WebChromeClient.h: Add directionality as 2nd parameter to setToolTip().
* WebElementPropertyBag.cpp:
(WebElementPropertyBag::Read): Change call of spellingToolTip() and title() due to signature change.
2009-07-15 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
Renamed parseURL to deprecatedParseURL.
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::createPlugin): Renamed.
2009-07-14 Steve Falkenburg <sfalken@apple.com>
Reorganize JavaScriptCore headers into:
API: include/JavaScriptCore/
Private: include/private/JavaScriptCore/
Reviewed by Darin Adler.
* WebKit.vcproj/WebKit.vcproj:
2009-07-14 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
Reviewed by Darin Adler.
Change all Noncopyable inheriting visibility to public.
https://bugs.webkit.org/show_bug.cgi?id=27225
Change all Noncopyable inheriting visibility to public because
it is needed to the custom allocation framework (bug #20422).
* COMEnumVariant.h:
* WebDatabaseManager.cpp:
* WebInspector.h:
* WebLocalizableStrings.cpp:
2009-07-13 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
Refactor WebFrame::spoolPages for easier sharing with Windows Cairo.
https://bugs.webkit.org/show_bug.cgi?id=27240.
* WebFrame.cpp:
(WebFrame::printHeader): New shared method to print the header.
(WebFrame::printFooter): New shared method to print the footer.
(WebFrame::spoolPage): New conditionally-compiled method to print
a page.
(WebFrame::spoolPages): Revised to call the platform-specific spoolPage
for each page.
* WebFrame.h: Add new method prototypes.
2009-07-13 Brent Fulgham <bfulgham@webkit.org>
Reviewed by Adam Roben.
Add new configuration flag for redistributable Windows build.
https://bugs.webkit.org/show_bug.cgi=27087
* WebKit.vcproj/WebKit.vcproj: Add new WinCairo.vsprops to
Debug_Cairo and Release_Cairo targets.
2009-07-12 Brent Fulgham <bfulgham@gmail.com>
Speculative Windows build fix after http://trac.webkit.org/changeset/45786.
* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::addMessageToConsole):
2009-07-10 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig with the power of Grayskull.
Enable XSSAuditor by default.
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
2009-07-09 Drew Wilson <atwilson@google.com>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=26903
Turned on CHANNEL_MESSAGING by default because the MessageChannel API
can now be implemented for Web Workers and is reasonably stable.
* WebKit.vcproj/WebKit.vcproj:
2009-07-09 Brian Weinstein <bweinstein@apple.com>
Reviewed by Alice Liu.
Fix of <rdar://5712929> Add preferences key to remember if the Inspector was docked (14271)
https://bugs.webkit.org/show_bug.cgi?id=27140
Added a preference key to remember whether the user prefers the inspector detached or attached.
* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::showWindow): Pass both parameters into setWindowVisible
(WebInspectorClient::closeWindow): Ditto
(WebInspectorClient::attachWindow): Set preference to attached windows here
(WebInspectorClient::detachWindow): Set preference to detached windows here
(WebInspectorClient::showWindowWithoutNotifications): Read preference for attached vs. detached
(WebInspectorClient::onClose): Pass both parameters into setWindowVisible
2009-07-09 Alexey Proskuryakov <ap@webkit.org>
Reviewed by Oliver Hunt.
<rdar://problem/6921671> Visit count shouldn't be incremented by redirects.
* WebCoreSupport/WebFrameLoaderClient.cpp: (WebFrameLoaderClient::updateGlobalHistory):
Do not increase visit count if there is a redirect source. As a result, only pages that were
explicitly visited by the user (by typing a URL, choosing one from bookmarks, or clicking
a link) will be counted.
* Interfaces/IWebHistoryItemPrivate.idl:
* WebHistory.cpp:
(WebHistory::visitedURL):
* WebHistory.h:
* WebHistoryItem.cpp:
(WebHistoryItem::visitedWithTitle):
* WebHistoryItem.h:
Marshal this new argument all the way down to WebCore.
2009-07-09 Beth Dakin and Jon Honeycutt <bdakin@apple.com>
Reviewed by Dave Hyatt.
Make Widget RefCounted to fix:
<rdar://problem/7038831> REGRESSION (TOT): In Mail, a crash occurs
at WebCore::Widget::afterMouseDown() after clicking To Do's close
box
<rdar://problem/6978804> WER #16: Repro Access Violation in
WebCore::PluginView::bindingInstance (1310178023)
-and-
<rdar://problem/6991251> WER #13: Crash in WebKit!
WebCore::PluginView::performRequest+203 (1311461169)
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::createPlugin):
* WebCoreSupport/WebFrameLoaderClient.h:
* WebFrame.cpp:
(WebFrame::createJavaAppletWidget):
* WebFrame.h:
2009-07-09 Sam Weinig <sam@webkit.org>
Reviewed by Steve Falkenburg.
Roll out r43848. The quirk is no longer necessary.
* WebView.cpp:
(WebView::userAgentForKURL):
2009-07-07 Ada Chan <adachan@apple.com>
Reviewed by Dave Hyatt.
Missed a call to FocusController::setFocused(true) when handling WM_SETFOCUS in WebView.
https://bugs.webkit.org/show_bug.cgi?id=27057
* WebView.cpp:
(WebViewWndProc):
2009-07-02 Erik Arvidsson <arv@chromium.org>
Reviewed by Adam Roben.
[Win] HTML5 Drag and drop, dragend is not fired when pressing Esc
https://bugs.webkit.org/show_bug.cgi?id=26699
* WebDropSource.cpp:
(WebDropSource::QueryContinueDrag):
2009-07-02 Oliver Hunt <oliver@apple.com>
Reviewed by Anders Carlsson.
<rdar://problem/6939593> REGRESSION (r37793): Hitting back button on Google often gives non-interactive Google page (26670)
<https://bugs.webkit.org/show_bug.cgi?id=26670>
Make windows loader client match mac behaviour more closely.
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::forceLayout):
2009-06-30 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Adam Roben.
Build DumpRenderTree under Cairo.
https://bugs.webkit.org/show_bug.cgi?id=26457
* WebKit.vcproj/WebKit.sln: Add Cairo targets to the
DumpRenderTree build, and use the in the Debug_Cairo
and Release_Cairo targets.
2009-07-02 Eric Carlson <eric.carlson@apple.com>
Fix Windows build by including missing localized string methods.
* WebCoreLocalizedStrings.cpp:
(WebCore::mediaElementLoadingStateText):
(WebCore::mediaElementLiveBroadcastStateText):
2009-07-01 David Hyatt <hyatt@apple.com>
Reviewed by Tim Hatcher.
<rdar://problem/6998524> REGRESSION (r44474): Form text field has focus ring, looks focused,
even though the field is not actually focused for keyboard input
Add the concept of whether or not the Page is focused by adding a boolean to the focusController. This allows the
focused frame and focused node to both be cached and changed programmatically without causing errors when the Page doesn't
have focus.
* WebView.cpp:
(WebViewWndProc):
2009-06-29 David Hyatt <hyatt@apple.com>
Fix Windows bustage. Missed two configurations for enabling DATAGRID.
* WebKit.vcproj/WebKit.vcproj:
2009-06-29 Jessie Berlin <jberlin@apple.com>
Reviewed by Adam Roben.
Fix the windows build.
* WebCoreSupport/WebContextMenuClient.cpp:
(WebContextMenuClient::isSpeaking):
* WebCoreSupport/WebContextMenuClient.h:
2009-06-29 David Hyatt <hyatt@apple.com>
Reviewed by Adam Roben.
Make sure to patch all configurations to have datagrid enabled.
* WebKit.vcproj/WebKit.vcproj:
2009-06-29 David Hyatt <hyatt@apple.com>
Reviewed by Adam Roben.
Put <datagrid> behind an ifdef.
* WebKit.vcproj/WebKit.vcproj:
2009-06-26 Brian Weinstein <bweinstein@apple.com>
Reviewed by Simon Fraser.
https://bugs.webkit.org/show_bug.cgi?id=26695
Added hit testing on scrollbars, so if you start a gesture over a scrollbar,
it isn't counted, and lets the user drag the scrollbar itself instead of a
panning gesture. Also cleaned up code in gesture.
* WebView.cpp:
(WebView::gestureNotify):
(WebView::gesture):
2009-06-26 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=26767
Fix a build break due to LocalStorage.h being included in WebKitDLL.cpp
despite it being deleted from the repo by the following patch/commit:
https://bugs.webkit.org/show_bug.cgi?id=26732
http://trac.webkit.org/changeset/45290
* WebKitDLL.cpp:
2009-06-26 Yongjun Zhang <yongjun.zhang@nokia.com>
Reviewed by Eric Seidel.
Bug 20303: [Qt] Key events are not working in frames.
Move the scroll handling code to EventHandler so that other
ports can share the functionality.
* WebView.cpp:
(WebView::keyDown):
(EnumTextMatches::QueryInterface):
2009-06-23 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
WebKit side of <rdar://problem/6946094>.
* Interfaces/IWebUIDelegate.idl:
Add a newPasteboard out parameter to willPerformDragSourceAction.
* WebCoreSupport/WebDragClient.cpp:
(WebDragClient::willPerformDragSourceAction):
Implement this. If the client returns a new pasteboard, use it for the drag.
* WebCoreSupport/WebInspectorDelegate.h:
(WebInspectorDelegate::willPerformDragSourceAction):
Add the new parameter.
2009-06-20 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
<rdar://problem/6964221> Need more processing of pluginspage.
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::createPlugin): Check protocolInHTTPFamily.
2009-06-19 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Steve Falkenburg.
https://bugs.webkit.org/show_bug.cgi?id=26494
Bug 26494: RenderTheme::themeForPage reads from Settings before it has
been initialized by WebKit
Get the shouldPaintNativeControls preference and update the settings
before initializing the page, as the page depends on it after the
themeForPage change.
* WebView.cpp:
(WebView::initWithFrame):
2009-06-19 Brian Weinstein <bweinstein@apple.com>
Reviewed by Steve Falkenburg.
https://bugs.webkit.org/show_bug.cgi?id=26488
No Support for Single Finger or Two Finger Panning in Windows 7
Added the code necessary for single finger and two-finger panning with
window bounce. We now register for WM_GESTURENOTIFY and WM_GESTURE messages,
and interpret the panning command. Also, added WindowsTouch.h which contains
structs and #defines from the Windows 7 SDK.
* WebKit.vcproj/WebKit.vcproj:
* WebView.cpp:
(WebView::gestureNotify): Checks if we are in a pannable region - IE: Not in the scrollbar
(WebView::gesture): Handles the Panning gesture, creating the WheelEvent
(WebViewWndProc): Added cases for WM_GESTURE and WM_GESTURENOTIFY
* WebView.h:
* WindowsTouch.h: Added.
2009-06-18 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=26199
Added preference to enable the XSSAuditor.
* Interfaces/IWebPreferencesPrivate.idl:
* WebPreferenceKeysPrivate.h:
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::isXSSAuditorEnabled):
(WebPreferences::setXSSAuditorEnabled):
* WebPreferences.h:
* WebView.cpp:
(WebView::notifyPreferencesChanged):
2009-06-18 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Dave Levin.
Remove some boilerplate using the BitmapInfo struct.
https://bugs.webkit.org/show_bug.cgi?id=26425
* WebFrame.cpp:
(WebFrame::spoolPages):
* WebIconDatabase.cpp:
(createDIB):
* WebKit.vcproj/WebKit.sln:
* WebNodeHighlight.cpp:
(WebNodeHighlight::update):
* WebView.cpp:
(WebView::ensureBackingStore):
2009-06-17 Steve Falkenburg <sfalken@apple.com>
Consolidate WebKit COM interfaces.
Moved IID from the highest numbered COM interface to the first interface and combined all methods.
Numbered interfaces can be combined since the latest shipping Safari 4 supports the latest interfaces.
Reviewed by Adam Roben.
* Interfaces/IWebFrameLoadDelegate.idl:
* Interfaces/IWebFrameLoadDelegatePrivate.idl:
* Interfaces/IWebResourceLoadDelegatePrivate.idl:
* Interfaces/IWebUIDelegate.idl:
* Interfaces/IWebUIDelegatePrivate.idl:
* Interfaces/WebKit.idl:
* WebCoreSupport/WebChromeClient.cpp:
* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebContextMenuClient.cpp:
* WebCoreSupport/WebFrameLoaderClient.cpp:
* WebCoreSupport/WebInspectorDelegate.h:
* WebFrame.cpp:
* WebView.cpp:
2009-06-16 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org>
Reviewed by Adam Roben.
Create a different RenderTheme per page, so that RenderTheme has
access to page specific theming. This is needed for the Qt port, as Qt
supports setting the theme (style) per widget.
This change was suggested and discussed with Dave Hyatt.
More detailed:
1) Create a theme per page or one global one, depending on the needs
of the platform.
2) Add an accesser to the theme from RenderObject.
3) Change all uses of the theming to access the theme through
RenderObject, using the global default theme as fallback, when the
document of RenderObject has no page.
When we don't have access to a RenderObject, use the default theme.
4) Modify all RenderTheme platform implementations to work with the
above changes, still creating only one global theme.
* WebView.cpp:
(WebViewWndProc): Get the theme from the associated page.
2009-06-16 Brian Weinstein <bweinstein@apple.com>
Reviewed by Adam Roben.
Switch Control+Mousewheel Zooming definitions to match other browsers on Windows.
Control+Mousewheel-Down now zooms out, Control+Mousewheel-Up now zooms in.
https://bugs.webkit.org/show_bug.cgi?id=25875.
<rdar://problem/6903976>
* WebView.cpp:
(WebView::mouseWheel):
2009-06-16 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Darin Adler.
Use consistent Windows GUID Comparison Functions.
https://bugs.webkit.org/show_bug.cgi?id=26427.
* WebView.cpp:
(EnumTextMatches::QueryInterface):
== Rolled over to ChangeLog-2009-06-16 ==
|