diff options
| author | simon.fraser@apple.com <simon.fraser@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc> | 2013-05-25 23:56:01 +0000 |
|---|---|---|
| committer | The Qt Project <gerrit-noreply@qt-project.org> | 2013-08-09 09:55:36 +0200 |
| commit | f3484678deb631b7d994dd400b609dcb7bbbc04b (patch) | |
| tree | ac9039ad86485ee18607e15adca2fc6b643ddc8f /Tools/DumpRenderTree | |
| parent | 412ec5284b300668101a1db137e08a729008d164 (diff) | |
| download | qtwebkit-f3484678deb631b7d994dd400b609dcb7bbbc04b.tar.gz | |
Unprefix Page Visibility API
https://bugs.webkit.org/show_bug.cgi?id=102340
Source/WebCore:
Reviewed by Tim Horton.
Remove prefixes from the document properties, and the visibilitychanged event.
Rename the "preview" state to "unloaded". The "unloaded" state is never
reached yet (see https://bugs.webkit.org/show_bug.cgi?id=116769).
Add some comments to places where we should update the visibility state
when going in and out of the page cache, but cannot safely do so yet.
Tested by existing Page Visibility tests.
* dom/Document.cpp:
(WebCore::Document::pageVisibilityState):
(WebCore::Document::visibilityState):
(WebCore::Document::hidden):
(WebCore::Document::dispatchVisibilityStateChangeEvent):
* dom/Document.h:
* dom/Document.idl:
* dom/EventNames.h:
* history/CachedFrame.cpp:
(WebCore::CachedFrameBase::restore):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::stopLoading):
* page/Page.cpp:
(WebCore::Page::setVisibilityState):
* page/PageVisibilityState.cpp:
(WebCore::pageVisibilityStateString):
* page/PageVisibilityState.h:
Source/WebKit/efl:
Reviewed by Tim Horton.
Rename "preview" state to "unloaded" state.
* WebCoreSupport/AssertMatchingEnums.cpp:
* ewk/ewk_view.h:
Source/WebKit/mac:
Reviewed by Tim Horton.
Renaming of the "preview" state to "unloaded".
* WebView/WebView.mm:
* WebView/WebViewPrivate.h:
Source/WebKit2:
Reviewed by Tim Horton.
Renaming of the "preview" state to "unloaded".
* Shared/API/c/WKPageVisibilityTypes.h:
* Shared/API/c/WKSharedAPICast.h:
(WebKit::toPageVisibilityState):
Tools:
Reviewed by Tim Horton.
Rename "preview" state to "unloaded" state, and adjust the tests
to test for it.
* DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::setPageVisibility):
* TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp:
(TestWebKitAPI::setPageVisibilityStateWithEvalContinuation):
(TestWebKitAPI::didRunStep2StateChangeHiddenToPrerender):
(TestWebKitAPI::didRunStep3StateChangePrerenderToUnloaded):
(TestWebKitAPI::didRunStep4InStateUnloaded):
* TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.html:
* TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
(TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setPageVisibility):
LayoutTests:
Reviewed by Tim Horton.
Remove prefixes, adjust to state name changes.
* fast/events/page-visibility-iframe-delete-test.html:
* fast/events/page-visibility-iframe-move-test-expected.txt:
* fast/events/page-visibility-iframe-move-test.html:
* fast/events/page-visibility-iframe-propagation-test-expected.txt:
* fast/events/page-visibility-iframe-propagation-test.html:
* fast/events/page-visibility-null-view-expected.txt:
* fast/events/page-visibility-null-view.html:
* fast/events/page-visibility-transition-test-expected.txt:
* fast/events/page-visibility-transition-test.html:
Change-Id: I9751efeae0bab8136a63c7e22ad0d513fc8ceb0c
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150695 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
Diffstat (limited to 'Tools/DumpRenderTree')
| -rw-r--r-- | Tools/DumpRenderTree/mac/TestRunnerMac.mm | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/Tools/DumpRenderTree/mac/TestRunnerMac.mm b/Tools/DumpRenderTree/mac/TestRunnerMac.mm index c6a2f4a37..22f5c2898 100644 --- a/Tools/DumpRenderTree/mac/TestRunnerMac.mm +++ b/Tools/DumpRenderTree/mac/TestRunnerMac.mm @@ -1171,8 +1171,8 @@ void TestRunner::setPageVisibility(const char* newVisibility) [webView _setVisibilityState:WebPageVisibilityStateHidden isInitialState:NO]; else if (!strcmp(newVisibility, "prerender")) [webView _setVisibilityState:WebPageVisibilityStatePrerender isInitialState:NO]; - else if (!strcmp(newVisibility, "preview")) - [webView _setVisibilityState:WebPageVisibilityStatePreview isInitialState:NO]; + else if (!strcmp(newVisibility, "unloaded")) + [webView _setVisibilityState:WebPageVisibilityStateUnloaded isInitialState:NO]; } void TestRunner::sendWebIntentResponse(JSStringRef) |