diff options
author | Simon Hausmann <simon.hausmann@nokia.com> | 2012-09-10 19:10:20 +0200 |
---|---|---|
committer | Simon Hausmann <simon.hausmann@nokia.com> | 2012-09-10 19:10:20 +0200 |
commit | 284837daa07b29d6a63a748544a90b1f5842ac5c (patch) | |
tree | ecd258180bde91fe741e0cfd2638beb3c6da7e8e /Source/WebKit/blackberry/ChangeLog | |
parent | 2e2ba8ff45915f40ed3e014101269c175f2a89a0 (diff) | |
download | qtwebkit-284837daa07b29d6a63a748544a90b1f5842ac5c.tar.gz |
Imported WebKit commit 68645295d2e3e09af2c942f092556f06aa5f8b0d (http://svn.webkit.org/repository/webkit/trunk@128073)
New snapshot
Diffstat (limited to 'Source/WebKit/blackberry/ChangeLog')
-rw-r--r-- | Source/WebKit/blackberry/ChangeLog | 1175 |
1 files changed, 1175 insertions, 0 deletions
diff --git a/Source/WebKit/blackberry/ChangeLog b/Source/WebKit/blackberry/ChangeLog index a7715af0a..823f9b8b0 100644 --- a/Source/WebKit/blackberry/ChangeLog +++ b/Source/WebKit/blackberry/ChangeLog @@ -1,3 +1,1178 @@ +2012-09-09 Arvid Nilsson <anilsson@rim.com> + + [BlackBerry] Fix flicker due to introduction of the fence extension. + https://bugs.webkit.org/show_bug.cgi?id=96207 + + Reviewed by George Staikos. + + Don't immediately add fence to garbage list, so it is destroyed + after only one swap, for a set of tiles just because one tile in + the set gets a new fence, the old fence may still not be signalled + and before rendering the other tiles in the set we have to wait for it. + + * WebKitSupport/BackingStoreTile.cpp: + (BlackBerry::WebKit::Fence::~Fence): + (WebKit): + * WebKitSupport/BackingStoreTile.h: + (WebKit): + (Fence): + * WebKitSupport/SurfacePool.cpp: + (BlackBerry::WebKit::SurfacePool::initialize): + (BlackBerry::WebKit::SurfacePool::notifyBuffersComposited): + (WebKit): + (BlackBerry::WebKit::SurfacePool::destroyPlatformSync): + * WebKitSupport/SurfacePool.h: + (SurfacePool): + +2012-09-08 Max Feil <mfeil@rim.com> + + [BlackBerry] Exiting fullscreen mode can leave user stuck without Browser menus + https://bugs.webkit.org/show_bug.cgi?id=96027 + + Reviewed by Antonio Gomes. + + The changes for bug 87337 (landed as trunk svn revision 119119) + introduced a bug. The same conditions are not checked on enter + fullscreen vs. exit. Web sites such as http://videojs.com + and youtube's mobile HTML5 player make the div container + of the video element go fullscreen. This is allowed in + WebPagePrivate::enterFullScreenForElement() but disallowed in + WebPagePrivate::exitFullScreenForElement(). I am fixing this by + allowing containers of video elements to exit fullscreen. + + * Api/WebPage.cpp: + (BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement): + +2012-09-07 Ming Xie <mxie@rim.com> + + + [BlackBerry] Remove browser from the build info page + https://bugs.webkit.org/show_bug.cgi?id=96162 + + Reviewed by George Staikos. + Internal reviewed by Jeff Rogers. + + WebKit build should not have the build info for browser which is + built on top of webkit. + + * WebKitSupport/AboutData.cpp: + (BlackBerry::WebKit::buildPage): + +2012-09-07 Yongxin Dai <yodai@rim.com> + + [BlackBerry] Initialize caret rectangle with invalid location + https://bugs.webkit.org/show_bug.cgi?id=96011 + + Reviewed by Rob Buis. + + In SelectionHandler::selectionPositionChanged() method, startCaret and + endCaret are used to notify clients about new caret positions. This patch + initializes startCaret and endCaret with location(-1. -1), and keeps them + empty before they are assigned to valid values. This would help for other + classes to check validity of the caret correctly. + + Internal reviewed by Mike Fenton. + + * WebKitSupport/SelectionHandler.cpp: + (BlackBerry::WebKit::adjustCaretRects): + (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged): + +2012-09-07 Lianghui Chen <liachen@rim.com> + + [BlackBerry] when one of multiple tabs uses authentication, user can get the auth dialog while the other tab has focus. + https://bugs.webkit.org/show_bug.cgi?id=95488 + PR: 186597. + + Internally reviewed by Joe Mason. + Reviewed by Yong Li. + + Use new AuthenticationChallengeClient interface to make authentication + challenge asynchronous to NetworkJob, MediaPlayerPrivateBlackBerry, and + other module that will use HTTP authentication. WebPage itself still use + synchronous authentication though. Switching to asynchronous authentication + in WebPage will require bigger platform layer change and not very necessary + at the moment for this bug. + + * Api/WebPage.cpp: + (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge): + * Api/WebPage_p.h: + (WebCore): + (WebPagePrivate): + +2012-09-07 Rob Buis <rbuis@rim.com> + + [BlackBerry] Remove feature about:cache/disable and about:cache/enable + https://bugs.webkit.org/show_bug.cgi?id=95820 + + Reviewed by Yong Li. + + Fix warning that was caused by r127680. + + * WebKitSupport/AboutData.cpp: + (BlackBerry::WebKit::cachePage): + +2012-09-07 Allan Sandfeld Jensen <allan.jensen@nokia.com> + + Simplify hitTestResultAtPoint and nodesFromRect APIs + https://bugs.webkit.org/show_bug.cgi?id=95720 + + Reviewed by Antonio Gomes. + + Update calls to new API. + + * Api/WebPage.cpp: + (BlackBerry::WebKit::WebPagePrivate::contextNode): + (BlackBerry::WebKit::WebPagePrivate::nodeForZoomUnderPoint): + (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent): + (BlackBerry::WebKit::WebPage::nodeAtPoint): + * WebKitSupport/FatFingers.cpp: + (BlackBerry::WebKit::FatFingers::getNodesFromRect): + (BlackBerry::WebKit::FatFingers::getRelevantInfoFromPoint): + * WebKitSupport/SelectionHandler.cpp: + (BlackBerry::WebKit::visiblePositionForPointIgnoringClipping): + +2012-09-07 Robin Cao <robin.cao@torchmobile.com.cn> + + [BlackBerry] Rendering issue after rotation + https://bugs.webkit.org/show_bug.cgi?id=96094 + PR #201930 + + Reviewed by George Staikos. + + The cause of the rendering issue is that the BackingStore tiles + are not reset after layout. This is a regression of r125680, which + overwrites a local variable that are used later in the function. + + * Api/WebPage.cpp: + (BlackBerry::WebKit::WebPagePrivate::setViewportSize): + +2012-09-06 Crystal Zhang <haizhang@rim.com> + + [BlackBerry] Implement a color picker + https://bugs.webkit.org/show_bug.cgi?id=96001 + + Reviewed by Rob Buis. + + Add files for color picker, replace old hook to AIR color picker. + + * WebCoreSupport/ColorPickerClient.cpp: Added. + (WebCore): + (WebCore::ColorPickerClient::ColorPickerClient): + (WebCore::ColorPickerClient::~ColorPickerClient): + (WebCore::ColorPickerClient::generateHTML): + (WebCore::ColorPickerClient::closePopup): + (WebCore::ColorPickerClient::contentSize): + (WebCore::ColorPickerClient::htmlSource): + (WebCore::ColorPickerClient::setValueAndClosePopup): + (WebCore::ColorPickerClient::didClosePopup): + (WebCore::ColorPickerClient::writeDocument): + * WebCoreSupport/ColorPickerClient.h: Added. + (WebKit): + (WebCore): + (ColorPickerClient): + * WebKitSupport/InputHandler.cpp: + (BlackBerry::WebKit::InputHandler::openColorPopup): + +2012-09-06 Genevieve Mak <gmak@rim.com> + + Add data-blackberry-webworks-context attribute and set the custom context when + getting context. + https://bugs.webkit.org/show_bug.cgi?id=95993 + + Reviewed by Antonio Gomes. + + PR #193726 + Reviewed Internally by Mike Fenton. + + * Api/WebPage.cpp: + (BlackBerry::WebKit::WebPagePrivate::webContext): + - Check for custom WebWorks context and add it if there. + * WebKitSupport/DOMSupport.cpp: + (BlackBerry::WebKit::DOMSupport::webWorksContext): + (DOMSupport): + * WebKitSupport/DOMSupport.h: + - Add a method that checks a given element for the data-webworks-context + attribute and returns its value if present. + +2012-09-06 Antonio Gomes <agomes@rim.com> + + [BlackBerry] Allow overscroll to composited scroll layers + https://bugs.webkit.org/show_bug.cgi?id=95998 + PR #195305 + + Reviewed by Rob Buis. + Internally reviewed by Gen Mak. + + No need to reset the overscroll limit factor at creation to 0. + It is already 0 by default, and later on the client sets the + appropriated value. + + * WebKitSupport/InRegionScrollableArea.cpp: + (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea): + +2012-09-05 Sam Weinig <sam@webkit.org> + + Part 2 of removing PlatformString.h, remove PlatformString.h + https://bugs.webkit.org/show_bug.cgi?id=95931 + + Reviewed by Adam Barth. + + Remove PlatformString.h + + * Api/DumpRenderTreeClient.h: + * WebCoreSupport/ChromeClientBlackBerry.cpp: + * WebCoreSupport/InspectorClientBlackBerry.h: + * WebCoreSupport/JavaScriptDebuggerBlackBerry.cpp: + * WebKitSupport/AboutData.h: + +2012-09-05 Jason Liu <jason.liu@torchmobile.com.cn> + + [BlackBerry] Remove feature about:cache/disable and about:cache/enable + https://bugs.webkit.org/show_bug.cgi?id=95820 + + Reviewed by Rob Buis. + + Remove this feature since we need to add a button in settings. + + * WebKitSupport/AboutData.cpp: + (BlackBerry::WebKit::cachePage): + +2012-09-05 Mike Fenton <mifenton@rim.com> + + [BlackBerry] Remove deprecated dialog connections. + https://bugs.webkit.org/show_bug.cgi?id=95868 + + Reviewed by Rob Buis. + + PR 187481. + Remove deprecated logic for unsupported + Dialog types. + + * Api/WebPageClient.h: + * WebKitSupport/InputHandler.cpp: + (BlackBerry::WebKit::InputHandler::openDatePopup): + (BlackBerry::WebKit::InputHandler::openColorPopup): + +2012-09-05 George Staikos <staikos@webkit.org> + + [BlackBerry] Assignment operators missing self-check + https://bugs.webkit.org/show_bug.cgi?id=95774 + + Reviewed by Rob Buis. + + Add a test for self-assignment. + + * Api/WebAnimation.cpp: + (BlackBerry::WebKit::WebAnimation::operator=): + * Api/WebString.cpp: + (BlackBerry::WebKit::WebString::operator=): + +2012-09-05 Leo Yang <leoyang@rim.com> + + [BlackBerry] Optimize BackingStorePrivate::isCurrentVisibleJob + https://bugs.webkit.org/show_bug.cgi?id=95897 + + Reviewed by Antonio Gomes. + + Bail out the loop early if one of the not-rendered rectangle is + not current regular render job. + + No behavior change, just code optimization. + + * Api/BackingStore.cpp: + (BlackBerry::WebKit::BackingStorePrivate::isCurrentVisibleJob): + +2012-09-05 Benjamin C Meyer <bmeyer@rim.com> + + [BlackBerry] JavaScriptVariant can crash when operator= is called with itself + https://bugs.webkit.org/show_bug.cgi?id=95859 + + Reviewed by George Staikos. + + * Api/JavaScriptVariant.cpp: + (BlackBerry::WebKit::JavaScriptVariant::operator=): + When JavaScriptVariant contains a string and operator= is + called with itself the memory will be free'd in 'this' and + then a copy will be attempted from 'that' resulting in a crash. + +2012-09-05 Leo Yang <leoyang@rim.com> + + [BlackBerry] Rotation and then reload causes less sized webpage (PR 190469) + https://bugs.webkit.org/show_bug.cgi?id=95870 + + Reviewed by George Staikos. + Reviewed internally by Jacky Jiang. + + Use the new zoom to fit scale if the page was zoomed to fit initial scale + When a page is reloaded the layout size may be changed. So the contents + size on which the initial scale depends may be changed. Use the new initial + scale in this case to make sure the page will be zoomed to correct scale. + + * WebCoreSupport/FrameLoaderClientBlackBerry.cpp: + (WebCore::FrameLoaderClientBlackBerry::restoreViewState): + +2012-09-05 Robin Cao <robin.cao@torchmobile.com.cn> + + [BlackBerry] Do not release shared backingstore memory prematurely + https://bugs.webkit.org/show_bug.cgi?id=95841 + PR #202517 + + Reviewed by George Staikos. + + The BackingStore memory is shared by all web pages. We should check if + the current backingStore is active before create/release this shared memory. + + * Api/BackingStore.cpp: + (BlackBerry::WebKit::BackingStore::createBackingStoreMemory): + (BlackBerry::WebKit::BackingStore::releaseBackingStoreMemory): + +2012-09-05 Andy Chen <andchen@rim.com> + + [BlackBerry] Implement number of matches and current active match index for find-on-page + https://bugs.webkit.org/show_bug.cgi?id=95801 + + Reviewed by Antonio Gomes. + + - Calculate current match index for find-on-page + - Notify client when number of matches and current match index update. + PR 162090 162091. + Internally reviewed by Mike Fenton and Joe Mason + + * Api/WebPageClient.h: + * WebKitSupport/InPageSearchManager.cpp: + (BlackBerry::WebKit::InPageSearchManager::DeferredScopeStringMatches::DeferredScopeStringMatches): + (BlackBerry::WebKit::InPageSearchManager::DeferredScopeStringMatches::doTimeout): + (InPageSearchManager::DeferredScopeStringMatches): + (BlackBerry::WebKit::InPageSearchManager::findNextString): + (BlackBerry::WebKit::InPageSearchManager::findAndMarkText): + (BlackBerry::WebKit::InPageSearchManager::scopeStringMatches): + (BlackBerry::WebKit::InPageSearchManager::scopeStringMatchesSoon): + (BlackBerry::WebKit::InPageSearchManager::callScopeStringMatches): + * WebKitSupport/InPageSearchManager.h: + (InPageSearchManager): + +2012-09-04 Rob Buis <rbuis@rim.com> + + [BlackBerry] FatFingers::cachingStrategy uses incorrect enum value + https://bugs.webkit.org/show_bug.cgi?id=95783 + + Reviewed by Antonio Gomes. + + Use the correct enum values. + + * WebKitSupport/FatFingers.cpp: + (BlackBerry::WebKit::FatFingers::cachingStrategy): + +2012-09-04 Antonio Gomes <agomes@rim.com> + + [BlackBerry] Use child/ScrollableContent layer's position instead of parent/ScrollLayer's boundsOrigin + https://bugs.webkit.org/show_bug.cgi?id=95778 + PR #202252 + + Reviewed by Rob Buis. + Internally reviewed by Arvid Nilsson. + + Upstream has switch away from using the parent scroll layer's bounds origin + in order to translate contents of all its child layers. Instead now, it directly + sets the scroll position of the child scrollable contents layer. + + Source/WebKit/blackberry: + * Api/InRegionScroller.cpp: + (BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionCompositingThread): + * WebKitSupport/InRegionScrollableArea.cpp: + (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea): + + No new tests, since it is a catch-up with upstreaming code. + +2012-09-04 George Staikos <staikos@webkit.org> + + [BlackBerry] Fix memory leak in InputHandler + https://bugs.webkit.org/show_bug.cgi?id=95771 + + Reviewed by Rob Buis. + + Simply delete the arrays at function exit. + + * WebKitSupport/InputHandler.cpp: + (BlackBerry::WebKit::InputHandler::openSelectPopup): + +2012-09-04 George Staikos <staikos@webkit.org> + + [BlackBerry] pass isMainFrame() through to notifyDocumentOnLoad() + https://bugs.webkit.org/show_bug.cgi?id=95766 + + Reviewed by Rob Buis. + + Passing the frame status through will allow the client to make better + decisions about how to act on the onload. + + * Api/WebPageClient.h: + * WebCoreSupport/FrameLoaderClientBlackBerry.cpp: + (WebCore::FrameLoaderClientBlackBerry::dispatchDidHandleOnloadEvents): + +2012-09-04 Rob Buis <rbuis@rim.com> + + [BlackBerry] Provide virtual dtor for DumpRenderTreeClient + https://bugs.webkit.org/show_bug.cgi?id=95769 + + Reviewed by Yong Li. + + Also remove WTF prefixes. + + * Api/DumpRenderTreeClient.h: + +2012-09-04 Mary Wu <mary.wu@torchmobile.com.cn> + + [BlackBerry] Add webplatform and browser to build info + https://bugs.webkit.org/show_bug.cgi?id=95715 + + Reviewed by George Staikos. + + PR# 202102 + + * WebKitSupport/AboutData.cpp: + (BlackBerry::WebKit::buildPage): + +2012-08-31 Jacky Jiang <zhajiang@rim.com> + + [BlackBerry] ASSERT failure in RenderBlock::checkPositionedObjectsNeedLayout + https://bugs.webkit.org/show_bug.cgi?id=95611 + + Reviewed by Antonio Gomes. + + PR:200127 + Remove r118405 now as we already have a new fix webkit/43f8394b for + that issue and it is not reproducible anymore after the removal. + In this way, we can get rid of this ASSERT failure as well. + Thanks Antonio for the suggestion. + + * Api/WebPage.cpp: + (BlackBerry::WebKit::WebPagePrivate::setViewportSize): + +2012-08-31 Joshua Netterfield <jnetterfield@rim.com> + + [BlackBerry] Eliminate WebGL IT policy + https://bugs.webkit.org/show_bug.cgi?id=95604 + Internal RIM PR #198764 + + Reviewed by Rob Buis. + + This is no longer a requirement for the BlackBerry port. + + * Api/WebPage.cpp: + (BlackBerry::WebKit::WebPagePrivate::init): + (BlackBerry::WebKit::WebPage::setWebGLEnabled): + * WebKitSupport/AboutData.cpp: + (BlackBerry::WebKit::configPage): + +2012-08-30 Benjamin Poulain <bpoulain@apple.com> + + Replace JSC::UString by WTF::String + https://bugs.webkit.org/show_bug.cgi?id=95271 + + Reviewed by Geoffrey Garen. + + Replace UString by String. + + * WebCoreSupport/ClientExtension.cpp: + * WebCoreSupport/PagePopupBlackBerry.cpp: + (WebCore::PagePopupBlackBerry::installDomFunction): + +2012-08-30 Jacky Jiang <zhajiang@rim.com> + + [BlackBerry] ASSERT failure in JSC::MarkedAllocator::allocateSlowCase + https://bugs.webkit.org/show_bug.cgi?id=95492 + + Reviewed by Yong Li. + + PR: 200724 + Hold the JSLock for the current thread before we call toRef to avoid + the ASSERT failure. + + * Api/WebPage.cpp: + (BlackBerry::WebKit::WebPagePrivate::executeJavaScript): + +2012-08-30 Antonio Gomes <agomes@rim.com> + + [BlackBerry] Remove unneeded force-immediate-repaint from InRegionScroller::setLayerScrollPosition + https://bugs.webkit.org/show_bug.cgi?id=95476 + PR #200704 + + Reviewed by Yong Li. + + This code is not needed at this point for neither the fast nor slow in-region + scroll codepaths, and it is a huge performance beast as it forces all + containers to get full-repainted per scroll call (in webkit thread). + + Patch also take this opportunity to remove an early-return we + have in the {i}frame slow scrolling code path so that we can + adjust the selection handles in this case as well. + + * Api/InRegionScroller.cpp: + (BlackBerry::WebKit::InRegionScrollerPrivate::setLayerScrollPosition): + +2012-08-30 Hanna Ma <Hanma@rim.com> + + [BlackBerry] node search does not work with elements on touch start listener + https://bugs.webkit.org/show_bug.cgi?id=95252 + + Reviewed by Antonio Gomes. + + Fix the node search function of web insepctor on elements with touch start listener. + Add methods from webPage to check if the node search functionality is enabled before handling touch events. + PR194107 + + * Api/WebPage.cpp: + (BlackBerry::WebKit::WebPage::touchEvent): + +2012-08-30 Arvid Nilsson <anilsson@rim.com> + + [BlackBerry] One shot drawing sync flag never cleared when there's no layers + https://bugs.webkit.org/show_bug.cgi?id=95447 + + Reviewed by Antonio Gomes. + + PR 199866 + When we remove the layers, WebKit could tell us we need a one shot + drawing sync to repaint the BackingStore with the content that was + previously drawn by layers. We also sometimes set the one shot drawing + sync flag manually. + + We would bail from commit if there were no layers and not actually + perform the osds, so it left the osds flag set forever and the + situation prevails, because nobody will ever clear the osds flag. + + The BackingStore surrenders the responsibility of blitting to the AC + commit mechanism when a one shot drawing sync is pending, because we + want the operations render, commit and blit to happen in the correct + order with no intermediate blits. + + So, no commit means no blit, and the result of regular rendering did + not show up on screen. + + Fixed by not bailing from commit if there's no layers, instead clearing + the "needs commit" and osds flags and performing a blit. + + Reviewed internally by Andrew Lo. + + * Api/WebPage.cpp: + (BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded): + +2012-08-30 Gyuyoung Kim <gyuyoung.kim@samsung.com> + + Use ASCIILiteral for DEFINE_STATIC_LOCAL string + https://bugs.webkit.org/show_bug.cgi?id=95420 + + Reviewed by Benjamin Poulain. + + As recommended by http://trac.webkit.org/wiki/EfficientStrings, + WebKit needs to use ASCIILiteral for the string of DEFINE_STATIC_LOCAL. + + * Api/WebSettings.cpp: + (WebKit): + +2012-08-29 Nima Ghanavatian <nghanavatian@rim.com> + + [BlackBerry] Do not use the shadow tree when retrieving the underlying element for FatFinger. + https://bugs.webkit.org/show_bug.cgi?id=95372 + + By using the shadow tree we were getting a mismatch between elements of the + current element under focus and the one return to us from FatFingers. + Passing ShadowContentNotAllowed to get the right handle. + + Reviewed by Antonio Gomes. + + * WebKitSupport/TouchEventHandler.cpp: + (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint): + +2012-08-29 Robin Cao <robin.cao@torchmobile.com.cn> + + [BlackBerry] Move the handling of UserMedia requests to the client + https://bugs.webkit.org/show_bug.cgi?id=95317 + PR #197283 + + Reviewed by George Staikos. + + Internally reviewed by George Staikos. + + Move the logic for user media requests handling to the client, as it requires + inputs from users. Also adds a origin field to WebUserMediaRequest. + + * Api/WebPageClient.h: + (Platform): + * WebCoreSupport/UserMediaClientImpl.cpp: + (WebCore::UserMediaClientImpl::UserMediaClientImpl): + (WebCore::UserMediaClientImpl::~UserMediaClientImpl): + (WebCore::UserMediaClientImpl::requestUserMedia): + (WebCore::UserMediaClientImpl::cancelUserMediaRequest): + * WebCoreSupport/UserMediaClientImpl.h: + (UserMediaClientImpl): + +2012-08-29 Antonio Gomes <agomes@rim.com> + + [BlackBerry] Replace blackberry specific HitTestRequest::FingerUp by TouchEvent + Release + https://bugs.webkit.org/show_bug.cgi?id=95383 + + Reviewed by Rob Buis. + + * WebKitSupport/TouchEventHandler.cpp: + (BlackBerry::WebKit::TouchEventHandler::touchEventCancel): + +2012-08-29 Rob Buis <rbuis@rim.com> + + [BlackBerry] Adjust wtf include header style + https://bugs.webkit.org/show_bug.cgi?id=95368 + + Reviewed by Yong Li. + + Switch to #include <wtf/...> like the other ports. + + * Api/BlackBerryGlobal.cpp: + * Api/WebPage.cpp: + * WebCoreSupport/ChromeClientBlackBerry.cpp: + * WebCoreSupport/GeolocationControllerClientBlackBerry.h: + * WebCoreSupport/SelectPopupClient.h: + * WebKitSupport/AboutData.cpp: + * WebKitSupport/DOMSupport.cpp: + * WebKitSupport/GLES2Context.cpp: + * WebKitSupport/InPageSearchManager.h: + * WebKitSupport/InputHandler.cpp: + +2012-08-29 Jacky Jiang <zhajiang@rim.com> + + [BlackBerry] Remove unused tapGesture in WebPage.cpp + https://bugs.webkit.org/show_bug.cgi?id=95357 + + Reviewed by Rob Buis. + + Remove unused variable tapGesture in WebPage.cpp. + Internally reviewed by Gen Mak. + + * Api/WebPage.cpp: + (BlackBerry::WebKit::WebPage::touchEvent): + +2012-08-28 Antonio Gomes <agomes@rim.com> + + [BlackBerry] crash while trying to scroll any inner frame + https://bugs.webkit.org/show_bug.cgi?id=95287 + PR #198510 + + Reviewed by George Staikos. + + Set the starting point of scrolling (slow path only still) + for inner frames. It was left over as set to 0 by r126474. + + In practice, patch fixes a crash on gmail.com desktop edition. + + * WebKitSupport/InRegionScrollableArea.cpp: + (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea): + +2012-08-28 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r126914. + http://trac.webkit.org/changeset/126914 + https://bugs.webkit.org/show_bug.cgi?id=95239 + + it breaks everything and fixes nothing (Requested by pizlo on + #webkit). + + * Api/BackingStore.cpp: + (BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect): + (BlackBerry::WebKit::BackingStorePrivate::visibleTilesRect): + (BlackBerry::WebKit::BackingStorePrivate::resetTiles): + (BlackBerry::WebKit::BackingStorePrivate::updateTiles): + (BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion): + (BlackBerry::WebKit::BackingStorePrivate::mapFromTransformedContentsToTiles): + * WebCoreSupport/NotificationPresenterImpl.cpp: + (WebCore::NotificationPresenterImpl::cancel): + (WebCore::NotificationPresenterImpl::onPermission): + (WebCore::NotificationPresenterImpl::notificationClicked): + * WebCoreSupport/UserMediaClientImpl.cpp: + (WebCore::UserMediaClientImpl::cancelUserMediaRequest): + * WebKitSupport/AboutData.cpp: + (BlackBerry::WebKit::dumpJSCTypeCountSetToTableHTML): + * WebKitSupport/FrameLayers.cpp: + (BlackBerry::WebKit::FrameLayers::removeLayerByFrame): + (BlackBerry::WebKit::FrameLayers::commitOnWebKitThread): + (BlackBerry::WebKit::FrameLayers::calculateRootLayer): + +2012-08-28 Nima Ghanavatian <nghanavatian@rim.com> + + [BlackBerry] Spellcheck should be enabled if undefined in content. + https://bugs.webkit.org/show_bug.cgi?id=95139 + + Currently we only enable spellcheck if it is defined as such in + the web content explicitly. + Making this change to enable by default, and only turn off if it is + explicitly set, or if we expect the field to be a username, email or + url. + + Internally reviewed by Mike Fenton. + + Reviewed by Rob Buis. + + * WebKitSupport/InputHandler.cpp: + (BlackBerry::WebKit::InputHandler::requestCheckingOfString): + (BlackBerry::WebKit::InputHandler::setElementFocused): + (BlackBerry::WebKit::InputHandler::unlockSequenceMap): + (WebKit): + (BlackBerry::WebKit::InputHandler::shouldSpellCheckElement): + * WebKitSupport/InputHandler.h: + (InputHandler): + +2012-08-28 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org> + + Rename first/second to key/value in HashMap iterators + https://bugs.webkit.org/show_bug.cgi?id=82784 + + Reviewed by Eric Seidel. + + * Api/BackingStore.cpp: + (BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect): + (BlackBerry::WebKit::BackingStorePrivate::visibleTilesRect): + (BlackBerry::WebKit::BackingStorePrivate::resetTiles): + (BlackBerry::WebKit::BackingStorePrivate::updateTiles): + (BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion): + (BlackBerry::WebKit::BackingStorePrivate::mapFromTransformedContentsToTiles): + * WebCoreSupport/NotificationPresenterImpl.cpp: + (WebCore::NotificationPresenterImpl::cancel): + (WebCore::NotificationPresenterImpl::onPermission): + (WebCore::NotificationPresenterImpl::notificationClicked): + * WebKitSupport/AboutData.cpp: + (BlackBerry::WebKit::dumpJSCTypeCountSetToTableHTML): + * WebKitSupport/FrameLayers.cpp: + (BlackBerry::WebKit::FrameLayers::removeLayerByFrame): + (BlackBerry::WebKit::FrameLayers::commitOnWebKitThread): + (BlackBerry::WebKit::FrameLayers::calculateRootLayer): + * WebCoreSupport/UserMediaClientImpl.cpp: + (WebCore::UserMediaClientImpl::cancelUserMediaRequest): + +2012-08-28 Nima Ghanavatian <nghanavatian@rim.com> + + [BlackBerry] Range boundaries should use endOfBlock instead of endOfLine. + https://bugs.webkit.org/show_bug.cgi?id=95135 + + The original implementation used nextLinePosition to iterate + through the field from the start of each line, and was bounded in + comparison to the endOfLine. This works fine as long as there aren't any + empty lines between paragraphs of text, since these will have + startOfLine == endOfLine and break out. + + Also, protect map access with a mutex in case we get a response + before updating the map. Further, we should check the Range pointer + before using it, since its not guaranteed to be valid. + + Internally reviewed by Mike Fenton. + + Reviewed by Antonio Gomes. + + * WebKitSupport/InputHandler.cpp: + (BlackBerry::WebKit::InputHandler::spellCheckBlock): + +2012-08-28 Andrew Lo <anlo@rim.com> + + [BlackBerry] One shot drawing synchronization broken + https://bugs.webkit.org/show_bug.cgi?id=95179 + + Reviewed by Antonio Gomes. + Internally reviewed by Arvid Nilsson. + + Make sure no backing store blits happen during one shot drawing + synchronization. + Since we always blit during commit now, make sure we don't blit if + we commit after a render. + We no longer need a deferred blit since we don't commit during renderContents + now. Instead, we only commit & blit once after a full render job. + + * Api/BackingStore.cpp: + (BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate): + (BlackBerry::WebKit::BackingStorePrivate::repaint): + (BlackBerry::WebKit::BackingStorePrivate::slowScroll): + (BlackBerry::WebKit::BackingStorePrivate::renderJob): + (BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents): + (BlackBerry::WebKit::BackingStorePrivate::blitContents): + (BlackBerry::WebKit::BackingStorePrivate::renderContents): + (WebKit): + (BlackBerry::WebKit::BackingStorePrivate::drawAndBlendLayersForDirectRendering): + (BlackBerry::WebKit::BackingStorePrivate::didRenderContent): + * Api/BackingStore_p.h: + (BackingStorePrivate): + * Api/WebPage.cpp: + (WebKit): + (BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired): + * Api/WebPage_p.h: + (WebPagePrivate): + * WebKitSupport/RenderQueue.cpp: + (BlackBerry::WebKit::RenderQueue::renderAllCurrentRegularRenderJobs): + (BlackBerry::WebKit::RenderQueue::renderRegularRenderJob): + (BlackBerry::WebKit::RenderQueue::visibleScrollJobsCompleted): + +2012-08-28 Parth Patel <parpatel@rim.com> + + [BlackBerry] Removing unnecessary include of Class BlackBerryPlatformClient + https://bugs.webkit.org/show_bug.cgi?id=95113 + + Reviewed by Kentaro Hara. + + Refactoring has lead to relocation of many or all methods from Class + BlackBerryPlatformClient to other classes. Some files include + BlackBerryPlatformClient but does not use its instance thus these + includes has to be removed. + + * Api/BackingStore.cpp: + +2012-08-28 Andy Chen <andchen@rim.com> + + [BlackBerry] UpdateViewport uses wrong size for frameView + https://bugs.webkit.org/show_bug.cgi?id=95138 + + Reviewed by Antonio Gomes. + Internally reviewed by Jakob Petsovits. + + Use actual visible size instead of screen size when updating viewport size, + otherwise, frameView size would be too big. + + * Api/WebPage.cpp: + (BlackBerry::WebKit::WebPagePrivate::updateViewportSize): + +2012-08-28 Andy Chen <andchen@rim.com> + + [BlackBerry] Pseudo class "active" is broken + https://bugs.webkit.org/show_bug.cgi?id=95142 + + Reviewed by Antonio Gomes. + + Check if an element is affected by active rule before cancelling + the touch event. + PR 198544. + + * WebKitSupport/TouchEventHandler.cpp: + (BlackBerry::WebKit::TouchEventHandler::touchEventCancel): + +2012-08-27 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r126836. + http://trac.webkit.org/changeset/126836 + https://bugs.webkit.org/show_bug.cgi?id=95163 + + Broke all Apple ports, EFL, and Qt. (Requested by tkent on + #webkit). + + * Api/BackingStore.cpp: + (BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect): + (BlackBerry::WebKit::BackingStorePrivate::visibleTilesRect): + (BlackBerry::WebKit::BackingStorePrivate::resetTiles): + (BlackBerry::WebKit::BackingStorePrivate::updateTiles): + (BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion): + (BlackBerry::WebKit::BackingStorePrivate::mapFromTransformedContentsToTiles): + * WebCoreSupport/NotificationPresenterImpl.cpp: + (WebCore::NotificationPresenterImpl::cancel): + (WebCore::NotificationPresenterImpl::onPermission): + (WebCore::NotificationPresenterImpl::notificationClicked): + * WebKitSupport/AboutData.cpp: + (BlackBerry::WebKit::dumpJSCTypeCountSetToTableHTML): + * WebKitSupport/FrameLayers.cpp: + (BlackBerry::WebKit::FrameLayers::removeLayerByFrame): + (BlackBerry::WebKit::FrameLayers::commitOnWebKitThread): + (BlackBerry::WebKit::FrameLayers::calculateRootLayer): + +2012-08-27 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org> + + Rename first/second to key/value in HashMap iterators + https://bugs.webkit.org/show_bug.cgi?id=82784 + + Reviewed by Eric Seidel. + + * Api/BackingStore.cpp: + (BlackBerry::WebKit::BackingStorePrivate::setBackingStoreRect): + (BlackBerry::WebKit::BackingStorePrivate::visibleTilesRect): + (BlackBerry::WebKit::BackingStorePrivate::resetTiles): + (BlackBerry::WebKit::BackingStorePrivate::updateTiles): + (BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion): + (BlackBerry::WebKit::BackingStorePrivate::mapFromTransformedContentsToTiles): + * WebCoreSupport/NotificationPresenterImpl.cpp: + (WebCore::NotificationPresenterImpl::cancel): + (WebCore::NotificationPresenterImpl::onPermission): + (WebCore::NotificationPresenterImpl::notificationClicked): + * WebKitSupport/AboutData.cpp: + (BlackBerry::WebKit::dumpJSCTypeCountSetToTableHTML): + * WebKitSupport/FrameLayers.cpp: + (BlackBerry::WebKit::FrameLayers::removeLayerByFrame): + (BlackBerry::WebKit::FrameLayers::commitOnWebKitThread): + (BlackBerry::WebKit::FrameLayers::calculateRootLayer): + +2012-08-27 Sheriff Bot <webkit.review.bot@gmail.com> + + Unreviewed, rolling out r126772. + http://trac.webkit.org/changeset/126772 + https://bugs.webkit.org/show_bug.cgi?id=95137 + + "This change breaks news.qq.com" (Requested by leoyang on + #webkit). + + * Api/WebPage.cpp: + (BlackBerry::WebKit::WebPagePrivate::fixedLayoutSize): + +2012-08-27 Leo Yang <leoyang@rim.com> + + [BlackBerry] Not using absoluteVisibleOverSize when rotating + https://bugs.webkit.org/show_bug.cgi?id=95092 + PR #190469 + + Reviewed by Antonio Gomes. + Reviewed internally by Arvid Nilsson. + + When we are rotating don't count absolute overflow visible size + into fixed layout size because we are in a transient state. The + absolute overflow visible size remains old size during rotation. + + * Api/WebPage.cpp: + (BlackBerry::WebKit::WebPagePrivate::fixedLayoutSize): + +2012-08-25 Antonio Gomes <agomes@rim.com> + + [BlackBerry] Remove the 'in region scrollable starting node' concept from InRegionScroller + https://bugs.webkit.org/show_bug.cgi?id=95020 + + Reviewed by Rob Buis. + + 'In-region start scrolling node' is an obsolete concept, and we can remove it + in favor of using the information from the cached layers. + + * Api/InRegionScroller.cpp: + (WebKit): + (BlackBerry::WebKit::InRegionScrollerPrivate::reset): Adjusted as it used to clear + the cached 'node'. + (BlackBerry::WebKit::InRegionScrollerPrivate::isActive): Added method to be + checked directly instead of only null-checking the previously cached 'node'. + (BlackBerry::WebKit::InRegionScrollerPrivate::clearDocumentData): New method to + clear the cached resources if its document is done. + (BlackBerry::WebKit::InRegionScrollerPrivate::pushBackInRegionScrollable): Adjusted + to not care about the cached 'node' anymore. + * Api/InRegionScroller_p.h: + (InRegionScrollerPrivate): + * Api/WebPage.cpp: + (BlackBerry::WebKit::WebPagePrivate::notifyInRegionScrollStopped): Check ::isActive instead + of ::hasNode, since the later is gone. + (BlackBerry::WebKit::WebPagePrivate::enqueueRenderingOfClippedContentOfScrollableAreaAfterInRegionScrolling): + Changed the method signature, given that we do have a cached 'node' to pass in as parameter anymore. + (BlackBerry::WebKit::WebPagePrivate::clearDocumentData): Delegate all the related work to InRegionScroller. + * Api/WebPage_p.h: + (WebPagePrivate): + * WebKitSupport/TouchEventHandler.cpp: + (BlackBerry::WebKit::TouchEventHandler::drawTapHighlight): +. +2012-08-25 Antonio Gomes <agomes@rim.com> + + BlackBerry] Shrink the in-region nested scrollable list as soon as we can + https://bugs.webkit.org/show_bug.cgi?id=95019 + + Reviewed by Rob Buis. + + We cache all possible nested scrollable in-region layers given a point. + It is up to the client to pick a view, based on the scroll position and limits + of each layer, and on the direction user swipes its finger. + From the point we pick a view on, we stick with it, and any other + possibly cached layer can be uncached, as it won't be needed. + Patch provides a simple solution to that. + + * Api/InRegionScroller.cpp: + (BlackBerry::WebKit::InRegionScrollerPrivate::InRegionScrollerPrivate): + (BlackBerry::WebKit::InRegionScrollerPrivate::reset): + (BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionWebKitThread): + (BlackBerry::WebKit::InRegionScrollerPrivate::calculateActiveAndShrinkCachedScrollableAreas): + (WebKit): + (BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint): + * Api/InRegionScroller_p.h: + (InRegionScrollerPrivate): + +2012-08-25 Antonio Gomes <agomes@rim.com> + + For convenience, make RenderLayer::enclosingElement a public method. + https://bugs.webkit.org/show_bug.cgi?id=95018 + + Reviewed by George Staikos. + + Make use of the new public RenderLayer::enclosingElement method and + remove duplicated code. + + * WebKitSupport/InRegionScrollableArea.cpp: + (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea): + +2012-08-27 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> + + Rename RegisterProtocolHandler API to NavigatorContentUtils + https://bugs.webkit.org/show_bug.cgi?id=94920 + + Reviewed by Adam Barth. + + Renaming whatever RegisterProtocolHandler-prefixed to NavigatorContentUtils-prefixed. + + * WebCoreSupport/AboutDataEnableFeatures.in: + * WebCoreSupport/ChromeClientBlackBerry.cpp: + (WebCore): + (WebCore::ChromeClientBlackBerry::registerProtocolHandler): + * WebCoreSupport/ChromeClientBlackBerry.h: + (ChromeClientBlackBerry): + +2012-08-26 Arvid Nilsson <anilsson@rim.com> + + [BlackBerry] ASSERT failed in WebPagePrivate::commitRootLayerIfNeeded() + https://bugs.webkit.org/show_bug.cgi?id=94921 + + PR 104676 + As visibility changed due to WebPage::setVisible(true), + resumeRootLayerCommit() would call commitRootLayerIfNeeded(), without + layouting or rendering. If a one shot drawing sync was pending at this + time, it would cause the condition + ASSERT(!needsOneShotDrawingSynchronization()) to fail. + + The comment immediately before the assert states that "In case of one + shot drawing synchronization, you should first layoutIfNeeded, render, + then commit and draw the layers". However, resumeRootLayerCommit() did + no such thing. + + Fixed by removing the call to commitRootLayerIfNeeded() from + resumeRootLayerCommit(), because the latter is only called in a code + path where we're going to layout, render and then commit anyway. These + operations will be performed from resumeBackingStore() which is called + at the end of setVisible(). + + Reviewed by George Staikos. + + * Api/WebPage.cpp: + (BlackBerry::WebKit::WebPagePrivate::resumeRootLayerCommit): + +2012-08-24 Adam Treat <atreat@rim.com> + + [BlackBerry] Web pages are zoomed out to much on initial load + https://bugs.webkit.org/show_bug.cgi?id=94830 + + The previous patch caused a slight regression to the calculation we do + for the default splitting factor in the render queue. The default value + we use to represent the max area should be the tile size. This was true + with the old calculation of default max layout width since it was the + screen size. The fix is to be explicit and use the tile size directly. + + Reviewed by George Staikos. + + * WebKitSupport/RenderQueue.cpp: + (BlackBerry::WebKit::RenderQueue::splittingFactor): + +2012-08-24 Parth Patel <parpatel@rim.com> + + [BlackBerry] Changes resulting from moving network related methods + from platform client to platform settings. + https://bugs.webkit.org/show_bug.cgi?id=94963 + + Reviewed by Yong Li. + + Changes in response to Network methods moved from + class BlackBerryPlatformClient to class BlackBerryPlatformSettings + in platform repository. + + * WebKitSupport/AboutData.cpp: + (BlackBerry::WebKit::cachePage): + +2012-08-24 Liam Quinn <lquinn@rim.com> + + [BlackBerry] Debug assertion fires in BackingStorePrivate::renderJob() + https://bugs.webkit.org/show_bug.cgi?id=94960 + + Reviewed by Adam Treat. + + Change the assertion into an early return as recommended by Adam Treat. + + * Api/BackingStore.cpp: + (BlackBerry::WebKit::BackingStorePrivate::renderJob): + +2012-08-24 Andrew Lo <anlo@rim.com> + + [BlackBerry] Animation & UI lag when rendering + https://bugs.webkit.org/show_bug.cgi?id=94943 + + Reviewed by Rob Buis. + + Schedule a backing store blit & composite when commiting root layer. + This results in compositing not having to wait until after a long render + operation, increasing responsiveness & fixing animations which skip to + the last frame due to lag. + + This can cause a blit during a "one shot drawing synchronization", which is + a render & commit on the AC layers, which may result in flashing. + However, this can happen in other situations as well, and we feel that + the responsiveness, reduced lag, and smoothness of animations is + more important. + + Internal PR194209 + Internally reviewed by: George Staikos. + + * Api/WebPage.cpp: + (BlackBerry::WebKit::WebPagePrivate::commitRootLayer): + +2012-08-24 Parth Patel <parpatel@rim.com> + + [BlackBerry] Changes resulting from moving application directory methods from platform client to platform settings. + https://bugs.webkit.org/show_bug.cgi?id=94249 + + Reviewed by Rob Buis. + + PR# 170160 + Changes in response to Application Directory methods moved from + Class BlackBerryPlatformClient to BlackBerryPlatformSettings in + platform respository since these methods are more appropriate in + class BlackBerryPlatformSettings. + + * WebCoreSupport/IconDatabaseClientBlackBerry.cpp: + (WebCore::IconDatabaseClientBlackBerry::initIconDatabase): + +2012-08-24 Antonio Gomes <agomes@rim.com> + + [BlackBerry] Touch cancel can cause huge and needless invalidations + https://bugs.webkit.org/show_bug.cgi?id=94938 + PR #198051 + + Reviewed by George Staikos. + Internally reviewed by Gen Mak. + + In order to remove the possible hover effect on touch_cancel, we always + invalidate the node under the fat finger, being the fat finger valid or not. + + Point is: having a valid fat finger node does not mean the original touch + position was actually adjust for clicking or that the fat finger is actually + valid. We set the fat finger node to be the result of the point-based hit-test + regardless if it is a click target or not (in order to make our mouse-move + machinery to work). + + We should can less aggressively invalidate the fat finger node, since it can + be rather an expensive call (longer than 1s in the worst scenario). + + * WebKitSupport/TouchEventHandler.cpp: + (BlackBerry::WebKit::TouchEventHandler::touchEventCancel): + +2012-08-24 Arvid Nilsson <anilsson@rim.com> + + [BlackBerry] Add WebPage API to reset block zoom + https://bugs.webkit.org/show_bug.cgi?id=94863 + + PR 187478 + This is an alternative to WebPage::blockZoomAnimationFinished() when + it's desirable to avoid rerendering of the whole web page at the end + of block zoom. This is the case when the planned "incremental zoom + factor" is used instead of zoomAboutPoint and it's relatives. + + Ideally, the block zoom algorithm would be clever enough not to need + a reset or any form of callback when the animation finishes, but that + requires the implementation of said incremental zoom factor, which is + not done yet. + + Reviewed by Antonio Gomes. + + * Api/WebPage.cpp: + (BlackBerry::WebKit::WebPage::resetBlockZoom): + (WebKit): + * Api/WebPage.h: + 2012-08-23 Antonio Gomes <agomes@rim.com> [BlackBerry] Obsolete the in-region scroll codepath prior to BB10's |