Fix valgrind warning about uninitialized access

A default cache-entry has a null String and an uninitialized key. We
should therefore only try to use the key if the String is not null.

Change-Id: Icd6819b96b9b650305cf0611b6b2978c07dc9196
Reviewed-by: Michael Bruning <michael.bruning@digia.com>

1 files changed, 3 insertions, 3 deletions

diff --git a/Source/JavaScriptCore/runtime/NumericStrings.h b/Source/JavaScriptCore/runtime/NumericStrings.h
index 4cd92fc1f..68bfbd06a 100644
--- a/Source/JavaScriptCore/runtime/NumericStrings.h
+++ b/Source/JavaScriptCore/runtime/NumericStrings.h
@@ -37,7 +37,7 @@ namespace JSC {
         ALWAYS_INLINE String add(double d)
         {
             CacheEntry<double>& entry = lookup(d);
-            if (d == entry.key && !entry.value.isNull())
+            if (!entry.value.isNull() && d == entry.key)
                 return entry.value;
             entry.key = d;
             entry.value = String::numberToStringECMAScript(d);
@@ -49,7 +49,7 @@ namespace JSC {
             if (static_cast<unsigned>(i) < cacheSize)
                 return lookupSmallString(static_cast<unsigned>(i));
             CacheEntry<int>& entry = lookup(i);
-            if (i == entry.key && !entry.value.isNull())
+            if (!entry.value.isNull() && i == entry.key)
                 return entry.value;
             entry.key = i;
             entry.value = String::number(i);
@@ -61,7 +61,7 @@ namespace JSC {
             if (i < cacheSize)
                 return lookupSmallString(static_cast<unsigned>(i));
             CacheEntry<unsigned>& entry = lookup(i);
-            if (i == entry.key && !entry.value.isNull())
+            if (!entry.value.isNull() && i == entry.key)
                 return entry.value;
             entry.key = i;
             entry.value = String::number(i);