1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
|
# Copyright 2016 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
def CheckChangeOnUpload(input_api, output_api):
return _CommonChecks(input_api, output_api)
def CheckChangeOnCommit(input_api, output_api):
return _CommonChecks(input_api, output_api)
def _CheckForTranslations(input_api, output_api):
shared_keywords = ['i18n(']
html_keywords = shared_keywords + ['$118n{']
js_keywords = shared_keywords + ['I18nBehavior', 'loadTimeData.get']
errors = []
for f in input_api.AffectedFiles():
local_path = f.LocalPath()
# Allow translation in i18n_behavior.js.
if local_path.endswith('i18n_behavior.js'):
continue
# Allow translation in the cr_components directory.
if 'cr_components' in local_path:
continue
keywords = None
if local_path.endswith('.js'):
keywords = js_keywords
elif local_path.endswith('.html'):
keywords = html_keywords
if not keywords:
continue
for lnum, line in f.ChangedContents():
if any(line for keyword in keywords if keyword in line):
errors.append("%s:%d\n%s" % (f.LocalPath(), lnum, line))
if not errors:
return []
return [output_api.PresubmitError("\n".join(errors) + """
Don't embed translations directly in shared UI code. Instead, inject your
translation from the place using the shared code. For an example: see
<cr-dialog>#closeText (http://bit.ly/2eLEsqh).""")]
def _CheckSvgsOptimized(input_api, output_api):
results = []
try:
import sys
old_sys_path = sys.path[:]
cwd = input_api.PresubmitLocalPath()
sys.path += [input_api.os_path.join(cwd, '..', '..', '..', 'tools')]
from resources import svgo_presubmit
results += svgo_presubmit.CheckOptimized(input_api, output_api)
finally:
sys.path = old_sys_path
return results
def _CheckWebDevStyle(input_api, output_api):
results = []
try:
import sys
old_sys_path = sys.path[:]
cwd = input_api.PresubmitLocalPath()
sys.path += [input_api.os_path.join(cwd, '..', '..', '..', 'tools')]
from web_dev_style import presubmit_support
IGNORELIST = ['ui/webui/resources/js/jstemplate_compiled.js']
file_filter = lambda f: f.LocalPath() not in IGNORELIST
results += presubmit_support.CheckStyle(input_api, output_api, file_filter)
finally:
sys.path = old_sys_path
return results
def _CheckJsModulizer(input_api, output_api):
affected = input_api.AffectedFiles()
affected_files = [input_api.os_path.basename(f.LocalPath()) for f in affected]
results = []
if 'js_modulizer.py' in affected_files:
presubmit_path = input_api.PresubmitLocalPath()
sources = [input_api.os_path.join('tools', 'js_modulizer_test.py')]
tests = [input_api.os_path.join(presubmit_path, s) for s in sources]
results += input_api.canned_checks.RunUnitTests(
input_api, output_api, tests)
return results
def _CheckGenerateGrd(input_api, output_api):
affected = input_api.AffectedFiles()
affected_files = [input_api.os_path.basename(f.LocalPath()) for f in affected]
results = []
if 'generate_grd.py' in affected_files:
presubmit_path = input_api.PresubmitLocalPath()
sources = [input_api.os_path.join('tools', 'generate_grd_test.py')]
tests = [input_api.os_path.join(presubmit_path, s) for s in sources]
results += input_api.canned_checks.RunUnitTests(
input_api, output_api, tests)
return results
def _CommonChecks(input_api, output_api):
results = []
results += _CheckForTranslations(input_api, output_api)
results += _CheckSvgsOptimized(input_api, output_api)
results += _CheckWebDevStyle(input_api, output_api)
results += _CheckJsModulizer(input_api, output_api)
results += _CheckGenerateGrd(input_api, output_api)
results += input_api.canned_checks.CheckPatchFormatted(input_api, output_api,
check_js=True)
return results
|
