summaryrefslogtreecommitdiff
path: root/chromium/ui/latency/skipped_frame_tracker_unittest.cc
blob: 06812c5c2228498961b1e2e81ae54f9b8ce119fc (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
// Copyright 2018 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include "ui/latency/skipped_frame_tracker.h"

#include "base/bind.h"
#include "testing/gtest/include/gtest/gtest.h"

namespace ui {
namespace {

// TestClient observes calls to AddFrameProduced so tests can verify
// those calls.
class TestClient : public SkippedFrameTracker::Client {
 public:
  TestClient() = default;
  ~TestClient() override = default;

  void AddFrameProduced(base::TimeTicks source_timestamp,
                        base::TimeDelta amount_produced,
                        base::TimeDelta amount_skipped) override {
    source_timestamp_ = source_timestamp.since_origin().InMicroseconds();
    amount_produced_ = amount_produced.InMicroseconds();
    amount_skipped_ = amount_skipped.InMicroseconds();
    call_count_++;
  }

  int GetAndResetCallCount() {
    int result = call_count_;
    call_count_ = 0;
    return result;
  }

  int call_count_ = 0;
  int source_timestamp_ = 0;
  int amount_produced_ = 0;
  int amount_skipped_ = 0;
};

// TestSkippedFrameTracker let's us verify the active state from tests.
class TestSkippedFrameTracker : public SkippedFrameTracker {
 public:
  TestSkippedFrameTracker(Client* client) : SkippedFrameTracker(client) {}

  bool IsActive() {
    switch (active_state_) {
      case ActiveState::Idle:
        return false;
      case ActiveState::WillProduce:
      case ActiveState::WillProduceFirst:
      case ActiveState::WasActive:
        break;
    }
    return true;
  }
};

// SkippedFrameTrackerTest is the test fixture used by all tests in this file.
class SkippedFrameTrackerTest : public testing::Test {
 public:
  SkippedFrameTrackerTest() : tracker_(&client_) {}

  ::testing::AssertionResult BeginFrame(int timestamp, int interval) {
    int call_count = client_.call_count_;
    tracker_.BeginFrame(
        base::TimeTicks() + base::TimeDelta::FromMicroseconds(timestamp),
        base::TimeDelta::FromMicroseconds(interval));
    return MaybeCallCountFailure(call_count);
  }

  ::testing::AssertionResult FinishFrame() {
    int call_count = client_.call_count_;
    tracker_.FinishFrame();
    return MaybeCallCountFailure(call_count);
  }

  ::testing::AssertionResult WillNotProduceFrame() {
    int call_count = client_.call_count_;
    tracker_.WillNotProduceFrame();
    return MaybeCallCountFailure(call_count);
  }

  ::testing::AssertionResult WillProduceFrame() {
    int call_count = client_.call_count_;
    tracker_.WillProduceFrame();
    return MaybeCallCountFailure(call_count);
  }

  ::testing::AssertionResult DidProduceFrame() {
    int call_count = client_.call_count_;
    tracker_.DidProduceFrame();
    return MaybeCallCountFailure(call_count);
  }

 protected:
  static ::testing::AssertionResult MaybeCallCountFailure(int count) {
    if (count == 0)
      return ::testing::AssertionSuccess();
    return ::testing::AssertionFailure()
           << count << " unverified calls to AddFrameProduced.";
  }

  TestClient client_;
  TestSkippedFrameTracker tracker_;
};

#define VERIFY_ADD_PRODUCED_CALLED(timestamp, produced, skipped) \
  EXPECT_EQ(1, client_.GetAndResetCallCount());                  \
  EXPECT_EQ(timestamp, client_.source_timestamp_);               \
  EXPECT_EQ(produced, client_.amount_produced_);                 \
  EXPECT_EQ(skipped, client_.amount_skipped_);

// Producing a frame entirely within a BeginFrame works.
TEST_F(SkippedFrameTrackerTest, NoSkips_BeginThenWill) {
  EXPECT_TRUE(BeginFrame(100, 10));
  EXPECT_TRUE(WillProduceFrame());
  EXPECT_TRUE(DidProduceFrame());
  VERIFY_ADD_PRODUCED_CALLED(100, 10, 0);
  EXPECT_TRUE(FinishFrame());
}

// Starting to produce a frame before receiving the BeginFrame works.
TEST_F(SkippedFrameTrackerTest, NoSkips_WillThenBegin) {
  EXPECT_TRUE(WillProduceFrame());
  EXPECT_TRUE(BeginFrame(100, 10));
  EXPECT_TRUE(DidProduceFrame());
  VERIFY_ADD_PRODUCED_CALLED(100, 10, 0);
  EXPECT_TRUE(FinishFrame());
}

// A (WillProduceFrame, DidProduceFrame) that spans multiple BeginFrames
// is registered properly.
TEST_F(SkippedFrameTrackerTest, Skips_ProducedOverMultipleBeginFrames) {
  EXPECT_TRUE(BeginFrame(100, 10));
  EXPECT_TRUE(WillProduceFrame());
  EXPECT_TRUE(FinishFrame());
  EXPECT_TRUE(BeginFrame(110, 10));
  EXPECT_TRUE(DidProduceFrame());
  VERIFY_ADD_PRODUCED_CALLED(110, 10, 10);
  EXPECT_TRUE(FinishFrame());
}

// An unexpected jump in the frame timestamp, compared to the interval,
// is registered as skipped time.
TEST_F(SkippedFrameTrackerTest, Skips_DroppedBeginFrames) {
  EXPECT_TRUE(BeginFrame(100, 10));
  EXPECT_TRUE(WillProduceFrame());
  EXPECT_TRUE(DidProduceFrame());
  VERIFY_ADD_PRODUCED_CALLED(100, 10, 0);
  EXPECT_TRUE(FinishFrame());

  EXPECT_TRUE(BeginFrame(200, 10));
  EXPECT_TRUE(WillProduceFrame());
  EXPECT_TRUE(DidProduceFrame());
  VERIFY_ADD_PRODUCED_CALLED(200, 10, 90);
  EXPECT_TRUE(FinishFrame());
}

// Jitter just below the interval midpoint rounds down the number of dropped
// BeginFrames detected.
TEST_F(SkippedFrameTrackerTest, Skips_DroppedBeginFrames_JitterRoundsDown) {
  EXPECT_TRUE(BeginFrame(100, 10));
  EXPECT_TRUE(WillProduceFrame());
  EXPECT_TRUE(FinishFrame());
  EXPECT_TRUE(BeginFrame(114, 10));
  EXPECT_TRUE(DidProduceFrame());
  VERIFY_ADD_PRODUCED_CALLED(114, 10, 10);
  EXPECT_TRUE(FinishFrame());
}

// Jitter just above the interval midpoint rounds up the number of dropped
// BeginFrames detected.
TEST_F(SkippedFrameTrackerTest, Skips_DroppedBeginFrames_JitterRoundsUp) {
  EXPECT_TRUE(BeginFrame(100, 10));
  EXPECT_TRUE(WillProduceFrame());
  EXPECT_TRUE(FinishFrame());
  EXPECT_TRUE(BeginFrame(116, 10));
  EXPECT_TRUE(DidProduceFrame());
  VERIFY_ADD_PRODUCED_CALLED(116, 10, 20);
  EXPECT_TRUE(FinishFrame());
}

// Active, idle, then active again.
// In second active period, start to produce frame first.
TEST_F(SkippedFrameTrackerTest, NoSkips_ActiveIdleActive_WillThenBegin) {
  // Active
  EXPECT_TRUE(BeginFrame(100, 10));
  EXPECT_TRUE(WillProduceFrame());
  EXPECT_TRUE(DidProduceFrame());
  VERIFY_ADD_PRODUCED_CALLED(100, 10, 0);
  EXPECT_TRUE(FinishFrame());

  // Idle
  EXPECT_TRUE(BeginFrame(110, 10));
  EXPECT_TRUE(FinishFrame());

  // Active
  EXPECT_TRUE(WillProduceFrame());
  EXPECT_TRUE(BeginFrame(120, 10));
  EXPECT_TRUE(DidProduceFrame());
  VERIFY_ADD_PRODUCED_CALLED(120, 10, 0);
  EXPECT_TRUE(FinishFrame());
}

// Active, idle, then active again.
// In second active period, BeginFrame first.
TEST_F(SkippedFrameTrackerTest, NoSkips_ActiveIdleActive_BeginThenWill) {
  EXPECT_TRUE(BeginFrame(100, 10));
  EXPECT_TRUE(WillProduceFrame());
  EXPECT_TRUE(DidProduceFrame());
  VERIFY_ADD_PRODUCED_CALLED(100, 10, 0);
  EXPECT_TRUE(FinishFrame());
  EXPECT_TRUE(tracker_.IsActive());

  EXPECT_TRUE(BeginFrame(110, 10));
  EXPECT_TRUE(FinishFrame());
  EXPECT_FALSE(tracker_.IsActive());

  EXPECT_TRUE(BeginFrame(120, 10));
  EXPECT_TRUE(WillProduceFrame());
  EXPECT_TRUE(DidProduceFrame());
  VERIFY_ADD_PRODUCED_CALLED(120, 10, 0);
  EXPECT_TRUE(FinishFrame());
  EXPECT_TRUE(tracker_.IsActive());
}

// Active, idle, then active again.
// Dropped BeginFrames during idle period shouldn't register as skipped.
TEST_F(SkippedFrameTrackerTest, NoSkips_ActiveIdleActive_JumpInIdle) {
  EXPECT_TRUE(BeginFrame(100, 10));
  EXPECT_TRUE(WillProduceFrame());
  EXPECT_TRUE(DidProduceFrame());
  VERIFY_ADD_PRODUCED_CALLED(100, 10, 0);
  EXPECT_TRUE(FinishFrame());
  EXPECT_TRUE(tracker_.IsActive());

  EXPECT_TRUE(BeginFrame(110, 10));
  EXPECT_TRUE(FinishFrame());
  EXPECT_FALSE(tracker_.IsActive());

  EXPECT_TRUE(WillProduceFrame());
  EXPECT_TRUE(BeginFrame(200, 10));
  EXPECT_TRUE(DidProduceFrame());
  VERIFY_ADD_PRODUCED_CALLED(200, 10, 0);
  EXPECT_TRUE(FinishFrame());
  EXPECT_TRUE(tracker_.IsActive());
}

// Active, Set idle after WillProduceFrame, then active again.
TEST_F(SkippedFrameTrackerTest, WillNotProduceFrame) {
  EXPECT_TRUE(BeginFrame(100, 10));
  EXPECT_TRUE(WillProduceFrame());
  EXPECT_TRUE(DidProduceFrame());
  VERIFY_ADD_PRODUCED_CALLED(100, 10, 0);
  EXPECT_TRUE(FinishFrame());
  EXPECT_TRUE(tracker_.IsActive());

  EXPECT_TRUE(BeginFrame(110, 10));
  EXPECT_TRUE(WillNotProduceFrame());
  EXPECT_FALSE(tracker_.IsActive());

  EXPECT_TRUE(WillProduceFrame());
  EXPECT_TRUE(BeginFrame(200, 10));
  EXPECT_TRUE(DidProduceFrame());
  VERIFY_ADD_PRODUCED_CALLED(200, 10, 0);
  EXPECT_TRUE(FinishFrame());
  EXPECT_TRUE(tracker_.IsActive());
}

// Active, idle, then active again.
TEST_F(SkippedFrameTrackerTest, WillNotProduceFrame2) {
  EXPECT_TRUE(BeginFrame(100, 10));
  EXPECT_TRUE(WillProduceFrame());
  EXPECT_TRUE(DidProduceFrame());
  VERIFY_ADD_PRODUCED_CALLED(100, 10, 0);
  EXPECT_TRUE(FinishFrame());
  EXPECT_TRUE(tracker_.IsActive());

  EXPECT_TRUE(WillNotProduceFrame());
  EXPECT_FALSE(tracker_.IsActive());

  EXPECT_TRUE(WillProduceFrame());
  EXPECT_TRUE(BeginFrame(200, 10));
  EXPECT_TRUE(DidProduceFrame());
  VERIFY_ADD_PRODUCED_CALLED(200, 10, 0);
  EXPECT_TRUE(FinishFrame());
  EXPECT_TRUE(tracker_.IsActive());
}

// If frames are pulled from later in the pipeline when the source hasn't tried
// to create a new frame, it should not be recorded as a frame produced
// by the source.
TEST_F(SkippedFrameTrackerTest, PulledFramesNotRecorded) {
  EXPECT_TRUE(BeginFrame(100, 10));
  // WillProduceFrame intentionally not called here impliles
  // next call to DidProduceFrame was "pulled" not "pushed".
  EXPECT_TRUE(DidProduceFrame());
  EXPECT_TRUE(FinishFrame());

  // Even though BeginFrames might've been dropped since the pulled frame,
  // act as if we should behanve just like the produce is coming out of an
  // idle period.
  EXPECT_TRUE(WillProduceFrame());
  EXPECT_TRUE(BeginFrame(200, 10));
  EXPECT_TRUE(DidProduceFrame());
  VERIFY_ADD_PRODUCED_CALLED(200, 10, 0);
  EXPECT_TRUE(FinishFrame());
}

// Multiple calls to WillProduceFrame are legal and should behave as if only
// the first call was made.
TEST_F(SkippedFrameTrackerTest, MultipleWillProduceBeforeDidProduce) {
  EXPECT_TRUE(WillProduceFrame());
  EXPECT_TRUE(BeginFrame(100, 10));
  EXPECT_TRUE(WillProduceFrame());
  EXPECT_TRUE(WillProduceFrame());
  EXPECT_TRUE(WillProduceFrame());
  EXPECT_TRUE(WillProduceFrame());
  EXPECT_TRUE(WillProduceFrame());
  EXPECT_TRUE(WillProduceFrame());
  EXPECT_TRUE(DidProduceFrame());
  VERIFY_ADD_PRODUCED_CALLED(100, 10, 0);
  EXPECT_TRUE(FinishFrame());
}

// Frame pulled before BeginFrame doesn't count.
TEST_F(SkippedFrameTrackerTest, NoSkips_ActiveIdleActive_FramePulledBeforeBF) {
  EXPECT_TRUE(BeginFrame(100, 10));
  EXPECT_TRUE(WillProduceFrame());
  EXPECT_TRUE(DidProduceFrame());
  VERIFY_ADD_PRODUCED_CALLED(100, 10, 0);
  EXPECT_TRUE(FinishFrame());
  EXPECT_TRUE(tracker_.IsActive());

  EXPECT_TRUE(BeginFrame(110, 10));
  EXPECT_TRUE(FinishFrame());
  EXPECT_FALSE(tracker_.IsActive());

  EXPECT_TRUE(WillProduceFrame());
  // Consider frame pulled since it came before the BeginFrame.
  EXPECT_TRUE(DidProduceFrame());
  // Make sure we are immune to multiple pulled frames.
  EXPECT_TRUE(DidProduceFrame());

  EXPECT_TRUE(BeginFrame(120, 10));
  EXPECT_TRUE(DidProduceFrame());
  VERIFY_ADD_PRODUCED_CALLED(120, 10, 0);
  EXPECT_TRUE(FinishFrame());
  EXPECT_TRUE(tracker_.IsActive());
}

// Frame pulled just after a push doesn't count.
TEST_F(SkippedFrameTrackerTest, NoSkips_ActiveIdleActive_FramePulledAfterPush) {
  EXPECT_TRUE(BeginFrame(100, 10));
  EXPECT_TRUE(WillProduceFrame());
  EXPECT_TRUE(DidProduceFrame());
  VERIFY_ADD_PRODUCED_CALLED(100, 10, 0);
  EXPECT_TRUE(FinishFrame());
  EXPECT_TRUE(tracker_.IsActive());

  EXPECT_TRUE(BeginFrame(110, 10));
  EXPECT_TRUE(FinishFrame());
  EXPECT_FALSE(tracker_.IsActive());

  EXPECT_TRUE(WillProduceFrame());
  EXPECT_TRUE(BeginFrame(120, 10));
  EXPECT_TRUE(DidProduceFrame());
  VERIFY_ADD_PRODUCED_CALLED(120, 10, 0);
  // Consider frame pulled since we aleady pushed one this frame.
  EXPECT_TRUE(DidProduceFrame());
  // Make sure we are immune to multiple pulled frames.
  EXPECT_TRUE(DidProduceFrame());
  EXPECT_TRUE(FinishFrame());
  EXPECT_TRUE(tracker_.IsActive());
}

// Frame pulled while attempting to push counts.
TEST_F(SkippedFrameTrackerTest, NoSkips_ActiveIdleActive_FramePulledIsPush) {
  EXPECT_TRUE(BeginFrame(100, 10));
  EXPECT_TRUE(WillProduceFrame());
  EXPECT_TRUE(FinishFrame());
  EXPECT_TRUE(tracker_.IsActive());

  // Consider frame pushed, even if we are outside the BeginFrame, since we
  // were trying to push.
  EXPECT_TRUE(DidProduceFrame());
  VERIFY_ADD_PRODUCED_CALLED(100, 10, 0);
  // A second pulled frame shouldn't count though.
  EXPECT_TRUE(DidProduceFrame());

  EXPECT_TRUE(BeginFrame(110, 10));
  EXPECT_TRUE(FinishFrame());
  EXPECT_FALSE(tracker_.IsActive());
}

// Simulate that SetNeedsRedraw is called, then the client realized that it
// doesn't need a new BeginFrame.
TEST_F(SkippedFrameTrackerTest, NoFrameProduced) {
  EXPECT_TRUE(WillProduceFrame());
  EXPECT_TRUE(WillNotProduceFrame());

  // Since no BeginFrame is needed, number of frames produced and the number
  // of skipped frames should all be 0.
  EXPECT_EQ(0, client_.amount_produced_);
  EXPECT_EQ(0, client_.amount_skipped_);
}

}  // namespace
}  // namespace ui