blob: 9b34f9a00fdae7c5b73565f05fc49adf82e101f3 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
|
# Copyright 2019 The Chromium Authors
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
import six
# Ignore the following files from SVG optimization checks.
BLOCKLIST = [
# Ignore since it holds documentation comments.
"components/dom_distiller/core/images/dom_distiller_material_spinner.svg",
# Ignore since SVGO collapses <g> elements with their ids that are both used
# by the embedder HTML.
"chrome/browser/resources/signin/dice_web_signin_intercept/images/" +
"split_header.svg"
]
def CheckOptimized(input_api, output_api):
file_filter = lambda f: f.LocalPath().endswith('.svg') and \
f.LocalPath().replace('\\', '/') not in BLOCKLIST
svgs = input_api.AffectedFiles(file_filter=file_filter, include_deletes=False)
if not svgs:
return []
from resources import svgo
unoptimized = []
def _ToBinary(s):
if isinstance(s, six.binary_type):
return s
if isinstance(s, six.text_type):
return s.encode('utf-8')
for f in svgs:
original = b'\n'.join(_ToBinary(line) for line in f.NewContents()).strip()
output = _ToBinary(
svgo.Run(input_api.os_path,
['-o', '-', '-i', f.AbsoluteLocalPath()]).strip())
if original != output:
unoptimized.append(f.LocalPath())
if unoptimized:
instructions = 'Run tools/resources/svgo.py on these files to optimize:'
msg = '\n '.join([instructions] + unoptimized)
return [output_api.PresubmitNotifyResult(msg)]
return []
|
