1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
|
// Copyright 2021 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "extensions/browser/permissions_manager.h"
#include "base/memory/raw_ptr.h"
#include "extensions/browser/extension_prefs.h"
#include "extensions/browser/extension_registry.h"
#include "extensions/browser/extension_util.h"
#include "extensions/browser/extensions_test.h"
#include "extensions/browser/pref_types.h"
#include "extensions/common/extension_builder.h"
#include "extensions/common/extension_icon_set.h"
#include "extensions/common/extensions_client.h"
#include "extensions/common/permissions/permissions_data.h"
#include "extensions/common/url_pattern_set.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "url/origin.h"
namespace {
std::unique_ptr<KeyedService> SetTestingPermissionsManager(
content::BrowserContext* browser_context) {
return std::make_unique<extensions::PermissionsManager>(browser_context);
}
} // namespace
namespace extensions {
using UserSiteSetting = PermissionsManager::UserSiteSetting;
class PermissionsManagerUnittest : public ExtensionsTest {
public:
PermissionsManagerUnittest() = default;
~PermissionsManagerUnittest() override = default;
PermissionsManagerUnittest(const PermissionsManagerUnittest&) = delete;
PermissionsManagerUnittest& operator=(const PermissionsManagerUnittest&) =
delete;
scoped_refptr<const Extension> AddExtensionWithHostPermission(
const std::string& name,
const std::string& host_permission);
// Returns the restricted sites stored in `manager_`.
std::set<url::Origin> GetRestrictedSitesFromManager();
// Returns the permittes sites stored in `manager_`.
std::set<url::Origin> GetPermittedSitesFromManager();
// Returns the restricted sites stored in `extension_prefs_`.
const base::Value* GetRestrictedSitesFromPrefs();
// Returns the permitted sites stored in `extension_prefs_`.
const base::Value* GetPermittedSitesFromPrefs();
// Returns the restricted sites stored in `PermissionsData`.
std::set<std::string> GetRestrictedSitesFromPermissionsData();
// Returns the permitted sites stored in `PermissionsData`.
std::set<std::string> GetPermittedSitesFromPermissionsData();
protected:
// ExtensionsTest:
void SetUp() override;
// PermissionsManager being tested.
raw_ptr<PermissionsManager> manager_;
raw_ptr<ExtensionPrefs> extension_prefs_;
};
void PermissionsManagerUnittest::SetUp() {
ExtensionsTest::SetUp();
manager_ = static_cast<PermissionsManager*>(
PermissionsManager::GetFactory()->SetTestingFactoryAndUse(
browser_context(),
base::BindRepeating(&SetTestingPermissionsManager)));
extension_prefs_ = ExtensionPrefs::Get(browser_context());
}
scoped_refptr<const Extension>
PermissionsManagerUnittest::AddExtensionWithHostPermission(
const std::string& name,
const std::string& host_permission) {
scoped_refptr<const extensions::Extension> extension =
extensions::ExtensionBuilder(name)
.SetManifestVersion(3)
.SetManifestKey(
"host_permissions",
extensions::ListBuilder().Append(host_permission).Build())
.Build();
ExtensionRegistryFactory::GetForBrowserContext(browser_context())
->AddEnabled(extension);
return extension;
}
const base::Value* PermissionsManagerUnittest::GetRestrictedSitesFromPrefs() {
const base::DictionaryValue* permissions =
extension_prefs_->GetPrefAsDictionary(kUserPermissions);
return permissions->FindKey("restricted_sites");
}
const base::Value* PermissionsManagerUnittest::GetPermittedSitesFromPrefs() {
const base::DictionaryValue* permissions =
extension_prefs_->GetPrefAsDictionary(kUserPermissions);
return permissions->FindKey("permitted_sites");
}
std::set<url::Origin>
PermissionsManagerUnittest::GetRestrictedSitesFromManager() {
const PermissionsManager::UserPermissionsSettings& permissions =
manager_->GetUserPermissionsSettings();
return permissions.restricted_sites;
}
std::set<url::Origin>
PermissionsManagerUnittest::GetPermittedSitesFromManager() {
const PermissionsManager::UserPermissionsSettings& permissions =
manager_->GetUserPermissionsSettings();
return permissions.permitted_sites;
}
std::set<std::string>
PermissionsManagerUnittest::GetRestrictedSitesFromPermissionsData() {
std::set<std::string> string_patterns;
URLPatternSet patterns = PermissionsData::GetUserBlockedHosts(
util::GetBrowserContextId(browser_context()));
for (const auto& pattern : patterns)
string_patterns.insert(pattern.GetAsString());
return string_patterns;
}
std::set<std::string>
PermissionsManagerUnittest::GetPermittedSitesFromPermissionsData() {
std::set<std::string> string_patterns;
URLPatternSet patterns = PermissionsData::GetUserAllowedHosts(
util::GetBrowserContextId(browser_context()));
for (const auto& pattern : patterns)
string_patterns.insert(pattern.GetAsString());
return string_patterns;
}
TEST_F(PermissionsManagerUnittest, AddAndRemoveRestrictedSite) {
const url::Origin url = url::Origin::Create(GURL("http://a.example.com"));
const std::string expected_url_pattern = "http://a.example.com/*";
std::set<url::Origin> set_with_url;
set_with_url.insert(url);
base::Value value_with_url(base::Value::Type::LIST);
value_with_url.Append(url.Serialize());
// Verify the restricted sites list is empty.
EXPECT_EQ(GetRestrictedSitesFromManager(), std::set<url::Origin>());
EXPECT_EQ(GetRestrictedSitesFromPrefs(), nullptr);
EXPECT_THAT(GetRestrictedSitesFromPermissionsData(), testing::IsEmpty());
EXPECT_EQ(manager_->GetUserSiteSetting(url),
UserSiteSetting::kCustomizeByExtension);
// Add `url` to restricted sites. Verify the site is stored both in manager
// and prefs restricted sites.
manager_->AddUserRestrictedSite(url);
EXPECT_EQ(GetRestrictedSitesFromManager(), set_with_url);
EXPECT_EQ(*GetRestrictedSitesFromPrefs(), value_with_url);
EXPECT_THAT(GetRestrictedSitesFromPermissionsData(),
testing::UnorderedElementsAre(expected_url_pattern));
EXPECT_EQ(manager_->GetUserSiteSetting(url),
UserSiteSetting::kBlockAllExtensions);
// Adding an existent restricted site. Verify the entry is not duplicated.
manager_->AddUserRestrictedSite(url);
EXPECT_EQ(GetRestrictedSitesFromManager(), set_with_url);
EXPECT_EQ(*GetRestrictedSitesFromPrefs(), value_with_url);
EXPECT_THAT(GetRestrictedSitesFromPermissionsData(),
testing::UnorderedElementsAre(expected_url_pattern));
// Remove `url` from restricted sites. Verify the site is removed from both
// manager and prefs restricted sites.
manager_->RemoveUserRestrictedSite(url);
EXPECT_EQ(GetRestrictedSitesFromManager(), std::set<url::Origin>());
EXPECT_EQ(*GetRestrictedSitesFromPrefs(),
base::Value(base::Value::Type::LIST));
EXPECT_THAT(GetRestrictedSitesFromPermissionsData(), testing::IsEmpty());
EXPECT_EQ(manager_->GetUserSiteSetting(url),
UserSiteSetting::kCustomizeByExtension);
}
TEST_F(PermissionsManagerUnittest, AddAndRemovePermittedSite) {
const url::Origin url = url::Origin::Create(GURL("http://a.example.com"));
const std::string expected_url_pattern = "http://a.example.com/*";
std::set<url::Origin> set_with_url;
set_with_url.insert(url);
base::Value value_with_url(base::Value::Type::LIST);
value_with_url.Append(url.Serialize());
// Verify the permitted sites list is empty.
EXPECT_EQ(GetPermittedSitesFromManager(), std::set<url::Origin>());
EXPECT_EQ(GetPermittedSitesFromPrefs(), nullptr);
EXPECT_THAT(GetPermittedSitesFromPermissionsData(), testing::IsEmpty());
EXPECT_EQ(manager_->GetUserSiteSetting(url),
PermissionsManager::UserSiteSetting::kCustomizeByExtension);
// Add `url` to permitted sites. Verify the site is stored both in manager
// and prefs permitted sites.
manager_->AddUserPermittedSite(url);
EXPECT_EQ(GetPermittedSitesFromManager(), set_with_url);
EXPECT_EQ(*GetPermittedSitesFromPrefs(), value_with_url);
EXPECT_THAT(GetPermittedSitesFromPermissionsData(),
testing::UnorderedElementsAre(expected_url_pattern));
EXPECT_EQ(manager_->GetUserSiteSetting(url),
PermissionsManager::UserSiteSetting::kGrantAllExtensions);
// Adding an existent permitted site. Verify the entry is not duplicated.
manager_->AddUserPermittedSite(url);
EXPECT_EQ(GetPermittedSitesFromManager(), set_with_url);
EXPECT_EQ(*GetPermittedSitesFromPrefs(), value_with_url);
EXPECT_THAT(GetPermittedSitesFromPermissionsData(),
testing::UnorderedElementsAre(expected_url_pattern));
// Remove `url` from permitted sites. Verify the site is removed from both
// manager and prefs permitted sites.
manager_->RemoveUserPermittedSite(url);
EXPECT_EQ(GetPermittedSitesFromManager(), std::set<url::Origin>());
EXPECT_EQ(*GetPermittedSitesFromPrefs(),
base::Value(base::Value::Type::LIST));
EXPECT_THAT(GetPermittedSitesFromPermissionsData(), testing::IsEmpty());
EXPECT_EQ(manager_->GetUserSiteSetting(url),
PermissionsManager::UserSiteSetting::kCustomizeByExtension);
}
TEST_F(PermissionsManagerUnittest,
RestrictedAndPermittedSitesAreMutuallyExclusive) {
const url::Origin url = url::Origin::Create(GURL("http://a.example.com"));
std::set<url::Origin> empty_set;
std::set<url::Origin> set_with_url;
set_with_url.insert(url);
{
manager_->AddUserRestrictedSite(url);
const PermissionsManager::UserPermissionsSettings& actual_permissions =
manager_->GetUserPermissionsSettings();
EXPECT_EQ(actual_permissions.restricted_sites, set_with_url);
EXPECT_EQ(actual_permissions.permitted_sites, empty_set);
EXPECT_EQ(manager_->GetUserSiteSetting(url),
PermissionsManager::UserSiteSetting::kBlockAllExtensions);
}
{
// Adding an url to the permitted sites that is already in the restricted
// sites should remove it from restricted sites and add it to permitted
// sites.
manager_->AddUserPermittedSite(url);
const PermissionsManager::UserPermissionsSettings& actual_permissions =
manager_->GetUserPermissionsSettings();
EXPECT_EQ(actual_permissions.restricted_sites, empty_set);
EXPECT_EQ(actual_permissions.permitted_sites, set_with_url);
EXPECT_EQ(manager_->GetUserSiteSetting(url),
PermissionsManager::UserSiteSetting::kGrantAllExtensions);
}
{
// Adding an url to the restricted sites that is already in the permitted
// sites should remove it from permitted sites and add it to restricted
// sites.
manager_->AddUserRestrictedSite(url);
const PermissionsManager::UserPermissionsSettings& actual_permissions =
manager_->GetUserPermissionsSettings();
EXPECT_EQ(actual_permissions.restricted_sites, set_with_url);
EXPECT_EQ(actual_permissions.permitted_sites, empty_set);
EXPECT_EQ(manager_->GetUserSiteSetting(url),
PermissionsManager::UserSiteSetting::kBlockAllExtensions);
}
}
TEST_F(PermissionsManagerUnittest, UpdateUserSiteSetting) {
const url::Origin url = url::Origin::Create(GURL("http://a.example.com"));
std::set<url::Origin> empty_set;
std::set<url::Origin> set_with_url;
set_with_url.insert(url);
{
manager_->UpdateUserSiteSetting(
url, PermissionsManager::UserSiteSetting::kGrantAllExtensions);
const PermissionsManager::UserPermissionsSettings& actual_permissions =
manager_->GetUserPermissionsSettings();
EXPECT_EQ(actual_permissions.restricted_sites, empty_set);
EXPECT_EQ(actual_permissions.permitted_sites, set_with_url);
EXPECT_EQ(manager_->GetUserSiteSetting(url),
PermissionsManager::UserSiteSetting::kGrantAllExtensions);
}
{
manager_->UpdateUserSiteSetting(
url, PermissionsManager::UserSiteSetting::kBlockAllExtensions);
const PermissionsManager::UserPermissionsSettings& actual_permissions =
manager_->GetUserPermissionsSettings();
EXPECT_EQ(actual_permissions.restricted_sites, set_with_url);
EXPECT_EQ(actual_permissions.permitted_sites, empty_set);
EXPECT_EQ(manager_->GetUserSiteSetting(url),
PermissionsManager::UserSiteSetting::kBlockAllExtensions);
}
{
manager_->UpdateUserSiteSetting(
url, PermissionsManager::UserSiteSetting::kCustomizeByExtension);
const PermissionsManager::UserPermissionsSettings& actual_permissions =
manager_->GetUserPermissionsSettings();
EXPECT_EQ(actual_permissions.restricted_sites, empty_set);
EXPECT_EQ(actual_permissions.permitted_sites, empty_set);
EXPECT_EQ(manager_->GetUserSiteSetting(url),
PermissionsManager::UserSiteSetting::kCustomizeByExtension);
}
}
TEST_F(PermissionsManagerUnittest, GetSiteAccess_AllUrls) {
auto extension =
AddExtensionWithHostPermission("AllUrls Extension", "<all_urls>");
const GURL non_restricted_url("https://www.non-restricted.com");
{
const PermissionsManager::ExtensionSiteAccess site_access =
manager_->GetSiteAccess(*extension, non_restricted_url);
EXPECT_TRUE(site_access.has_site_access);
EXPECT_FALSE(site_access.withheld_site_access);
EXPECT_TRUE(site_access.has_all_sites_access);
EXPECT_FALSE(site_access.withheld_all_sites_access);
}
// Chrome pages should be restricted, and the extension shouldn't have grant
// or withheld site access.
const GURL restricted_url("chrome://extensions");
{
const PermissionsManager::ExtensionSiteAccess site_access =
manager_->GetSiteAccess(*extension, restricted_url);
EXPECT_FALSE(site_access.has_site_access);
EXPECT_FALSE(site_access.withheld_site_access);
EXPECT_TRUE(site_access.has_all_sites_access);
EXPECT_FALSE(site_access.withheld_all_sites_access);
}
}
TEST_F(PermissionsManagerUnittest, GetSiteAccess_RequestedUrl) {
auto extension = AddExtensionWithHostPermission("RequestedUrl Extension",
"*://*.requested.com/*");
const GURL requested_url("https://www.requested.com");
{
const PermissionsManager::ExtensionSiteAccess site_access =
manager_->GetSiteAccess(*extension, requested_url);
EXPECT_TRUE(site_access.has_site_access);
EXPECT_FALSE(site_access.withheld_site_access);
EXPECT_FALSE(site_access.has_all_sites_access);
EXPECT_FALSE(site_access.withheld_all_sites_access);
}
const GURL non_requested_url("https://non-requested.com");
{
const PermissionsManager::ExtensionSiteAccess site_access =
manager_->GetSiteAccess(*extension, non_requested_url);
EXPECT_FALSE(site_access.has_site_access);
EXPECT_FALSE(site_access.withheld_site_access);
EXPECT_FALSE(site_access.has_all_sites_access);
EXPECT_FALSE(site_access.withheld_all_sites_access);
}
}
// Tests that for the purposes of displaying an extension's site access to the
// user (or granting/revoking permissions), we ignore paths in the URL. We
// always strip the path from host permissions directly, but we don't strip the
// path from content scripts.
TEST_F(PermissionsManagerUnittest,
GetSiteAccess_ContentScript_RequestedUrlWithPath) {
scoped_refptr<const Extension> extension =
ExtensionBuilder("extension")
.AddContentScript("foo.js", {"https://www.example.com/foo"})
.SetLocation(mojom::ManifestLocation::kInternal)
.Build();
ExtensionRegistryFactory::GetForBrowserContext(browser_context())
->AddEnabled(extension);
const GURL other_path_url("https://www.example.com/bar");
{
const PermissionsManager::ExtensionSiteAccess site_access =
manager_->GetSiteAccess(*extension, other_path_url);
// Even though the path doesn't match the one requested, the domain does
// match and thus we treat it as if the site was requested.
EXPECT_TRUE(site_access.has_site_access);
EXPECT_FALSE(site_access.withheld_site_access);
EXPECT_FALSE(site_access.has_all_sites_access);
EXPECT_FALSE(site_access.withheld_all_sites_access);
}
}
TEST_F(PermissionsManagerUnittest, GetSiteAccess_ActiveTab) {
auto extension =
AddExtensionWithHostPermission("ActiveTab Extension", "activeTab");
const GURL url("https://example.com");
{
const PermissionsManager::ExtensionSiteAccess site_access =
manager_->GetSiteAccess(*extension, url);
// The site access computation does not take into account active tab, and
// therefore it does not have or withheld any access.
EXPECT_FALSE(site_access.has_site_access);
EXPECT_FALSE(site_access.withheld_site_access);
EXPECT_FALSE(site_access.has_all_sites_access);
EXPECT_FALSE(site_access.withheld_all_sites_access);
}
}
TEST_F(PermissionsManagerUnittest, GetSiteAccess_NoHostPermissions) {
auto extension = AddExtensionWithHostPermission("", "Extension");
const GURL url("https://example.com");
{
const PermissionsManager::ExtensionSiteAccess site_access =
manager_->GetSiteAccess(*extension, url);
// The site access computation does not take into account active tab, and
// therefore it does not have or withheld any access.
EXPECT_FALSE(site_access.has_site_access);
EXPECT_FALSE(site_access.withheld_site_access);
EXPECT_FALSE(site_access.has_all_sites_access);
EXPECT_FALSE(site_access.withheld_all_sites_access);
}
}
} // namespace extensions
|