1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
|
# Copyright (c) 2013 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
"""Presubmit script for android buildbot.
See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
details on the presubmit API built into depot_tools.
"""
USE_PYTHON3 = True
def CommonChecks(input_api, output_api):
build_android_dir = input_api.PresubmitLocalPath()
def J(*dirs):
"""Returns a path relative to presubmit directory."""
return input_api.os_path.join(build_android_dir, *dirs)
build_pys = [
r'gn/.*\.py$',
r'gyp/.*\.py$',
]
tests = []
# yapf likes formatting the extra_paths_list to be less readable.
# yapf: disable
tests.extend(
input_api.canned_checks.GetPylint(
input_api,
output_api,
pylintrc='pylintrc',
files_to_skip=[
r'.*_pb2\.py'
] + build_pys,
extra_paths_list=[
J(),
J('gyp'),
J('buildbot'),
J('..', 'util', 'lib', 'common'),
J('..', '..', 'third_party', 'catapult', 'common',
'py_trace_event'),
J('..', '..', 'third_party', 'catapult', 'common', 'py_utils'),
J('..', '..', 'third_party', 'catapult', 'devil'),
J('..', '..', 'third_party', 'catapult', 'tracing'),
J('..', '..', 'third_party', 'depot_tools'),
J('..', '..', 'third_party', 'colorama', 'src'),
J('..', '..', 'build'),
],
version='2.7'))
tests.extend(
input_api.canned_checks.GetPylint(
input_api,
output_api,
files_to_check=build_pys,
files_to_skip=[
r'.*_pb2\.py',
r'.*_pb2\.py',
r'.*create_unwind_table\.py',
r'.*create_unwind_table_tests\.py',
],
extra_paths_list=[J('gyp'), J('gn')],
version='2.7'))
tests.extend(
input_api.canned_checks.GetPylint(
input_api,
output_api,
files_to_check=[
r'.*create_unwind_table\.py',
r'.*create_unwind_table_tests\.py',
],
extra_paths_list=[J('gyp'), J('gn')],
version='2.7'))
# yapf: enable
# Disabled due to http://crbug.com/410936
#output.extend(input_api.canned_checks.RunUnitTestsInDirectory(
#input_api, output_api, J('buildbot', 'tests', skip_shebang_check=True)))
pylib_test_env = dict(input_api.environ)
pylib_test_env.update({
'PYTHONPATH': build_android_dir,
'PYTHONDONTWRITEBYTECODE': '1',
})
tests.extend(
input_api.canned_checks.GetUnitTests(
input_api,
output_api,
unit_tests=[
J('.', 'emma_coverage_stats_test.py'),
J('.', 'list_class_verification_failures_test.py'),
J('pylib', 'constants', 'host_paths_unittest.py'),
J('pylib', 'gtest', 'gtest_test_instance_test.py'),
J('pylib', 'instrumentation',
'instrumentation_test_instance_test.py'),
J('pylib', 'local', 'device', 'local_device_gtest_run_test.py'),
J('pylib', 'local', 'device',
'local_device_instrumentation_test_run_test.py'),
J('pylib', 'local', 'device', 'local_device_test_run_test.py'),
J('pylib', 'local', 'machine',
'local_machine_junit_test_run_test.py'),
J('pylib', 'output', 'local_output_manager_test.py'),
J('pylib', 'output', 'noop_output_manager_test.py'),
J('pylib', 'output', 'remote_output_manager_test.py'),
J('pylib', 'results', 'json_results_test.py'),
J('pylib', 'utils', 'chrome_proxy_utils_test.py'),
J('pylib', 'utils', 'decorators_test.py'),
J('pylib', 'utils', 'device_dependencies_test.py'),
J('pylib', 'utils', 'dexdump_test.py'),
J('pylib', 'utils', 'gold_utils_test.py'),
J('pylib', 'utils', 'proguard_test.py'),
J('pylib', 'utils', 'test_filter_test.py'),
J('gyp', 'util', 'build_utils_test.py'),
J('gyp', 'util', 'manifest_utils_test.py'),
J('gyp', 'util', 'md5_check_test.py'),
J('gyp', 'util', 'resource_utils_test.py'),
],
env=pylib_test_env,
run_on_python2=False,
run_on_python3=True,
skip_shebang_check=True))
return input_api.RunTests(tests)
def CheckChangeOnUpload(input_api, output_api):
return CommonChecks(input_api, output_api)
def CheckChangeOnCommit(input_api, output_api):
return CommonChecks(input_api, output_api)
|