1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
|
// Copyright 2021 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "base/win/security_util.h"
#include <aclapi.h>
#include <sddl.h>
#include <windows.h>
#include "base/files/file_util.h"
#include "base/files/scoped_temp_dir.h"
#include "base/win/scoped_handle.h"
#include "base/win/scoped_localalloc.h"
#include "base/win/sid.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace base {
namespace win {
namespace {
constexpr wchar_t kBaseDacl[] = L"D:P(A;;FA;;;WD)";
constexpr wchar_t kTest1Dacl[] = L"D:PAI(A;;FR;;;AU)(A;;FA;;;WD)";
constexpr wchar_t kTest2Dacl[] = L"D:PAI(A;;FA;;;BA)(A;;FA;;;AU)(A;;FA;;;WD)";
constexpr wchar_t kTest1DenyDacl[] = L"D:PAI(D;;FR;;;LG)(A;;FA;;;WD)";
constexpr wchar_t kTest1DaclNoInherit[] = L"D:P(A;;FR;;;AU)(A;;FA;;;WD)";
constexpr wchar_t kTest2DaclNoInherit[] =
L"D:P(A;;FA;;;BA)(A;;FA;;;AU)(A;;FA;;;WD)";
constexpr wchar_t kBaseDirDacl[] = L"D:P(A;OICI;FA;;;WD)";
constexpr wchar_t kTest1InheritedDacl[] = L"D:(A;ID;FA;;;WD)";
constexpr wchar_t kBaseDir2Dacl[] = L"D:PAI(A;OICI;FR;;;AU)(A;OICI;FA;;;WD)";
constexpr wchar_t kTest2InheritedDacl[] = L"D:AI(A;ID;FR;;;AU)(A;ID;FA;;;WD)";
constexpr wchar_t kBaseDir2DaclNoInherit[] =
L"D:P(A;OICI;FR;;;AU)(A;OICI;FA;;;WD)";
constexpr wchar_t kTest2InheritedDaclNoInherit[] = L"D:P(A;;FA;;;WD)";
constexpr wchar_t kTest3InheritedDacl[] = L"D:(A;ID;FR;;;AU)(A;ID;FA;;;WD)";
constexpr wchar_t kNoWriteDacDacl[] = L"D:(D;;WD;;;OW)(A;;FRSD;;;WD)";
constexpr wchar_t kAuthenticatedUsersSid[] = L"AU";
constexpr wchar_t kLocalGuestSid[] = L"LG";
std::wstring GetFileDacl(const FilePath& path) {
PSECURITY_DESCRIPTOR sd;
if (::GetNamedSecurityInfo(path.value().c_str(), SE_FILE_OBJECT,
DACL_SECURITY_INFORMATION, nullptr, nullptr,
nullptr, nullptr, &sd) != ERROR_SUCCESS) {
return std::wstring();
}
auto sd_ptr = TakeLocalAlloc(sd);
LPWSTR sddl;
if (!::ConvertSecurityDescriptorToStringSecurityDescriptor(
sd_ptr.get(), SDDL_REVISION_1, DACL_SECURITY_INFORMATION, &sddl,
nullptr)) {
return std::wstring();
}
return TakeLocalAlloc(sddl).get();
}
bool CreateWithDacl(const FilePath& path, const wchar_t* sddl, bool directory) {
PSECURITY_DESCRIPTOR sd;
if (!::ConvertStringSecurityDescriptorToSecurityDescriptor(
sddl, SDDL_REVISION_1, &sd, nullptr)) {
return false;
}
auto sd_ptr = TakeLocalAlloc(sd);
SECURITY_ATTRIBUTES security_attr = {};
security_attr.nLength = sizeof(security_attr);
security_attr.lpSecurityDescriptor = sd_ptr.get();
if (directory)
return !!::CreateDirectory(path.value().c_str(), &security_attr);
return ScopedHandle(::CreateFile(path.value().c_str(), GENERIC_ALL, 0,
&security_attr, CREATE_ALWAYS, 0, nullptr))
.is_valid();
}
} // namespace
TEST(SecurityUtilTest, GrantAccessToPathErrorCase) {
ScopedTempDir temp_dir;
auto sids = Sid::FromSddlStringVector({kAuthenticatedUsersSid});
ASSERT_TRUE(sids);
ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
FilePath path = temp_dir.GetPath().Append(L"test");
EXPECT_FALSE(
GrantAccessToPath(path, *sids, FILE_GENERIC_READ, NO_INHERITANCE, true));
EXPECT_FALSE(
GrantAccessToPath(path, *sids, FILE_GENERIC_READ, NO_INHERITANCE, false));
ASSERT_TRUE(CreateWithDacl(path, kBaseDacl, false));
EXPECT_TRUE(
GrantAccessToPath(path, *sids, FILE_GENERIC_READ, NO_INHERITANCE, true));
EXPECT_TRUE(
GrantAccessToPath(path, *sids, FILE_GENERIC_READ, NO_INHERITANCE, false));
path = temp_dir.GetPath().Append(L"test_nowritedac");
ASSERT_TRUE(CreateWithDacl(path, kNoWriteDacDacl, false));
EXPECT_FALSE(
GrantAccessToPath(path, *sids, FILE_GENERIC_READ, NO_INHERITANCE, true));
EXPECT_FALSE(
GrantAccessToPath(path, *sids, FILE_GENERIC_READ, NO_INHERITANCE, false));
}
TEST(SecurityUtilTest, GrantAccessToPathFile) {
ScopedTempDir temp_dir;
ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
FilePath path = temp_dir.GetPath().Append(L"test");
ASSERT_TRUE(CreateWithDacl(path, kBaseDacl, false));
EXPECT_EQ(kBaseDacl, GetFileDacl(path));
auto sids = Sid::FromSddlStringVector({kAuthenticatedUsersSid});
ASSERT_TRUE(sids);
EXPECT_TRUE(
GrantAccessToPath(path, *sids, FILE_GENERIC_READ, NO_INHERITANCE, true));
EXPECT_EQ(kTest1Dacl, GetFileDacl(path));
auto sids2 = Sid::FromSddlStringVector({L"S-1-5-11", L"BA"});
ASSERT_TRUE(sids2);
EXPECT_TRUE(
GrantAccessToPath(path, *sids2, GENERIC_ALL, NO_INHERITANCE, true));
EXPECT_EQ(kTest2Dacl, GetFileDacl(path));
}
TEST(SecurityUtilTest, GrantAccessToPathFileNoInherit) {
ScopedTempDir temp_dir;
ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
FilePath path = temp_dir.GetPath().Append(L"test");
ASSERT_TRUE(CreateWithDacl(path, kBaseDacl, false));
EXPECT_EQ(kBaseDacl, GetFileDacl(path));
auto sids = Sid::FromSddlStringVector({kAuthenticatedUsersSid});
ASSERT_TRUE(sids);
EXPECT_TRUE(
GrantAccessToPath(path, *sids, FILE_GENERIC_READ, NO_INHERITANCE, false));
EXPECT_EQ(kTest1DaclNoInherit, GetFileDacl(path));
auto sids2 = Sid::FromSddlStringVector({L"S-1-5-11", L"BA"});
ASSERT_TRUE(sids2);
EXPECT_TRUE(
GrantAccessToPath(path, *sids2, GENERIC_ALL, NO_INHERITANCE, false));
EXPECT_EQ(kTest2DaclNoInherit, GetFileDacl(path));
}
TEST(SecurityUtilTest, DenyAccessToPathFile) {
ScopedTempDir temp_dir;
ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
FilePath path = temp_dir.GetPath().Append(L"test");
ASSERT_TRUE(CreateWithDacl(path, kBaseDacl, false));
EXPECT_EQ(kBaseDacl, GetFileDacl(path));
auto sids = Sid::FromSddlStringVector({kLocalGuestSid});
ASSERT_TRUE(sids);
EXPECT_TRUE(
DenyAccessToPath(path, *sids, FILE_GENERIC_READ, NO_INHERITANCE, true));
EXPECT_EQ(kTest1DenyDacl, GetFileDacl(path));
}
TEST(SecurityUtilTest, GrantAccessToPathDirectory) {
ScopedTempDir temp_dir;
ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
FilePath path = temp_dir.GetPath().Append(L"testdir");
ASSERT_TRUE(CreateWithDacl(path, kBaseDirDacl, true));
EXPECT_EQ(kBaseDirDacl, GetFileDacl(path));
FilePath file_path = path.Append(L"test");
File file(file_path, File::FLAG_CREATE_ALWAYS | File::FLAG_WRITE);
ASSERT_TRUE(file.IsValid());
file.Close();
EXPECT_EQ(kTest1InheritedDacl, GetFileDacl(file_path));
auto sids = Sid::FromSddlStringVector({kAuthenticatedUsersSid});
ASSERT_TRUE(sids);
EXPECT_TRUE(GrantAccessToPath(path, *sids, FILE_GENERIC_READ,
OBJECT_INHERIT_ACE | CONTAINER_INHERIT_ACE,
true));
EXPECT_EQ(kBaseDir2Dacl, GetFileDacl(path));
EXPECT_EQ(kTest2InheritedDacl, GetFileDacl(file_path));
}
TEST(SecurityUtilTest, GrantAccessToPathDirectoryNoInherit) {
ScopedTempDir temp_dir;
ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
FilePath path = temp_dir.GetPath().Append(L"testdir");
ASSERT_TRUE(CreateWithDacl(path, kBaseDirDacl, true));
EXPECT_EQ(kBaseDirDacl, GetFileDacl(path));
FilePath file_path = path.Append(L"test");
File file(file_path, File::FLAG_CREATE_ALWAYS | File::FLAG_WRITE);
ASSERT_TRUE(file.IsValid());
file.Close();
EXPECT_EQ(kTest1InheritedDacl, GetFileDacl(file_path));
auto sids = Sid::FromSddlStringVector({kAuthenticatedUsersSid});
ASSERT_TRUE(sids);
EXPECT_TRUE(GrantAccessToPath(path, *sids, FILE_GENERIC_READ,
OBJECT_INHERIT_ACE | CONTAINER_INHERIT_ACE,
false));
EXPECT_EQ(kBaseDir2DaclNoInherit, GetFileDacl(path));
EXPECT_EQ(kTest2InheritedDaclNoInherit, GetFileDacl(file_path));
FilePath file_path2 = path.Append(L"test2");
File file2(file_path2, File::FLAG_CREATE_ALWAYS | File::FLAG_WRITE);
ASSERT_TRUE(file2.IsValid());
file2.Close();
EXPECT_EQ(kTest3InheritedDacl, GetFileDacl(file_path2));
}
TEST(SecurityUtilTest, CloneSidVector) {
std::vector<Sid> sids =
*Sid::FromKnownSidVector({WellKnownSid::kNull, WellKnownSid::kWorld});
std::vector<Sid> clone = CloneSidVector(sids);
ASSERT_EQ(sids.size(), clone.size());
for (size_t index = 0; index < sids.size(); ++index) {
ASSERT_EQ(sids[index], clone[index]);
ASSERT_NE(sids[index].GetPSID(), clone[index].GetPSID());
}
ASSERT_EQ(CloneSidVector(std::vector<Sid>()).size(), 0U);
}
TEST(SecurityUtilTest, AppendSidVector) {
std::vector<Sid> sids =
*Sid::FromKnownSidVector({WellKnownSid::kNull, WellKnownSid::kWorld});
std::vector<Sid> total_sids;
AppendSidVector(total_sids, sids);
EXPECT_EQ(total_sids.size(), sids.size());
std::vector<Sid> sids2 = *Sid::FromKnownSidVector(
{WellKnownSid::kCreatorOwner, WellKnownSid::kNetwork});
AppendSidVector(total_sids, sids2);
EXPECT_EQ(total_sids.size(), sids.size() + sids2.size());
auto sid_interator = total_sids.cbegin();
for (size_t index = 0; index < sids.size(); ++index) {
ASSERT_EQ(*sid_interator, sids[index]);
ASSERT_NE(sid_interator->GetPSID(), sids[index].GetPSID());
sid_interator++;
}
for (size_t index = 0; index < sids2.size(); ++index) {
ASSERT_EQ(*sid_interator, sids2[index]);
ASSERT_NE(sid_interator->GetPSID(), sids2[index].GetPSID());
sid_interator++;
}
}
} // namespace win
} // namespace base
|
