summaryrefslogtreecommitdiff
path: root/chromium/components/permissions/android
diff options
context:
space:
mode:
Diffstat (limited to 'chromium/components/permissions/android')
-rw-r--r--chromium/components/permissions/android/BUILD.gn3
-rw-r--r--chromium/components/permissions/android/java/src/org/chromium/components/permissions/PermissionDialogController.java10
2 files changed, 9 insertions, 4 deletions
diff --git a/chromium/components/permissions/android/BUILD.gn b/chromium/components/permissions/android/BUILD.gn
index 6e409eec28d..9c226bae1cb 100644
--- a/chromium/components/permissions/android/BUILD.gn
+++ b/chromium/components/permissions/android/BUILD.gn
@@ -140,6 +140,9 @@ java_library("components_permissions_junit_tests") {
":java",
"//base:base_java_test_support",
"//base:base_junit_test_support",
+ "//third_party/android_deps:robolectric_all_java",
+ "//third_party/junit",
+ "//third_party/mockito:mockito_java",
"//ui/android:ui_java",
]
}
diff --git a/chromium/components/permissions/android/java/src/org/chromium/components/permissions/PermissionDialogController.java b/chromium/components/permissions/android/java/src/org/chromium/components/permissions/PermissionDialogController.java
index b1d120e721a..2b05abc83ea 100644
--- a/chromium/components/permissions/android/java/src/org/chromium/components/permissions/PermissionDialogController.java
+++ b/chromium/components/permissions/android/java/src/org/chromium/components/permissions/PermissionDialogController.java
@@ -5,7 +5,6 @@
package org.chromium.components.permissions;
import android.annotation.SuppressLint;
-import android.app.Activity;
import android.content.Context;
import android.content.Intent;
import android.os.Build;
@@ -15,6 +14,7 @@ import androidx.annotation.IntDef;
import androidx.annotation.VisibleForTesting;
import org.chromium.base.BuildInfo;
+import org.chromium.base.ContextUtils;
import org.chromium.base.annotations.CalledByNative;
import org.chromium.ui.modaldialog.DialogDismissalCause;
import org.chromium.ui.modaldialog.ModalDialogManager;
@@ -144,12 +144,14 @@ public class PermissionDialogController
assert mState == State.NOT_SHOWING;
mDialogDelegate = mRequestQueue.remove(0);
- Activity activity = mDialogDelegate.getWindow().getActivity().get();
+ // Use the context to access resources instead of the activity because the activity may not
+ // have the correct resources in some cases (e.g. WebLayer).
+ Context context = mDialogDelegate.getWindow().getContext().get();
// It's possible for the activity to be null if we reach here just after the user
// backgrounds the browser and cleanup has happened. In that case, we can't show a prompt,
// so act as though the user dismissed it.
- if (activity == null) {
+ if (ContextUtils.activityFromContext(context) == null) {
// TODO(timloh): This probably doesn't work, as this happens synchronously when creating
// the PermissionPromptAndroid, so the PermissionRequestManager won't be ready yet.
mDialogDelegate.onDismiss();
@@ -167,7 +169,7 @@ public class PermissionDialogController
mModalDialogManager = mDialogDelegate.getWindow().getModalDialogManager();
mDialogModel = PermissionDialogModel.getModel(
- this, mDialogDelegate, () -> showFilteredTouchEventDialog(activity));
+ this, mDialogDelegate, () -> showFilteredTouchEventDialog(context));
mModalDialogManager.showDialog(mDialogModel, ModalDialogManager.ModalDialogType.TAB);
mState = State.PROMPT_OPEN;
}