diff options
Diffstat (limited to 'chromium/components/feature_engagement')
9 files changed, 43 insertions, 0 deletions
diff --git a/chromium/components/feature_engagement/internal/persistent_availability_store.cc b/chromium/components/feature_engagement/internal/persistent_availability_store.cc index 50567ab0913..26ff4929998 100644 --- a/chromium/components/feature_engagement/internal/persistent_availability_store.cc +++ b/chromium/components/feature_engagement/internal/persistent_availability_store.cc @@ -12,6 +12,7 @@ #include "base/bind.h" #include "base/callback.h" #include "base/feature_list.h" +#include "base/logging.h" #include "components/feature_engagement/internal/proto/availability.pb.h" #include "components/feature_engagement/internal/stats.h" #include "components/feature_engagement/public/feature_list.h" diff --git a/chromium/components/feature_engagement/public/android/java/src/org/chromium/components/feature_engagement/EventConstants.java b/chromium/components/feature_engagement/public/android/java/src/org/chromium/components/feature_engagement/EventConstants.java index bbc6bf5f93b..c2a9f311ae9 100644 --- a/chromium/components/feature_engagement/public/android/java/src/org/chromium/components/feature_engagement/EventConstants.java +++ b/chromium/components/feature_engagement/public/android/java/src/org/chromium/components/feature_engagement/EventConstants.java @@ -116,6 +116,12 @@ public final class EventConstants { "contextual_search_triggered_by_longpress"; /** + * Contextual Search attempted-trigger by Tap when user should Long-press. + */ + public static final String CONTEXTUAL_SEARCH_TAPPED_BUT_SHOULD_LONGPRESS = + "contextual_search_tapped_but_should_longpress"; + + /** * The partner homepage was pressed. */ public static final String PARTNER_HOME_PAGE_BUTTON_PRESSED = diff --git a/chromium/components/feature_engagement/public/android/java/src/org/chromium/components/feature_engagement/FeatureConstants.java b/chromium/components/feature_engagement/public/android/java/src/org/chromium/components/feature_engagement/FeatureConstants.java index d05a7ed9dae..232f051ab40 100644 --- a/chromium/components/feature_engagement/public/android/java/src/org/chromium/components/feature_engagement/FeatureConstants.java +++ b/chromium/components/feature_engagement/public/android/java/src/org/chromium/components/feature_engagement/FeatureConstants.java @@ -27,6 +27,7 @@ import java.lang.annotation.RetentionPolicy; FeatureConstants.CONTEXTUAL_SEARCH_PROMOTE_TAP_FEATURE, FeatureConstants.CONTEXTUAL_SEARCH_PROMOTE_PANEL_OPEN_FEATURE, FeatureConstants.CONTEXTUAL_SEARCH_OPT_IN_FEATURE, + FeatureConstants.CONTEXTUAL_SEARCH_TAPPED_BUT_SHOULD_LONGPRESS_FEATURE, FeatureConstants.KEYBOARD_ACCESSORY_ADDRESS_FILL_FEATURE, FeatureConstants.KEYBOARD_ACCESSORY_PASSWORD_FILLING_FEATURE, FeatureConstants.KEYBOARD_ACCESSORY_PAYMENT_FILLING_FEATURE, @@ -86,6 +87,12 @@ public @interface FeatureConstants { String CONTEXTUAL_SEARCH_OPT_IN_FEATURE = "IPH_ContextualSearchOptIn"; /** + * An IPH feature educating users that tap to use longpress instead. + */ + String CONTEXTUAL_SEARCH_TAPPED_BUT_SHOULD_LONGPRESS_FEATURE = + "IPH_ContextualSearchTappedButShouldLongpress"; + + /** * An IPH feature indicating to users that there are settings for downloads and they are * accessible through Downloads Home. */ diff --git a/chromium/components/feature_engagement/public/event_constants.cc b/chromium/components/feature_engagement/public/event_constants.cc index 1e8973aceea..3f97ea2ec32 100644 --- a/chromium/components/feature_engagement/public/event_constants.cc +++ b/chromium/components/feature_engagement/public/event_constants.cc @@ -19,6 +19,9 @@ const char kNewTabOpened[] = "new_tab_opened"; #if defined(OS_WIN) || defined(OS_MACOSX) || defined(OS_LINUX) || \ defined(OS_CHROMEOS) +const char kSixthTabOpened[] = "sixth_tab_opened"; +const char kTabGroupCreated[] = "tab_group_created"; + const char kReopenTabConditionsMet[] = "reopen_tab_conditions_met"; const char kTabReopened[] = "tab_reopened"; diff --git a/chromium/components/feature_engagement/public/event_constants.h b/chromium/components/feature_engagement/public/event_constants.h index 638a72e929d..c7d21870944 100644 --- a/chromium/components/feature_engagement/public/event_constants.h +++ b/chromium/components/feature_engagement/public/event_constants.h @@ -24,6 +24,11 @@ extern const char kNewTabOpened[]; // Desktop #if defined(OS_WIN) || defined(OS_MACOSX) || defined(OS_LINUX) || \ defined(OS_CHROMEOS) +// A new tab was opened when 5 (or more) tabs were already open. +extern const char kSixthTabOpened[]; +// The user made a new tab group. +extern const char kTabGroupCreated[]; + // All conditions for reopen closed tab IPH were met. Since this IPH needs to // track user events (opening/closing tabs, focusing the omnibox, etc) on the // second level, it must be done manually. diff --git a/chromium/components/feature_engagement/public/feature_constants.cc b/chromium/components/feature_engagement/public/feature_constants.cc index 6f191db5d71..80c34cc8b23 100644 --- a/chromium/components/feature_engagement/public/feature_constants.cc +++ b/chromium/components/feature_engagement/public/feature_constants.cc @@ -16,10 +16,14 @@ const base::Feature kIPHDummyFeature{"IPH_Dummy", #if defined(OS_WIN) || defined(OS_MACOSX) || defined(OS_LINUX) || \ defined(OS_CHROMEOS) +const base::Feature kIPHDesktopTabGroupsNewGroupFeature{ + "IPH_DesktopTabGroupsNewGroup", base::FEATURE_DISABLED_BY_DEFAULT}; const base::Feature kIPHFocusModeFeature{"IPH_FocusMode", base::FEATURE_DISABLED_BY_DEFAULT}; const base::Feature kIPHGlobalMediaControlsFeature{ "IPH_GlobalMediaControls", base::FEATURE_DISABLED_BY_DEFAULT}; +const base::Feature kIPHPasswordsAccountStorageFeature{ + "IPH_PasswordsAccountStorage", base::FEATURE_DISABLED_BY_DEFAULT}; const base::Feature kIPHReopenTabFeature{"IPH_ReopenTab", base::FEATURE_DISABLED_BY_DEFAULT}; const base::Feature kIPHWebUITabStripFeature{"IPH_WebUITabStrip", @@ -67,6 +71,9 @@ const base::Feature kIPHContextualSearchPromotePanelOpenFeature{ "IPH_ContextualSearchPromotePanelOpen", base::FEATURE_DISABLED_BY_DEFAULT}; const base::Feature kIPHContextualSearchOptInFeature{ "IPH_ContextualSearchOptIn", base::FEATURE_DISABLED_BY_DEFAULT}; +const base::Feature kIPHContextualSearchTappedButShouldLongpressFeature{ + "IPH_ContextualSearchTappedButShouldLongpress", + base::FEATURE_DISABLED_BY_DEFAULT}; const base::Feature kIPHDownloadSettingsFeature{ "IPH_DownloadSettings", base::FEATURE_DISABLED_BY_DEFAULT}; const base::Feature kIPHDownloadInfoBarDownloadContinuingFeature{ diff --git a/chromium/components/feature_engagement/public/feature_constants.h b/chromium/components/feature_engagement/public/feature_constants.h index 64655e40f64..499449de664 100644 --- a/chromium/components/feature_engagement/public/feature_constants.h +++ b/chromium/components/feature_engagement/public/feature_constants.h @@ -19,8 +19,10 @@ extern const base::Feature kIPHDummyFeature; #if defined(OS_WIN) || defined(OS_MACOSX) || defined(OS_LINUX) || \ defined(OS_CHROMEOS) +extern const base::Feature kIPHDesktopTabGroupsNewGroupFeature; extern const base::Feature kIPHFocusModeFeature; extern const base::Feature kIPHGlobalMediaControlsFeature; +extern const base::Feature kIPHPasswordsAccountStorageFeature; extern const base::Feature kIPHReopenTabFeature; extern const base::Feature kIPHWebUITabStripFeature; @@ -51,6 +53,7 @@ extern const base::Feature kIPHContextualSearchWebSearchFeature; extern const base::Feature kIPHContextualSearchPromoteTapFeature; extern const base::Feature kIPHContextualSearchPromotePanelOpenFeature; extern const base::Feature kIPHContextualSearchOptInFeature; +extern const base::Feature kIPHContextualSearchTappedButShouldLongpressFeature; extern const base::Feature kIPHDownloadSettingsFeature; extern const base::Feature kIPHDownloadInfoBarDownloadContinuingFeature; extern const base::Feature kIPHDownloadInfoBarDownloadsAreFasterFeature; diff --git a/chromium/components/feature_engagement/public/feature_list.cc b/chromium/components/feature_engagement/public/feature_list.cc index 7cd9547ed41..8d8a48e4872 100644 --- a/chromium/components/feature_engagement/public/feature_list.cc +++ b/chromium/components/feature_engagement/public/feature_list.cc @@ -35,6 +35,7 @@ const base::Feature* const kAllFeatures[] = { &kIPHContextualSearchPromoteTapFeature, &kIPHContextualSearchPromotePanelOpenFeature, &kIPHContextualSearchOptInFeature, + &kIPHContextualSearchTappedButShouldLongpressFeature, &kIPHDownloadSettingsFeature, &kIPHDownloadInfoBarDownloadContinuingFeature, &kIPHDownloadInfoBarDownloadsAreFasterFeature, @@ -65,8 +66,10 @@ const base::Feature* const kAllFeatures[] = { #endif // defined(OS_IOS) #if defined(OS_WIN) || defined(OS_MACOSX) || defined(OS_LINUX) || \ defined(OS_CHROMEOS) + &kIPHDesktopTabGroupsNewGroupFeature, &kIPHFocusModeFeature, &kIPHGlobalMediaControlsFeature, + &kIPHPasswordsAccountStorageFeature, &kIPHReopenTabFeature, &kIPHWebUITabStripFeature, #if BUILDFLAG(ENABLE_LEGACY_DESKTOP_IN_PRODUCT_HELP) diff --git a/chromium/components/feature_engagement/public/feature_list.h b/chromium/components/feature_engagement/public/feature_list.h index dc5a2b4f8cc..849acc1e0de 100644 --- a/chromium/components/feature_engagement/public/feature_list.h +++ b/chromium/components/feature_engagement/public/feature_list.h @@ -77,6 +77,8 @@ DEFINE_VARIATION_PARAM(kIPHContextualSearchPromotePanelOpenFeature, "IPH_ContextualSearchPromotePanelOpen"); DEFINE_VARIATION_PARAM(kIPHContextualSearchOptInFeature, "IPH_ContextualSearchOptIn"); +DEFINE_VARIATION_PARAM(kIPHContextualSearchTappedButShouldLongpressFeature, + "IPH_ContextualSearchTappedButShouldLongpress"); DEFINE_VARIATION_PARAM(kIPHDownloadSettingsFeature, "IPH_DownloadSettings"); DEFINE_VARIATION_PARAM(kIPHDownloadInfoBarDownloadContinuingFeature, "IPH_DownloadInfoBarDownloadContinuing"); @@ -121,8 +123,12 @@ DEFINE_VARIATION_PARAM(kIPHBadgedTranslateManualTriggerFeature, #if defined(OS_WIN) || defined(OS_MACOSX) || defined(OS_LINUX) || \ defined(OS_CHROMEOS) +DEFINE_VARIATION_PARAM(kIPHDesktopTabGroupsNewGroupFeature, + "IPH_DesktopTabGroupsNewGroup"); DEFINE_VARIATION_PARAM(kIPHFocusModeFeature, "IPH_FocusMode"); DEFINE_VARIATION_PARAM(kIPHGlobalMediaControls, "IPH_GlobalMediaControls"); +DEFINE_VARIATION_PARAM(kIPHPasswordsAccountStorageFeature, + "IPH_PasswordsAccountStorage"); DEFINE_VARIATION_PARAM(kIPHReopenTabFeature, "IPH_ReopenTab"); DEFINE_VARIATION_PARAM(kIPHWebUITabStripFeature, "IPH_WebUITabStrip"); #if BUILDFLAG(ENABLE_LEGACY_DESKTOP_IN_PRODUCT_HELP) @@ -159,6 +165,7 @@ constexpr flags_ui::FeatureEntry::FeatureVariation VARIATION_ENTRY(kIPHContextualSearchPromoteTapFeature), VARIATION_ENTRY(kIPHContextualSearchPromotePanelOpenFeature), VARIATION_ENTRY(kIPHContextualSearchOptInFeature), + VARIATION_ENTRY(kIPHContextualSearchTappedButShouldLongpressFeature), VARIATION_ENTRY(kIPHDownloadSettingsFeature), VARIATION_ENTRY(kIPHDownloadInfoBarDownloadContinuingFeature), VARIATION_ENTRY(kIPHDownloadInfoBarDownloadsAreFasterFeature), @@ -187,6 +194,7 @@ constexpr flags_ui::FeatureEntry::FeatureVariation VARIATION_ENTRY(kIPHBadgedTranslateManualTriggerFeature), #elif defined(OS_WIN) || defined(OS_MACOSX) || defined(OS_LINUX) || \ defined(OS_CHROMEOS) + VARIATION_ENTRY(kIPHDesktopTabGroupsNewGroupFeature), VARIATION_ENTRY(kIPHFocusModeFeature), VARIATION_ENTRY(kIPHGlobalMediaControls), VARIATION_ENTRY(kIPHReopenTabFeature), |