diff options
Diffstat (limited to 'chromium/build/gn_helpers_unittest.py')
| -rw-r--r-- | chromium/build/gn_helpers_unittest.py | 105 |
1 files changed, 80 insertions, 25 deletions
diff --git a/chromium/build/gn_helpers_unittest.py b/chromium/build/gn_helpers_unittest.py index 99d720b907b..5886577ea2b 100644 --- a/chromium/build/gn_helpers_unittest.py +++ b/chromium/build/gn_helpers_unittest.py @@ -3,6 +3,7 @@ # found in the LICENSE file. import mock +import sys import textwrap import unittest @@ -11,9 +12,56 @@ import gn_helpers class UnitTest(unittest.TestCase): def test_ToGNString(self): - self.assertEqual( - gn_helpers.ToGNString([1, 'two', [ '"thr$\\', True, False, [] ]]), - '[ 1, "two", [ "\\"thr\\$\\\\", true, false, [ ] ] ]') + test_cases = [ + (42, '42', '42'), ('foo', '"foo"', '"foo"'), (True, 'true', 'true'), + (False, 'false', 'false'), ('', '""', '""'), + ('\\$"$\\', '"\\\\\\$\\"\\$\\\\"', '"\\\\\\$\\"\\$\\\\"'), + (' \t\r\n', '" $0x09$0x0D$0x0A"', '" $0x09$0x0D$0x0A"'), + (u'\u2713', '"$0xE2$0x9C$0x93"', '"$0xE2$0x9C$0x93"'), + ([], '[ ]', '[]'), ([1], '[ 1 ]', '[\n 1\n]\n'), + ([3, 1, 4, 1], '[ 3, 1, 4, 1 ]', '[\n 3,\n 1,\n 4,\n 1\n]\n'), + (['a', True, 2], '[ "a", true, 2 ]', '[\n "a",\n true,\n 2\n]\n'), + ({ + 'single': 'item' + }, 'single = "item"\n', 'single = "item"\n'), + ({ + 'kEy': 137, + '_42A_Zaz_': [False, True] + }, '_42A_Zaz_ = [ false, true ]\nkEy = 137\n', + '_42A_Zaz_ = [\n false,\n true\n]\nkEy = 137\n'), + ([1, 'two', + ['"thr,.$\\', True, False, [], + u'(\u2713)']], '[ 1, "two", [ "\\"thr,.\\$\\\\", true, false, ' + + '[ ], "($0xE2$0x9C$0x93)" ] ]', '''[ + 1, + "two", + [ + "\\"thr,.\\$\\\\", + true, + false, + [], + "($0xE2$0x9C$0x93)" + ] +] +'''), + ({ + 's': 'foo', + 'n': 42, + 'b': True, + 'a': [3, 'x'] + }, 'a = [ 3, "x" ]\nb = true\nn = 42\ns = "foo"\n', + 'a = [\n 3,\n "x"\n]\nb = true\nn = 42\ns = "foo"\n'), + ( + [[[], [[]]], []], + '[ [ [ ], [ [ ] ] ], [ ] ]', + '[\n [\n [],\n [\n []\n ]\n ],\n []\n]\n', + ) + ] + for obj, exp_ugly, exp_pretty in test_cases: + out_ugly = gn_helpers.ToGNString(obj) + self.assertEqual(exp_ugly, out_ugly) + out_pretty = gn_helpers.ToGNString(obj, pretty=True) + self.assertEqual(exp_pretty, out_pretty) def test_UnescapeGNString(self): # Backslash followed by a \, $, or " means the folling character without @@ -27,7 +75,7 @@ class UnitTest(unittest.TestCase): gn_helpers.FromGNString('[1, -20, true, false,["as\\"", []]]'), [ 1, -20, True, False, [ 'as"', [] ] ]) - with self.assertRaises(gn_helpers.GNException): + with self.assertRaises(gn_helpers.GNError): parser = gn_helpers.GNValueParser('123 456') parser.Parse() @@ -42,10 +90,10 @@ class UnitTest(unittest.TestCase): parser = gn_helpers.GNValueParser('123') self.assertEqual(parser.ParseNumber(), 123) - with self.assertRaises(gn_helpers.GNException): + with self.assertRaises(gn_helpers.GNError): parser = gn_helpers.GNValueParser('') parser.ParseNumber() - with self.assertRaises(gn_helpers.GNException): + with self.assertRaises(gn_helpers.GNError): parser = gn_helpers.GNValueParser('a123') parser.ParseNumber() @@ -53,13 +101,13 @@ class UnitTest(unittest.TestCase): parser = gn_helpers.GNValueParser('"asdf"') self.assertEqual(parser.ParseString(), 'asdf') - with self.assertRaises(gn_helpers.GNException): + with self.assertRaises(gn_helpers.GNError): parser = gn_helpers.GNValueParser('') # Empty. parser.ParseString() - with self.assertRaises(gn_helpers.GNException): + with self.assertRaises(gn_helpers.GNError): parser = gn_helpers.GNValueParser('asdf') # Unquoted. parser.ParseString() - with self.assertRaises(gn_helpers.GNException): + with self.assertRaises(gn_helpers.GNError): parser = gn_helpers.GNValueParser('"trailing') # Unterminated. parser.ParseString() @@ -67,16 +115,16 @@ class UnitTest(unittest.TestCase): parser = gn_helpers.GNValueParser('[1,]') # Optional end comma OK. self.assertEqual(parser.ParseList(), [ 1 ]) - with self.assertRaises(gn_helpers.GNException): + with self.assertRaises(gn_helpers.GNError): parser = gn_helpers.GNValueParser('') # Empty. parser.ParseList() - with self.assertRaises(gn_helpers.GNException): + with self.assertRaises(gn_helpers.GNError): parser = gn_helpers.GNValueParser('asdf') # No []. parser.ParseList() - with self.assertRaises(gn_helpers.GNException): + with self.assertRaises(gn_helpers.GNError): parser = gn_helpers.GNValueParser('[1, 2') # Unterminated parser.ParseList() - with self.assertRaises(gn_helpers.GNException): + with self.assertRaises(gn_helpers.GNError): parser = gn_helpers.GNValueParser('[1 2]') # No separating comma. parser.ParseList() @@ -93,10 +141,15 @@ class UnitTest(unittest.TestCase): gn_args_lines = [ '# Top-level comment.', 'foo = true', - 'bar = 1 # In-line comment.', + 'bar = 1 # In-line comment followed by whitespace.', + ' ', + 'baz = false', ] - self.assertEqual(gn_helpers.FromGNArgs('\n'.join(gn_args_lines)), - {'foo': True, 'bar': 1}) + self.assertEqual(gn_helpers.FromGNArgs('\n'.join(gn_args_lines)), { + 'foo': True, + 'bar': 1, + 'baz': False + }) # Lists should work. self.assertEqual(gn_helpers.FromGNArgs('foo=[1, 2, 3]'), @@ -107,15 +160,15 @@ class UnitTest(unittest.TestCase): self.assertEqual(gn_helpers.FromGNArgs(' \n '), {}) # Non-identifiers should raise an exception. - with self.assertRaises(gn_helpers.GNException): + with self.assertRaises(gn_helpers.GNError): gn_helpers.FromGNArgs('123 = true') # References to other variables should raise an exception. - with self.assertRaises(gn_helpers.GNException): + with self.assertRaises(gn_helpers.GNError): gn_helpers.FromGNArgs('foo = bar') # References to functions should raise an exception. - with self.assertRaises(gn_helpers.GNException): + with self.assertRaises(gn_helpers.GNError): gn_helpers.FromGNArgs('foo = exec_script("//build/baz.py")') # Underscores in identifiers should work. @@ -134,7 +187,7 @@ class UnitTest(unittest.TestCase): some_arg2 = "val2" """)) parser.ReplaceImports() - self.assertEquals( + self.assertEqual( parser.input, textwrap.dedent(""" some_arg1 = "val1" @@ -150,9 +203,11 @@ class UnitTest(unittest.TestCase): some_arg2 = "val2" """)) fake_import = 'some_imported_arg = "imported_val"' - with mock.patch('__builtin__.open', mock.mock_open(read_data=fake_import)): + builtin_var = '__builtin__' if sys.version_info.major < 3 else 'builtins' + open_fun = '{}.open'.format(builtin_var) + with mock.patch(open_fun, mock.mock_open(read_data=fake_import)): parser.ReplaceImports() - self.assertEquals( + self.assertEqual( parser.input, textwrap.dedent(""" some_arg1 = "val1" @@ -161,19 +216,19 @@ class UnitTest(unittest.TestCase): """)) # No trailing parenthesis should raise an exception. - with self.assertRaises(gn_helpers.GNException): + with self.assertRaises(gn_helpers.GNError): parser = gn_helpers.GNValueParser( textwrap.dedent('import("//some/args/file.gni"')) parser.ReplaceImports() # No double quotes should raise an exception. - with self.assertRaises(gn_helpers.GNException): + with self.assertRaises(gn_helpers.GNError): parser = gn_helpers.GNValueParser( textwrap.dedent('import(//some/args/file.gni)')) parser.ReplaceImports() # A path that's not source absolute should raise an exception. - with self.assertRaises(gn_helpers.GNException): + with self.assertRaises(gn_helpers.GNError): parser = gn_helpers.GNValueParser( textwrap.dedent('import("some/relative/args/file.gni")')) parser.ReplaceImports() |