summaryrefslogtreecommitdiff
path: root/chromium/v8/tools/lldb_commands.py
diff options
context:
space:
mode:
authorAllan Sandfeld Jensen <allan.jensen@qt.io>2020-10-12 14:27:29 +0200
committerAllan Sandfeld Jensen <allan.jensen@qt.io>2020-10-13 09:35:20 +0000
commitc30a6232df03e1efbd9f3b226777b07e087a1122 (patch)
treee992f45784689f373bcc38d1b79a239ebe17ee23 /chromium/v8/tools/lldb_commands.py
parent7b5b123ac58f58ffde0f4f6e488bcd09aa4decd3 (diff)
downloadqtwebengine-chromium-85-based.tar.gz
BASELINE: Update Chromium to 85.0.4183.14085-based
Change-Id: Iaa42f4680837c57725b1344f108c0196741f6057 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Diffstat (limited to 'chromium/v8/tools/lldb_commands.py')
-rw-r--r--chromium/v8/tools/lldb_commands.py15
1 files changed, 12 insertions, 3 deletions
diff --git a/chromium/v8/tools/lldb_commands.py b/chromium/v8/tools/lldb_commands.py
index 2884cd60b01..dc96e5747d0 100644
--- a/chromium/v8/tools/lldb_commands.py
+++ b/chromium/v8/tools/lldb_commands.py
@@ -21,8 +21,17 @@ def current_frame(debugger):
return current_thread(debugger).GetSelectedFrame()
def no_arg_cmd(debugger, cmd):
- current_frame(debugger).EvaluateExpression(cmd)
- print("")
+ evaluate_result = current_frame(debugger).EvaluateExpression(cmd)
+ # When a void function is called the return value type is 0x1001 which
+ # is specified in http://tiny.cc/bigskz. This does not indicate
+ # an error so we check for that value below.
+ kNoResult = 0x1001
+ error = evaluate_result.GetError()
+ if error.fail and error.value != kNoResult:
+ print("Failed to evaluate command {} :".format(cmd))
+ print(error.description)
+ else:
+ print("")
def ptr_arg_cmd(debugger, name, param, cmd):
if not param:
@@ -41,7 +50,7 @@ def job(debugger, param, *args):
def jlh(debugger, param, *args):
"""Print v8::Local handle value"""
ptr_arg_cmd(debugger, 'jlh', param,
- "_v8_internal_Print_Object(*(v8::internal::Object**)(*{}))")
+ "_v8_internal_Print_Object(*(v8::internal::Object**)({}.val_))")
def jco(debugger, param, *args):
"""Print the code object at the given pc (default: current pc)"""